rubocop-sorbet 0.6.11 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0a3b043348a2ad38724ebb70db4bb8db09a6a02d9c9bbc56a262e0de4b90d5eb
-  data.tar.gz: 50e5a9d5e61b0e95343a8d4699f81910bff19f10387119ae97bfec688906c6d9
+  metadata.gz: 87c7e5f3cd38dc5528234c83895115c4f0fe10010c041c0c914f73cf92f289f4
+  data.tar.gz: f991837c8cce7938ae4f0043b2c10a98b9130bd01f0d2b95f62a967e03337fab
 SHA512:
-  metadata.gz: e749a4ac82f0e9b76a5f3bb2e77bbefeec539a939b107b3dc59c1d20c83b4f4b4766a6792938a03cd8d7e8044ec58a53d8af4d346ec5177390993fb2ddcd181e
-  data.tar.gz: 417259e5915b4836c8b90939d7922d34ab02e2d4d7955482d9fdb7dac58cb728114bd08e0437650b10687e64cdbfd75361ed586dd21cfb9de5bbacd1fc816db7
+  metadata.gz: 71581073a6caba33b050d643815d98fdeae36d17eedbbcab985b9b467c9ccde100f153c58970ac3fb06f03c7834170fab65276f499bcf5e398b8dfdcde0ae5f7
+  data.tar.gz: 66ab517902652d5921967544c7c81d89b758886d9c893b2ed60d0e32a4826fc8391c6e91c6c0701e17c916a0a6535390fead92f740cc367e34530865cc4e4122

data/.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [ '2.5', '2.6', '2.7', '3.0', '3.1' ]
+        ruby: [ '2.5', '2.6', '2.7', '3.0', '3.1', '3.2' ]
     name: Test Ruby ${{ matrix.ruby }}
     steps:
       - uses: actions/checkout@v2
@@ -22,5 +22,7 @@ jobs:
           bundler-cache: true
       - name: Lint Ruby files
         run: bin/rubocop
+      - name: Verify documentation is up to date
+        run: bundle exec rake generate_cops_documentation
       - name: Run tests
         run: bin/rspec

data/.github/workflows/cla.yml

@@ -0,0 +1,22 @@
+name: Contributor License Agreement (CLA)
+
+on:
+  pull_request_target:
+    types: [opened, synchronize, reopened]
+  issue_comment:
+    types: [created]
+
+jobs:
+  cla:
+    runs-on: ubuntu-latest
+    if: |
+      (github.event.issue.pull_request 
+        && !github.event.issue.pull_request.merged_at
+        && contains(github.event.comment.body, 'signed')
+      ) 
+      || (github.event.pull_request && !github.event.pull_request.merged)
+    steps:
+      - uses: Shopify/shopify-cla-action@v1
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          cla-token: ${{ secrets.CLA_TOKEN }}

data/.github/workflows/stale.yml

@@ -0,0 +1,24 @@
+name: "Close stale PRs"
+
+permissions:
+  pull-requests: write
+  issues: write
+
+on:
+  schedule:
+    - cron: "55 1 * * *"
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/stale@v5
+        with:
+          stale-pr-message: >
+            This PR has been automatically marked as stale because it has not had
+            recent activity. It will be closed if no further activity occurs. Thank you
+            for your contributions.
+          days-before-stale: 30
+          days-before-issue-stale: -1
+          days-before-close: 7
+          exempt-pr-labels: pinned,security

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-sorbet (0.6.11)
+    rubocop-sorbet (0.7.0)
       rubocop (>= 0.90.0)
 
 GEM

data/Rakefile

@@ -22,15 +22,15 @@ task :new_cop, [:cop] do |_task, args|
     exit!
   end
 
-  github_user = %x(git config github.user).chop
-  github_user = "Shopify" if github_user.empty?
-
-  generator = RuboCop::Cop::Generator.new(cop_name, github_user)
+  generator = RuboCop::Cop::Generator.new(cop_name)
 
   generator.write_source
   generator.write_spec
   generator.inject_require(root_file_path: "lib/rubocop/cop/sorbet_cops.rb")
   generator.inject_config(config_file_path: "config/default.yml")
 
-  puts generator.todo
+  # We don't use Rubocop's changelog automation workflow
+  todo_without_changelog_instruction = generator.todo
+    .sub(/$\s+4\. Run.*changelog.*for your new cop\.$/m, "")
+  puts todo_without_changelog_instruction
 end

data/config/default.yml

@@ -25,6 +25,11 @@ Sorbet/CheckedTrueInSignature:
   Enabled: true
   VersionAdded: 0.2.0
 
+Sorbet/EmptyLineAfterSig:
+  Description: 'Ensures that there are no blank lines after signatures'
+  Enabled: true
+  VersionAdded: 0.7.0
+
 Sorbet/ConstantsFromStrings:
   Description: >-
                   Forbids constant access through meta-programming.
@@ -42,7 +47,7 @@ Sorbet/EnforceSigilOrder:
 Sorbet/EnforceSingleSigil:
   Description: 'Ensures that there is only one Sorbet sigil in a file.'
   Enabled: true
-  VersionAdded: '<<next>>'
+  VersionAdded: 0.7.0
 
 Sorbet/EnforceSignatures:
   Description: 'Ensures all methods have a valid signature.'
@@ -73,6 +78,7 @@ Sorbet/ForbidRBIOutsideOfAllowedPaths:
   Enabled: true
   VersionAdded: 0.6.1
   AllowedPaths:
+  - "rbi/**"
   - "sorbet/rbi/**"
   Include:
   - "**/*.rbi"
@@ -150,6 +156,16 @@ Sorbet/OneAncestorPerLine:
   Enabled: false
   VersionAdded: '0.6.0'
 
+Sorbet/RedundantExtendTSig:
+  Description: >-
+    Forbid the usage of redundant `extend T::Sig`.
+
+    Only for use in applications that monkey patch `Module.include(T::Sig)` directly,
+    where it is useful to reduce noise.
+  Enabled: false
+  Safe: false
+  VersionAdded: 0.7.0
+
 Sorbet/SignatureBuildOrder:
   Description: >-
                   Enforces the order of parts in a signature.

data/dev.yml

@@ -3,7 +3,7 @@ name: "rubocop-sorbet"
 type: "ruby"
 
 up:
-  - ruby: "2.5.5"
+  - ruby: "3.2.0"
   - "bundler"
 
 commands:

data/lib/rubocop/cop/sorbet/forbid_untyped_struct_props.rb

@@ -7,18 +7,18 @@ module RuboCop
   module Cop
     module Sorbet
       # This cop disallows use of `T.untyped` or `T.nilable(T.untyped)`
-      # as a prop type for `T::Struct`.
+      # as a prop type for `T::Struct` or `T::ImmutableStruct`.
       #
       # @example
       #
       #   # bad
-      #   class SomeClass
+      #   class SomeClass < T::Struct
       #     const :foo, T.untyped
       #     prop :bar, T.nilable(T.untyped)
       #   end
       #
       #   # good
-      #   class SomeClass
+      #   class SomeClass < T::Struct
       #     const :foo, Integer
       #     prop :bar, T.nilable(String)
       #   end
@@ -29,6 +29,10 @@ module RuboCop
           (const (const nil? :T) :Struct)
         PATTERN
 
+        def_node_matcher :t_immutable_struct, <<~PATTERN
+          (const (const nil? :T) :ImmutableStruct)
+        PATTERN
+
         def_node_matcher :t_untyped, <<~PATTERN
           (send (const nil? :T) :untyped)
         PATTERN
@@ -38,7 +42,7 @@ module RuboCop
         PATTERN
 
         def_node_matcher :subclass_of_t_struct?, <<~PATTERN
-          (class (const ...) #t_struct ...)
+          (class (const ...) {#t_struct #t_immutable_struct} ...)
         PATTERN
 
         def_node_search :untyped_props, <<~PATTERN

data/lib/rubocop/cop/sorbet/rbi/forbid_rbi_outside_of_allowed_paths.rb

@@ -9,7 +9,7 @@ module RuboCop
       #
       # Options:
       #
-      # * `AllowedPaths`: A list of the paths where RBI files are allowed (default: ["sorbet/rbi/**"])
+      # * `AllowedPaths`: A list of the paths where RBI files are allowed (default: ["rbi/**", "sorbet/rbi/**"])
       #
       # @example
       #   # bad
@@ -17,6 +17,7 @@ module RuboCop
       #   # other_file.rbi
       #
       #   # good
+      #   # rbi/external_interface.rbi
       #   # sorbet/rbi/some_file.rbi
       #   # sorbet/rbi/any/path/for/file.rbi
       class ForbidRBIOutsideOfAllowedPaths < RuboCop::Cop::Cop

data/lib/rubocop/cop/sorbet/redundant_extend_t_sig.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sorbet
+      # Forbids the use of redundant `extend T::Sig`. Only for use in
+      # applications that monkey patch `Module.include(T::Sig)` globally,
+      # which would make it redundant.
+      #
+      # @safety
+      #   This cop should not be enabled in applications that have not monkey
+      #   patched `Module`.
+      #
+      # @example
+      #   # bad
+      #   class Example
+      #     extend T::Sig
+      #     sig { void }
+      #     def no_op; end
+      #   end
+      #
+      #   # good
+      #   class Example
+      #     sig { void }
+      #     def no_op; end
+      #   end
+      #
+      class RedundantExtendTSig < RuboCop::Cop::Cop
+        MSG = "Do not redundantly `extend T::Sig` when it is already included in all modules."
+        RESTRICT_ON_SEND = [:extend].freeze
+
+        def_node_matcher :extend_t_sig?, <<~PATTERN
+          (send _ :extend (const (const {nil? | cbase} :T) :Sig))
+        PATTERN
+
+        def on_send(node)
+          return unless extend_t_sig?(node)
+
+          add_offense(node)
+        end
+
+        def autocorrect(node)
+          lambda do |corrector|
+            corrector.remove(node)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sorbet/sigils/enforce_sigil_order.rb

@@ -7,7 +7,7 @@ module RuboCop
     module Sorbet
       # This cop checks that the Sorbet sigil comes as the first magic comment in the file.
       #
-      # The expected order for magic comments is: typed, (en)?coding, warn_indent then frozen_string_literal.
+      # The expected order for magic comments is: (en)?coding, typed, warn_indent then frozen_string_literal.
       #
       # For example, the following bad ordering:
       #
@@ -25,7 +25,7 @@ module RuboCop
       # class Foo; end
       # ```
       #
-      # Only `typed`, `(en)?coding`, `warn_indent` and `frozen_string_literal` magic comments are considered,
+      # Only `(en)?coding`, `typed`, `warn_indent` and `frozen_string_literal` magic comments are considered,
       # other comments or magic comments are left in the same place.
       class EnforceSigilOrder < ValidSigil
         include RangeHelp

data/lib/rubocop/cop/sorbet/signatures/empty_line_after_sig.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require_relative "signature_cop"
+
+module RuboCop
+  module Cop
+    module Sorbet
+      # This cop checks for blank lines after signatures.
+      #
+      # It also suggests an autocorrect
+      #
+      # @example
+      #
+      #   # bad
+      #   sig { void }
+      #
+      #   def foo; end
+      #
+      #   # good
+      #   sig { void }
+      #   def foo; end
+      #
+      class EmptyLineAfterSig < SignatureCop
+        include RangeHelp
+
+        def on_signature(node)
+          if (next_method(node).line - node.last_line) > 1
+            location = source_range(processed_source.buffer, next_method(node).line - 1, 0)
+            add_offense(node, location: location, message: "Extra empty line or comment detected")
+          end
+        end
+
+        def autocorrect(node)
+          -> (corrector) do
+            offending_range = node.source_range.with(
+              begin_pos: node.source_range.end_pos + 1,
+              end_pos: processed_source.buffer.line_range(next_method(node).line).begin_pos
+            )
+            corrector.remove(offending_range)
+            clean_range = offending_range.source.split("\n").reject(&:empty?).join("\n")
+            offending_line = processed_source.buffer.line_range(node.source_range.first_line)
+            corrector.insert_before(offending_line, "#{clean_range}\n") unless clean_range.empty?
+          end
+        end
+
+        private
+
+        def next_method(node)
+          processed_source.tokens.find do |t|
+            t.line >= node.last_line &&
+              (t.type == :kDEF || t.text.start_with?("attr_"))
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sorbet/signatures/signature_build_order.rb

@@ -94,6 +94,8 @@ module RuboCop
         end
 
         def call_chain(sig_child_node)
+          return [] if sig_child_node.nil?
+
           call_node = root_call(sig_child_node).first
           return [] unless call_node
 

data/lib/rubocop/cop/sorbet/signatures/signature_cop.rb

@@ -12,7 +12,11 @@ module RuboCop
         @registry = Cop.registry # So we can properly subclass this cop
 
         def_node_matcher(:signature?, <<~PATTERN)
-          (block (send #allowed_recv :sig) (args) ...)
+          (block (send
+            {nil? #with_runtime? #without_runtime?}
+            :sig
+            (sym :final)?
+          ) (args) ...)
         PATTERN
 
         def_node_matcher(:with_runtime?, <<~PATTERN)
@@ -23,13 +27,6 @@ module RuboCop
           (const (const (const nil? :T) :Sig) :WithoutRuntime)
         PATTERN
 
-        def allowed_recv(recv)
-          return true unless recv
-          return true if with_runtime?(recv)
-          return true if without_runtime?(recv)
-          false
-        end
-
         def on_block(node)
           on_signature(node) if signature?(node)
         end

data/lib/rubocop/cop/sorbet_cops.rb

@@ -8,6 +8,7 @@ require_relative "sorbet/one_ancestor_per_line"
 require_relative "sorbet/callback_conditionals_binding"
 require_relative "sorbet/forbid_t_unsafe"
 require_relative "sorbet/forbid_t_untyped"
+require_relative "sorbet/redundant_extend_t_sig"
 require_relative "sorbet/type_alias_name"
 
 require_relative "sorbet/rbi/forbid_extend_t_sig_helpers_in_shims"
@@ -19,6 +20,7 @@ require_relative "sorbet/signatures/checked_true_in_signature"
 require_relative "sorbet/signatures/keyword_argument_ordering"
 require_relative "sorbet/signatures/signature_build_order"
 require_relative "sorbet/signatures/enforce_signatures"
+require_relative "sorbet/signatures/empty_line_after_sig"
 
 require_relative "sorbet/sigils/valid_sigil"
 require_relative "sorbet/sigils/has_sigil"

data/lib/rubocop/sorbet/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module RuboCop
   module Sorbet
-    VERSION = "0.6.11"
+    VERSION = "0.7.0"
   end
 end

data/manual/cops.md

@@ -10,6 +10,7 @@ In the following section you find all available cops:
 * [Sorbet/CallbackConditionalsBinding](cops_sorbet.md#sorbetcallbackconditionalsbinding)
 * [Sorbet/CheckedTrueInSignature](cops_sorbet.md#sorbetcheckedtrueinsignature)
 * [Sorbet/ConstantsFromStrings](cops_sorbet.md#sorbetconstantsfromstrings)
+* [Sorbet/EmptyLineAfterSig](cops_sorbet.md#sorbetemptylineaftersig)
 * [Sorbet/EnforceSigilOrder](cops_sorbet.md#sorbetenforcesigilorder)
 * [Sorbet/EnforceSignatures](cops_sorbet.md#sorbetenforcesignatures)
 * [Sorbet/EnforceSingleSigil](cops_sorbet.md#sorbetenforcesinglesigil)
@@ -25,6 +26,7 @@ In the following section you find all available cops:
 * [Sorbet/IgnoreSigil](cops_sorbet.md#sorbetignoresigil)
 * [Sorbet/KeywordArgumentOrdering](cops_sorbet.md#sorbetkeywordargumentordering)
 * [Sorbet/OneAncestorPerLine](cops_sorbet.md#sorbetoneancestorperline)
+* [Sorbet/RedundantExtendTSig](cops_sorbet.md#sorbetredundantextendtsig)
 * [Sorbet/SignatureBuildOrder](cops_sorbet.md#sorbetsignaturebuildorder)
 * [Sorbet/SignatureCop](cops_sorbet.md#sorbetsignaturecop)
 * [Sorbet/SingleLineRbiClassModuleDefinitions](cops_sorbet.md#sorbetsinglelinerbiclassmoduledefinitions)

data/manual/cops_sorbet.md

@@ -138,6 +138,29 @@ end
 { "User" => User }.fetch(class_name)
 ```
 
+## Sorbet/EmptyLineAfterSig
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Enabled | Yes | Yes  | 0.7.0 | -
+
+This cop checks for blank lines after signatures.
+
+It also suggests an autocorrect
+
+### Examples
+
+```ruby
+# bad
+sig { void }
+
+def foo; end
+
+# good
+sig { void }
+def foo; end
+```
+
 ## Sorbet/EnforceSigilOrder
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
@@ -146,7 +169,7 @@ Enabled | Yes | Yes  | 0.3.4 | -
 
 This cop checks that the Sorbet sigil comes as the first magic comment in the file.
 
-The expected order for magic comments is: typed, (en)?coding, warn_indent then frozen_string_literal.
+The expected order for magic comments is: (en)?coding, typed, warn_indent then frozen_string_literal.
 
 For example, the following bad ordering:
 
@@ -164,7 +187,7 @@ Will be corrected as:
 class Foo; end
 ```
 
-Only `typed`, `(en)?coding`, `warn_indent` and `frozen_string_literal` magic comments are considered,
+Only `(en)?coding`, `typed`, `warn_indent` and `frozen_string_literal` magic comments are considered,
 other comments or magic comments are left in the same place.
 
 ## Sorbet/EnforceSignatures
@@ -197,7 +220,7 @@ You can configure the placeholders used by changing the following options:
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
 --- | --- | --- | --- | ---
-Enabled | Yes | Yes  | <<next>> | -
+Enabled | Yes | Yes  | 0.7.0 | -
 
 This cop checks that there is only one Sorbet sigil in a given file
 
@@ -288,7 +311,7 @@ This cop makes sure that RBI files are always located under the defined allowed
 
 Options:
 
-* `AllowedPaths`: A list of the paths where RBI files are allowed (default: ["sorbet/rbi/**"])
+* `AllowedPaths`: A list of the paths where RBI files are allowed (default: ["rbi/**", "sorbet/rbi/**"])
 
 ### Examples
 
@@ -298,6 +321,7 @@ Options:
 # other_file.rbi
 
 # good
+# rbi/external_interface.rbi
 # sorbet/rbi/some_file.rbi
 # sorbet/rbi/any/path/for/file.rbi
 ```
@@ -306,7 +330,7 @@ Options:
 
 Name | Default value | Configurable values
 --- | --- | ---
-AllowedPaths | `sorbet/rbi/**` | Array
+AllowedPaths | `rbi/**`, `sorbet/rbi/**` | Array
 Include | `**/*.rbi` | Array
 
 ## Sorbet/ForbidSuperclassConstLiteral
@@ -368,19 +392,19 @@ Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChan
 Enabled | Yes | No | 0.4.0 | -
 
 This cop disallows use of `T.untyped` or `T.nilable(T.untyped)`
-as a prop type for `T::Struct`.
+as a prop type for `T::Struct` or `T::ImmutableStruct`.
 
 ### Examples
 
 ```ruby
 # bad
-class SomeClass
+class SomeClass < T::Struct
   const :foo, T.untyped
   prop :bar, T.nilable(T.untyped)
 end
 
 # good
-class SomeClass
+class SomeClass < T::Struct
   const :foo, Integer
   prop :bar, T.nilable(String)
 end
@@ -473,6 +497,33 @@ module SomeModule
 end
 ```
 
+## Sorbet/RedundantExtendTSig
+
+Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
+--- | --- | --- | --- | ---
+Disabled | No | Yes  | 0.7.0 | -
+
+Forbids the use of redundant `extend T::Sig`. Only for use in
+applications that monkey patch `Module.include(T::Sig)` globally,
+which would make it redundant.
+
+### Examples
+
+```ruby
+# bad
+class Example
+  extend T::Sig
+  sig { void }
+  def no_op; end
+end
+
+# good
+class Example
+  sig { void }
+  def no_op; end
+end
+```
+
 ## Sorbet/SignatureBuildOrder
 
 Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged

data/service.yml

@@ -1 +0,0 @@
-classification: library

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sorbet
 version: !ruby/object:Gem::Version
-  version: 0.6.11
+  version: 0.7.0
 platform: ruby
 authors:
 - Ufuk Kayserilioglu
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-06-30 00:00:00.000000000 Z
+date: 2023-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -63,10 +63,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/CODEOWNERS"
-- ".github/probots.yml"
 - ".github/release.yml"
-- ".github/stale.yml"
 - ".github/workflows/ci.yml"
+- ".github/workflows/cla.yml"
+- ".github/workflows/stale.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -98,6 +98,7 @@ files:
 - lib/rubocop/cop/sorbet/rbi/forbid_extend_t_sig_helpers_in_shims.rb
 - lib/rubocop/cop/sorbet/rbi/forbid_rbi_outside_of_allowed_paths.rb
 - lib/rubocop/cop/sorbet/rbi/single_line_rbi_class_module_definitions.rb
+- lib/rubocop/cop/sorbet/redundant_extend_t_sig.rb
 - lib/rubocop/cop/sorbet/sigils/enforce_sigil_order.rb
 - lib/rubocop/cop/sorbet/sigils/enforce_single_sigil.rb
 - lib/rubocop/cop/sorbet/sigils/false_sigil.rb
@@ -109,6 +110,7 @@ files:
 - lib/rubocop/cop/sorbet/sigils/valid_sigil.rb
 - lib/rubocop/cop/sorbet/signatures/allow_incompatible_override.rb
 - lib/rubocop/cop/sorbet/signatures/checked_true_in_signature.rb
+- lib/rubocop/cop/sorbet/signatures/empty_line_after_sig.rb
 - lib/rubocop/cop/sorbet/signatures/enforce_signatures.rb
 - lib/rubocop/cop/sorbet/signatures/keyword_argument_ordering.rb
 - lib/rubocop/cop/sorbet/signatures/signature_build_order.rb

data/.github/probots.yml

@@ -1,3 +0,0 @@
-enabled:
-  - cla
-  - probot-stale

data/.github/stale.yml

@@ -1,20 +0,0 @@
-# Number of days of inactivity before an issue becomes stale
-daysUntilStale: 30
-# Number of days of inactivity before a stale issue is closed
-daysUntilClose: 7
-# Issues with these labels will never be considered stale
-exemptLabels:
-  - pinned
-  - security
-# Label to use when marking an issue as stale
-staleLabel: stale
-# Comment to post when marking an issue as stale. Set to `false` to disable
-markComment: >
-  This PR has been automatically marked as stale because it has not had
-  recent activity. It will be closed if no further activity occurs. Thank you
-  for your contributions.
-# Comment to post when closing a stale issue. Set to `false` to disable
-closeComment: false
-#
-only: pulls
-#