rubocop-solidus 0.1.1 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 101df3597b1ea7fe8229ada4f77a940a7918edb988025a5dc59422d459985410
-  data.tar.gz: 322ae6772c8d8c05e71cb3e5d257da7cf1970dea04d4dc1394e7d094fc9fcf61
+  metadata.gz: 745ca1ca12310bb9de934135f03aae227d87d616005ce5e82aafe58d6554a88d
+  data.tar.gz: 9723caf52452c8b1d4fa8bf88f644298bda3d01631af85df95a6aceb6b741462
 SHA512:
-  metadata.gz: 52e20d00967742080012fc3a09ceac7a847b792fe6bc510f9caca95ccaef4de6993e203344b1d16157a34f4814aaeb165386718cba3701cd5d4d1a6ef2af035c
-  data.tar.gz: e384e8d9eaae46bd4d9027c3ba46b3829b9ab4f4d7a56714666fb85e8d53665a5dbcbd872c7e0719e4ac8387d86d8bad4a09b4481c1465b0bf5c3fe6c5e4a65b
+  metadata.gz: 8683bf3a98d2483a25e1d18a078ca9a44ad39eb138a069364b664dbdc989f0199a7bcb86c68ce750268a310ca0c0342cc4cd55a60448edc65d3ff9b3a28e56f8
+  data.tar.gz: 2c36b5f8362baf576f3eaecc05e63324d988f1fcf0a0d63ce27c606787437a8fd303e8ca1172269f7766de26378d6aaf2598831dcbf43eef5583551f2581177a

data/.rubocop.yml

@@ -1,6 +1,7 @@
+inherit_from: .rubocop_todo.yml
+
 AllCops:
   NewCops: enable
-  TargetRubyVersion: 2.4
 
 Naming/FileName:
  Exclude:
@@ -16,8 +17,3 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Exclude:
     - 'tasks/**/*.rb'
-
-# Prevents Ruby 3.1 incompatibility error. You can enable this cop when Ruby 2.4 support is dropped.
-# See https://github.com/rubocop/rubocop/issues/10258
-Layout/BlockAlignment:
-  Enabled: false

data/.rubocop_todo.yml

@@ -0,0 +1,15 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2023-07-21 15:08:23 UTC using RuboCop version 1.54.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Severity, Include.
+# Include: **/*.gemspec
+Gemspec/RequireMFA:
+  Exclude:
+    - 'rubocop-solidus.gemspec'

data/CHANGELOG.md

@@ -1,5 +1,22 @@
 ## master (unreleased)
 
+## 0.1.3 (2023-07-28)
+
+### New features
+
+* [#47](https://github.com/solidusio/rubocop-solidus/pull/47): Remove support for old versions of ruby. ([@MassimilianoLattanzio][])
+
+### Bug fixes
+
+* [#48](https://github.com/solidusio/rubocop-solidus/pull/48): Fix typos in README and add instructions on how to use the changelog rake task. ([@MassimilianoLattanzio][])
+
+## 0.1.2 (2023-07-14)
+
+### New features
+
+* [#45](https://github.com/solidusio/rubocop-solidus/pull/45): Fix gem version comparison. ([@MassimilianoLattanzio][])
+
 ## 0.1.0 (2023-07-10)
 
 - Initial release
+[@MassimilianoLattanzio]: https://github.com/MassimilianoLattanzio

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-solidus (0.1.1)
+    rubocop-solidus (0.1.3)
       rubocop
 
 GEM
@@ -11,15 +11,17 @@ GEM
     bump (0.10.0)
     coderay (1.1.3)
     diff-lcs (1.5.0)
+    json (2.6.3)
+    language_server-protocol (3.17.0.3)
     method_source (1.0.0)
-    parallel (1.20.1)
+    parallel (1.23.0)
     parser (3.2.2.3)
       ast (~> 2.4.1)
       racc
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    racc (1.5.2)
+    racc (1.7.1)
     rainbow (3.1.1)
     rake (13.0.6)
     regexp_parser (2.8.1)
@@ -37,17 +39,19 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-support (3.12.1)
-    rubocop (1.12.1)
+    rubocop (1.54.2)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.2.2.3)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.2.0, < 2.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.28.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.4.1)
-      parser (>= 2.7.1.5)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.29.0)
+      parser (>= 3.2.1.0)
     ruby-progressbar (1.13.0)
     unicode-display_width (2.4.2)
 

data/README.md

@@ -8,7 +8,7 @@ A RuboCop extension focused on enforcing Solidus best practices and coding conve
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'rubocop-solidus', github: 'nebulab/rubocop-solidus', require: false
+gem 'rubocop-solidus' require: false
 ```
 
 And then execute:
@@ -35,17 +35,45 @@ After this simply use the `rubocop` command to start linting.
 To create a new cop, run the following command:
 
 ```bash
-$ bundle exec rake new_cop[Solidus/NameOfTheCop]
+$ bundle exec rake 'new_cop[Solidus/NameOfTheCop]'
 ```
 
 and then follow the instructions on the screen.
 
+## Creating changelog entries
+
+Changelog entries are just files under the `changelog/` folder that will be merged
+into `CHANGELOG.md` at release time. You can create new changelog entries like this:
+
+```console
+$ bundle exec rake changelog:new|fix|change
+```
+
+The type of the changelog correspond to "new feature", "bug-fix" and "changed" entries in the changelog.
+
+### Changelog entry format
+
+Here are a few examples:
+
+```markdown
+* [#46](https://github.com/solidusio/rubocop-solidus/issues/46): **(Breaking)** Remove support for old Ruby versions. ([@MassimilianoLattanzio][])
+* [#4](https://github.com/solidusio/rubocop-solidus/pull/4): Update CHANGELOG. ([@piyushswain][])
+```
+
+* Create one file `changelog/{type}_{some_description}.md`, where `type` is `new` (New feature), `fix` or `change`, and `some_description` is unique to avoid conflicts. Task `changelog:fix` (or `:new` or `:change`) can help you.
+* Mark it up in [Markdown syntax][1].
+* The entry should be a single line, starting with `* ` (an asterisk and a space).
+* If the change has a related GitHub issue (e.g. a bug fix for a reported issue), put a link to the issue as `[#123](https://github.com/solidusio/rubocop-solidus/issues/123): `.
+* Describe the brief of the change. The sentence should end with a punctuation.
+* If this is a breaking change, mark it with `**(Breaking)**`.
+* At the end of the entry, add an implicit link to your GitHub user page as `([@username][])`.
+
 ## Release a new version
 
 To release a new version, run the following command:
 
 ```bash
-$ bundle exec rake cut_release:[major|minor|patch]
+$ bundle exec rake cut_release:major|minor|patch
 ```
 
 and then follow the instructions on the screen.
@@ -63,8 +91,10 @@ $ bundle exec rake release
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/nebulab/rubocop-solidus.
+Bug reports and pull requests are welcome on GitHub at https://github.com/solidusio/rubocop-solidus.
 
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
+
+[1]: https://www.markdownguide.org/basic-syntax/

data/config/default.yml

@@ -12,58 +12,58 @@ Solidus/ClassEvalDecorator:
   Description: 'Checks if Class.class_eval is being used in the code'
   Enabled: true
   VersionAdded: '0.1.0'
-  Reference: 'https://github.com/nebulab/rubocop-solidus/issues/21'
+  Reference: 'https://github.com/solidusio/rubocop-solidus/issues/21'
 
 Solidus/ReimbursementHookDeprecated:
   Description: 'Checks if reimbursement_success_hooks and reimbursement_failed_hooks is being used'
   Enabled: true
   VersionAdded: '0.1.0'
-  Reference: 'https://github.com/nebulab/rubocop-solidus/issues/27'
+  Reference: 'https://github.com/solidusio/rubocop-solidus/issues/27'
 
 Solidus/SpreeCalculatorFreeShippingDeprecated:
   Description: 'Checks if Spree::Calculator::FreeShipping is being used and add deprecation message'
   Enabled: true
   VersionAdded: '0.1.0'
-  Reference: 'https://github.com/nebulab/rubocop-solidus/issues/29'
+  Reference: 'https://github.com/solidusio/rubocop-solidus/issues/29'
 
 Solidus/SpreeCalculatorPercentPerItemDeprecated:
   Description: 'Checks if Spree::Calculator::PercentPerItem is being used and add deprecation message'
   Enabled: true
   VersionAdded: '0.1.0'
-  Reference: 'https://github.com/nebulab/rubocop-solidus/issues/29'
+  Reference: 'https://github.com/solidusio/rubocop-solidus/issues/29'
 
 Solidus/SpreeCalculatorPriceSackDeprecated:
   Description: 'Checks if Spree::Calculator::PriceSack is being used and add deprecation message'
   Enabled: true
   VersionAdded: '0.1.0'
-  Reference: 'https://github.com/nebulab/rubocop-solidus/issues/29'
+  Reference: 'https://github.com/solidusio/rubocop-solidus/issues/29'
 
 Solidus/SpreeDefaultCreditCardDeprecated:
   Description: 'Checks if user.default_credit_card is used and suggest using user.wallet.default_wallet_payment_source'
   Enabled: true
   VersionAdded: '0.1.0'
-  Reference: 'https://github.com/nebulab/rubocop-solidus/issues/33'
+  Reference: 'https://github.com/solidusio/rubocop-solidus/issues/33'
 
 Solidus/SpreeGatewayBogusDeprecated:
   Description: 'Checks if SpreeGatewayBogus is being used and replaces it with Spree::PaymentMethod::BogusCreditCard'
   Enabled: true
   VersionAdded: '0.1.0'
-  Reference: 'https://github.com/nebulab/rubocop-solidus/issues/26'
+  Reference: 'https://github.com/solidusio/rubocop-solidus/issues/26'
 
 Solidus/SpreeIconDeprecated:
   Description: 'Checks if icon helper is being used and suggest `solidus_icon`'
   Enabled: true
   VersionAdded: '0.1.0'
-  Reference: 'https://github.com/nebulab/rubocop-solidus/issues/32'
+  Reference: 'https://github.com/solidusio/rubocop-solidus/issues/32'
 
 Solidus/SpreeRefundCallPerform:
   Description: 'Checks if Spree::Refund.create is being used and require calling .perform!'
   Enabled: true
   VersionAdded: '0.1.0'
-  Reference: 'https://github.com/nebulab/rubocop-solidus/issues/28'
+  Reference: 'https://github.com/solidusio/rubocop-solidus/issues/28'
 
 Solidus/SpreeTDeprecated:
   Description: 'Checks if Spree.t is being used and replaces it with I18n.t.'
   Enabled: true
   VersionAdded: '0.1.0'
-  Reference: 'https://github.com/nebulab/rubocop-solidus/issues/22'
+  Reference: 'https://github.com/solidusio/rubocop-solidus/issues/22'

data/lib/rubocop/cop/mixin/target_solidus_version.rb

@@ -22,7 +22,7 @@ module RuboCop
         end
 
         def targeted_solidus_version?(version)
-          @minimum_solidus_version <= version
+          Gem::Version.new(@minimum_solidus_version) <= Gem::Version.new(version)
         end
       end
 
@@ -47,7 +47,7 @@ module RuboCop
 
       def target_solidus_version
         @target_solidus_version ||=
-          config.for_all_cops['TargetSolidusVersion']&.to_f || solidus_version_from_lock_file || DEFAULT_SOLIDUS_VERSION
+          config.for_all_cops['TargetSolidusVersion'] || solidus_version_from_lock_file || DEFAULT_SOLIDUS_VERSION
       end
 
       def solidus_version_from_lock_file
@@ -62,7 +62,7 @@ module RuboCop
           # If Solidus (or one of its frameworks) is in Gemfile.lock, there should be a line like:
           #   solidus_core (X.X.X)
           result = line.match(/^\s+solidus_core\s+\((\d+\.\d+)/)
-          return result.captures.first.to_f if result
+          return result.captures.first if result
         end
       end
     end

data/lib/rubocop/solidus/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Solidus
-    VERSION = '0.1.1'
+    VERSION = '0.1.3'
   end
 end

data/relnotes/v0.1.2.md

@@ -0,0 +1,5 @@
+### New features
+
+* [#45](https://github.com/solidusio/rubocop-solidus/pull/45): Fix gem version comparison. ([@MassimilianoLattanzio][])
+
+[@MassimilianoLattanzio]: https://github.com/MassimilianoLattanzio

data/relnotes/v0.1.3.md

@@ -0,0 +1,9 @@
+### New features
+
+* [#47](https://github.com/solidusio/rubocop-solidus/pull/47): Remove support for old versions of ruby. ([@MassimilianoLattanzio][])
+
+### Bug fixes
+
+* [#48](https://github.com/solidusio/rubocop-solidus/pull/48): Fix typos in README and add instructions on how to use the changelog rake task. ([@MassimilianoLattanzio][])
+
+[@MassimilianoLattanzio]: https://github.com/MassimilianoLattanzio

data/rubocop-solidus.gemspec

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require_relative 'lib/rubocop/solidus/version'
+
+Gem::Specification.new do |spec|
+  spec.name = 'rubocop-solidus'
+  spec.version = RuboCop::Solidus::VERSION
+  spec.authors = ['piyushswain']
+  spec.email = ['piyush.swain3@gmail.com']
+
+  spec.summary = 'Automatic Solidus code style checking tool.'
+  spec.description = <<~DESCRIPTION
+    Automatic Solidus code style checking tool.
+    A RuboCop extension focused on enforcing Solidus best practices and coding conventions.
+  DESCRIPTION
+  spec.homepage = 'https://www.github.com/solidusio/rubocop-solidus'
+  spec.license = 'MIT'
+  spec.required_ruby_version = '>= 2.7.0'
+
+  spec.metadata['homepage_uri'] = spec.homepage
+  spec.metadata['source_code_uri'] = 'https://www.github.com/solidusio/rubocop-solidus'
+  spec.metadata['changelog_uri'] = 'https://www.github.com/solidusio/rubocop-solidus'
+
+  # Specify which files should be added to the gem when it is released.
+  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
+  spec.files = Dir.chdir(File.expand_path(__dir__)) do
+    `git ls-files -z`.split("\x0").reject do |f|
+      (f == __FILE__) || f.match(%r{\A(?:(?:bin|test|spec|features)/|\.(?:git|travis|circleci)|appveyor)})
+    end
+  end
+  spec.bindir = 'exe'
+  spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
+  spec.require_paths = ['lib']
+
+  # Uncomment to register a new dependency of your gem
+  # spec.add_dependency "example-gem", "~> 1.0"
+
+  # For more information and examples about making a new gem, check out our
+  # guide at: https://bundler.io/guides/creating_gem.html
+
+  spec.add_runtime_dependency 'rubocop'
+end

data/tasks/changelog.rb

@@ -9,7 +9,7 @@ class Changelog
   TYPE_TO_HEADER = { new: 'New features', fix: 'Bug fixes', change: 'Changes' }.freeze
   HEADER = /### (.*)/.freeze
   PATH = 'CHANGELOG.md'
-  REF_URL = 'https://github.com/nebulab/rubocop-solidus'
+  REF_URL = 'https://github.com/solidusio/rubocop-solidus'
   MAX_LENGTH = 40
   CONTRIBUTOR = '[@%<user>s]: https://github.com/%<user>s'
   SIGNATURE = Regexp.new(format(Regexp.escape('[@%<user>s][]'), user: '([\w-]+)'))
@@ -64,8 +64,8 @@ class Changelog
     end
 
     def github_user
-      user = `git config --global credential.username`.chomp
-      warn 'Set your username with `git config --global credential.username "myusernamehere"`' if user.empty?
+      user = `git config --global user.username`.chomp
+      warn 'Set your username with `git config --global user.username "myusernamehere"`' if user.empty?
 
       user
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-solidus
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.3
 platform: ruby
 authors:
 - piyushswain
-autorequire:
+autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-07-13 00:00:00.000000000 Z
+date: 2023-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -35,6 +35,7 @@ extra_rdoc_files: []
 files:
 - ".rspec"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -58,18 +59,21 @@ files:
 - lib/rubocop/solidus.rb
 - lib/rubocop/solidus/inject.rb
 - lib/rubocop/solidus/version.rb
+- relnotes/v0.1.2.md
+- relnotes/v0.1.3.md
+- rubocop-solidus.gemspec
 - sig/rubocop/solidus.rbs
 - tasks/changelog.rake
 - tasks/changelog.rb
 - tasks/cut_release.rake
-homepage: https://www.github.com/nebulab/rubocop-solidus
+homepage: https://www.github.com/solidusio/rubocop-solidus
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://www.github.com/nebulab/rubocop-solidus
-  source_code_uri: https://www.github.com/nebulab/rubocop-solidus
-  changelog_uri: https://www.github.com/nebulab/rubocop-solidus
-post_install_message:
+  homepage_uri: https://www.github.com/solidusio/rubocop-solidus
+  source_code_uri: https://www.github.com/solidusio/rubocop-solidus
+  changelog_uri: https://www.github.com/solidusio/rubocop-solidus
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -77,15 +81,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.17
-signing_key:
+rubygems_version: 3.4.16
+signing_key: 
 specification_version: 4
 summary: Automatic Solidus code style checking tool.
 test_files: []