rubocop-sketchup 1.2.0 → 1.4.0

data/lib/rubocop/sketchup/cop/requirements/gem_install.rb

@@ -1,45 +1,45 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupRequirements
-      # It's tempting to use gems in an extension. However, there are issues if
-      # consuming them via Gem.install;
-      #
-      # * Net::HTTP is unreliable. (SSL certificate issues, OpenSSL performance
-      #   freeze under Windows)
-      # * Compiled extensions cannot be installed like this as they require
-      #   DevKit.
-      # * While downloading and installing SketchUp freezes. (Bad thing if done
-      #   automatically upon loading the extensions - especially without user
-      #   notice. It's easy to think SU have stopped working)
-      # * Version collisions. If multiple extensions want to use different
-      #   versions of a gem they will clash if the versions aren't compatible
-      #   with the features they use.
-      #
-      # They only way to ensure extensions doesn't clash is to namespace
-      # everything into extension namespace. This means making a copy of the
-      # gem you want to use and wrap it in your own namespace.
-      class GemInstall < SketchUp::Cop
-
-        include RangeHelp
-        include SketchUp::NoCommentDisable
-
-        MSG = '`Gem.install` is unreliable in SketchUp, and can cause '\
-              'extensions to clash.'
-
-        # Reference: http://rubocop.readthedocs.io/en/latest/development/
-        def_node_matcher :gem_install?, <<-PATTERN
-          (send (const nil? :Gem) :install ...)
-        PATTERN
-
-        def on_send(node)
-          return unless gem_install?(node)
-
-          range = range_with_receiver(node)
-          add_offense(node, location: range)
-        end
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupRequirements
+      # It's tempting to use gems in an extension. However, there are issues if
+      # consuming them via Gem.install;
+      #
+      # * Net::HTTP is unreliable. (SSL certificate issues, OpenSSL performance
+      #   freeze under Windows)
+      # * Compiled extensions cannot be installed like this as they require
+      #   DevKit.
+      # * While downloading and installing SketchUp freezes. (Bad thing if done
+      #   automatically upon loading the extensions - especially without user
+      #   notice. It's easy to think SU have stopped working)
+      # * Version collisions. If multiple extensions want to use different
+      #   versions of a gem they will clash if the versions aren't compatible
+      #   with the features they use.
+      #
+      # They only way to ensure extensions doesn't clash is to namespace
+      # everything into extension namespace. This means making a copy of the
+      # gem you want to use and wrap it in your own namespace.
+      class GemInstall < SketchUp::Cop
+
+        include RangeHelp
+        include SketchUp::NoCommentDisable
+
+        MSG = '`Gem.install` is unreliable in SketchUp, and can cause ' \
+              'extensions to clash.'
+
+        # Reference: http://rubocop.readthedocs.io/en/latest/development/
+        def_node_matcher :gem_install?, <<-PATTERN
+          (send (const nil? :Gem) :install ...)
+        PATTERN
+
+        def on_send(node)
+          return unless gem_install?(node)
+
+          range = range_with_receiver(node)
+          add_offense(node, location: range)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/cop/requirements/get_extension_license.rb

@@ -1,95 +1,95 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupRequirements
-      # Don't attempt to kill the Ruby interpreter by calling `exit` or `exit!`.
-      # SketchUp will trap `exit` and prevent that, with a message in the
-      # console. But `exit!` is not trapped and with terminate SketchUp without
-      # shutting down cleanly.
-      #
-      # Use `return`, `next`, `break` or `raise` instead.
-      class GetExtensionLicense < SketchUp::Cop
-
-        include RangeHelp
-        include SketchUp::NoCommentDisable
-
-        MSG_INVALID = 'Invalid extension GUID'
-
-        MSG_WRONG_TYPE = 'Only pass in extension GUID from local string '\
-                         'literals.'
-
-        MSG_TRAILING_SPACE = 'Extra space in extension GUID'
-
-        def_node_matcher :get_extension_license, <<-PATTERN
-          (send
-            (const
-              (const nil? :Sketchup) :Licensing) :get_extension_license
-            $_)
-        PATTERN
-
-        # rubocop:disable Layout/LineLength
-        EXTENSION_ID_PATTERN = /^[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12}$/.freeze
-        # rubocop:enable Layout/LineLength
-
-        def on_send(node)
-          argument = get_extension_license(node)
-          return unless argument
-
-          if argument.lvar_type?
-            variable_name = argument.children.first
-            assignment_node = find_assignment(node, variable_name)
-            argument = assignment_node.children.last if assignment_node
-          end
-
-          if argument.str_type?
-            validate_extension_id(argument)
-          else
-            location = argument.loc.expression
-            add_offense(node, location: location, message: MSG_WRONG_TYPE)
-          end
-        end
-
-        private
-
-        def find_assignment(node, variable_name)
-          scope = node
-          until scope.parent.nil?
-            scope = scope.parent
-            scope.each_child_node { |child|
-              # next unless child.is_a?(RuboCop::AST::Node)
-              next unless child.lvasgn_type?
-              next unless child.children.first == variable_name
-
-              return child
-            }
-          end
-          nil
-        end
-
-        def validate_extension_id(node)
-          extension_id = node.str_content
-
-          # Trailing spaces
-          if extension_id.rstrip.size < extension_id.size
-            end_pos = node.loc.end.begin_pos
-            begin_pos = node.loc.begin.end_pos + extension_id.rstrip.size
-            range = range_between(begin_pos, end_pos)
-            add_offense(node, location: range, message: MSG_TRAILING_SPACE)
-            return false
-          end
-
-          # Invalid format.
-          unless EXTENSION_ID_PATTERN.match?(extension_id)
-            range = string_contents_range(node)
-            add_offense(node, location: range, message: MSG_INVALID)
-            return false
-          end
-
-          true
-        end
-
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupRequirements
+      # Don't attempt to kill the Ruby interpreter by calling `exit` or `exit!`.
+      # SketchUp will trap `exit` and prevent that, with a message in the
+      # console. But `exit!` is not trapped and with terminate SketchUp without
+      # shutting down cleanly.
+      #
+      # Use `return`, `next`, `break` or `raise` instead.
+      class GetExtensionLicense < SketchUp::Cop
+
+        include RangeHelp
+        include SketchUp::NoCommentDisable
+
+        MSG_INVALID = 'Invalid extension GUID'
+
+        MSG_WRONG_TYPE = 'Only pass in extension GUID from local string ' \
+                         'literals.'
+
+        MSG_TRAILING_SPACE = 'Extra space in extension GUID'
+
+        def_node_matcher :get_extension_license, <<-PATTERN
+          (send
+            (const
+              (const nil? :Sketchup) :Licensing) :get_extension_license
+            $_)
+        PATTERN
+
+        # rubocop:disable Layout/LineLength
+        EXTENSION_ID_PATTERN = /^[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12}$/.freeze
+        # rubocop:enable Layout/LineLength
+
+        def on_send(node)
+          argument = get_extension_license(node)
+          return unless argument
+
+          if argument.lvar_type?
+            variable_name = argument.children.first
+            assignment_node = find_assignment(node, variable_name)
+            argument = assignment_node.children.last if assignment_node
+          end
+
+          if argument.str_type?
+            validate_extension_id(argument)
+          else
+            location = argument.loc.expression
+            add_offense(node, location: location, message: MSG_WRONG_TYPE)
+          end
+        end
+
+        private
+
+        def find_assignment(node, variable_name)
+          scope = node
+          until scope.parent.nil?
+            scope = scope.parent
+            scope.each_child_node { |child|
+              # next unless child.is_a?(RuboCop::AST::Node)
+              next unless child.lvasgn_type?
+              next unless child.children.first == variable_name
+
+              return child
+            }
+          end
+          nil
+        end
+
+        def validate_extension_id(node)
+          extension_id = node.str_content
+
+          # Trailing spaces
+          if extension_id.rstrip.size < extension_id.size
+            end_pos = node.loc.end.begin_pos
+            begin_pos = node.loc.begin.end_pos + extension_id.rstrip.size
+            range = range_between(begin_pos, end_pos)
+            add_offense(node, location: range, message: MSG_TRAILING_SPACE)
+            return false
+          end
+
+          # Invalid format.
+          unless EXTENSION_ID_PATTERN.match?(extension_id)
+            range = string_contents_range(node)
+            add_offense(node, location: range, message: MSG_INVALID)
+            return false
+          end
+
+          true
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/cop/requirements/global_constants.rb

@@ -1,38 +1,38 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupRequirements
-      # Extensions in SketchUp all share the same Ruby environment on the user's
-      # machine. Because of this it's important that each extension isolate
-      # itself to avoid clashing with other extensions.
-      #
-      # Extensions submitted to Extension Warehouse is expected to not define
-      # global constants.
-      class GlobalConstants < SketchUp::Cop
-
-        include SketchUp::NoCommentDisable
-        include SketchUp
-
-        MSG = 'Do not introduce global constants.'
-
-        def_node_matcher :namespaced_constant?, <<-PATTERN
-          (casgn
-            (const _ _) ...
-          )
-        PATTERN
-
-        # Constant assignment.
-        def on_casgn(node)
-          return if namespaced_constant?(node)
-
-          namespace = Namespace.new(node.parent_module_name)
-          return unless namespace.top_level?
-
-          add_offense(node, location: :name)
-        end
-
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupRequirements
+      # Extensions in SketchUp all share the same Ruby environment on the user's
+      # machine. Because of this it's important that each extension isolate
+      # itself to avoid clashing with other extensions.
+      #
+      # Extensions submitted to Extension Warehouse is expected to not define
+      # global constants.
+      class GlobalConstants < SketchUp::Cop
+
+        include SketchUp::NoCommentDisable
+        include SketchUp
+
+        MSG = 'Do not introduce global constants.'
+
+        def_node_matcher :namespaced_constant?, <<-PATTERN
+          (casgn
+            (const _ _) ...
+          )
+        PATTERN
+
+        # Constant assignment.
+        def on_casgn(node)
+          return if namespaced_constant?(node)
+
+          namespace = Namespace.new(node.parent_module_name)
+          return unless namespace.top_level?
+
+          add_offense(node, location: :name)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/cop/requirements/global_include.rb

@@ -1,42 +1,42 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupRequirements
-      # Extensions in SketchUp all share the same Ruby environment on the user's
-      # machine. Because of this it's important that each extension isolate
-      # itself to avoid clashing with other extensions.
-      #
-      # Extensions submitted to Extension Warehouse is expected to not pollute
-      # the global namespace by including mix-in modules.
-      class GlobalInclude < SketchUp::Cop
-
-        include SketchUp::NoCommentDisable
-        include SketchUp
-
-        MSG = 'Do not include into global namespace.'
-
-        def_node_matcher :is_include?, <<-PATTERN
-          (send nil? :include ...)
-        PATTERN
-
-        def on_send(node)
-          return unless global_include?(node)
-
-          add_offense(node, location: :selector)
-        end
-
-        private
-
-        def global_include?(node)
-          is_include?(node) && global_namespace?(node)
-        end
-
-        def global_namespace?(node)
-          %w[Kernel Object].include?(node.parent_module_name)
-        end
-
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupRequirements
+      # Extensions in SketchUp all share the same Ruby environment on the user's
+      # machine. Because of this it's important that each extension isolate
+      # itself to avoid clashing with other extensions.
+      #
+      # Extensions submitted to Extension Warehouse is expected to not pollute
+      # the global namespace by including mix-in modules.
+      class GlobalInclude < SketchUp::Cop
+
+        include SketchUp::NoCommentDisable
+        include SketchUp
+
+        MSG = 'Do not include into global namespace.'
+
+        def_node_matcher :is_include?, <<-PATTERN
+          (send nil? :include ...)
+        PATTERN
+
+        def on_send(node)
+          return unless global_include?(node)
+
+          add_offense(node, location: :selector)
+        end
+
+        private
+
+        def global_include?(node)
+          is_include?(node) && global_namespace?(node)
+        end
+
+        def global_namespace?(node)
+          %w[Kernel Object].include?(node.parent_module_name)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/cop/requirements/global_methods.rb

@@ -1,65 +1,65 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupRequirements
-      # Extensions in SketchUp all share the same Ruby environment on the user's
-      # machine. Because of this it's important that each extension isolate
-      # itself to avoid clashing with other extensions.
-      #
-      # Extensions submitted to Extension Warehouse is expected to not define
-      # global methods.
-      class GlobalMethods < SketchUp::Cop
-
-        include SketchUp::NoCommentDisable
-        include SketchUp
-
-        MSG = 'Do not introduce global methods.'
-
-        # Reference: http://www.rubydoc.info/gems/rubocop/RuboCop/NodePattern
-        #
-        # Matchers for methods defined with this syntax:
-        #
-        # def Example.foo
-        # end
-        #
-        # def (Example::Foo).bar
-        # end
-
-        def_node_matcher :class_method?, <<-PATTERN
-          (defs
-            (const _ _) ...
-          )
-        PATTERN
-
-        def_node_matcher :class_method, <<-PATTERN
-          (defs
-            {
-              (const nil? $_)
-              (const (const nil? $_) ...)
-            }
-            ...
-          )
-        PATTERN
-
-        def on_def(node)
-          if class_method?(node)
-            class_method_parent = class_method(node)
-            namespace = Namespace.new(class_method_parent.to_s)
-          else
-            # If a method is defined inside a block then parent_module_name
-            # will return nil.
-            return if node.parent_module_name.nil?
-
-            namespace = Namespace.new(node.parent_module_name)
-          end
-          return unless namespace.top_level?
-
-          add_offense(node, location: :name)
-        end
-        alias on_defs on_def
-
-      end
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupRequirements
+      # Extensions in SketchUp all share the same Ruby environment on the user's
+      # machine. Because of this it's important that each extension isolate
+      # itself to avoid clashing with other extensions.
+      #
+      # Extensions submitted to Extension Warehouse is expected to not define
+      # global methods.
+      class GlobalMethods < SketchUp::Cop
+
+        include SketchUp::NoCommentDisable
+        include SketchUp
+
+        MSG = 'Do not introduce global methods.'
+
+        # Reference: http://www.rubydoc.info/gems/rubocop/RuboCop/NodePattern
+        #
+        # Matchers for methods defined with this syntax:
+        #
+        # def Example.foo
+        # end
+        #
+        # def (Example::Foo).bar
+        # end
+
+        def_node_matcher :class_method?, <<-PATTERN
+          (defs
+            (const _ _) ...
+          )
+        PATTERN
+
+        def_node_matcher :class_method, <<-PATTERN
+          (defs
+            {
+              (const nil? $_)
+              (const (const nil? $_) ...)
+            }
+            ...
+          )
+        PATTERN
+
+        def on_def(node)
+          if class_method?(node)
+            class_method_parent = class_method(node)
+            namespace = Namespace.new(class_method_parent.to_s)
+          else
+            # If a method is defined inside a block then parent_module_name
+            # will return nil.
+            return if node.parent_module_name.nil?
+
+            namespace = Namespace.new(node.parent_module_name)
+          end
+          return unless namespace.top_level?
+
+          add_offense(node, location: :name)
+        end
+        alias on_defs on_def
+
+      end
+    end
+  end
+end