rubocop-sketchup 0.6.0 → 0.7.0

data/lib/rubocop-sketchup.rb

@@ -1,48 +1,49 @@
-require 'rubocop'
-require 'rubocop/sketchup'
-require 'rubocop/sketchup/version'
-require 'rubocop/sketchup/inject'
-
-require 'rubocop/sketchup/formatter/extension_review'
-require 'rubocop/sketchup/config'
-require 'rubocop/sketchup/cop'
-require 'rubocop/sketchup/dc_globals'
-require 'rubocop/sketchup/dc_methods'
-require 'rubocop/sketchup/extension_project'
-require 'rubocop/sketchup/features'
-require 'rubocop/sketchup/namespace'
-require 'rubocop/sketchup/namespace_checker'
-require 'rubocop/sketchup/no_comment_disable'
-require 'rubocop/sketchup/range_help'
-require 'rubocop/sketchup/sketchup_version'
-require 'rubocop/sketchup/tool_checker'
-
-RuboCop::SketchUp::Inject.defaults!
-
-# Monkey patching the built in formatter list to add a short alias for custom
-# formatters. Naughty! Naughty!
-class RuboCop::Formatter::FormatterSet
-  formatters = BUILTIN_FORMATTERS_FOR_KEYS.dup
-  formatters['extension_review'] =
-      RuboCop::Formatter::ExtensionReviewFormatter
-  verbose = $VERBOSE
-  begin
-    $VERBOSE = nil
-    BUILTIN_FORMATTERS_FOR_KEYS = formatters.freeze
-  ensure
-    $VERBOSE = verbose
-  end
-end
-
-# Make it easier to explore available methods on a method.
-class Object
-  def methods!
-    methods.sort - Object.class.instance_methods
-  end
-end
-
-# Load all custom cops.
-pattern = File.join(__dir__, 'rubocop', 'sketchup', 'cop', '**/*rb')
-Dir.glob(pattern) { |file|
-  require file
-}
+require 'rubocop'
+require 'rubocop/sketchup'
+require 'rubocop/sketchup/version'
+require 'rubocop/sketchup/inject'
+
+require 'rubocop/sketchup/formatter/extension_review'
+require 'rubocop/sketchup/config'
+require 'rubocop/sketchup/cop'
+require 'rubocop/sketchup/dc_globals'
+require 'rubocop/sketchup/dc_methods'
+require 'rubocop/sketchup/extension_project'
+require 'rubocop/sketchup/features'
+require 'rubocop/sketchup/namespace'
+require 'rubocop/sketchup/namespace_checker'
+require 'rubocop/sketchup/no_comment_disable'
+require 'rubocop/sketchup/range_help'
+require 'rubocop/sketchup/sketchup_target_range'
+require 'rubocop/sketchup/sketchup_version'
+require 'rubocop/sketchup/tool_checker'
+
+RuboCop::SketchUp::Inject.defaults!
+
+# Monkey patching the built in formatter list to add a short alias for custom
+# formatters. Naughty! Naughty!
+class RuboCop::Formatter::FormatterSet
+  formatters = BUILTIN_FORMATTERS_FOR_KEYS.dup
+  formatters['extension_review'] =
+      RuboCop::Formatter::ExtensionReviewFormatter
+  verbose = $VERBOSE
+  begin
+    $VERBOSE = nil
+    BUILTIN_FORMATTERS_FOR_KEYS = formatters.freeze
+  ensure
+    $VERBOSE = verbose
+  end
+end
+
+# Make it easier to explore available methods on a method.
+class Object
+  def methods!
+    methods.sort - Object.class.instance_methods
+  end
+end
+
+# Load all custom cops.
+pattern = File.join(__dir__, 'rubocop', 'sketchup', 'cop', '**/*rb')
+Dir.glob(pattern) { |file|
+  require file
+}

data/lib/rubocop/sketchup.rb

@@ -1,12 +1,12 @@
-require 'pathname'
-
-module RuboCop
-  # RuboCop SketchUp project namespace
-  module SketchUp
-    PROJECT_ROOT   = Pathname.new(__dir__).parent.parent.expand_path.freeze
-    CONFIG_DEFAULT = PROJECT_ROOT.join('config', 'default.yml').freeze
-    CONFIG         = YAML.safe_load(CONFIG_DEFAULT.read).freeze
-
-    private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
-  end
-end
+require 'pathname'
+
+module RuboCop
+  # RuboCop SketchUp project namespace
+  module SketchUp
+    PROJECT_ROOT   = Pathname.new(__dir__).parent.parent.expand_path.freeze
+    CONFIG_DEFAULT = PROJECT_ROOT.join('config', 'default.yml').freeze
+    CONFIG         = YAML.safe_load(CONFIG_DEFAULT.read).freeze
+
+    private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
+  end
+end

data/lib/rubocop/sketchup/config.rb

@@ -1,63 +1,63 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module SketchUp
-    module Config
-
-      DEFAULT_CONFIGURATION =
-          SketchUp::CONFIG.fetch('AllCops').fetch('SketchUp')
-
-      private
-
-      def all_cops_config
-        config.for_all_cops
-      end
-
-      def sketchup_cops_config
-        config.for_all_cops.fetch('SketchUp', DEFAULT_CONFIGURATION)
-      end
-
-
-      def sketchup_config_key?(key)
-        return unless all_cops_config.key?('SketchUp')
-
-        all_cops_config.fetch('SketchUp').key?(key)
-      end
-
-
-      def sketchup_target_version?
-        sketchup_config_key?('TargetSketchUpVersion')
-      end
-
-      def sketchup_target_version
-        version = sketchup_cops_config.fetch('TargetSketchUpVersion')
-        version ? SketchUpVersion.new(version) : nil
-      end
-
-
-      def extension_source_path_config?
-        sketchup_config_key?('SourcePath')
-      end
-
-      def extension_source_path_config
-        sketchup_cops_config.fetch('SourcePath')
-      end
-
-
-      def encrypted_extension?
-        sketchup_config_key?('EncryptedExtension') &&
-          sketchup_cops_config.fetch('EncryptedExtension')
-      end
-
-
-      def extension_binaries?
-        sketchup_config_key?('ExtensionBinaries')
-      end
-
-      def extension_binaries
-        sketchup_cops_config.fetch('ExtensionBinaries')
-      end
-
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module SketchUp
+    module Config
+
+      DEFAULT_CONFIGURATION =
+          SketchUp::CONFIG.fetch('AllCops').fetch('SketchUp')
+
+      private
+
+      def all_cops_config
+        config.for_all_cops
+      end
+
+      def sketchup_cops_config
+        config.for_all_cops.fetch('SketchUp', DEFAULT_CONFIGURATION)
+      end
+
+
+      def sketchup_config_key?(key)
+        return unless all_cops_config.key?('SketchUp')
+
+        all_cops_config.fetch('SketchUp').key?(key)
+      end
+
+
+      def sketchup_target_version?
+        sketchup_config_key?('TargetSketchUpVersion')
+      end
+
+      def sketchup_target_version
+        version = sketchup_cops_config.fetch('TargetSketchUpVersion')
+        version ? SketchUpVersion.new(version) : nil
+      end
+
+
+      def extension_source_path_config?
+        sketchup_config_key?('SourcePath')
+      end
+
+      def extension_source_path_config
+        sketchup_cops_config.fetch('SourcePath')
+      end
+
+
+      def encrypted_extension?
+        sketchup_config_key?('EncryptedExtension') &&
+          sketchup_cops_config.fetch('EncryptedExtension')
+      end
+
+
+      def extension_binaries?
+        sketchup_config_key?('ExtensionBinaries')
+      end
+
+      def extension_binaries
+        sketchup_cops_config.fetch('ExtensionBinaries')
+      end
+
+    end
+  end
+end

data/lib/rubocop/sketchup/cop.rb

@@ -1,111 +1,111 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module SketchUp
-
-    WorkaroundCop = RuboCop::Cop::Cop.dup
-
-    # Clone of the the normal RuboCop::Cop::Cop class so we can rewrite
-    # the inherited method without breaking functionality
-    class WorkaroundCop
-      # Remove the Cop.inherited method to be a noop. Our SketchUp::Cop
-      # class will invoke the inherited hook instead
-      class << self
-        undef inherited
-        def inherited(*) end
-      end
-
-      # Special case `Module#<` so that the rspec support rubocop exports
-      # is compatible with our subclass
-      def self.<(other)
-        other.equal?(RuboCop::Cop::Cop) || super
-      end
-    end
-    private_constant(:WorkaroundCop)
-
-    # @abstract parent class to SketchUp cops
-    #
-    # The criteria for whether rubocop-sketchup analyzes a certain ruby file
-    # is configured via `AllCops/SketchUp`. For example, if you want to
-    # customize your project to scan all files within a `test/` directory
-    # then you could add this to your configuration:
-    #
-    # @example configuring analyzed paths
-    #
-    #   AllCops:
-    #     SketchUp:
-    #       SketchupDeprecations:
-    #         Exclude:
-    #         - '_test.rb$'
-    #         - '(?:^|/)test/'
-    class Cop < WorkaroundCop
-
-      include SketchUp::Config
-
-      # Invoke the original inherited hook so our cops are recognized
-      def self.inherited(subclass)
-        RuboCop::Cop::Cop.inherited(subclass)
-      end
-
-      def relevant_file?(file)
-        relevant_rubocop_sketchup_file?(file) && super
-      end
-
-      private
-
-      def default_severity
-        sketchup_severity || super
-      end
-
-      def sketchup_severity
-        case self.class.department
-        when :SketchupRequirements
-          :error
-        when :SketchupDeprecations
-          :warning
-        when :SketchupPerformance
-          :warning
-        when :SketchupSuggestions
-          :convention
-        end
-      end
-
-      def department_name
-        self.class.department.to_s
-      end
-
-      def relevant_rubocop_sketchup_file?(file)
-        !sketchup_excluded?(file)
-      end
-
-      def sketchup_excluded?(file)
-        matches_file?(file, sketchup_exclude_pattern) ||
-          matches_file?(file, sketchup_department_exclude_pattern)
-      end
-
-      def matches_file?(file, patterns)
-        path = nil
-        patterns.any? do |pattern|
-          # Try to match the absolute path, as Exclude properties are absolute.
-          next true if match_path?(pattern, file)
-
-          # Try with relative path.
-          path ||= config.path_relative_to_config(file)
-          match_path?(pattern, path)
-        end
-      end
-
-      def sketchup_department_exclude_pattern
-        sketchup_cops_config
-          .fetch(department_name, {})
-          .fetch('Exclude', [])
-      end
-
-      def sketchup_exclude_pattern
-        sketchup_cops_config
-          .fetch('Exclude', [])
-      end
-
-    end
-  end
-end
+# frozen_string_literal: true
+
+module RuboCop
+  module SketchUp
+
+    WorkaroundCop = RuboCop::Cop::Cop.dup
+
+    # Clone of the the normal RuboCop::Cop::Cop class so we can rewrite
+    # the inherited method without breaking functionality
+    class WorkaroundCop
+      # Remove the Cop.inherited method to be a noop. Our SketchUp::Cop
+      # class will invoke the inherited hook instead
+      class << self
+        undef inherited
+        def inherited(*) end
+      end
+
+      # Special case `Module#<` so that the rspec support rubocop exports
+      # is compatible with our subclass
+      def self.<(other)
+        other.equal?(RuboCop::Cop::Cop) || super
+      end
+    end
+    private_constant(:WorkaroundCop)
+
+    # @abstract parent class to SketchUp cops
+    #
+    # The criteria for whether rubocop-sketchup analyzes a certain ruby file
+    # is configured via `AllCops/SketchUp`. For example, if you want to
+    # customize your project to scan all files within a `test/` directory
+    # then you could add this to your configuration:
+    #
+    # @example configuring analyzed paths
+    #
+    #   AllCops:
+    #     SketchUp:
+    #       SketchupDeprecations:
+    #         Exclude:
+    #         - '_test.rb$'
+    #         - '(?:^|/)test/'
+    class Cop < WorkaroundCop
+
+      include SketchUp::Config
+
+      # Invoke the original inherited hook so our cops are recognized
+      def self.inherited(subclass)
+        RuboCop::Cop::Cop.inherited(subclass)
+      end
+
+      def relevant_file?(file)
+        relevant_rubocop_sketchup_file?(file) && super
+      end
+
+      private
+
+      def default_severity
+        sketchup_severity || super
+      end
+
+      def sketchup_severity
+        case self.class.department
+        when :SketchupRequirements
+          :error
+        when :SketchupDeprecations
+          :warning
+        when :SketchupPerformance
+          :warning
+        when :SketchupSuggestions
+          :convention
+        end
+      end
+
+      def department_name
+        self.class.department.to_s
+      end
+
+      def relevant_rubocop_sketchup_file?(file)
+        !sketchup_excluded?(file)
+      end
+
+      def sketchup_excluded?(file)
+        matches_file?(file, sketchup_exclude_pattern) ||
+          matches_file?(file, sketchup_department_exclude_pattern)
+      end
+
+      def matches_file?(file, patterns)
+        path = nil
+        patterns.any? do |pattern|
+          # Try to match the absolute path, as Exclude properties are absolute.
+          next true if match_path?(pattern, file)
+
+          # Try with relative path.
+          path ||= config.path_relative_to_config(file)
+          match_path?(pattern, path)
+        end
+      end
+
+      def sketchup_department_exclude_pattern
+        sketchup_cops_config
+          .fetch(department_name, {})
+          .fetch('Exclude', [])
+      end
+
+      def sketchup_exclude_pattern
+        sketchup_cops_config
+          .fetch('Exclude', [])
+      end
+
+    end
+  end
+end