rubocop-sketchup 0.2.1 → 0.3.0

data/lib/rubocop/sketchup/suggestions/dc_internals.rb

@@ -12,14 +12,14 @@ module RuboCop
         MSG = "Avoid relying on internal logic of Dynamic Components.".freeze
 
         def on_gvar(node)
-          check(node)
+          check_global(node)
         end
 
         def on_gvasgn(node)
-          check(node)
+          check_global(node)
         end
 
-        def check(node)
+        def check_global(node)
           global_var, = *node
           return unless dc_global_var?(global_var)
           add_offense(node, location: :name, severity: :error)

data/lib/rubocop/sketchup/suggestions/file_encoding.rb

@@ -45,9 +45,7 @@ module RuboCop
 
 
         def_node_search :force_encoding, <<-PATTERN
-          (send
-            (_ $_)
-            :force_encoding ...)
+          (send ({lvar ivar cvar} $_) :force_encoding ...)
         PATTERN
 
         def on_assign(node)
@@ -61,7 +59,6 @@ module RuboCop
           add_offense(node)
         end
 
-        # TODO: Review this list of aliases.
         alias on_lvasgn   on_assign
         alias on_masgn    on_assign
         alias on_casgn    on_assign

data/lib/rubocop/sketchup/suggestions/monkey_patched_api.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module SketchupSuggestions
+      # Some of the shipped extensions in SketchUp monkey-patch the API
+      # namespace. This is an unfortunate no-no that was done a long time ago
+      # before the extension best-practices were established. These functions
+      # might change or be removed at any time. They will also not work when
+      # the extensions are disabled. Avoid using these methods.
+      class MonkeyPatchedApi < Cop
+
+        include SketchUp::DynamicComponentMethods
+
+        def on_send(node)
+          # Only check instance methods.
+          return if node.receiver && node.receiver.const_type?
+
+          name = node.method_name
+
+          dc_method = DC_METHODS.find { |m| m[:name] == name }
+          return unless dc_method
+
+          if dc_method.key?(:variables)
+            return unless node.receiver && node.receiver.variable?
+            receiver_name = node.receiver.children.first
+            # Account for instance and class variables.
+            receiver_name = receiver_name.to_s.tr('@', '').to_sym
+            return unless dc_method[:variables].include?(receiver_name)
+          end
+
+          path = dc_method[:path]
+          message = "#{path}##{name} is not part of the official API. "\
+                    "It's a monkey-patched addition by Dynamic Components."
+          add_offense(node, severity: :error, message: message)
+        end
+
+      end
+    end
+  end
+end

data/lib/rubocop/sketchup/suggestions/operation_name.rb

@@ -5,6 +5,8 @@ module RuboCop
     module SketchupSuggestions
       class OperationName < Cop
 
+        include RangeHelp
+
         MSG = 'Operation name should be a short capitalized description.'.freeze
         MSG_MAX = "Operation names should not be short and concise. [%d/%d]".freeze
 

data/lib/rubocop/sketchup/suggestions/sketchup_require.rb

@@ -25,9 +25,30 @@ module RuboCop
           )
         PATTERN
 
+
+        def_node_matcher :sketchup_extension_new, <<-PATTERN
+          (send
+            (const nil? :SketchupExtension) :new
+            _
+            (str $_))
+        PATTERN
+
+        def_node_matcher :sketchup_extension_new?, <<-PATTERN
+          (send
+            (const nil? :SketchupExtension) :new
+            _
+            (str _))
+        PATTERN
+
+
         def on_send(node)
-          return unless sketchup_require?(node)
-          filename = sketchup_require(node)
+          if sketchup_require?(node)
+            filename = sketchup_require(node)
+          elsif sketchup_extension_new?(node)
+            filename = sketchup_extension_new(node)
+          else
+            return
+          end
           add_offense(node, location: :expression) unless valid_filename?(filename)
         end
 
@@ -36,6 +57,7 @@ module RuboCop
         def valid_filename?(filename)
           File.extname(filename).empty?
         end
+
       end
     end
   end

data/lib/rubocop/sketchup/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module SketchUp
-    VERSION = '0.2.1'
+    VERSION = '0.3.0'
   end
 end

data/rubocop-sketchup.gemspec

@@ -25,6 +25,6 @@ Gem::Specification.new do |spec|
 
   # NOTE: Remember to update the README.md instructions on how to install
   #       compatible RuboCop version.
-  spec.add_dependency 'rubocop', '~> 0.52.0'
+  spec.add_dependency 'rubocop', '~> 0.54.0'
   spec.add_development_dependency 'bundler', '~> 1.13'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sketchup
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Trimble Inc, SketchUp Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-05 00:00:00.000000000 Z
+date: 2018-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.52.0
+        version: 0.54.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.52.0
+        version: 0.54.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -50,6 +50,7 @@ files:
 - lib/rubocop/sketchup.rb
 - lib/rubocop/sketchup/config.rb
 - lib/rubocop/sketchup/dc_globals.rb
+- lib/rubocop/sketchup/dc_methods.rb
 - lib/rubocop/sketchup/deprecations/add_separator_to_menu.rb
 - lib/rubocop/sketchup/deprecations/operation_next_transparent.rb
 - lib/rubocop/sketchup/deprecations/require_all.rb
@@ -57,6 +58,7 @@ files:
 - lib/rubocop/sketchup/deprecations/show_ruby_panel.rb
 - lib/rubocop/sketchup/deprecations/sketchup_set.rb
 - lib/rubocop/sketchup/extension_project.rb
+- lib/rubocop/sketchup/features.rb
 - lib/rubocop/sketchup/formatter/extension_review.rb
 - lib/rubocop/sketchup/inject.rb
 - lib/rubocop/sketchup/namespace.rb
@@ -71,19 +73,24 @@ files:
 - lib/rubocop/sketchup/requirements/extension_namespace.rb
 - lib/rubocop/sketchup/requirements/file_structure.rb
 - lib/rubocop/sketchup/requirements/global_constants.rb
+- lib/rubocop/sketchup/requirements/global_include.rb
 - lib/rubocop/sketchup/requirements/global_methods.rb
 - lib/rubocop/sketchup/requirements/global_variables.rb
 - lib/rubocop/sketchup/requirements/language_handler_globals.rb
 - lib/rubocop/sketchup/requirements/load_path.rb
 - lib/rubocop/sketchup/requirements/minimal_registration.rb
+- lib/rubocop/sketchup/requirements/observers_start_operation.rb
 - lib/rubocop/sketchup/requirements/register_extension.rb
 - lib/rubocop/sketchup/requirements/ruby_core_namespace.rb
 - lib/rubocop/sketchup/requirements/ruby_stdlib_namespace.rb
 - lib/rubocop/sketchup/requirements/shipped_extensions_namespace.rb
 - lib/rubocop/sketchup/requirements/sketchup_extension.rb
+- lib/rubocop/sketchup/sketchup_version.rb
+- lib/rubocop/sketchup/suggestions/compatibility.rb
 - lib/rubocop/sketchup/suggestions/dc_internals.rb
 - lib/rubocop/sketchup/suggestions/file_encoding.rb
 - lib/rubocop/sketchup/suggestions/model_entities.rb
+- lib/rubocop/sketchup/suggestions/monkey_patched_api.rb
 - lib/rubocop/sketchup/suggestions/operation_name.rb
 - lib/rubocop/sketchup/suggestions/sketchup_find_support_file.rb
 - lib/rubocop/sketchup/suggestions/sketchup_require.rb