rubocop-sketchup 0.15.3 → 0.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a1cf2e12c3df5de41cd1e8946347d84d9d75a2eba781a04d7b57a4919b32268c
-  data.tar.gz: b689f16ac44a191e5b8909a3c39667e99c02648a48cbbf5bca4a4118a9fd289b
+  metadata.gz: 296266d556b988a46320807d3f1a7023a29eac0f27d1d6c224c5cc86554ddf1b
+  data.tar.gz: 8d0c5a738811e681ddbcab81d5c6ab93ee6228c0d1e9cf9154bc225bb5452f06
 SHA512:
-  metadata.gz: ec1337ac7cd214bace6109aab6d657d99d14d11ee72889578bcafdba3444000f93adde46b47e893ccfe6f1d00a28adb9064bebed910d3a2a8d0f5288b64637b5
-  data.tar.gz: 83a975e6b7821d340f4efc335cf368b6f94d1a91873e08d6a98f0cf90c4cdf81f7cd61fd25176c181577fb1a53f810296d8c13ed84e72c975708c4f66f106d07
+  metadata.gz: a8916d683a516025a8ed848037b65f5a2e6772e973fcd709ebacc010c71ab9bf3ea63acb8926cd8fb3e627cd98c05505240925705d60295fa7c0619f1928476e
+  data.tar.gz: 60e5d532f3ee97a3789ab30b9027b3f17e0e967eead46a64708df9706dca992eab8884b05f1f05b8eb3eaca7d9a799a4679f7cfb00b77be07e5b9625f618015e

data/Gemfile

@@ -8,12 +8,12 @@ group :test do
   gem 'appveyor-worker', '~> 0.2', require: false
   gem 'rake', '~> 12.0', require: false
   gem 'rspec', '~> 3.7', require: false
+  gem 'rubocop-performance', '~> 1.7.0', require: false
+  gem 'simplecov', '~> 0.10', require: false
 end
 
 group :development do
   gem 'bump', '~> 0.5', require: false
-  gem 'rubocop-performance', require: false
-  gem 'simplecov', '~> 0.10', require: false
   gem 'solargraph', '~> 0.34', require: false
   gem 'thor', '~> 0.20', require: false
   gem 'yard', '~> 0.9', require: false

data/config/default.yml

@@ -18,7 +18,7 @@ AllCops:
     ExtensionBinaries: []
     # You can set up exclude pattens for all SketchUp departments.
     Exclude: []
-    # Alternativly you can set up department wide exclusion.
+    # Alternatively you can set up department wide exclusion.
     SketchupBugs:
       Exclude: []
     SketchupDeprecations:
@@ -156,7 +156,7 @@ SketchupRequirements/ExtensionNamespace:
   Description: Confine extensions to a single root namespace.
   Details: >-
              To avoid clashing with other extensions a single root namespace
-             should all the extension's code.
+             should contain all the extension's code.
   Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#extensionnamespace
   Exceptions: []
   Enabled: true

data/lib/rubocop-sketchup.rb

@@ -39,7 +39,7 @@ end
 
 # Make it easier to explore available methods on a method.
 class Object
-  def methods!(queries = true)
+  def methods!(queries = true) # rubocop:disable Style/OptionalBooleanParameter
     sorted = methods.sort - Object.class.instance_methods
     sorted.reject! { |m| m.to_s.end_with?('?') } unless queries
     sorted

data/lib/rubocop/sketchup/cop.rb

@@ -12,7 +12,7 @@ module RuboCop
       # class will invoke the inherited hook instead
       class << self
         undef inherited
-        def inherited(*) end
+        def inherited(*) end # rubocop:disable Lint/MissingSuper
       end
 
       # Special case `Module#<` so that the rspec support rubocop exports
@@ -42,8 +42,16 @@ module RuboCop
 
       include SketchUp::Config
 
+      SKETCHUP_DEPARTMENT_SEVERITY = {
+        SketchupRequirements: :error,
+        SketchupDeprecations: :warning,
+        SketchupPerformance: :warning,
+        SketchupBugs: :warning,
+        SketchupSuggestions: :convention,
+      }.freeze
+
       # Invoke the original inherited hook so our cops are recognized
-      def self.inherited(subclass)
+      def self.inherited(subclass) # rubocop:disable Lint/MissingSuper
         RuboCop::Cop::Cop.inherited(subclass)
       end
 
@@ -58,16 +66,7 @@ module RuboCop
       end
 
       def sketchup_severity
-        case self.class.department
-        when :SketchupRequirements
-          :error
-        when :SketchupDeprecations
-          :warning
-        when :SketchupPerformance
-          :warning
-        when :SketchupSuggestions
-          :convention
-        end
+        SKETCHUP_DEPARTMENT_SEVERITY[self.class.department]
       end
 
       def department_name

data/lib/rubocop/sketchup/cop/requirements/get_extension_license.rb

@@ -80,7 +80,7 @@ module RuboCop
           end
 
           # Invalid format.
-          if extension_id !~ EXTENSION_ID_PATTERN
+          unless EXTENSION_ID_PATTERN.match?(extension_id)
             range = string_contents_range(node)
             add_offense(node, location: range, message: MSG_INVALID)
             return false

data/lib/rubocop/sketchup/features.rb

@@ -41,6 +41,62 @@ module RuboCop
 
       FEATURES = [
 
+        {
+          version: 'SketchUp 2021.0',
+          types: {
+            class: [
+              'Sketchup::LayerFolder',
+            ],
+            method: [
+              'Sketchup.redo',
+              'Sketchup::ComponentDefinition#live_component?',
+              'Sketchup::Layer#folder',
+              'Sketchup::Layer#folder=',
+              'Sketchup::LayerFolder#==',
+              'Sketchup::LayerFolder#add_folder',
+              'Sketchup::LayerFolder#add_layer',
+              'Sketchup::LayerFolder#count_folders',
+              'Sketchup::LayerFolder#count_layers',
+              'Sketchup::LayerFolder#display_name',
+              'Sketchup::LayerFolder#each',
+              'Sketchup::LayerFolder#each_folder',
+              'Sketchup::LayerFolder#each_layer',
+              'Sketchup::LayerFolder#folder',
+              'Sketchup::LayerFolder#folder=',
+              'Sketchup::LayerFolder#folders',
+              'Sketchup::LayerFolder#layers',
+              'Sketchup::LayerFolder#length',
+              'Sketchup::LayerFolder#name',
+              'Sketchup::LayerFolder#name=',
+              'Sketchup::LayerFolder#remove_folder',
+              'Sketchup::LayerFolder#remove_layer',
+              'Sketchup::LayerFolder#size',
+              'Sketchup::LayerFolder#visible=',
+              'Sketchup::LayerFolder#visible?',
+              'Sketchup::LayerFolder#visible_on_new_pages=',
+              'Sketchup::LayerFolder#visible_on_new_pages?',
+              'Sketchup::Layers#add_folder',
+              'Sketchup::Layers#count_folders',
+              'Sketchup::Layers#count_layers',
+              'Sketchup::Layers#each_folder',
+              'Sketchup::Layers#each_layer',
+              'Sketchup::Layers#folders',
+              'Sketchup::Layers#layers',
+              'Sketchup::Layers#purge_unused_folders',
+              'Sketchup::Layers#remove_folder',
+              'Sketchup::LayersObserver#onLayerFolderAdded',
+              'Sketchup::LayersObserver#onLayerFolderChanged',
+              'Sketchup::LayersObserver#onLayerFolderRemoved',
+              'Sketchup::LayersObserver#onParentFolderChanged',
+              'Sketchup::Page#layer_folders',
+              'Sketchup::Skp.read_guid',
+            ],
+            module: [
+              'Sketchup::Skp',
+            ],
+          },
+        },
+
         {
           version: 'LayOut 2020.1',
           types: {
@@ -1137,6 +1193,8 @@ module RuboCop
         add_classification
         add_dimension_linear
         add_dimension_radial
+        add_folder
+        add_layer
         add_matchphoto_page
         add_section_plane
         aligned_text_position
@@ -1154,10 +1212,14 @@ module RuboCop
         colorize_deltas
         colorize_type
         colorize_type=
+        count_folders
+        count_layers
         count_used_instances
         dash_scale
         days_remaining
         drawing_element_visible?
+        each_folder
+        each_layer
         edit_transform
         effects_modified?
         end_attached_to
@@ -1188,6 +1250,7 @@ module RuboCop
         instance_path_from_pid_path
         is_polygon?
         large_icon
+        layer_folders
         layers_modified?
         leader_break_point
         leader_break_point=
@@ -1195,6 +1258,7 @@ module RuboCop
         line_style
         line_style=
         line_styles
+        live_component?
         load_from_url
         load_on_start?
         load_schema
@@ -1221,6 +1285,7 @@ module RuboCop
         persistent_id_path
         refresh_thumbnail
         remove_classification
+        remove_folder
         reset_camera
         reset_effects
         reset_layers
@@ -1251,6 +1316,8 @@ module RuboCop
         unload_schema
         upper_left
         upper_right
+        visible_on_new_pages?
+        visible_on_new_pages=
         winding
         window_pick
       ].freeze
@@ -1263,6 +1330,10 @@ module RuboCop
         onElementModified
         onExplode
         onLayerChanged
+        onLayerFolderAdded
+        onLayerFolderChanged
+        onLayerFolderRemoved
+        onParentFolderChanged
         onPidChanged
         onPlaceComponent
         onPostSaveModel

data/lib/rubocop/sketchup/formatter/extension_review.rb

@@ -207,7 +207,7 @@ module RuboCop
         end
 
         # Make Kernel#binding public.
-        def binding
+        def binding # rubocop:disable Lint/UselessMethodDefinition
           super
         end
 

data/lib/rubocop/sketchup/sketchup_version.rb

@@ -17,9 +17,10 @@ module RuboCop
       #   @param [Integer, Float] version
       #   @param [Integer] maintenance
       def initialize(*args)
-        if args.size == 1
+        case args.size
+        when 1
           @version, @maintenance = parse_version(args.first)
-        elsif args.size == 2
+        when 2
           validate(args)
           @version, @maintenance = args
         else
@@ -66,6 +67,7 @@ module RuboCop
       #
       # The second item in the array is maintenance annotation
       VALID_VERSIONS = [
+        [2021.0, 0],
         [2020.1, 0],
         [2020.0, 0],
         [2019.2, 0],
@@ -93,7 +95,8 @@ module RuboCop
       def parse_version(version)
         v = 0
         m = 0
-        if version.is_a?(String)
+        case version
+        when String
           # Treat all LayOut versions as SketchUp versions for now.
           normalized_version = version.gsub('LayOut', 'SketchUp')
           result = normalized_version.match(VERSION_NUMBER_REGEX)
@@ -101,7 +104,7 @@ module RuboCop
             v = result.captures[0].to_f
             m = (result.captures[1] || '0').to_i
           end
-        elsif version.is_a?(Numeric)
+        when Numeric
           v = version
           m = 0
         end

data/lib/rubocop/sketchup/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module SketchUp
-    VERSION = '0.15.3'
+    VERSION = '0.18.0'
   end
 end

data/rubocop-sketchup.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
 
   spec.version = RuboCop::SketchUp::VERSION
   spec.platform = Gem::Platform::RUBY
-  spec.required_ruby_version = '>= 2.3.0'
+  spec.required_ruby_version = '>= 2.4.0'
 
   spec.require_paths = ['lib']
   spec.files = Dir[
@@ -24,6 +24,6 @@ Gem::Specification.new do |spec|
       'Gemfile'
   ]
 
-  spec.add_dependency 'rubocop', '>= 0.80', '<= 0.81'
+  spec.add_dependency 'rubocop', '>= 0.82', '<= 0.93'
   spec.add_development_dependency 'bundler', '>= 1.13', '< 3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sketchup
 version: !ruby/object:Gem::Version
-  version: 0.15.3
+  version: 0.18.0
 platform: ruby
 authors:
 - Trimble Inc, SketchUp Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-08 00:00:00.000000000 Z
+date: 2020-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,20 +16,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.82'
     - - "<="
       - !ruby/object:Gem::Version
-        version: '0.81'
+        version: '0.93'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.82'
     - - "<="
       - !ruby/object:Gem::Version
-        version: '0.81'
+        version: '0.93'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -137,7 +137,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="