rubocop-sketchup 0.15.2 → 0.17.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb8f59f597a5b011ae7965be3f569d599a17a6d8ef31f6e641fb308e4aa5babb
-  data.tar.gz: 62a2a93290ee790d319ed0ba4bb83b536c74bbcfba1e66d9bc1fee07795276f2
+  metadata.gz: 6bd27f360422724e5ad35227388ddee8d1f731ea1f42c1f6b898a59c720b800f
+  data.tar.gz: 31dbfc388b6dedef075bdde3d923a67d0ede2d4dfa0e7a983bbec0d8c59e43f1
 SHA512:
-  metadata.gz: 602d081ad3a47adc82b36a8a831d47cf725500e9400a52837e9f1247db2726d952613c76e98cc5e2ca93696d65728febcb6b7e6bbe96ec1b9e25574677c3c72c
-  data.tar.gz: f8cf43e865b96a80cc86fc8f20f4ac6890bce824630f0359135f7e9c81c8a1211189956a72409098bf0a029834db7794e30f55841e1544d0ba28ee87a6680716
+  metadata.gz: e93bf11a5c0f44a553b7bbb48538c202694cb2385b1cfe94dc2b241ab8465a089b3d85fa2d9ec14bde7067ffe8cd031d4ff072087a8335c00d2f6a488f4c054e
+  data.tar.gz: 64dc81a2c59e85bb6b42629326e5663beeed6fc62ed0df1be56a507ed0ef32e0fe8b662f1dd0d30bbcf6faa727f3053668a6dac6b649198d8d42dd512666e058

data/Gemfile

@@ -8,12 +8,12 @@ group :test do
   gem 'appveyor-worker', '~> 0.2', require: false
   gem 'rake', '~> 12.0', require: false
   gem 'rspec', '~> 3.7', require: false
+  gem 'rubocop-performance', '~> 1.7.0', require: false
+  gem 'simplecov', '~> 0.10', require: false
 end
 
 group :development do
   gem 'bump', '~> 0.5', require: false
-  gem 'rubocop-performance', require: false
-  gem 'simplecov', '~> 0.10', require: false
   gem 'solargraph', '~> 0.34', require: false
   gem 'thor', '~> 0.20', require: false
   gem 'yard', '~> 0.9', require: false

data/config/default.yml

@@ -18,7 +18,7 @@ AllCops:
     ExtensionBinaries: []
     # You can set up exclude pattens for all SketchUp departments.
     Exclude: []
-    # Alternativly you can set up department wide exclusion.
+    # Alternatively you can set up department wide exclusion.
     SketchupBugs:
       Exclude: []
     SketchupDeprecations:
@@ -156,7 +156,7 @@ SketchupRequirements/ExtensionNamespace:
   Description: Confine extensions to a single root namespace.
   Details: >-
              To avoid clashing with other extensions a single root namespace
-             should all the extension's code.
+             should contain all the extension's code.
   Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#extensionnamespace
   Exceptions: []
   Enabled: true

data/lib/rubocop-sketchup.rb

@@ -39,7 +39,7 @@ end
 
 # Make it easier to explore available methods on a method.
 class Object
-  def methods!(queries = true)
+  def methods!(queries = true) # rubocop:disable Style/OptionalBooleanParameter
     sorted = methods.sort - Object.class.instance_methods
     sorted.reject! { |m| m.to_s.end_with?('?') } unless queries
     sorted

data/lib/rubocop/sketchup/cop.rb

@@ -12,7 +12,7 @@ module RuboCop
       # class will invoke the inherited hook instead
       class << self
         undef inherited
-        def inherited(*) end
+        def inherited(*) end # rubocop:disable Lint/MissingSuper
       end
 
       # Special case `Module#<` so that the rspec support rubocop exports
@@ -42,8 +42,16 @@ module RuboCop
 
       include SketchUp::Config
 
+      SKETCHUP_DEPARTMENT_SEVERITY = {
+        SketchupRequirements: :error,
+        SketchupDeprecations: :warning,
+        SketchupPerformance: :warning,
+        SketchupBugs: :warning,
+        SketchupSuggestions: :convention,
+      }.freeze
+
       # Invoke the original inherited hook so our cops are recognized
-      def self.inherited(subclass)
+      def self.inherited(subclass) # rubocop:disable Lint/MissingSuper
         RuboCop::Cop::Cop.inherited(subclass)
       end
 
@@ -58,16 +66,7 @@ module RuboCop
       end
 
       def sketchup_severity
-        case self.class.department
-        when :SketchupRequirements
-          :error
-        when :SketchupDeprecations
-          :warning
-        when :SketchupPerformance
-          :warning
-        when :SketchupSuggestions
-          :convention
-        end
+        SKETCHUP_DEPARTMENT_SEVERITY[self.class.department]
       end
 
       def department_name

data/lib/rubocop/sketchup/cop/requirements/get_extension_license.rb

@@ -80,7 +80,7 @@ module RuboCop
           end
 
           # Invalid format.
-          if extension_id !~ EXTENSION_ID_PATTERN
+          unless EXTENSION_ID_PATTERN.match?(extension_id)
             range = string_contents_range(node)
             add_offense(node, location: range, message: MSG_INVALID)
             return false

data/lib/rubocop/sketchup/formatter/extension_review.rb

@@ -207,7 +207,7 @@ module RuboCop
         end
 
         # Make Kernel#binding public.
-        def binding
+        def binding # rubocop:disable Lint/UselessMethodDefinition
           super
         end
 

data/lib/rubocop/sketchup/sketchup_version.rb

@@ -17,9 +17,10 @@ module RuboCop
       #   @param [Integer, Float] version
       #   @param [Integer] maintenance
       def initialize(*args)
-        if args.size == 1
+        case args.size
+        when 1
           @version, @maintenance = parse_version(args.first)
-        elsif args.size == 2
+        when 2
           validate(args)
           @version, @maintenance = args
         else
@@ -93,7 +94,8 @@ module RuboCop
       def parse_version(version)
         v = 0
         m = 0
-        if version.is_a?(String)
+        case version
+        when String
           # Treat all LayOut versions as SketchUp versions for now.
           normalized_version = version.gsub('LayOut', 'SketchUp')
           result = normalized_version.match(VERSION_NUMBER_REGEX)
@@ -101,7 +103,7 @@ module RuboCop
             v = result.captures[0].to_f
             m = (result.captures[1] || '0').to_i
           end
-        elsif version.is_a?(Numeric)
+        when Numeric
           v = version
           m = 0
         end

data/lib/rubocop/sketchup/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module SketchUp
-    VERSION = '0.15.2'
+    VERSION = '0.17.1'
   end
 end

data/rubocop-sketchup.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
 
   spec.version = RuboCop::SketchUp::VERSION
   spec.platform = Gem::Platform::RUBY
-  spec.required_ruby_version = '>= 2.3.0'
+  spec.required_ruby_version = '>= 2.4.0'
 
   spec.require_paths = ['lib']
   spec.files = Dir[
@@ -24,6 +24,6 @@ Gem::Specification.new do |spec|
       'Gemfile'
   ]
 
-  spec.add_dependency 'rubocop', '>= 0.80', '<= 0.80'
+  spec.add_dependency 'rubocop', '>= 0.82', '<= 0.93'
   spec.add_development_dependency 'bundler', '>= 1.13', '< 3.0'
 end

metadata

@@ -1,35 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sketchup
 version: !ruby/object:Gem::Version
-  version: 0.15.2
+  version: 0.17.1
 platform: ruby
 authors:
 - Trimble Inc, SketchUp Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-08 00:00:00.000000000 Z
+date: 2020-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<="
-      - !ruby/object:Gem::Version
-        version: '0.80'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.82'
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '0.93'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<="
-      - !ruby/object:Gem::Version
-        version: '0.80'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.82'
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '0.93'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -137,7 +137,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="