rubocop-sketchup 0.15.1 → 0.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2334f4c89d95d0a67f773420a64210548648972215ffd39604e31d8f41eb7772
-  data.tar.gz: d7fedb24560c0dd565d047697cfce245ae981326ffdf0f1ad6051a6782fc755e
+  metadata.gz: a7df76ab15e23629404f20058b4526fa349087d3565698da08ffc7cf684a4e76
+  data.tar.gz: 4854d4b9c5867484d75e80d9ab2a73d66928b73ebf3ba3690c6806dc609b93e2
 SHA512:
-  metadata.gz: 4ba542095b93c86c14fd5d99a0a8f97da03c697f4365d27101c278f548e3fec968cb7085c3c9de03ce75789cb15e866c7a9e5fe489e3cf1f213b73e7bf63b954
-  data.tar.gz: a706d89507d0dffa87085e5951267daab6f4815fcaf55f3261af7b4c1ca9b2fc7b72ef86aa6bef9398a777a6db74e2b2dd91bc1612cb3235e7e5fca43daba4b6
+  metadata.gz: ff776f302d5439f1b44324a4b41155f39b4cae4396d18675265fe17a696ec3220530f5b76cdf409aa1e28a6eac21f7be2c1e5e6ded7fcba53acdb71a91b58958
+  data.tar.gz: c54421dc0d103ac574be46ce850906282710fdb6e2ad1d3e3214596122f4d47154fc9017bc1ead17a8fe78aa2867eb8c333e6b7a9e923723638975f6c3d34499

data/Gemfile

@@ -8,12 +8,12 @@ group :test do
   gem 'appveyor-worker', '~> 0.2', require: false
   gem 'rake', '~> 12.0', require: false
   gem 'rspec', '~> 3.7', require: false
+  gem 'rubocop-performance', '~> 1.7.0', require: false
+  gem 'simplecov', '~> 0.10', require: false
 end
 
 group :development do
   gem 'bump', '~> 0.5', require: false
-  gem 'rubocop-performance', require: false
-  gem 'simplecov', '~> 0.10', require: false
   gem 'solargraph', '~> 0.34', require: false
   gem 'thor', '~> 0.20', require: false
   gem 'yard', '~> 0.9', require: false

data/lib/rubocop/sketchup/cop.rb

@@ -42,6 +42,14 @@ module RuboCop
 
       include SketchUp::Config
 
+      SKETCHUP_DEPARTMENT_SEVERITY = {
+        SketchupRequirements: :error,
+        SketchupDeprecations: :warning,
+        SketchupPerformance: :warning,
+        SketchupBugs: :warning,
+        SketchupSuggestions: :convention,
+      }.freeze
+
       # Invoke the original inherited hook so our cops are recognized
       def self.inherited(subclass)
         RuboCop::Cop::Cop.inherited(subclass)
@@ -58,16 +66,7 @@ module RuboCop
       end
 
       def sketchup_severity
-        case self.class.department
-        when :SketchupRequirements
-          :error
-        when :SketchupDeprecations
-          :warning
-        when :SketchupPerformance
-          :warning
-        when :SketchupSuggestions
-          :convention
-        end
+        SKETCHUP_DEPARTMENT_SEVERITY[self.class.department]
       end
 
       def department_name

data/lib/rubocop/sketchup/cop/requirements/get_extension_license.rb

@@ -80,7 +80,7 @@ module RuboCop
           end
 
           # Invalid format.
-          if extension_id !~ EXTENSION_ID_PATTERN
+          unless EXTENSION_ID_PATTERN.match?(extension_id)
             range = string_contents_range(node)
             add_offense(node, location: range, message: MSG_INVALID)
             return false

data/lib/rubocop/sketchup/features.rb

@@ -18,9 +18,16 @@
 # positives. The method names should be names that are not commonly used in
 # general context.
 #
+# Since it's difficult to know what a variable in Ruby code represent by static
+# analysis, these methods are assumed to belong to the FEATURES list.
+#
 # When a new version is released and FEATURES is updated the new methods from
 # the new version should be considered for this list.
 #
+# TODO(thomthom): Investigate if Solargraph's static analysis can be used to
+#   provide a more accurate analysis. Not sure how well it works on code bases
+#   that isn't well documented with YARD type tags.
+#
 #
 # OBSERVER_METHODS constant:
 #
@@ -34,6 +41,48 @@ module RuboCop
 
       FEATURES = [
 
+        {
+          version: 'LayOut 2020.1',
+          types: {
+            method: [
+              'Layout::Document#export',
+              'Layout::Grid#clip_to_margins=',
+              'Layout::Grid#clip_to_margins?',
+              'Layout::Grid#in_front=',
+              'Layout::Grid#in_front?',
+              'Layout::Grid#major_color=',
+              'Layout::Grid#major_spacing=',
+              'Layout::Grid#minor_color=',
+              'Layout::Grid#minor_divisions=',
+              'Layout::Grid#print=',
+              'Layout::Grid#show=',
+              'Layout::Grid#show_major=',
+              'Layout::Grid#show_minor=',
+              'Layout::SketchUpModel#camera_modified?',
+              'Layout::SketchUpModel#effects_modified?',
+              'Layout::SketchUpModel#layers_modified?',
+              'Layout::SketchUpModel#reset_camera',
+              'Layout::SketchUpModel#reset_effects',
+              'Layout::SketchUpModel#reset_layers',
+              'Layout::SketchUpModel#reset_style',
+              'Layout::SketchUpModel#style_modified?',
+            ],
+          },
+        },
+
+        {
+          version: 'SketchUp 2020.1',
+          types: {
+            method: [
+              'Sketchup::Entities#weld',
+              'Sketchup::Page#use_hidden_geometry=',
+              'Sketchup::Page#use_hidden_geometry?',
+              'Sketchup::Page#use_hidden_objects=',
+              'Sketchup::Page#use_hidden_objects?',
+            ],
+          },
+        },
+
         {
           version: 'SketchUp 2020.0',
           types: {
@@ -1097,8 +1146,11 @@ module RuboCop
         attached_to
         attached_to=
         boundingbox_pick
+        camera_modified?
         center_2d
         classifications
+        clip_to_margins?
+        clip_to_margins=
         colorize_deltas
         colorize_type
         colorize_type=
@@ -1107,6 +1159,7 @@ module RuboCop
         days_remaining
         drawing_element_visible?
         edit_transform
+        effects_modified?
         end_attached_to
         end_attached_to=
         error_description
@@ -1127,12 +1180,15 @@ module RuboCop
         icon_tooltip
         icon_tooltip=
         image_rep
+        in_front?
+        in_front=
         include_in_animation?
         include_in_animation=
         instance_path
         instance_path_from_pid_path
         is_polygon?
         large_icon
+        layers_modified?
         leader_break_point
         leader_break_point=
         leader_points
@@ -1145,7 +1201,11 @@ module RuboCop
         local_bounds
         lower_left
         lower_right
+        major_color=
+        major_spacing=
         menu_text
+        minor_color=
+        minor_divisions=
         mipmapping?
         mipmapping=
         navigation_buttons_enabled?
@@ -1161,6 +1221,10 @@ module RuboCop
         persistent_id_path
         refresh_thumbnail
         remove_classification
+        reset_camera
+        reset_effects
+        reset_layers
+        reset_style
         same_direction?
         scale_2d
         screen_scale_factor
@@ -1174,11 +1238,14 @@ module RuboCop
         set_upload_progress_callback
         set_uv
         show_differences
+        show_major=
+        show_minor=
         sketch_plane
         small_icon
         start_attached_to
         start_attached_to=
         status_bar_text
+        style_modified?
         text_bounds
         unit_vector?
         unload_schema

data/lib/rubocop/sketchup/sketchup_version.rb

@@ -17,9 +17,10 @@ module RuboCop
       #   @param [Integer, Float] version
       #   @param [Integer] maintenance
       def initialize(*args)
-        if args.size == 1
+        case args.size
+        when 1
           @version, @maintenance = parse_version(args.first)
-        elsif args.size == 2
+        when 2
           validate(args)
           @version, @maintenance = args
         else
@@ -66,6 +67,7 @@ module RuboCop
       #
       # The second item in the array is maintenance annotation
       VALID_VERSIONS = [
+        [2020.1, 0],
         [2020.0, 0],
         [2019.2, 0],
         [2019.0, 0], # SketchUp dropped M notation as of SU2019.
@@ -92,7 +94,8 @@ module RuboCop
       def parse_version(version)
         v = 0
         m = 0
-        if version.is_a?(String)
+        case version
+        when String
           # Treat all LayOut versions as SketchUp versions for now.
           normalized_version = version.gsub('LayOut', 'SketchUp')
           result = normalized_version.match(VERSION_NUMBER_REGEX)
@@ -100,7 +103,7 @@ module RuboCop
             v = result.captures[0].to_f
             m = (result.captures[1] || '0').to_i
           end
-        elsif version.is_a?(Numeric)
+        when Numeric
           v = version
           m = 0
         end

data/lib/rubocop/sketchup/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module SketchUp
-    VERSION = '0.15.1'
+    VERSION = '0.17.0'
   end
 end

data/rubocop-sketchup.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
 
   spec.version = RuboCop::SketchUp::VERSION
   spec.platform = Gem::Platform::RUBY
-  spec.required_ruby_version = '>= 2.3.0'
+  spec.required_ruby_version = '>= 2.4.0'
 
   spec.require_paths = ['lib']
   spec.files = Dir[
@@ -24,6 +24,6 @@ Gem::Specification.new do |spec|
       'Gemfile'
   ]
 
-  spec.add_dependency 'rubocop', '>= 0.80', '<= 0.80'
+  spec.add_dependency 'rubocop', '>= 0.82', '<= 0.88'
   spec.add_development_dependency 'bundler', '>= 1.13', '< 3.0'
 end

metadata

@@ -1,35 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sketchup
 version: !ruby/object:Gem::Version
-  version: 0.15.1
+  version: 0.17.0
 platform: ruby
 authors:
 - Trimble Inc, SketchUp Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-27 00:00:00.000000000 Z
+date: 2020-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<="
-      - !ruby/object:Gem::Version
-        version: '0.80'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.82'
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '0.88'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<="
-      - !ruby/object:Gem::Version
-        version: '0.80'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.82'
+    - - "<="
+      - !ruby/object:Gem::Version
+        version: '0.88'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -137,7 +137,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="