rubocop-sketchup 0.15.0 → 0.16.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 8d4062efd8aa26cece01050daea55cf94b1e5492
-  data.tar.gz: 47f479739fac0fdc84bdcce80f9a95b26b3b9117
+SHA256:
+  metadata.gz: b427141ab0bf473dda0cb9a9f896d2733634b4d640050a643cb6782fbe20b8ee
+  data.tar.gz: 7bcbd253ca25dd0ec5aa8eb59d1fa1752e1c43b2c2316b962f571ce2b530600c
 SHA512:
-  metadata.gz: 8805d041327c8b7ac6408109397bec25661fc10c84c0aa19f68f639e516e903de03b34d08f6caf1c0f00b0977a4ea6db42d78d3112a260176d2d64e7cc72eae4
-  data.tar.gz: a4e294799b1f455b78a652656ee9fb9911ed60fb859c4ff6787811ebad293448b0c1dbb3292bc1a7029c07522f684030a47054f2ecb747df680478a445fe70e1
+  metadata.gz: 870f52b31064818785e18215714c40dd1a83c3f367e178bb640ee2a3525e30c7f34a9b47ba4cf3358e737666c349f7e35c1b5c1335e25bd4783984753c469e02
+  data.tar.gz: a0e29858b9156a313530c850316ec07915c7313e19705356b8cf850e0a3950a15dfc4e247d20c60c1382aa1ad84faa4d14c00e5bb3945c45d2c2507cf96ee6b3

data/Gemfile

@@ -8,12 +8,12 @@ group :test do
   gem 'appveyor-worker', '~> 0.2', require: false
   gem 'rake', '~> 12.0', require: false
   gem 'rspec', '~> 3.7', require: false
+  gem 'rubocop-performance', require: false
+  gem 'simplecov', '~> 0.10', require: false
 end
 
 group :development do
   gem 'bump', '~> 0.5', require: false
-  gem 'rubocop-performance', require: false
-  gem 'simplecov', '~> 0.10', require: false
   gem 'solargraph', '~> 0.34', require: false
   gem 'thor', '~> 0.20', require: false
   gem 'yard', '~> 0.9', require: false

data/lib/rubocop/sketchup/cop/requirements/get_extension_license.rb

@@ -80,7 +80,7 @@ module RuboCop
           end
 
           # Invalid format.
-          if extension_id !~ EXTENSION_ID_PATTERN
+          unless EXTENSION_ID_PATTERN.match?(extension_id)
             range = string_contents_range(node)
             add_offense(node, location: range, message: MSG_INVALID)
             return false

data/lib/rubocop/sketchup/cop/requirements/sketchup_require.rb

@@ -7,8 +7,7 @@ module RuboCop
       # files to be loaded.
       #
       # Ruby C extensions, `.so`/`.bundle` libraries must always be loaded via
-      # the normal `require`. Omit the file extension to the libraries as Ruby
-      # will resolve the`.so`/`.bundle` automatically.
+      # the normal `require`.
       #
       # @example Bad - This will fail if extension is encrypted
       #   Sketchup.require 'hello/world.rb'
@@ -36,9 +35,6 @@ module RuboCop
         MSG_REQUIRE_FOR_BINARY = 'Use `require` instead of `Sketchup.require` '\
                                  'to load binary Ruby libraries.'
 
-        MSG_OMIT_BINARY_EXT = 'Do not hard code .so/.bundle file '\
-                              'extensions'
-
         MSG_REQUIRE_ENCRYPTED = 'Use `Sketchup.require` when loading Ruby '\
                                 'files for encrypted extensions.'
 
@@ -80,7 +76,6 @@ module RuboCop
 
           elsif ruby_require?(node)
             filename = ruby_require(node)
-            return if check_binary_ruby_require(node, filename)
             return if check_encrypted_require(node, filename)
 
           elsif sketchup_extension_new?(node)
@@ -108,15 +103,6 @@ module RuboCop
           true
         end
 
-        def check_binary_ruby_require(node, filename)
-          ext_name = File.extname(filename)
-          return unless %w[.so .bundle].include?(ext_name)
-
-          add_offense(node, location: file_ext_range(node.arguments.first),
-                            message: MSG_OMIT_BINARY_EXT)
-          true
-        end
-
         def check_sketchup_require_filename(node, filename)
           return if valid_filename?(filename)
 

data/lib/rubocop/sketchup/features.rb

@@ -18,9 +18,16 @@
 # positives. The method names should be names that are not commonly used in
 # general context.
 #
+# Since it's difficult to know what a variable in Ruby code represent by static
+# analysis, these methods are assumed to belong to the FEATURES list.
+#
 # When a new version is released and FEATURES is updated the new methods from
 # the new version should be considered for this list.
 #
+# TODO(thomthom): Investigate if Solargraph's static analysis can be used to
+#   provide a more accurate analysis. Not sure how well it works on code bases
+#   that isn't well documented with YARD type tags.
+#
 #
 # OBSERVER_METHODS constant:
 #
@@ -34,6 +41,48 @@ module RuboCop
 
       FEATURES = [
 
+        {
+          version: 'LayOut 2020.1',
+          types: {
+            method: [
+              'Layout::Document#export',
+              'Layout::Grid#clip_to_margins=',
+              'Layout::Grid#clip_to_margins?',
+              'Layout::Grid#in_front=',
+              'Layout::Grid#in_front?',
+              'Layout::Grid#major_color=',
+              'Layout::Grid#major_spacing=',
+              'Layout::Grid#minor_color=',
+              'Layout::Grid#minor_divisions=',
+              'Layout::Grid#print=',
+              'Layout::Grid#show=',
+              'Layout::Grid#show_major=',
+              'Layout::Grid#show_minor=',
+              'Layout::SketchUpModel#camera_modified?',
+              'Layout::SketchUpModel#effects_modified?',
+              'Layout::SketchUpModel#layers_modified?',
+              'Layout::SketchUpModel#reset_camera',
+              'Layout::SketchUpModel#reset_effects',
+              'Layout::SketchUpModel#reset_layers',
+              'Layout::SketchUpModel#reset_style',
+              'Layout::SketchUpModel#style_modified?',
+            ],
+          },
+        },
+
+        {
+          version: 'SketchUp 2020.1',
+          types: {
+            method: [
+              'Sketchup::Entities#weld',
+              'Sketchup::Page#use_hidden_geometry=',
+              'Sketchup::Page#use_hidden_geometry?',
+              'Sketchup::Page#use_hidden_objects=',
+              'Sketchup::Page#use_hidden_objects?',
+            ],
+          },
+        },
+
         {
           version: 'SketchUp 2020.0',
           types: {
@@ -1097,8 +1146,11 @@ module RuboCop
         attached_to
         attached_to=
         boundingbox_pick
+        camera_modified?
         center_2d
         classifications
+        clip_to_margins?
+        clip_to_margins=
         colorize_deltas
         colorize_type
         colorize_type=
@@ -1107,6 +1159,7 @@ module RuboCop
         days_remaining
         drawing_element_visible?
         edit_transform
+        effects_modified?
         end_attached_to
         end_attached_to=
         error_description
@@ -1127,12 +1180,15 @@ module RuboCop
         icon_tooltip
         icon_tooltip=
         image_rep
+        in_front?
+        in_front=
         include_in_animation?
         include_in_animation=
         instance_path
         instance_path_from_pid_path
         is_polygon?
         large_icon
+        layers_modified?
         leader_break_point
         leader_break_point=
         leader_points
@@ -1145,7 +1201,11 @@ module RuboCop
         local_bounds
         lower_left
         lower_right
+        major_color=
+        major_spacing=
         menu_text
+        minor_color=
+        minor_divisions=
         mipmapping?
         mipmapping=
         navigation_buttons_enabled?
@@ -1161,6 +1221,10 @@ module RuboCop
         persistent_id_path
         refresh_thumbnail
         remove_classification
+        reset_camera
+        reset_effects
+        reset_layers
+        reset_style
         same_direction?
         scale_2d
         screen_scale_factor
@@ -1174,11 +1238,14 @@ module RuboCop
         set_upload_progress_callback
         set_uv
         show_differences
+        show_major=
+        show_minor=
         sketch_plane
         small_icon
         start_attached_to
         start_attached_to=
         status_bar_text
+        style_modified?
         text_bounds
         unit_vector?
         unload_schema

data/lib/rubocop/sketchup/sketchup_version.rb

@@ -66,6 +66,7 @@ module RuboCop
       #
       # The second item in the array is maintenance annotation
       VALID_VERSIONS = [
+        [2020.1, 0],
         [2020.0, 0],
         [2019.2, 0],
         [2019.0, 0], # SketchUp dropped M notation as of SU2019.

data/lib/rubocop/sketchup/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module SketchUp
-    VERSION = '0.15.0'
+    VERSION = '0.16.1'
   end
 end

data/rubocop-sketchup.gemspec

@@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
 
   spec.version = RuboCop::SketchUp::VERSION
   spec.platform = Gem::Platform::RUBY
-  spec.required_ruby_version = '>= 2.3.0'
+  spec.required_ruby_version = '>= 2.4.0'
 
   spec.require_paths = ['lib']
   spec.files = Dir[
@@ -24,6 +24,6 @@ Gem::Specification.new do |spec|
       'Gemfile'
   ]
 
-  spec.add_dependency 'rubocop', '>= 0.80', '<= 0.80'
+  spec.add_dependency 'rubocop', '>= 0.82', '<= 0.86'
   spec.add_development_dependency 'bundler', '>= 1.13', '< 3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sketchup
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.16.1
 platform: ruby
 authors:
 - Trimble Inc, SketchUp Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-18 00:00:00.000000000 Z
+date: 2020-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,20 +16,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.82'
     - - "<="
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.86'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.82'
     - - "<="
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '0.86'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -137,15 +137,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: RuboCop rules for SketchUp extensions.