rubocop-sidekiq_plus 0.1.0

data/config/default.yml

@@ -0,0 +1,396 @@
+---
+Sidekiq:
+  Enabled: true
+  DocumentationBaseURL: https://github.com/ydah/rubocop-sidekiq/blob/main/docs/modules/ROOT/pages
+
+Sidekiq/ActiveRecordArgument:
+  Description: Do not pass ActiveRecord objects to Sidekiq jobs.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/ActiveRecordArgument
+
+Sidekiq/AsyncInTest:
+  Description: Prefer perform_inline over perform_async in tests.
+  Enabled: false
+  VersionAdded: '0.1'
+  Include:
+    - spec/**/*_spec.rb
+    - test/**/*_test.rb
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/AsyncInTest
+
+Sidekiq/ConsistentJobSuffix:
+  Description: Enforce consistent job class name suffix.
+  Enabled: false
+  VersionAdded: '0.1'
+  EnforcedSuffix: Job
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/ConsistentJobSuffix
+
+Sidekiq/ConstantJobClassName:
+  Description: Ensure job class names are constant.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/ConstantJobClassName
+
+Sidekiq/DatabaseConnectionLeak:
+  Description: Ensure database connections are properly released.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/DatabaseConnectionLeak
+
+Sidekiq/DateTimeArgument:
+  Description: Do not pass Date/Time objects to Sidekiq jobs.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/DateTimeArgument
+
+Sidekiq/DeprecatedDefaultWorkerOptions:
+  Description: Detect deprecated Sidekiq.default_worker_options usage.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/DeprecatedDefaultWorkerOptions
+
+Sidekiq/DeprecatedDelayExtension:
+  Description: Detect deprecated delay extension usage.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/DeprecatedDelayExtension
+
+Sidekiq/DeprecatedWorkerModule:
+  Description: Detect Sidekiq::Worker usage and prefer Sidekiq::Job.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/DeprecatedWorkerModule
+
+Sidekiq/EnqueueInefficiency:
+  Description: Prefer perform_bulk over perform_async inside loops.
+  Enabled: true
+  VersionAdded: '0.1'
+  AllowedMethods:
+    - each
+    - find_each
+    - find_in_batches
+  MinimumIterations: ~
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/EnqueueInefficiency
+
+Sidekiq/ExcessiveRetry:
+  Description: Detect excessive retry counts.
+  Enabled: false
+  VersionAdded: '0.1'
+  MaxRetries: 25
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/ExcessiveRetry
+
+Sidekiq/FindEachInJob:
+  Description: Avoid processing large datasets inside a single Sidekiq job.
+  Enabled: true
+  VersionAdded: '0.1'
+  AllowedMethods: []
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/FindEachInJob
+
+Sidekiq/HugeJobArguments:
+  Description: Avoid passing potentially huge arguments to Sidekiq jobs.
+  Enabled: true
+  VersionAdded: '0.1'
+  MaxArraySize: 10
+  MaxHashSize: 10
+  MaxPluckColumns: 3
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/HugeJobArguments
+
+Sidekiq/JobDependency:
+  Description: Detect implicit job dependencies, suggest Batches.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/JobDependency
+
+Sidekiq/JobFileLocation:
+  Description: Ensure job classes are in app/jobs or app/workers.
+  Enabled: false
+  VersionAdded: '0.1'
+  AllowedDirectories:
+    - app/jobs
+    - app/workers
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/JobFileLocation
+
+Sidekiq/JobFileNaming:
+  Description: Ensure job file names match class names.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/JobFileNaming
+
+Sidekiq/JobInclude:
+  Description: Prefer including Sidekiq::Job over Sidekiq::Worker.
+  Enabled: true
+  VersionAdded: '0.1'
+  PreferredModule: Job
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/JobInclude
+
+Sidekiq/MissingLogging:
+  Description: Encourage logging in jobs.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/MissingLogging
+
+Sidekiq/MissingTimeout:
+  Description: Ensure network operations have timeouts configured.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/MissingTimeout
+
+Sidekiq/MixedRetryStrategies:
+  Description: Avoid mixing ActiveJob retry_on with Sidekiq retries.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/MixedRetryStrategies
+
+Sidekiq/NoRescueAll:
+  Description: Avoid rescuing all exceptions in Sidekiq jobs.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/NoRescueAll
+
+Sidekiq/PerformInlineUsage:
+  Description: Avoid using perform_inline in production code.
+  Enabled: true
+  VersionAdded: '0.1'
+  AllowedInTests: true
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/PerformInlineUsage
+
+Sidekiq/PerformMethodParameters:
+  Description: Do not use keyword arguments in perform method.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/PerformMethodParameters
+
+Sidekiq/PiiInArguments:
+  Description: Avoid passing PII in job arguments.
+  Enabled: false
+  VersionAdded: '0.1'
+  PiiPatterns:
+    - email
+    - phone
+    - address
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/PiiInArguments
+
+Sidekiq/PutsOrPrintUsage:
+  Description: Use logger instead of puts/print in jobs.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/PutsOrPrintUsage
+
+Sidekiq/QueueSpecified:
+  Description: Require explicit queue specification for jobs.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/QueueSpecified
+
+Sidekiq/RedisInJob:
+  Description: Use Sidekiq.redis instead of creating new Redis connections.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/RedisInJob
+
+Sidekiq/RetrySpecified:
+  Description: Require explicit retry configuration for jobs.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/RetrySpecified
+
+Sidekiq/RetryZero:
+  Description: 'Prefer retry: false over retry: 0 for clarity.'
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/RetryZero
+
+Sidekiq/SelfSchedulingJob:
+  Description: Detect jobs that reschedule themselves.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/SelfSchedulingJob
+
+Sidekiq/SensitiveDataInArguments:
+  Description: Avoid passing sensitive data in job arguments.
+  Enabled: true
+  VersionAdded: '0.1'
+  SensitivePatterns:
+    - password
+    - passwd
+    - pwd
+    - token
+    - api_key
+    - secret
+    - credit_card
+    - card_number
+    - cvv
+    - ssn
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/SensitiveDataInArguments
+
+Sidekiq/SidekiqOverActiveJob:
+  Description: Recommend using Sidekiq directly instead of ActiveJob.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/SidekiqOverActiveJob
+
+Sidekiq/SilentRescue:
+  Description: Avoid silently swallowing exceptions in jobs.
+  Enabled: true
+  VersionAdded: '0.1'
+  AllowedExceptions:
+    - ActiveRecord::RecordNotFound
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/SilentRescue
+
+Sidekiq/SleepInJobs:
+  Description: Do not use sleep in Sidekiq jobs.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/SleepInJobs
+
+Sidekiq/SymbolArgument:
+  Description: Do not pass symbols to Sidekiq jobs.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/SymbolArgument
+
+Sidekiq/ThreadInJob:
+  Description: Do not create threads inside Sidekiq jobs.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/ThreadInJob
+
+Sidekiq/TransactionLeak:
+  Description: Do not enqueue jobs inside database transactions.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/TransactionLeak
+
+Sidekiq/UnknownSidekiqOption:
+  Description: Check sidekiq_options for unknown or unsupported keys.
+  Enabled: true
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/Sidekiq/UnknownSidekiqOption
+
+SidekiqPro:
+  Enabled: false
+  DocumentationBaseURL: https://github.com/ydah/rubocop-sidekiq/blob/main/docs/modules/ROOT/pages
+
+SidekiqPro/BatchCallbackMethod:
+  Description: Ensure batch callback methods are named correctly.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqPro/BatchCallbackMethod
+
+SidekiqPro/BatchStatusPolling:
+  Description: Discourage polling batch status, prefer callbacks.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqPro/BatchStatusPolling
+
+SidekiqPro/BatchWithoutCallback:
+  Description: Recommend registering callbacks for batches.
+  Enabled: false
+  VersionAdded: '0.1'
+  Severity: warning
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqPro/BatchWithoutCallback
+
+SidekiqPro/EmptyBatch:
+  Description: Detect batch.jobs blocks that may be empty.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqPro/EmptyBatch
+
+SidekiqPro/ExpiringJobWithoutTTL:
+  Description: Validate TTL range for expiring jobs.
+  Enabled: false
+  VersionAdded: '0.1'
+  MinimumTTL: 300
+  MaximumTTL: 604800
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqPro/ExpiringJobWithoutTTL
+
+SidekiqPro/LargeArgumentInBatch:
+  Description: Avoid passing large arguments to jobs within a batch.
+  Enabled: false
+  VersionAdded: '0.1'
+  MaxArraySize: 10
+  MaxHashSize: 10
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqPro/LargeArgumentInBatch
+
+SidekiqPro/ReliabilityNotEnabled:
+  Description: Recommend enabling super_fetch and reliable_push.
+  Enabled: false
+  VersionAdded: '0.1'
+  Include:
+    - config/initializers/sidekiq.rb
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqPro/ReliabilityNotEnabled
+
+SidekiqEnt:
+  Enabled: false
+  DocumentationBaseURL: https://github.com/ydah/rubocop-sidekiq/blob/main/docs/modules/ROOT/pages
+
+SidekiqEnt/EncryptionWithManyArguments:
+  Description: Ensure sensitive data is in the last argument for encryption.
+  Enabled: false
+  VersionAdded: '0.1'
+  MaxArguments: 2
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqEnt/EncryptionWithManyArguments
+
+SidekiqEnt/EncryptionWithoutSecretBag:
+  Description: Recommend proper secret bag usage with encryption.
+  Enabled: false
+  VersionAdded: '0.1'
+  Severity: info
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqEnt/EncryptionWithoutSecretBag
+
+SidekiqEnt/LeaderElectionWithoutBlock:
+  Description: Warn about long-running operations in leader checks.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqEnt/LeaderElectionWithoutBlock
+
+SidekiqEnt/LimiterNotReused:
+  Description: Create rate limiters as class constants for reuse.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqEnt/LimiterNotReused
+
+SidekiqEnt/LimiterWithoutLockTimeout:
+  Description: Recommend setting lock_timeout for concurrent limiters.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqEnt/LimiterWithoutLockTimeout
+
+SidekiqEnt/LimiterWithoutWaitTimeout:
+  Description: Specify wait_timeout option for rate limiters.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqEnt/LimiterWithoutWaitTimeout
+
+SidekiqEnt/PeriodicJobInvalidCron:
+  Description: Validate cron expressions for periodic jobs.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqEnt/PeriodicJobInvalidCron
+
+SidekiqEnt/PeriodicJobWithArguments:
+  Description: Periodic jobs should not require arguments.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqEnt/PeriodicJobWithArguments
+
+SidekiqEnt/UniqueJobTooShortTTL:
+  Description: Warn about unique jobs with too short TTL.
+  Enabled: false
+  VersionAdded: '0.1'
+  MinimumTTL: 60
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqEnt/UniqueJobTooShortTTL
+
+SidekiqEnt/UniqueJobWithoutTTL:
+  Description: Require unique_for when using unique_until option.
+  Enabled: false
+  VersionAdded: '0.1'
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqEnt/UniqueJobWithoutTTL
+
+SidekiqEnt/UniqueUntilMismatch:
+  Description: Validate unique_until option values.
+  Enabled: false
+  VersionAdded: '0.1'
+  AllowedValues:
+    - success
+  Reference: https://www.rubydoc.info/gems/rubocop-sidekiq_plus/RuboCop/Cop/SidekiqEnt/UniqueUntilMismatch

data/lib/rubocop/cop/sidekiq/active_record_argument.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sidekiq
+      # Checks for ActiveRecord objects passed to Sidekiq job methods.
+      #
+      # Passing ActiveRecord objects to Sidekiq jobs is problematic because:
+      # - Objects cannot be properly serialized to JSON
+      # - The object may change or be deleted before the job runs
+      # - It increases Redis memory usage
+      #
+      # Instead, pass the record's ID and reload it in the job.
+      #
+      # @example
+      #   # bad
+      #   MyJob.perform_async(user)
+      #   MyJob.perform_async(User.find(1))
+      #   MyJob.perform_async(User.first)
+      #
+      #   # good
+      #   MyJob.perform_async(user.id)
+      #   MyJob.perform_async(user_id)
+      #
+      class ActiveRecordArgument < Base
+        include ArgumentTraversal
+
+        MSG = 'Do not pass ActiveRecord objects to Sidekiq jobs. ' \
+              'Pass the id and fetch the record in the job instead.'
+
+        RESTRICT_ON_SEND = PerformMethods.all
+
+        FINDER_METHODS = %i[find find_by find_by! first last take where].freeze
+
+        # @!method sidekiq_perform_call?(node)
+        def_node_matcher :sidekiq_perform_call?, <<~PATTERN
+          (send _ {#{PerformMethods.all.map(&:inspect).join(' ')}} $...)
+        PATTERN
+
+        # @!method active_record_finder?(node)
+        def_node_matcher :active_record_finder?, <<~PATTERN
+          (send (const ...) {#{FINDER_METHODS.map(&:inspect).join(' ')}} ...)
+        PATTERN
+
+        # @!method chained_finder?(node)
+        def_node_matcher :chained_finder?, <<~PATTERN
+          (send (send (const ...) ...) {#{FINDER_METHODS.map(&:inspect).join(' ')}} ...)
+        PATTERN
+
+        def on_send(node)
+          sidekiq_perform_call?(node) do |args|
+            check_arguments(args)
+          end
+        end
+        alias on_csend on_send
+
+        private
+
+        def check_argument(arg)
+          if active_record_object?(arg)
+            add_offense(arg)
+          elsif arg.hash_type?
+            check_hash_values(arg)
+          elsif arg.array_type?
+            check_array_elements(arg)
+          end
+        end
+
+        def active_record_object?(node)
+          return false unless node.send_type?
+
+          active_record_finder?(node) || chained_finder?(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sidekiq/async_in_test.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sidekiq
+      # Checks for perform_async usage in test files.
+      #
+      # @example
+      #   # bad
+      #   MyJob.perform_async(user.id)
+      #
+      #   # good
+      #   MyJob.perform_inline(user.id)
+      #
+      class AsyncInTest < Base
+        MSG = 'Avoid perform_async in tests. Use perform_inline or call perform directly.'
+
+        RESTRICT_ON_SEND = %i[perform_async].freeze
+
+        def on_send(node)
+          return unless in_test_file?
+
+          add_offense(node)
+        end
+        alias on_csend on_send
+
+        private
+
+        def in_test_file?
+          file_path = processed_source.file_path
+          return false unless file_path
+
+          test_patterns.any? { |pattern| File.fnmatch?(pattern, file_path) }
+        end
+
+        def test_patterns
+          cop_config.fetch('Include', ['spec/**/*_spec.rb', 'test/**/*_test.rb'])
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sidekiq/base.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sidekiq
+      # @abstract
+      # Base class for Sidekiq cops.
+      class Base < ::RuboCop::Cop::Base
+        abstract! if respond_to?(:abstract!)
+        include RuboCop::Sidekiq::Language
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sidekiq/consistent_job_suffix.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sidekiq
+      # Enforces consistent job class name suffix (Job or Worker).
+      #
+      # @example EnforcedSuffix: Job (default)
+      #   # bad
+      #   class ProcessPaymentWorker
+      #     include Sidekiq::Job
+      #   end
+      #
+      #   # good
+      #   class ProcessPaymentJob
+      #     include Sidekiq::Job
+      #   end
+      #
+      class ConsistentJobSuffix < Base
+        include ClassNameHelper
+
+        MSG = 'Use `%<suffix>s` suffix for Sidekiq job class names.'
+
+        def on_class(node)
+          return unless sidekiq_job_class?(node)
+
+          class_name = class_name(node)
+          return unless class_name
+
+          suffix = enforced_suffix
+          return if class_name.end_with?(suffix)
+
+          add_offense(node.loc.keyword, message: format(MSG, suffix: suffix))
+        end
+
+        private
+
+        def enforced_suffix
+          cop_config.fetch('EnforcedSuffix', 'Job')
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sidekiq/constant_job_class_name.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sidekiq
+      # Checks that job class names are constants.
+      #
+      # Using dynamic class names for jobs can lead to:
+      # - Security vulnerabilities (arbitrary code execution)
+      # - Difficult to trace job execution
+      # - Harder static analysis
+      #
+      # @example
+      #   # bad
+      #   job_class.perform_async(args)
+      #   "#{prefix}Job".constantize.perform_async(args)
+      #
+      #   # good
+      #   MyJob.perform_async(args)
+      #   MyModule::MyJob.perform_async(args)
+      #
+      class ConstantJobClassName < Base
+        MSG = 'Use a constant class name for Sidekiq jobs. ' \
+              'Dynamic job class names are harder to trace and may be insecure.'
+
+        RESTRICT_ON_SEND = PerformMethods.all
+
+        def on_send(node)
+          return unless RESTRICT_ON_SEND.include?(node.method_name)
+          return if constant_receiver?(node)
+
+          add_offense(node.receiver)
+        end
+        alias on_csend on_send
+
+        private
+
+        def constant_receiver?(node)
+          receiver = node.receiver
+          return false unless receiver
+
+          receiver.const_type? || (receiver.send_type? && nested_const?(receiver))
+        end
+
+        def nested_const?(node)
+          return true if node.const_type?
+
+          node.send_type? && node.receiver && nested_const?(node.receiver)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sidekiq/database_connection_leak.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Sidekiq
+      # Checks for explicit ActiveRecord connection usage in Sidekiq jobs.
+      #
+      # @example
+      #   # bad
+      #   ActiveRecord::Base.connection.execute('SELECT 1')
+      #
+      #   # good
+      #   ActiveRecord::Base.connection_pool.with_connection { |conn| conn.execute('SELECT 1') }
+      #
+      class DatabaseConnectionLeak < Base
+        MSG = 'Avoid using ActiveRecord::Base.connection directly in jobs. Use connection_pool.with_connection.'
+
+        def on_def(node)
+          return unless node.method?(:perform)
+          return unless in_sidekiq_job?(node)
+
+          node.each_descendant(:send) do |send|
+            receiver = send.receiver
+            next unless receiver&.const_name == 'ActiveRecord::Base'
+            next unless send.method?(:connection)
+
+            add_offense(send)
+          end
+        end
+      end
+    end
+  end
+end