rubocop-sequel 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: a6bd53027cc6d6df7b1d67153a46c9ac5325509b
-  data.tar.gz: 32b4aa5476643d2c82d4c5495b77ba5cd3fcab02
+SHA256:
+  metadata.gz: 8b48c970ba23412aca37456e02bc2e3cd27856338494132bfe0ef2e43fe2bf0b
+  data.tar.gz: 55f74cf994978072f005b0c23603e12d2eb79a9cb680f49496aaf430500ee2fe
 SHA512:
-  metadata.gz: 75952359885f37ceafdc126f9df5b102f3f64d06ed761308085a6fe3498d68382a28bdfef00a6658c14af589f98900a70076fce221d425eb8167b3f2de1d8ed0
-  data.tar.gz: 2016916ef31f9459cc2ad51b4180534563d7c38f901a72e060db218716ddbad3ef9dfc2e35970333bb1877f7ea2d6f6e69018df4c5af37f5ce2de2bd188e5031
+  metadata.gz: '069b933d71802921ffdbf4e763686c00f69104ec6b181c1854f259e4bb9a13352ed39ccc76197341bc39487908eed2eecfd3d9e1ea1bd3453441de3a45f4f774'
+  data.tar.gz: c6273c16039bf43725eaa6218881fcd84c64835fcae46dc18393d15e32bb944a69252800d312f2a0f23b5d29aeb81c8ac28468ed3f5620cbfa1aa605731532c0

data/.github/workflows/actions.yml

@@ -1,5 +1,5 @@
 name: CI
-on: push
+on: [push, pull_request]
 
 jobs:
   main:
@@ -12,6 +12,7 @@ jobs:
           - 2.5
           - 2.6
           - 2.7
+          - 3.0
     steps:
       - uses: actions/checkout@v2
 

data/lib/rubocop/cop/sequel/column_default.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     module Sequel
       # ColumnDefault looks for column creation with a default value.
-      class ColumnDefault < Cop
+      class ColumnDefault < Base
         MSG = "Don't create new column with default values"
 
         def_node_matcher :add_column_default?, <<-MATCHER
@@ -14,7 +14,7 @@ module RuboCop
         def on_send(node)
           return unless add_column_default?(node)
 
-          add_offense(node, location: :selector, message: MSG)
+          add_offense(node.loc.selector, message: MSG)
         end
       end
     end

data/lib/rubocop/cop/sequel/concurrent_index.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     module Sequel
       # ConcurrentIndex looks for non-concurrent index creation.
-      class ConcurrentIndex < Cop
+      class ConcurrentIndex < Base
         MSG = 'Prefer creating or dropping new index concurrently'
 
         def_node_matcher :indexes?, <<-MATCHER
@@ -13,7 +13,7 @@ module RuboCop
 
         def on_send(node)
           indexes?(node) do |args|
-            add_offense(node, location: :selector, message: MSG) if offensive?(args)
+            add_offense(node.loc.selector, message: MSG) if offensive?(args)
           end
         end
 

data/lib/rubocop/cop/sequel/json_column.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     module Sequel
       # JSONColumn looks for non-JSONB columns.
-      class JSONColumn < Cop
+      class JSONColumn < Base
         MSG = 'Use JSONB rather than JSON or hstore'
 
         def_node_matcher :json_or_hstore?, <<-MATCHER
@@ -22,7 +22,7 @@ module RuboCop
         def on_send(node)
           return unless json_or_hstore?(node)
 
-          add_offense(node, location: :selector, message: MSG)
+          add_offense(node.loc.selector, message: MSG)
         end
 
         def on_block(node)
@@ -31,7 +31,7 @@ module RuboCop
           node.each_node(:send) do |method|
             next unless column_method?(method) || column_type?(method)
 
-            add_offense(method, location: :selector, message: MSG)
+            add_offense(method.loc.selector, message: MSG)
           end
         end
       end

data/lib/rubocop/cop/sequel/migration_name.rb

@@ -4,19 +4,19 @@ module RuboCop
   module Cop
     module Sequel
       # MigrationName looks for migration files named with a default name.
-      class MigrationName < Cop
+      class MigrationName < Base
         include RangeHelp
 
         MSG = 'Migration files should not use default name.'
 
-        def investigate(processed_source)
+        def on_new_investigation
           file_path = processed_source.buffer.name
           return if config.file_to_include?(file_path)
 
           return unless filename_bad?(file_path)
 
           location = source_range(processed_source.buffer, 1, 0)
-          add_offense(nil, location: location)
+          add_offense(location)
         end
 
         private

data/lib/rubocop/cop/sequel/save_changes.rb

@@ -4,7 +4,9 @@ module RuboCop
   module Cop
     module Sequel
       # SaveChanges promotes the use of save_changes.
-      class SaveChanges < Cop
+      class SaveChanges < Base
+        extend AutoCorrector
+
         MSG = 'Use `Sequel::Model#save_changes` instead of '\
           '`Sequel::Model#save`.'
 
@@ -15,11 +17,11 @@ module RuboCop
         def on_send(node)
           return unless model_save?(node)
 
-          add_offense(node, location: :selector, message: MSG)
-        end
+          range = node.loc.selector
 
-        def autocorrect(node)
-          ->(corrector) { corrector.replace(node.loc.selector, 'save_changes') }
+          add_offense(range, message: MSG) do |corrector|
+            corrector.replace(range, 'save_changes')
+          end
         end
       end
     end

data/rubocop-sequel.gemspec

@@ -13,9 +13,9 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = 'rubocop-sequel'
   gem.require_paths = ['lib']
-  gem.version       = '0.1.0'
+  gem.version       = '0.2.0'
 
-  gem.required_ruby_version = '~> 2.4'
+  gem.required_ruby_version = '>= 2.4'
 
   gem.add_runtime_dependency 'rubocop', '~> 1.0'
 

data/spec/rubocop/cop/sequel/column_default_spec.rb

@@ -6,12 +6,12 @@ describe RuboCop::Cop::Sequel::ColumnDefault do
   subject(:cop) { described_class.new }
 
   it 'registers an offense when setting a default' do
-    inspect_source('add_column(:products, :type, :text, default: "cop")')
-    expect(cop.offenses.size).to eq(1)
+    offenses = inspect_source('add_column(:products, :type, :text, default: "cop")')
+    expect(offenses.size).to eq(1)
   end
 
   it 'does not register an offense when not setting a default' do
-    inspect_source('add_column(:products, :type, :text)')
-    expect(cop.offenses).to be_empty
+    offenses = inspect_source('add_column(:products, :type, :text)')
+    expect(offenses).to be_empty
   end
 end

data/spec/rubocop/cop/sequel/concurrent_index_spec.rb

@@ -7,35 +7,35 @@ describe RuboCop::Cop::Sequel::ConcurrentIndex do
 
   context 'without the concurrent option' do
     it 'registers an offense without options' do
-      inspect_source(<<~SOURCE)
+      offenses = inspect_source(<<~SOURCE)
         add_index(:products, :name)
         drop_index(:products, :name)
       SOURCE
-      expect(cop.offenses.size).to eq(2)
+      expect(offenses.size).to eq(2)
     end
 
     it 'registers an offense with other options' do
-      inspect_source(<<~SOURCE)
+      offenses = inspect_source(<<~SOURCE)
         add_index(:products, :name, unique: true)
         drop_index(:products, :name, unique: true)
       SOURCE
-      expect(cop.offenses.size).to eq(2)
+      expect(offenses.size).to eq(2)
     end
 
     it 'registers an offense with composite index' do
-      inspect_source(<<~SOURCE)
+      offenses = inspect_source(<<~SOURCE)
         add_index(:products, [:name, :price], unique: true)
         drop_index(:products, [:name, :price])
       SOURCE
-      expect(cop.offenses.size).to eq(2)
+      expect(offenses.size).to eq(2)
     end
   end
 
   it 'does not register an offense when using concurrent option' do
-    inspect_source(<<~SOURCE)
+    offenses = inspect_source(<<~SOURCE)
       add_index(:products, :name, unique: true, concurrently: true)
       drop_index(:products, :name, concurrently: true)
     SOURCE
-    expect(cop.offenses).to be_empty
+    expect(offenses).to be_empty
   end
 end

data/spec/rubocop/cop/sequel/json_column_spec.rb

@@ -7,45 +7,45 @@ describe RuboCop::Cop::Sequel::JSONColumn do
 
   context 'with add_column' do
     it 'registers an offense when using json type' do
-      inspect_source('add_column(:products, :type, :json)')
-      expect(cop.offenses.size).to eq(1)
+      offenses = inspect_source('add_column(:products, :type, :json)')
+      expect(offenses.size).to eq(1)
     end
 
     it 'registers an offense when using hstore type' do
-      inspect_source('add_column(:products, :type, :hstore)')
-      expect(cop.offenses.size).to eq(1)
+      offenses = inspect_source('add_column(:products, :type, :hstore)')
+      expect(offenses.size).to eq(1)
     end
 
     it 'does not register an offense when using jsonb' do
-      inspect_source('add_column(:products, :type, :jsonb)')
-      expect(cop.offenses).to be_empty
+      offenses = inspect_source('add_column(:products, :type, :jsonb)')
+      expect(offenses).to be_empty
     end
   end
 
   context 'with create_table' do
     it 'registers an offense when using json as a method' do
-      inspect_source('create_table(:products) { json :type, default: {} }')
-      expect(cop.offenses.size).to eq(1)
+      offenses = inspect_source('create_table(:products) { json :type, default: {} }')
+      expect(offenses.size).to eq(1)
     end
 
     it 'registers an offense when using the column method with hstore' do
-      inspect_source('create_table(:products) { column :type, :hstore }')
-      expect(cop.offenses.size).to eq(1)
+      offenses = inspect_source('create_table(:products) { column :type, :hstore }')
+      expect(offenses.size).to eq(1)
     end
 
     it 'does not register an offense when using jsonb as column type`' do
-      inspect_source('create_table(:products) { column :type, :jsonb }')
-      expect(cop.offenses).to be_empty
+      offenses = inspect_source('create_table(:products) { column :type, :jsonb }')
+      expect(offenses).to be_empty
     end
 
     it 'does not register an offense when using jsonb' do
-      inspect_source('create_table(:products) { jsonb :type }')
-      expect(cop.offenses).to be_empty
+      offenses = inspect_source('create_table(:products) { jsonb :type }')
+      expect(offenses).to be_empty
     end
 
     it 'does not register an offense when using a simple type' do
-      inspect_source('create_table(:products) { integer :type, default: 0 }')
-      expect(cop.offenses).to be_empty
+      offenses = inspect_source('create_table(:products) { integer :type, default: 0 }')
+      expect(offenses).to be_empty
     end
   end
 end

data/spec/rubocop/cop/sequel/migration_name_spec.rb

@@ -17,13 +17,13 @@ describe RuboCop::Cop::Sequel::MigrationName, :config do
     let(:cop_config) { {} }
 
     it 'registers an offense when using the default name' do
-      inspect_source('', 'new_migration.rb')
-      expect(cop.offenses.size).to eq(1)
+      offenses = inspect_source('', 'new_migration.rb')
+      expect(offenses.size).to eq(1)
     end
 
     it 'does not register an offense when using a specific name' do
-      inspect_source('', 'add_index.rb')
-      expect(cop.offenses).to be_empty
+      offenses = inspect_source('', 'add_index.rb')
+      expect(offenses).to be_empty
     end
   end
 
@@ -31,13 +31,13 @@ describe RuboCop::Cop::Sequel::MigrationName, :config do
     let(:cop_config) { { 'DefaultName' => 'add_migration' } }
 
     it 'registers an offense when using the default name' do
-      inspect_source('', 'add_migration.rb')
-      expect(cop.offenses.size).to eq(1)
+      offenses = inspect_source('', 'add_migration.rb')
+      expect(offenses.size).to eq(1)
     end
 
     it 'does not register an offense when using a specific name' do
-      inspect_source('', 'add_index.rb')
-      expect(cop.offenses).to be_empty
+      offenses = inspect_source('', 'add_index.rb')
+      expect(offenses).to be_empty
     end
   end
 end

data/spec/rubocop/cop/sequel/save_changes_spec.rb

@@ -6,13 +6,13 @@ describe RuboCop::Cop::Sequel::SaveChanges do
   subject(:cop) { described_class.new }
 
   it 'registers an offense when using save' do
-    inspect_source('favorite.save')
-    expect(cop.offenses.size).to eq(1)
+    offenses = inspect_source('favorite.save')
+    expect(offenses.size).to eq(1)
   end
 
   it 'does not register an offense when using save_changes' do
-    inspect_source('favorite.save_changes')
-    expect(cop.offenses).to be_empty
+    offenses = inspect_source('favorite.save_changes')
+    expect(offenses).to be_empty
   end
 
   it 'auto-corrects by using save_changes' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sequel
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Timothée Peignier
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-11-23 00:00:00.000000000 Z
+date: 2021-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -152,7 +152,7 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
     - !ruby/object:Gem::Version
       version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
@@ -161,8 +161,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project:
-rubygems_version: 2.6.11
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: A Sequel plugin for RuboCop