rubocop-sequel 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7060c587b01d22b660cfabc0ead46e03524b0f51
-  data.tar.gz: 59617e179cec66a67b2d051f0dde3170164b4026
+  metadata.gz: 65861f84673b5424553f927f79bfedf762fbc128
+  data.tar.gz: 8191bd88678e0980457aef64fb2a3748000e15cf
 SHA512:
-  metadata.gz: acdd32c982d42943d8b0dc806668699b024f56deeafc3c9bb38a3c300d650234209a61721396466c82f989482420c29b6618f0a99733c274882eee7153067773
-  data.tar.gz: 39473108b08740593758b370b41848b831d12aea8b44434a433f121ce0315dc035b19b2e6facf6fe52ca15cab15ab73fc3230c96b7e32e800ae0d9e5b038f30b
+  metadata.gz: d7be5cc421d8d5e9284c4d8304b41a4d483e237e5f1b8038a07649344ae059c6c11badfeede6231676f3be25c49bf80f491d636c91fc5fadfe2f3c5165637fee
+  data.tar.gz: ce105d871158dc7c62ba784d54239733b371f696b9ff766b6538f18deff561afd4238f062242254c9000d0f73fc4ed811b136ecdbb12ed2dda9639b8893490e9

data/.gitignore

@@ -1,2 +1,3 @@
 .tags
 *.gem
+Gemfile.lock

data/.travis.yml

@@ -0,0 +1,5 @@
+language: ruby
+rvm:
+  - 2.3.3
+  - 2.4.0
+script: bundle exec rspec spec

data/lib/rubocop/cop/sequel/column_default.rb

@@ -5,12 +5,13 @@ module RuboCop
       class ColumnDefault < Cop
         MSG = "Don't create new column with default values".freeze
 
-        def_node_matcher :add_column_default, <<-END
+        def_node_matcher :add_column_default, <<-MATCHER
           (send _ :add_column ... (hash (pair (sym :default) _)))
-        END
+        MATCHER
 
         def on_send(node)
-          add_offense(node, :selector, MSG) if add_column_default(node)
+          return unless add_column_default(node)
+          add_offense(node, location: :selector, message: MSG)
         end
       end
     end

data/lib/rubocop/cop/sequel/concurrent_index.rb

@@ -5,20 +5,22 @@ module RuboCop
       class ConcurrentIndex < Cop
         MSG = 'Prefer creating new index concurrently'.freeze
 
-        def_node_matcher :add_index, <<-END
+        def_node_matcher :add_index, <<-MATCHER
           (send _ :add_index $...)
-        END
+        MATCHER
 
         def on_send(node)
           add_index(node) do |args|
-            add_offense(node, :selector, MSG) if offensive?(args)
+            if offensive?(args)
+              add_offense(node, location: :selector, message: MSG)
+            end
           end
         end
 
         private
 
         def offensive?(args)
-          !args.last.hash_type? || !args.last.each_descendant.any? do |n|
+          !args.last.hash_type? || args.last.each_descendant.none? do |n|
             next unless n.sym_type?
             n.children.any? { |s| s == :concurrently }
           end

data/lib/rubocop/cop/sequel/migration_name.rb

@@ -11,7 +11,8 @@ module RuboCop
 
           return unless filename_bad?(file_path)
 
-          add_offense(nil, source_range(processed_source.buffer, 1, 0), nil)
+          location = source_range(processed_source.buffer, 1, 0)
+          add_offense(nil, location: location)
         end
 
         private

data/lib/rubocop/cop/sequel/save_changes.rb

@@ -3,14 +3,16 @@ module RuboCop
     module Sequel
       # SaveChanges promotes the use of save_changes.
       class SaveChanges < Cop
-        MSG = 'Use `Sequel::Model#save_changes` instead of `Sequel::Model#save`.'.freeze
+        MSG = 'Use `Sequel::Model#save_changes` instead of '\
+          '`Sequel::Model#save`.'.freeze
 
-        def_node_matcher :model_save, <<-END
+        def_node_matcher :model_save, <<-MATCHER
           (send _ :save)
-        END
+        MATCHER
 
         def on_send(node)
-          add_offense(node, :selector, MSG) if model_save(node)
+          return unless model_save(node)
+          add_offense(node, location: :selector, message: MSG)
         end
 
         def autocorrect(node)

data/rubocop-sequel.gemspec

@@ -1,5 +1,3 @@
-# -*- encoding: utf-8 -*-
-
 Gem::Specification.new do |gem|
   gem.authors       = ['Timothée Peignier']
   gem.email         = ['timothee.peignier@tryphon.org']
@@ -13,12 +11,13 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = 'rubocop-sequel'
   gem.require_paths = ['lib']
-  gem.version       = '0.0.1'
+  gem.version       = '0.0.2'
 
-  gem.add_runtime_dependency 'rubocop', '~> 0.46', '>= 0.46'
+  gem.add_runtime_dependency 'rubocop', '~> 0.51', '>= 0.51'
 
-  gem.add_development_dependency 'sequel', '~> 4.41', '>= 4.41.0'
+  gem.add_development_dependency 'rake', '~> 12.0.0', '>= 12.0.0'
   gem.add_development_dependency 'rspec', '~> 3.5', '>= 3.5.0'
+  gem.add_development_dependency 'sequel', '~> 4.41', '>= 4.41.0'
   gem.add_development_dependency 'simplecov', '~> 0.12'
   gem.add_development_dependency 'sqlite3', '~> 1.3', '>= 1.3.12'
 end

data/spec/rubocop/cop/sequel/column_default_spec.rb

@@ -4,12 +4,12 @@ describe RuboCop::Cop::Sequel::ColumnDefault do
   subject(:cop) { described_class.new }
 
   it 'registers an offense when setting a default' do
-    inspect_source(cop, 'add_column(:products, :type, :text, default: "cop")')
+    inspect_source('add_column(:products, :type, :text, default: "cop")')
     expect(cop.offenses.size).to eq(1)
   end
 
   it 'does not register an offense when not setting a default' do
-    inspect_source(cop, 'add_column(:products, :type, :text)')
+    inspect_source('add_column(:products, :type, :text)')
     expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/sequel/concurrent_index_spec.rb

@@ -5,23 +5,25 @@ describe RuboCop::Cop::Sequel::ConcurrentIndex do
 
   context 'without the concurrent option' do
     it 'registers an offense without options' do
-      inspect_source(cop, 'add_index(:products, :name)')
+      inspect_source('add_index(:products, :name)')
       expect(cop.offenses.size).to eq(1)
     end
 
     it 'registers an offense with other options' do
-      inspect_source(cop, 'add_index(:products, :name, unique: true)')
+      inspect_source('add_index(:products, :name, unique: true)')
       expect(cop.offenses.size).to eq(1)
     end
 
     it 'registers an offense with composite index' do
-      inspect_source(cop, 'add_index(:products, :name, unique: true)')
+      inspect_source('add_index(:products, :name, unique: true)')
       expect(cop.offenses.size).to eq(1)
     end
   end
 
   it 'does not register an offense when using concurrent option' do
-    inspect_source(cop, 'add_index(:products, :name, unique: true, concurrently: true)')
+    inspect_source(
+      'add_index(:products, :name, unique: true, concurrently: true)'
+    )
     expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/sequel/migration_name_spec.rb

@@ -15,12 +15,12 @@ describe RuboCop::Cop::Sequel::MigrationName, :config do
     let(:cop_config) { {} }
 
     it 'registers an offense when using the default name' do
-      inspect_source(cop, '', 'new_migration.rb')
+      inspect_source('', 'new_migration.rb')
       expect(cop.offenses.size).to eq(1)
     end
 
     it 'does not register an offense when using a specific name' do
-      inspect_source(cop, '', 'add_index.rb')
+      inspect_source('', 'add_index.rb')
       expect(cop.offenses).to be_empty
     end
   end
@@ -29,12 +29,12 @@ describe RuboCop::Cop::Sequel::MigrationName, :config do
     let(:cop_config) { { 'DefaultName' => 'add_migration' } }
 
     it 'registers an offense when using the default name' do
-      inspect_source(cop, '', 'add_migration.rb')
+      inspect_source('', 'add_migration.rb')
       expect(cop.offenses.size).to eq(1)
     end
 
     it 'does not register an offense when using a specific name' do
-      inspect_source(cop, '', 'add_index.rb')
+      inspect_source('', 'add_index.rb')
       expect(cop.offenses).to be_empty
     end
   end

data/spec/rubocop/cop/sequel/save_changes_spec.rb

@@ -4,17 +4,17 @@ describe RuboCop::Cop::Sequel::SaveChanges do
   subject(:cop) { described_class.new }
 
   it 'registers an offense when using save' do
-    inspect_source(cop, 'favorite.save')
+    inspect_source('favorite.save')
     expect(cop.offenses.size).to eq(1)
   end
 
   it 'does not register an offense when using save_changes' do
-    inspect_source(cop, 'favorite.save_changes')
+    inspect_source('favorite.save_changes')
     expect(cop.offenses).to be_empty
   end
 
   it 'auto-corrects by using save_changes' do
-    new_source = autocorrect_source(cop, 'favorite.save')
+    new_source = autocorrect_source('favorite.save')
     expect(new_source).to eq('favorite.save_changes')
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sequel
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Timothée Peignier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-19 00:00:00.000000000 Z
+date: 2017-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,40 +16,40 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: '0.51'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: '0.51'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: '0.51'
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: '0.51'
 - !ruby/object:Gem::Dependency
-  name: sequel
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.41'
+        version: 12.0.0
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.41.0
+        version: 12.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.41'
+        version: 12.0.0
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.41.0
+        version: 12.0.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -70,6 +70,26 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.5.0
+- !ruby/object:Gem::Dependency
+  name: sequel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.41'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.41.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.41'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 4.41.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -114,8 +134,8 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop_todo.yml"
+- ".travis.yml"
 - Gemfile
-- Gemfile.lock
 - LICENSE
 - README.md
 - lib/rubocop-sequel.rb
@@ -151,7 +171,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: A plugin for the RuboCop code style & linting tool.

data/Gemfile.lock

@@ -1,58 +0,0 @@
-PATH
-  remote: .
-  specs:
-    rubocop-sequel (0.0.1)
-      rubocop (~> 0.46, >= 0.46)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    ast (2.3.0)
-    diff-lcs (1.2.5)
-    docile (1.1.5)
-    json (2.0.2)
-    parser (2.3.3.1)
-      ast (~> 2.2)
-    powerpack (0.1.1)
-    rainbow (2.1.0)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    rubocop (0.46.0)
-      parser (>= 2.3.1.1, < 3.0)
-      powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.8.1)
-    sequel (4.41.0)
-    simplecov (0.12.0)
-      docile (~> 1.1.0)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
-    sqlite3 (1.3.12)
-    unicode-display_width (1.1.2)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  rspec (~> 3.5, >= 3.5.0)
-  rubocop-sequel!
-  sequel (~> 4.41, >= 4.41.0)
-  simplecov (~> 0.12)
-  sqlite3 (~> 1.3, >= 1.3.12)
-
-BUNDLED WITH
-   1.13.6