rubocop-sensible 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0fda0cc6fc88dea9320e290e2bfed5a768afd39f4b7d1f533017d6bb744befe5
-  data.tar.gz: 6496351bf703a841adb1482e22339d1ba5348aeb862e062c8f0773bfecce71a9
+  metadata.gz: d19bb41e5121b46ae55382d2742f2b7f7ae82dd64081e0cd37fd319ba02d2948
+  data.tar.gz: bb1f9acce57c7e3e63d417951580d6de0697dacd7dcf990538379686629463c6
 SHA512:
-  metadata.gz: a58c3b852fbd0e125c1d484673ae9b57b1b27645fe49ab6832dc4eb2bbfa36335704c69696534d8f579dee9fbc02ff1abd32de87facdc4c336bc2545bc7dd484
-  data.tar.gz: 47a10b94722465f1afb486751fa0f10bed1ad18eb5d0a8edfa5fde8a5eedb4ddad46d20cb31af5080d914746fa4b03ea0bdb15a0449cf55bf34f3bd06be25f22
+  metadata.gz: 964524154b24fa3f9395acda9c3b33fe36a8e0b7e0cf7b1d5ebe499678e12585dd157896d40d522ca76a426ca57b29f52a96131046324f2319b016c9707aedb0
+  data.tar.gz: 0dc8672964cb71236d3a0a327b603301c494388912a79da1caf06df5c9b087e2188b24f86f0ef3219d0f99277fef0ae01075d189fbd7d1439ec85e6b0148edc1

data/Gemfile

@@ -1,4 +1,6 @@
-source "https://rubygems.org"
+# frozen_string_literal: true
+
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in rubocop-sensible.gemspec
 gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop-sensible (0.2.0)
+    rubocop-sensible (0.3.0)
       rubocop (>= 0.60.0)
 
 GEM
@@ -9,9 +9,9 @@ GEM
   specs:
     ast (2.4.0)
     diff-lcs (1.3)
-    jaro_winkler (1.5.2)
-    parallel (1.17.0)
-    parser (2.6.3.0)
+    jaro_winkler (1.5.4)
+    parallel (1.19.1)
+    parser (2.7.0.2)
       ast (~> 2.4.0)
     rainbow (3.0.0)
     rake (10.5.0)
@@ -28,15 +28,15 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.0)
-    rubocop (0.70.0)
+    rubocop (0.79.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
-      parser (>= 2.6)
+      parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 1.7)
     ruby-progressbar (1.10.1)
-    unicode-display_width (1.6.0)
+    unicode-display_width (1.6.1)
 
 PLATFORMS
   ruby
@@ -48,4 +48,4 @@ DEPENDENCIES
   rubocop-sensible!
 
 BUNDLED WITH
-   2.0.1
+   2.1.4

data/README.md

@@ -2,6 +2,36 @@
 
 Sensible default for RuboCop.
 
+## Purpose
+
+The purpose of this tiny gem is to be useless at all.
+
+No, seriously. This gem adds serveral congigurations for RuboCop that I think are sensible and that's it. If RuboCop's default will be changed in the future, it's useless anymore.
+
+## What it does
+
+It overrides the following configurations.
+
+### Metrics/AbcSize
+
+It increases the default value to `20`. It can be lower, but 20 seems pretty reasonable from my experience. Send a Pull Request if you have a different opinion.
+
+### Metrics/LineLength
+
+It can be disabled at all, but for now it's `160`. `160` comes from my experience that code which is longer than 160 characters tends to have some problem.
+
+### Style/AsciiComments
+
+When the team is not international, we'd like to write comments in our own language.
+
+### Style/DoubleNegation
+
+Double negation is used so widely that it doesn't make sense to disable it by default.
+
+### Style/SymbolArray, Style/WordArray
+
+This is a little controversial but using styles like `[:create, :edit]` makes sense.
+
 ## Installation
 
 Add this line to your application's Gemfile:

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,7 +1,8 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "bundler/setup"
-require "rubocop/sensible"
+require 'bundler/setup'
+require 'rubocop/sensible'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +11,5 @@ require "rubocop/sensible"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start(__FILE__)

data/config/rubocop.yml

@@ -5,15 +5,15 @@ AllCops:
     - 'node_modules/**/*'
     - 'vendor/bundle/**/*'
 
+# LineLength 80 comes from restrictions in good old days.
+Layout/LineLength:
+  Max: 160
+
 # ABC size 20 is pretty well-done actually.
 # For a reference, RuboCop itself configures this value as 17.
 Metrics/AbcSize:
   Max: 20
 
-# LineLength 80 comes from restrictions in good old days.
-Metrics/LineLength:
-  Max: 160
-
 # If all member of the team is Japanese, writing comments in Japanese
 # makes sense.
 Style/AsciiComments:

data/lib/rubocop/sensible.rb

@@ -1,4 +1,6 @@
-require "rubocop/sensible/version"
+# frozen_string_literal: true
+
+require 'rubocop/sensible/version'
 
 module Rubocop
   module Sensible

data/lib/rubocop/sensible/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Rubocop
   module Sensible
-    VERSION = "0.2.0"
+    VERSION = '0.3.0'
   end
 end

data/rubocop-sensible.gemspec

@@ -1,30 +1,31 @@
+# frozen_string_literal: true
 
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "rubocop/sensible/version"
+require 'rubocop/sensible/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "rubocop-sensible"
+  spec.name          = 'rubocop-sensible'
   spec.version       = Rubocop::Sensible::VERSION
-  spec.authors       = ["OKURA Masafumi"]
-  spec.email         = ["masafumi.o1988@gmail.com"]
+  spec.authors       = ['OKURA Masafumi']
+  spec.email         = ['masafumi.o1988@gmail.com']
 
-  spec.summary       = "Sensible configuration for RuboCop"
-  spec.description   = "Sensible configuration for RuboCop"
-  spec.homepage      = "https://github.com/okuramasafumi/rubocop-sensible"
-  spec.license       = "MIT"
+  spec.summary       = 'Sensible configuration for RuboCop'
+  spec.description   = 'Sensible configuration for RuboCop'
+  spec.homepage      = 'https://github.com/okuramasafumi/rubocop-sensible'
+  spec.license       = 'MIT'
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files         = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "rubocop", ">= 0.60.0"
-  spec.add_development_dependency "bundler", "~> 2.0"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_dependency 'rubocop', '>= 0.60.0'
+  spec.add_development_dependency 'bundler', '~> 2.0'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sensible
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - OKURA Masafumi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-05-29 00:00:00.000000000 Z
+date: 2020-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -107,7 +107,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Sensible configuration for RuboCop