rubocop-sensei 0.1.1 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eadef9a8f8be1d6ef6ac1eb8ca500edb3d66e5b7f916ed94dc9207527d5ebb20
-  data.tar.gz: 254999ef760ebe16339196c7fb130290b1059f49f4e4856b84a85bd83277f944
+  metadata.gz: 4417b210dffcd34adf72e0699d8f8fb835da4adf6495800f61b4d20337ef1789
+  data.tar.gz: 0e52dde379f1e0f6d1bef9e6e294c8504dc07862522712edcd2162ff0170ecc0
 SHA512:
-  metadata.gz: 24b4a56e67cb97e6e5653ad1c270be034f1d97bf9da33e81a8b57b18d0ba434fa14b75d6c1e04ebc5d6941998ea4d2b44784ebba62eff2ff79d1672d08d7c5b4
-  data.tar.gz: 8a81bca988686cd1f245a15c4cdf256d07170c7733d49a44b2bca3a130c63c2b8a9598f27fdf59c45e9b7ecd69bc956226f1b82f4f80d6696b4a63f49dfa07d6
+  metadata.gz: 6ce15e09a41f442788be5ef73bb6612d1c2716a2860f2d1fa71b1cb8788d6ee0861039e49bdb69436a0ef1010fa0d73a8fd88ae426930795059b89c50084ebf4
+  data.tar.gz: d9cf4aab057cc1af99cb732702eb6deda38ae9c6b4763b599ab36e836ae75a5ed86266990c68adfb7b093328f81d49db74c3a5752016369c9c1d550f1f902f7c

data/Gemfile.lock

@@ -1,29 +1,29 @@
 PATH
   remote: .
   specs:
-    rubocop-sensei (0.1.1)
+    rubocop-sensei (0.1.3)
       rubocop
 
 GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.2)
-    debug (1.7.0)
+    debug (1.7.1)
       irb (>= 1.5.0)
       reline (>= 0.3.1)
     diff-lcs (1.5.0)
-    io-console (0.5.11)
-    irb (1.6.0)
+    io-console (0.6.0)
+    irb (1.6.2)
       reline (>= 0.3.0)
     json (2.6.3)
-    minitest (5.15.0)
+    minitest (5.17.0)
     parallel (1.22.1)
-    parser (3.1.3.0)
+    parser (3.2.0.0)
       ast (~> 2.4.1)
     rainbow (3.1.1)
     rake (13.0.6)
     regexp_parser (2.6.1)
-    reline (0.3.1)
+    reline (0.3.2)
       io-console (~> 0.5)
     rexml (3.2.5)
     rspec (3.12.0)
@@ -32,27 +32,27 @@ GEM
       rspec-mocks (~> 3.12.0)
     rspec-core (3.12.0)
       rspec-support (~> 3.12.0)
-    rspec-expectations (3.12.0)
+    rspec-expectations (3.12.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
-    rspec-mocks (3.12.0)
+    rspec-mocks (3.12.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-support (3.12.0)
-    rubocop (1.41.1)
+    rubocop (1.42.0)
       json (~> 2.3)
       parallel (~> 1.10)
       parser (>= 3.1.2.1)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.23.0, < 2.0)
+      rubocop-ast (>= 1.24.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
     rubocop-ast (1.24.1)
       parser (>= 3.1.1.0)
     ruby-progressbar (1.11.0)
-    unicode-display_width (2.3.0)
+    unicode-display_width (2.4.2)
 
 PLATFORMS
   arm64-darwin-21

data/config/default.yml

@@ -1,4 +1,9 @@
-Style/ReplaceElsif:
-  Description: '`elsif` can be replaced with `case`'
+Lecture/ReplaceElsif:
+  Description: "`elsif` can be replaced with `case`"
   Enabled: true
-  VersionAdded: '0.1.0'
+  VersionAdded: "0.1.0"
+
+Lecture/UnlessElse:
+  Description: "Do not use `unless` with `else`. Rewrite these with the positive case first."
+  Enabled: true
+  VersionAdded: "0.1.3"

data/lib/rubocop/cop/{style → lecture}/replace_elsif.rb

@@ -2,7 +2,7 @@
 
 module RuboCop
   module Cop
-    module Style
+    module Lecture
       # `elsif`は`case`で書き換え可能です。
       # N個の分岐から1つ選ぶ「N者択一」のときはcaseをつかうと読みやすくなります。
       #
@@ -65,7 +65,10 @@ module RuboCop
           return unless node.elsif?
 
           add_offense(node) do |corrector|
-            corrector.replace(node.parent.loc.keyword, "case\nwhen")  # if => case when
+            # if => case when
+            replacing_string = "case" + "\n" +
+             " " * node.parent.source_range.column + "when"
+            corrector.replace(node.parent.loc.keyword, replacing_string)
             corrector.replace(node.loc.keyword, "when") # elsif => when
           end
         end

data/lib/rubocop/cop/lecture/unless_else.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Lecture
+      class UnlessElse < ::RuboCop::Cop::Style::UnlessElse
+        MSG = <<~STRING
+          `unless` `else` は避けた方が良いです。
+          `if` をつかって書き直すと読みやすくなります。
+
+          unless x == 1
+            puts "foo"
+          else
+            puts "bar"
+          end
+
+          ifをつかって書き直した例です。
+
+          if x == 1
+            puts "bar"
+          else
+            puts "foo"
+          end
+
+          このCopは RuboCop gem Style/UnlessElse と同じ内容です。
+        STRING
+      end
+    end
+  end
+end

data/lib/rubocop/cop/sensei_cops.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
 
-require_relative 'style/replace_elsif'
+require_relative 'lecture/replace_elsif'
+require_relative 'lecture/unless_else'

data/lib/rubocop/sensei/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Sensei
-    VERSION = "0.1.1"
+    VERSION = "0.1.3"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sensei
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.3
 platform: ruby
 authors:
 - Kuniaki Igarashi
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-12-31 00:00:00.000000000 Z
+date: 2023-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -40,8 +40,9 @@ files:
 - Rakefile
 - config/default.yml
 - lib/rubocop-sensei.rb
+- lib/rubocop/cop/lecture/replace_elsif.rb
+- lib/rubocop/cop/lecture/unless_else.rb
 - lib/rubocop/cop/sensei_cops.rb
-- lib/rubocop/cop/style/replace_elsif.rb
 - lib/rubocop/sensei.rb
 - lib/rubocop/sensei/inject.rb
 - lib/rubocop/sensei/version.rb