rubocop-rubomatic 2.0.0 → 2.1.0

data/config/lint.yml

@@ -19,6 +19,10 @@ Lint/AmbiguousRange:
 Lint/AmbiguousRegexpLiteral:
   Enabled: true
 
+Lint/ArgumentMismatch:
+  # Requires `AllCops/UseProjectIndex: true` and the `rubydex` gem
+  Enabled: true
+
 Lint/ArrayLiteralInRegexp:
   Enabled: true
 
@@ -61,6 +65,9 @@ Lint/ConstantResolution:
 Lint/CopDirectiveSyntax:
   Enabled: true
 
+Lint/DataDefineOverride:
+  Enabled: true
+
 Lint/Debugger:
   Enabled: true
   DebuggerMethods:
@@ -141,6 +148,10 @@ Lint/DeprecatedConstants:
 Lint/DeprecatedOpenSSLConstant:
   Enabled: true
 
+Lint/DeprecatedReference:
+  # Requires `AllCops/UseProjectIndex: true` and the `rubydex` gem
+  Enabled: true
+
 Lint/DisjunctiveAssignmentInConstructor:
   Enabled: true
 
@@ -167,6 +178,8 @@ Lint/DuplicateMatchPattern:
 
 Lint/DuplicateMethods:
   Enabled: true
+  DelegatingMethods:
+    - delegate
 
 Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
@@ -288,6 +301,9 @@ Lint/LiteralInInterpolation:
 Lint/Loop:
   Enabled: true
 
+Lint/MisplacedMagicComment:
+  Enabled: true
+
 Lint/MissingCopEnableDirective:
   Enabled: true
   # Maximum number of consecutive lines the cop can be disabled for.
@@ -297,7 +313,7 @@ Lint/MissingCopEnableDirective:
   #   a = 1
   #   # rubocop:enable SomeCop
   # .inf for any size
-  MaximumRangeSize: .inf
+  MaxRangeSize: .inf
 
 Lint/MissingSuper:
   Enabled: true
@@ -311,6 +327,13 @@ Lint/MixedRegexpCaptureTypes:
 Lint/MultipleComparison:
   Enabled: true
 
+Lint/NameTypo:
+  # Requires `AllCops/UseProjectIndex: true` and the `rubydex` gem
+  Enabled: true
+  CheckConstants: true
+  CheckMethods: true
+  AllowedNames: [] # Project specific
+
 Lint/NestedMethodDefinition:
   Enabled: true
   AllowedMethods: [ ]
@@ -357,7 +380,7 @@ Lint/NumberConversion:
     - fortnights
     - in_milliseconds
   AllowedPatterns: [ ]
-  IgnoredClasses:
+  AllowedClasses:
     - Time
     - DateTime
 
@@ -468,6 +491,18 @@ Lint/SafeNavigationChain:
     - try
     - try!
     - in?
+    # BrandsInsurance/rails-extensions NilClass support
+    - positive?
+    - negative?
+    - zero?
+    - nonzero?
+    - to_sym
+    - to_date
+    - to_datetime
+    - html_safe
+    - usd_to_f
+    - usd_to_i
+    - to_bool
 
 Lint/SafeNavigationConsistency:
   Enabled: true
@@ -506,6 +541,10 @@ Lint/SharedMutableDefault:
 Lint/StructNewOverride:
   Enabled: true
 
+Lint/SuperArgumentMismatch:
+  # Requires `AllCops/UseProjectIndex: true` and the `rubydex` gem
+  Enabled: true
+
 Lint/SuppressedException:
   Enabled: true
   AllowComments: true
@@ -576,6 +615,9 @@ Lint/UnreachableLoop:
     # eg. `exactly(2).times`
     - !ruby/regexp /(exactly|at_least|at_most)\(\d+\)\.times/
 
+Lint/UnreachablePatternBranch:
+  Enabled: true
+
 Lint/UnusedBlockArgument:
   Enabled: true
   IgnoreEmptyBlocks: true
@@ -587,6 +629,12 @@ Lint/UnusedMethodArgument:
   IgnoreEmptyMethods: true
   IgnoreNotImplementedMethods: true
 
+Lint/UnusedPrivateMethod:
+  # Requires `AllCops/UseProjectIndex: true` and the `rubydex` gem
+  Enabled: true
+  AllowedNames: [ ]
+  AllowedPatterns: [ ]
+
 Lint/UriEscapeUnescape:
   Enabled: true
 

data/config/metrics.yml

@@ -39,9 +39,9 @@ Metrics/ClassLength:
 <% if RuboCop::Version.document_version.to_f >= 1.47 %>
 Metrics/CollectionLiteralLength:
   Enabled: true
-  LengthThreshold: 250
+  Max: 250
   Exclude:
-    - lib/tasks/seeds
+    - db/seeds
 <% end %>
 
 # Avoid complex methods.

data/config/rspec.yml

@@ -96,6 +96,10 @@ RSpec/DescribedClassModuleWrapping:
 RSpec/Dialect:
   Enabled: false
 
+RSpec/DiscardedMatcher:
+  Enabled: true
+  CustomMatcherMethods: [ ]
+
 RSpec/DuplicatedMetadata:
   Enabled: true
 
@@ -160,6 +164,7 @@ RSpec/ExpectActual:
 RSpec/ExpectChange:
   Enabled: true
   EnforcedStyle: block
+  NegatedMatcher: not_change
 
 RSpec/ExpectInHook:
   Enabled: true
@@ -239,12 +244,15 @@ RSpec/LetSetup:
 RSpec/MatchArray:
   Enabled: true
 
+RSpec/MatchWithSimpleRegex:
+  Enabled: true
+
 RSpec/MessageChain:
   Enabled: true
 
 RSpec/MessageExpectation:
   Enabled: true
-  EnforcedStyle: expect
+  EnforcedStyle: allow
 
 RSpec/MessageSpies:
   Enabled: true
@@ -295,6 +303,9 @@ RSpec/NotToNot:
   Enabled: true
   EnforcedStyle: to_not
 
+RSpec/Output:
+  Enabled: true
+
 RSpec/OverwritingSetup:
   Enabled: true
 
@@ -358,6 +369,7 @@ RSpec/ScatteredSetup:
 
 RSpec/SharedContext:
   Enabled: true
+  Strict: true
 
 RSpec/SharedExamples:
   Enabled: true

data/config/rubocop.yml

@@ -20,6 +20,8 @@ inherit_mode:
 
 AllCops:
   NewCops: disable
+  UseProjectIndex: true
+  ProjectIndexIncludesGems: false
   Exclude:
     - 'vendor/**/*'
     - 'spec/fixtures/**/*'

data/config/style.yml

@@ -299,6 +299,9 @@ Style/CollectionMethods:
     - inject
     - reduce
 
+Style/CollectionQuerying:
+  Enabled: true
+
 Style/ColonMethodCall:
   Enabled: true
 
@@ -410,10 +413,15 @@ Style/Dir:
 Style/DirEmpty:
   Enabled: true
 
+Style/DirectiveScope:
+  Enabled: true
+
 Style/DisableCopsWithinSourceCodeDirective:
   Severity: info # Or warning
   Enabled: true
-  AllowedCops: # Project specific
+  AllowedCops: [] # Project specific
+  DisallowedCops: [] # Project specific
+  AllowWithReason: true
 
 Style/DocumentDynamicEvalDefinition:
   Enabled: true
@@ -436,9 +444,6 @@ Style/DocumentationMethod:
     - method_missing
     - respond_to_missing?
 
-Style/DoubleCopDisableDirective:
-  Enabled: true
-
 Style/DoubleNegation:
   Enabled: true
   EnforcedStyle: allowed_in_returns
@@ -458,6 +463,14 @@ Style/EmptyBlockParameter:
 Style/EmptyCaseCondition:
   Enabled: true
 
+Style/EmptyClassDefinition:
+  Enabled: true
+  EnforcedStyle: class_keyword
+  SupportedStyles:
+    - class_keyword
+    - class_new
+  AllowedParentClasses: [ ]
+
 Style/EmptyElse:
   Enabled: true
   EnforcedStyle: both
@@ -533,7 +546,7 @@ Style/ExponentialNotation:
 Style/FetchEnvVar:
   Enabled: true
   # Environment variables to be excluded from the inspection.
-  AllowedVars: [ ]
+  AllowedVariables: [ ]
   DefaultToNil: false
 
 Style/FileEmpty:
@@ -542,6 +555,9 @@ Style/FileEmpty:
 Style/FileNull:
   Enabled: true
 
+Style/FileOpen:
+  Enabled: true
+
 Style/FileRead:
   Enabled: true
 
@@ -653,6 +669,13 @@ Style/HashLikeCase:
   # to trigger this cop
   MinBranchesCount: 3
 
+Style/HashLookupMethod:
+  Enabled: false
+  EnforcedStyle: fetch
+  SupportedStyles:
+    - brackets
+    - fetch
+
 Style/HashSlice:
   Enabled: true
 
@@ -840,6 +863,9 @@ Style/MapCompactWithConditionalBlock:
 Style/MapIntoArray:
   Enabled: true
 
+Style/MapJoin:
+  Enabled: true
+
 Style/MapToHash:
   Enabled: true
 
@@ -849,7 +875,12 @@ Style/MapToSet:
 Style/MethodCallWithArgsParentheses:
   Enabled: true
   IgnoreMacros: true
-  AllowedMethods: [ ]
+  AllowedMethods:
+    - has_many
+    - has_one
+    - belongs_to
+    - delegate
+    - accepts_nested_attributes_for
   AllowedPatterns: [ ]
   IncludedMacros: [ ]
   IncludedMacroPatterns: [ ]
@@ -958,7 +989,7 @@ Style/MultilineWhenThen:
 Style/MultipleComparison:
   Enabled: true
   AllowMethodComparison: true
-  ComparisonsThreshold: 2
+  ComparisonsThreshold: 3
 
 Style/MutableConstant:
   Enabled: true
@@ -1001,6 +1032,9 @@ Style/NegatedUnless:
 Style/NegatedWhile:
   Enabled: true
 
+Style/NegativeArrayIndex:
+  Enabled: true
+
 Style/NestedFileDirname:
   Enabled: true
 
@@ -1126,6 +1160,10 @@ Style/ObjectThen:
     - then
     - yield_self
 
+Style/OneClassPerFile:
+  Enabled: true
+  AllowedClasses: [ ]
+
 Style/OneLineConditional:
   Enabled: true
   AlwaysCorrectToMultiline: false
@@ -1166,6 +1204,9 @@ Style/ParenthesesAroundCondition:
   AllowSafeAssignment: true
   AllowInMultilineConditions: false
 
+Style/PartitionInsteadOfDoubleSelect:
+  Enabled: true
+
 Style/PercentLiteralDelimiters:
   Enabled: true
   # Specify the default preferred delimiter for all types with the 'default' key
@@ -1184,6 +1225,9 @@ Style/PercentQLiterals:
 Style/PerlBackrefs:
   Enabled: true
 
+Style/PredicateWithKind:
+  Enabled: true
+
 Style/PreferredHashMethods:
   Enabled: false
   EnforcedStyle: short
@@ -1213,6 +1257,9 @@ Style/RaiseArgs:
 Style/RandomWithOffset:
   Enabled: true
 
+Style/ReduceToHash:
+  Enabled: true
+
 Style/RedundantArgument:
   Enabled: true
   Methods:
@@ -1294,6 +1341,9 @@ Style/RedundantInterpolationUnfreeze:
 Style/RedundantLineContinuation:
   Enabled: true
 
+Style/RedundantMinMaxBy:
+  Enabled: true
+
 Style/RedundantParentheses:
   Enabled: true
 
@@ -1335,6 +1385,9 @@ Style/RedundantSortBy:
 Style/RedundantStringEscape:
   Enabled: true
 
+Style/RedundantStructKeywordInit:
+  Enabled: true
+
 Style/RegexpLiteral:
   Enabled: true
   EnforcedStyle: slashes
@@ -1365,7 +1418,7 @@ Style/RescueStandardError:
     - explicit
 
 Style/ReturnNil:
-  Enabled: false
+  Enabled: true
   EnforcedStyle: return
   SupportedStyles:
     - return
@@ -1376,6 +1429,10 @@ Style/ReturnNilInPredicateMethodDefinition:
   AllowedMethods: [ ]
   AllowedPatterns: [ ]
 
+Style/ReverseFind:
+  # `Array#rfind` was added in ruby 4.0
+  Enabled: <%= ENV['RUBY_VERSION'].to_f >= 4.0 %>
+
 Style/SafeNavigation:
   Enabled: true
   # Safe navigation may cause a statement to start returning `nil` in addition
@@ -1396,6 +1453,12 @@ Style/SafeNavigationChainLength:
 Style/Sample:
   Enabled: true
 
+Style/SelectByKind:
+  Enabled: false
+
+Style/SelectByRange:
+  Enabled: false
+
 Style/SelectByRegexp:
   Enabled: true
 
@@ -1545,6 +1608,9 @@ Style/SymbolProc:
   AllowedPatterns: [ ]
   AllowComments: false
 
+Style/TallyMethod:
+  Enabled: true
+
 Style/TernaryParentheses:
   Enabled: true
   EnforcedStyle: require_parentheses_when_complex
@@ -1554,6 +1620,9 @@ Style/TernaryParentheses:
     - require_parentheses_when_complex
   AllowSafeAssignment: false
 
+Style/TimeNow:
+  Enabled: true
+
 Style/TopLevelMethodDefinition:
   Enabled: false
 

data/docs/cops/layout/README.md

@@ -0,0 +1,7 @@
+# Layout
+
+Layout cops check for stylistic whitespace in your code
+
+## Cops
+
+* [`Layout/MultilineArrayLineBreaks`](./multiline_array_line_breaks/README.md)

data/docs/cops/layout/multiline_array_line_breaks/README.md

@@ -0,0 +1,36 @@
+# `Layout/MultilineArrayLineBreaks`
+
+## Description
+
+Extends the built-in [`Layout/MultilineArrayLineBreaks`][upstream] and adds the `AllowPercentArray` option
+
+[upstream]: https://docs.rubocop.org/rubocop/1.49/cops_layout.html#layoutmultilinearraylinebreaks
+
+## Examples
+
+```ruby
+# bad
+%w[
+  1
+  2
+  3
+  4
+]
+
+# good
+%w[
+  1 2
+  3 4
+]
+```
+
+## Configurable Attributes
+
+| Name                       | Default value | Configurable values |
+| -------------------------- | ------------- | ------------------- |
+| AllowMultilineFinalElement | false         | Boolean             |
+| AllowPercentArray          | false         | Boolean             |
+
+## References
+
+* https://github.com/BrandsInsurance/expert-chainsaw/issues/1032

data/docs/cops/style/README.md

@@ -0,0 +1,7 @@
+# Style
+
+Style cops check for stylistic consistency of your code
+
+## Cops
+
+* [`Style/DisallowedMethods`](./disallowed_methods/README.md)

data/docs/cops/style/disallowed_methods/{README.adoc → README.md}

@@ -1,13 +1,12 @@
-= ``Style/DisallowedMethods``
+# `Style/DisallowedMethods`
 
-== Description
+## Description
 
 Certain methods should not be used
 
-== Examples
+## Examples
 
-[source,ruby]
-----
+```ruby
 # Bad (Don't use `tap`)
 tap do
 end
@@ -17,12 +16,12 @@ abort
 
 # Good (Use `raise` instead of `abort`)
 raise
-----
+```
 
-== Configurable Attributes
+## Configurable Attributes
 
 There are no configurable attributes
 
-== References
+## References
 
 * https://github.com/BrandsInsurance/expert-chainsaw/issues/434

data/lib/rubocop/cop/rubomatic/generator/cop_readme_injector.rb

@@ -6,7 +6,7 @@ module RuboCop
       class Generator
         class CopReadmeInjector < DeptReadmeInjector
           TEMPLATE =
-            '* xref:./%{cop_folder}/README.adoc[``%{department}/%{cop}``]'
+            '* [`%{department}/%{cop}`](./%{cop_folder}/README.md)'
 
           # :nodoc:
           def initialize(badge:, **kwargs)
@@ -26,7 +26,7 @@ module RuboCop
                 department_folder: snake_case(department),
                 cop_folder: snake_case(cop),
                 department: department,
-                cop: cop
+                cop: cop,
               })
             end
 
@@ -42,7 +42,7 @@ module RuboCop
 
             # @see super
             def target_regex
-              %r{\* xref:\./docs/cops/[a-z_]+/[a-z_]+/README\.adoc\[``(?<department>[a-zA-Z_]+)/(?<cop>[a-zA-Z_]+)``\]}
+              %r{\* \[`(?<department>[a-zA-Z_]+)/(?<cop>[a-zA-Z_]+)`\]\(\./[a-z_]+/README\.md\)}
             end
         end
       end

data/lib/rubocop/cop/rubomatic/generator/dept_readme_injector.rb

@@ -5,7 +5,7 @@ module RuboCop
     module Rubomatic
       class Generator
         class DeptReadmeInjector
-          TEMPLATE = '* xref:./docs/cops/%{department_folder}/README.adoc[``%{department}``]'
+          TEMPLATE = '* [`%{department}`](./docs/cops/%{department_folder}/README.md)'
 
           # :nodoc:
           def initialize(readme_file_path:, badge:, department:)
@@ -46,7 +46,7 @@ module RuboCop
             # @return [*] Default $stdout
             attr_reader :output
 
-            # Lines in <department>/README.adoc
+            # Lines in <department>/README.md
             #
             # @return [Array<String>]
             #
@@ -61,7 +61,7 @@ module RuboCop
             def new_readme_entry
               format(TEMPLATE, {
                 department_folder: snake_case(department),
-                department: department
+                department: department,
               })
             end
 
@@ -74,7 +74,7 @@ module RuboCop
                 return index if line_is_good?(line)
               end
 
-              return nil
+              return
             end
 
             # Determines if the given line is the same type we're trying to add and if it's alphabetically before
@@ -93,7 +93,7 @@ module RuboCop
             # @return [Regexp]
             #
             def target_regex
-              %r{\* xref:\./docs/cops/[a-z_]+/README\.adoc\[``(?<department>[a-zA-Z_]+)``\]}
+              %r{\* \[`(?<department>[a-zA-Z_]+)`\]\(\./docs/cops/[a-z_]+/README\.md\)}
             end
 
             # Copied from Rubocop::Cop::Generator