rubocop-rubomatic 1.6.0.rc.pre.1 → 1.6.0.rc.pre.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c2428f17fa3a09ef250e03a6561c4de254ee61052b956c78c917d56fa2b85a6
-  data.tar.gz: 193c58c2cd0c1ca4b06f193b093440adb497353a33ab4fa61ba0402f6f879487
+  metadata.gz: 366175b4cee4057a13a3aa830e3d3b6d5792a4a8769ecbf05c242d45d04b02e6
+  data.tar.gz: 1b46b321dfaa75c7a0dc6a8414a1b8f70ba255b4c4d736f0d779554a921b9a1f
 SHA512:
-  metadata.gz: 983db2f236ae6127ea6fadbaba7651b46576f48489ad1c992adb87b53bd13a5f7d75a26e37e4a19b2b287ce6d1ab1bccb67be657cdd50f5da619adf70957c40c
-  data.tar.gz: 4c387073a9cbd65b674f183792261ff50710f38c2782fbd92d42f5734cc9085212be1220c89c35ba971cd6ee0c2a5694e712cee7691225cfe4861a062f5ed1be
+  metadata.gz: 2c011520f266a5734ebc12d6ace5c9089db36686761232b901ace8179ac24a852e0b7c6928b6013091c4a78e629fb7ba2c172d6e8034f0cd22cd58380965975b
+  data.tar.gz: 1b11a43dab354bd17f100a8d987634211f828868077b37a58a8a6f4c5cf1fb9fd551e45a7fff8eeb167042b12a57632bb85cee4df7c0da06f39146815851b682

data/CHANGELOG.adoc

@@ -3,6 +3,54 @@
 * Upgrade to ``ruobcop 1.76.1``
 ** This includes the change from ``require:`` to ``plugins:``.
 While ``require:`` will still work, there will be a deprecation warning
+** Set ``Layout/LeadingCommentSpace/AllowSteepAnnotation`` to ``false``
+** Enabled ``Lint/ArrayLiteralInRegexp``
+** Enabled ``Lint/ConstantReassignment``
+** Enabled ``Lint/CopDirectiveSyntax``
+** Enabled ``Lint/DuplicateSetElement``
+** Set ``Lint/DuplicateBranch/IgnoreDuplicateElseBranch`` to ``true``
+** Enabled ``Lint/HashNewWithKeywordArgumentsAsDefault``
+** Enabled ``Lint/NumericOperationWithConstantResult``
+** Enabled ``Lint/RedundantTypeConversion``
+** Enabled ``Lint/SharedMutableDefault``
+** Enabled ``Lint/SuppressedExceptionInNumberConversion``
+** Enabled ``Lint/UnescapedBracketInRegexp``
+** Enabled ``Lint/UselessConstantScoping``
+** Enabled ``Lint/UselessDefaultValueArgument``
+** Enabled ``Lint/UselessDefined``
+** Enabled ``Lint/UselessNumericOperation``
+** Enabled ``Lint/UselessOr``
+** Enabled ``Naming/PredicateMethod``
+** Enabled ``Style/AmbiguousEndlessMethodDefinition``
+** Enabled ``Style/BitwisePredicate``
+** Enabled ``Style/ComparableBetween``
+** Enabled ``Style/CombinableDefined``
+** Enabled ``Style/DigChain``
+** Enabled ``Style/EmptyStringInsideInterpolation``
+** Enabled ``Style/FileNull``
+** Enabled ``Style/FileTouch``
+** Enabled ``Style/HashFetchChain``
+** Enabled ``Style/HashSlice``
+** Enabled ``Style/ItAssignment``
+** Enabled ``Style/ItBlockParameter``
+** Enabled ``Style/KeywordArgumentsMergin``
+** Enabled ``Style/RedundantArrayFlatten``
+** Enabled ``Style/RedundantFormat``
+** Enabled ``Style/RedundantInterpolationUnfreeze``
+** Disabled ``Style/SafeNavigationChainLength``
+* Added ``rack_attack.rb`` to exclude list for ``Style/IpAddresses``
+* Upgraded to ``rubocop-performance 1.25.0``
+** Enabled ``Performance/StringBytesize``
+** Enabled ``Performance/ZipWithoutBlock``
+* Added ``rubocop-packaging 0.6.0``
+** Enabled ``Packaging/GemspecGit``
+* Added ``rubocop-thread_safety 0.7.2``
+** Enabled ``ThreadSafety/ClassAndModuleAttributes``
+** Enabled ``ThreadSafety/ClassInstanceVariable``
+** Enabled ``ThreadSafety/DirChdir``
+** Enabled ``ThreadSafety/MutableClassInstanceVariable``
+** Enabled ``ThreadSafety/NewThread``
+** Enabled ``ThreadSafety/RackMiddlewareInstanceVariable``
 
 == 1.5.1 (2024-10-22)
 

data/config/gemspec_on.yml

@@ -56,3 +56,11 @@ Gemspec/RubyVersionGlobalsUsage:
 
 Naming/FileName:
   Enabled: false
+
+plugins: rubocop-packaging
+
+Packaging:
+  Enabled: false
+
+Packaging/GemspecGit:
+  Enabled: true

data/config/layout.yml

@@ -526,6 +526,7 @@ Layout/LeadingCommentSpace:
   Enabled: true
   AllowDoxygenCommentStyle: false
   AllowGemfileRubyComment: false
+  AllowSteepAnnotation: false
 
 Layout/LeadingEmptyLines:
   Enabled: true

data/config/lint.yml

@@ -19,6 +19,9 @@ Lint/AmbiguousRange:
 Lint/AmbiguousRegexpLiteral:
   Enabled: true
 
+Lint/ArrayLiteralInRegexp:
+  Enabled: true
+
 Lint/AssignmentInCondition:
   Enabled: true
   AllowSafeAssignment: false
@@ -45,6 +48,9 @@ Lint/ConstantDefinitionInBlock:
 Lint/ConstantOverwrittenInRescue:
   Enabled: true
 
+Lint/ConstantReassignment:
+  Enabled: true
+
 Lint/ConstantResolution:
   Enabled: false
   # Restrict this cop to only looking at certain names
@@ -52,6 +58,9 @@ Lint/ConstantResolution:
   # Restrict this cop from only looking at certain names
   Ignore: [ ]
 
+Lint/CopDirectiveSyntax:
+  Enabled: true
+
 Lint/Debugger:
   Enabled: true
   DebuggerMethods:
@@ -139,6 +148,7 @@ Lint/DuplicateBranch:
   Enabled: true
   IgnoreLiteralBranches: true
   IgnoreConstantBranches: true
+  IgnoreDuplicateElseBranch: true
 
 Lint/DuplicateCaseCondition:
   Enabled: true
@@ -167,6 +177,9 @@ Lint/DuplicateRequire:
 Lint/DuplicateRescueException:
   Enabled: true
 
+Lint/DuplicateSetElement:
+  Enabled: true
+
 Lint/EachWithObjectArgument:
   Enabled: true
 
@@ -228,6 +241,9 @@ Lint/FormatParameterMismatch:
 Lint/HashCompareByIdentity:
   Enabled: true
 
+Lint/HashNewWithKeywordArgumentsAsDefault:
+  Enabled: true
+
 Lint/HeredocMethodCallPosition:
   Enabled: true
 
@@ -348,6 +364,9 @@ Lint/NumberConversion:
 Lint/NumberedParameterAssignment:
   Enabled: true
 
+Lint/NumericOperationWithConstantResult:
+  Enabled: true
+
 Lint/OrAssignmentToConstant:
   Enabled: true
 
@@ -407,6 +426,9 @@ Lint/RedundantSplatExpansion:
 Lint/RedundantStringCoercion:
   Enabled: true
 
+Lint/RedundantTypeConversion:
+  Enabled: true
+
 Lint/RedundantWithIndex:
   Enabled: true
 
@@ -478,6 +500,9 @@ Lint/ShadowedException:
 Lint/ShadowingOuterLocalVariable:
   Enabled: true
 
+Lint/SharedMutableDefault:
+  Enabled: true
+
 Lint/StructNewOverride:
   Enabled: true
 
@@ -486,6 +511,9 @@ Lint/SuppressedException:
   AllowComments: true
   AllowNil: true
 
+Lint/SuppressedExceptionInNumberConversion:
+  Enabled: true
+
 Lint/SymbolConversion:
   Enabled: true
   EnforcedStyle: consistent
@@ -515,6 +543,9 @@ Lint/UnderscorePrefixedVariableName:
   Enabled: true
   AllowKeywordBlockArguments: false
 
+Lint/UnescapedBracketInRegexp:
+  Enabled: true
+
 Lint/UnexpectedBlockArity:
   Enabled: true
   Methods:
@@ -570,12 +601,29 @@ Lint/UselessAccessModifier:
 Lint/UselessAssignment:
   Enabled: true
 
+Lint/UselessConstantScoping:
+  Enabled: true
+
+Lint/UselessDefaultValueArgument:
+  Enabled: true
+  AllowedReceivers:
+    - 'Rails.cache'
+
+Lint/UselessDefined:
+  Enabled: true
+
 Lint/UselessElseWithoutRescue:
   Enabled: true
 
 Lint/UselessMethodDefinition:
   Enabled: true
 
+Lint/UselessNumericOperation:
+  Enabled: true
+
+Lint/UselessOr:
+  Enabled: true
+
 Lint/UselessRescue:
   Enabled: true
 

data/config/naming.yml

@@ -191,7 +191,11 @@ Naming/MethodParameterName:
   # Forbidden names that will register an offense
   ForbiddenNames: [ ]
 
-Naming/PredicateName:
+Naming/PredicateMethod:
+  Enabled: true
+  Mode: aggresive
+
+Naming/PredicatePrefix:
   Enabled: true
   # Predicate name prefixes.
   NamePrefix:

data/config/performance.yml

@@ -119,6 +119,9 @@ Performance/StartWith:
   Enabled: true
   SafeMultiline: false
 
+Performance/StringBytesize:
+  Enabled: true
+
 Performance/StringIdentifierArgument:
   Enabled: true
 
@@ -134,3 +137,6 @@ Performance/Sum:
 
 Performance/TimesMap:
   Enabled: true
+
+Performance/ZipWithoutBlock:
+  Enabled: true

data/config/rubocop.yml

@@ -11,6 +11,7 @@ inherit_from:
   - ./performance.yml
   - ./security.yml
   - ./style.yml
+  - ./thread_safety.yml
 
 inherit_mode:
   merge:

data/config/style.yml

@@ -23,6 +23,9 @@ Style/Alias:
     - prefer_alias
     - prefer_alias_method
 
+Style/AmbiguousEndlessMethodDefinition:
+  Enabled: true
+
 Style/AndOr:
   Enabled: true
   # Whether `and` and `or` are banned only in conditionals (conditionals)
@@ -75,6 +78,9 @@ Style/BeginBlock:
 Style/BisectedAttrAccessor:
   Enabled: true
 
+Style/BitwisePredicate:
+  Enabled: true
+
 Style/BlockComments:
   Enabled: true
 
@@ -295,6 +301,9 @@ Style/ColonMethodCall:
 Style/ColonMethodDefinition:
   Enabled: true
 
+Style/CombinableDefined:
+  Enabled: true
+
 Style/CombinableLoops:
   Enabled: true
 
@@ -327,6 +336,9 @@ Style/CommentAnnotation:
 Style/CommentedKeyword:
   Enabled: true
 
+Style/ComparableBetween:
+  Enabled: true
+
 Style/ComparableClamp:
   Enabled: true
 
@@ -385,6 +397,9 @@ Style/DateTime:
 Style/DefWithParentheses:
   Enabled: true
 
+Style/DigChain:
+  Enabled: true
+
 Style/Dir:
   Enabled: true
 
@@ -467,6 +482,10 @@ Style/EmptyMethod:
     - compact
     - expanded
 
+Style/EmptyStringInsideInterpolation:
+  Enabled: true
+  EnforcedStyle: trailing_conditional
+
 Style/Encoding:
   Enabled: true
 
@@ -515,9 +534,15 @@ Style/FetchEnvVar:
 Style/FileEmpty:
   Enabled: true
 
+Style/FileNull:
+  Enabled: true
+
 Style/FileRead:
   Enabled: true
 
+Style/FileTouch:
+  Enabled: true
+
 Style/FileWrite:
   Enabled: true
 
@@ -614,12 +639,18 @@ Style/HashEachMethods:
 Style/HashExcept:
   Enabled: true
 
+Style/HashFetchChain:
+  Enabled: true
+
 Style/HashLikeCase:
   Enabled: true
   # `MinBranchesCount` defines the number of branches `case` needs to have
   # to trigger this cop
   MinBranchesCount: 3
 
+Style/HashSlice:
+  Enabled: true
+
 Style/HashSyntax:
   Enabled: true
   EnforcedStyle: ruby19_no_mixed_keys
@@ -745,6 +776,17 @@ Style/IpAddresses:
     - '**/Gemfile'
     - '**/gems.rb'
     - '**/*.gemspec'
+    - '**/rack_attack.rb'
+
+Style/ItAssignment:
+  Enabled: <%= ENV['RUBY_MAJOR'].to_f >= 3.4 %>
+
+Style/ItBlockParameter:
+  Enabled: true
+  EnforcedStyle: disallow
+
+Style/KeywordArgumentsMergin:
+  Enabled: true
 
 Style/KeywordParametersOrder:
   Enabled: true
@@ -1173,6 +1215,9 @@ Style/RedundantArgument:
 Style/RedundantArrayConstructor:
   Enabled: true
 
+Style/RedundantArrayFlatten:
+  Enabled: true
+
 Style/RedundantAssignment:
   Enabled: true
 
@@ -1216,6 +1261,9 @@ Style/RedundantFileExtensionInRequire:
 Style/RedundantFilterChain:
   Enabled: true
 
+Style/RedundantFormat:
+  Enabled: true
+
 Style/RedundantFreeze:
   Enabled: true
 
@@ -1229,6 +1277,9 @@ Style/RedundantInitialize:
 Style/RedundantInterpolation:
   Enabled: true
 
+Style/RedundantInterpolationUnfreeze:
+  Enabled: <%= ENV['RUBY_MAJOR'].to_i >= 3 %>
+
 Style/RedundantLineContinuation:
   Enabled: true
 
@@ -1328,6 +1379,9 @@ Style/SafeNavigation:
   # Maximum length of method chains for register an offense.
   MaxChainLength: 2
 
+Style/SafeNavigationChainLength:
+  Enabled: false
+
 Style/Sample:
   Enabled: true
 

data/config/thread_safety.yml

@@ -0,0 +1,27 @@
+plugins: rubocop-thread_safety
+
+ThreadSafety/ClassAndModuleAttributes:
+  Enabled: true
+
+ThreadSafety/ClassInstanceVariable:
+  Enabled: true
+
+ThreadSafety/DirChdir:
+  Enabled: true
+  AllowCallWithBlock: true
+
+ThreadSafety/MutableClassInstanceVariable:
+  Enabled: true
+  EnforcedStyle: strict
+
+ThreadSafety/NewThread:
+  Enabled: true
+
+ThreadSafety/RackMiddlewareInstanceVariable:
+  Enabled: true
+  Include:
+    - app/middleware/**/*.rb
+    - lib/middleware/**/*.rb
+    - app/middlewares/**/*.rb
+    - lib/middlewares/**/*.rb
+  AllowedIdentifiers: [ ]

data/lib/rubocop/rubomatic/version.rb

@@ -8,7 +8,7 @@ module RuboCop
       TINY = 0
 
       # Set PRE to nil unless it's a pre-release (beta, rc, etc.)
-      PRE = 'rc.pre.1'
+      PRE = 'rc.pre.3'
 
       STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.').freeze
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rubomatic
 version: !ruby/object:Gem::Version
-  version: 1.6.0.rc.pre.1
+  version: 1.6.0.rc.pre.3
 platform: ruby
 authors:
 - Brands Insurance
@@ -44,6 +44,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.76.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-packaging
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.6.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -58,6 +72,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.25.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-thread_safety
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.7.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.7.2
 description: 
 email:
 - documents@brandsinsurance.com
@@ -84,6 +112,7 @@ files:
 - config/rubomatic/style.yml
 - config/security.yml
 - config/style.yml
+- config/thread_safety.yml
 - docs/cops/layout/README.adoc
 - docs/cops/layout/multiline_array_line_breaks/README.adoc
 - docs/cops/style/README.adoc