rubocop-rubomatic 1.5.1 → 1.6.0.rc.pre.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4b4154f15fb2c0b9c3ba4355595acfc396b36ea0f5c38a0a5b9c12ac2e90f007
-  data.tar.gz: 696e99074ba2d5aaa15268b1d8b0289a88077da8682213cf81dc223b0ca9085e
+  metadata.gz: ac51c170c79e162bf18425f6d7f371fafc134e476bd4576ec7e2b82a40503dea
+  data.tar.gz: 894ca741d0e15316e9209b400bee9056d361ca35560e4382cf9cdf05073f9445
 SHA512:
-  metadata.gz: 2ac9540f544a3edce7fe69c18261750c790b6f53092e93e394d30804568fbdc7b7ce2daa620ab90bd754a28a6a286e2d83439b17f20911add43462f48b738ce2
-  data.tar.gz: 9957b2a2e5d726aa9672166146f11fd5bac5c705dd5e49e412cb63136def5bd74f8939f41e70880427282a7432f180acd911057d7065c23d0430a0f355d22757
+  metadata.gz: fe8074c3cd26574c5cd4114ea75d28a1fdc4a903635bc1f1429f4c7eff9df7099871466ed557730827233cf9fff887103ce04aaceccae9811141f9def2f075d3
+  data.tar.gz: 13b40864cb18e60caa068c751c93d3a8223814e8e6017042c0996d28f5eb40789bff55054aa334ddb09824b209fc6c6cae2b0c89f3726e88be7bd811354a925a

data/CHANGELOG.adoc

@@ -1,3 +1,57 @@
+== 1.6.0 (2025-06-12)
+
+* Upgrade to ``ruobcop 1.76.1``
+** This includes the change from ``require:`` to ``plugins:``.
+While ``require:`` will still work, there will be a deprecation warning
+** Set ``Layout/LeadingCommentSpace/AllowSteepAnnotation`` to ``false``
+** Enabled ``Lint/ArrayLiteralInRegexp``
+** Enabled ``Lint/ConstantReassignment``
+** Enabled ``Lint/CopDirectiveSyntax``
+** Enabled ``Lint/DuplicateSetElement``
+** Set ``Lint/DuplicateBranch/IgnoreDuplicateElseBranch`` to ``true``
+** Enabled ``Lint/HashNewWithKeywordArgumentsAsDefault``
+** Enabled ``Lint/NumericOperationWithConstantResult``
+** Enabled ``Lint/RedundantTypeConversion``
+** Enabled ``Lint/SharedMutableDefault``
+** Enabled ``Lint/SuppressedExceptionInNumberConversion``
+** Enabled ``Lint/UnescapedBracketInRegexp``
+** Enabled ``Lint/UselessConstantScoping``
+** Enabled ``Lint/UselessDefaultValueArgument``
+** Enabled ``Lint/UselessDefined``
+** Enabled ``Lint/UselessNumericOperation``
+** Enabled ``Lint/UselessOr``
+** Enabled ``Naming/PredicateMethod``
+** Enabled ``Style/AmbiguousEndlessMethodDefinition``
+** Enabled ``Style/BitwisePredicate``
+** Enabled ``Style/ComparableBetween``
+** Enabled ``Style/CombinableDefined``
+** Enabled ``Style/DigChain``
+** Enabled ``Style/EmptyStringInsideInterpolation``
+** Enabled ``Style/FileNull``
+** Enabled ``Style/FileTouch``
+** Enabled ``Style/HashFetchChain``
+** Enabled ``Style/HashSlice``
+** Enabled ``Style/ItAssignment``
+** Enabled ``Style/ItBlockParameter``
+** Enabled ``Style/KeywordArgumentsMergin``
+** Enabled ``Style/RedundantArrayFlatten``
+** Enabled ``Style/RedundantFormat``
+** Enabled ``Style/RedundantInterpolationUnfreeze``
+** Disabled ``Style/SafeNavigationChainLength``
+* Added ``rack_attack.rb`` to exclude list for ``Style/IpAddresses``
+* Upgraded to ``rubocop-performance 1.25.0``
+** Enabled ``Performance/StringBytesize``
+** Enabled ``Performance/ZipWithoutBlock``
+* Added ``rubocop-packaging 0.6.0``
+** Enabled ``Packaging/GemspecGit``
+* Added ``rubocop-thread_safety 0.7.2``
+** Enabled ``ThreadSafety/ClassAndModuleAttributes``
+** Enabled ``ThreadSafety/ClassInstanceVariable``
+** Enabled ``ThreadSafety/DirChdir``
+** Enabled ``ThreadSafety/MutableClassInstanceVariable``
+** Enabled ``ThreadSafety/NewThread``
+** Enabled ``ThreadSafety/RackMiddlewareInstanceVariable``
+
 == 1.5.1 (2024-10-22)
 
 === Misc

data/config/gemspec_on.yml

@@ -56,3 +56,11 @@ Gemspec/RubyVersionGlobalsUsage:
 
 Naming/FileName:
   Enabled: false
+
+plugins: rubocop-packaging
+
+Packaging:
+  Enabled: false
+
+Packaging/GemspecGit:
+  Enabled: true

data/config/layout.yml

@@ -526,6 +526,7 @@ Layout/LeadingCommentSpace:
   Enabled: true
   AllowDoxygenCommentStyle: false
   AllowGemfileRubyComment: false
+  AllowSteepAnnotation: false
 
 Layout/LeadingEmptyLines:
   Enabled: true

data/config/lint.yml

@@ -19,6 +19,9 @@ Lint/AmbiguousRange:
 Lint/AmbiguousRegexpLiteral:
   Enabled: true
 
+Lint/ArrayLiteralInRegexp:
+  Enabled: true
+
 Lint/AssignmentInCondition:
   Enabled: true
   AllowSafeAssignment: false
@@ -45,6 +48,9 @@ Lint/ConstantDefinitionInBlock:
 Lint/ConstantOverwrittenInRescue:
   Enabled: true
 
+Lint/ConstantReassignment:
+  Enabled: true
+
 Lint/ConstantResolution:
   Enabled: false
   # Restrict this cop to only looking at certain names
@@ -52,6 +58,9 @@ Lint/ConstantResolution:
   # Restrict this cop from only looking at certain names
   Ignore: [ ]
 
+Lint/CopDirectiveSyntax:
+  Enabled: true
+
 Lint/Debugger:
   Enabled: true
   DebuggerMethods:
@@ -139,6 +148,7 @@ Lint/DuplicateBranch:
   Enabled: true
   IgnoreLiteralBranches: true
   IgnoreConstantBranches: true
+  IgnoreDuplicateElseBranch: true
 
 Lint/DuplicateCaseCondition:
   Enabled: true
@@ -167,6 +177,9 @@ Lint/DuplicateRequire:
 Lint/DuplicateRescueException:
   Enabled: true
 
+Lint/DuplicateSetElement:
+  Enabled: true
+
 Lint/EachWithObjectArgument:
   Enabled: true
 
@@ -228,6 +241,9 @@ Lint/FormatParameterMismatch:
 Lint/HashCompareByIdentity:
   Enabled: true
 
+Lint/HashNewWithKeywordArgumentsAsDefault:
+  Enabled: true
+
 Lint/HeredocMethodCallPosition:
   Enabled: true
 
@@ -348,6 +364,9 @@ Lint/NumberConversion:
 Lint/NumberedParameterAssignment:
   Enabled: true
 
+Lint/NumericOperationWithConstantResult:
+  Enabled: true
+
 Lint/OrAssignmentToConstant:
   Enabled: true
 
@@ -407,6 +426,9 @@ Lint/RedundantSplatExpansion:
 Lint/RedundantStringCoercion:
   Enabled: true
 
+Lint/RedundantTypeConversion:
+  Enabled: true
+
 Lint/RedundantWithIndex:
   Enabled: true
 
@@ -478,6 +500,9 @@ Lint/ShadowedException:
 Lint/ShadowingOuterLocalVariable:
   Enabled: true
 
+Lint/SharedMutableDefault:
+  Enabled: true
+
 Lint/StructNewOverride:
   Enabled: true
 
@@ -486,6 +511,9 @@ Lint/SuppressedException:
   AllowComments: true
   AllowNil: true
 
+Lint/SuppressedExceptionInNumberConversion:
+  Enabled: true
+
 Lint/SymbolConversion:
   Enabled: true
   EnforcedStyle: consistent
@@ -515,6 +543,9 @@ Lint/UnderscorePrefixedVariableName:
   Enabled: true
   AllowKeywordBlockArguments: false
 
+Lint/UnescapedBracketInRegexp:
+  Enabled: true
+
 Lint/UnexpectedBlockArity:
   Enabled: true
   Methods:
@@ -570,12 +601,29 @@ Lint/UselessAccessModifier:
 Lint/UselessAssignment:
   Enabled: true
 
+Lint/UselessConstantScoping:
+  Enabled: true
+
+Lint/UselessDefaultValueArgument:
+  Enabled: true
+  AllowedReceivers:
+    - 'Rails.cache'
+
+Lint/UselessDefined:
+  Enabled: true
+
 Lint/UselessElseWithoutRescue:
   Enabled: true
 
 Lint/UselessMethodDefinition:
   Enabled: true
 
+Lint/UselessNumericOperation:
+  Enabled: true
+
+Lint/UselessOr:
+  Enabled: true
+
 Lint/UselessRescue:
   Enabled: true
 

data/config/naming.yml

@@ -191,7 +191,11 @@ Naming/MethodParameterName:
   # Forbidden names that will register an offense
   ForbiddenNames: [ ]
 
-Naming/PredicateName:
+Naming/PredicateMethod:
+  Enabled: true
+  Mode: aggresive
+
+Naming/PredicatePrefix:
   Enabled: true
   # Predicate name prefixes.
   NamePrefix:

data/config/performance.yml

@@ -1,4 +1,4 @@
-require: rubocop-performance
+plugins: rubocop-performance
 
 Performance:
   Enabled: false
@@ -119,6 +119,9 @@ Performance/StartWith:
   Enabled: true
   SafeMultiline: false
 
+Performance/StringBytesize:
+  Enabled: true
+
 Performance/StringIdentifierArgument:
   Enabled: true
 
@@ -134,3 +137,6 @@ Performance/Sum:
 
 Performance/TimesMap:
   Enabled: true
+
+Performance/ZipWithoutBlock:
+  Enabled: true

data/config/rubocop.yml

@@ -11,6 +11,7 @@ inherit_from:
   - ./performance.yml
   - ./security.yml
   - ./style.yml
+  - ./thread_safety.yml
 
 inherit_mode:
   merge:

data/config/rubomatic/rubocop.yml

@@ -1,4 +1,4 @@
-require: rubocop-rubomatic
+plugins: rubocop-rubomatic
 
 inherit_from:
   - ./layout.yml

data/config/style.yml

@@ -23,6 +23,9 @@ Style/Alias:
     - prefer_alias
     - prefer_alias_method
 
+Style/AmbiguousEndlessMethodDefinition:
+  Enabled: true
+
 Style/AndOr:
   Enabled: true
   # Whether `and` and `or` are banned only in conditionals (conditionals)
@@ -75,6 +78,9 @@ Style/BeginBlock:
 Style/BisectedAttrAccessor:
   Enabled: true
 
+Style/BitwisePredicate:
+  Enabled: true
+
 Style/BlockComments:
   Enabled: true
 
@@ -295,6 +301,9 @@ Style/ColonMethodCall:
 Style/ColonMethodDefinition:
   Enabled: true
 
+Style/CombinableDefined:
+  Enabled: true
+
 Style/CombinableLoops:
   Enabled: true
 
@@ -327,6 +336,9 @@ Style/CommentAnnotation:
 Style/CommentedKeyword:
   Enabled: true
 
+Style/ComparableBetween:
+  Enabled: true
+
 Style/ComparableClamp:
   Enabled: true
 
@@ -385,6 +397,9 @@ Style/DateTime:
 Style/DefWithParentheses:
   Enabled: true
 
+Style/DigChain:
+  Enabled: true
+
 Style/Dir:
   Enabled: true
 
@@ -467,6 +482,10 @@ Style/EmptyMethod:
     - compact
     - expanded
 
+Style/EmptyStringInsideInterpolation:
+  Enabled: true
+  EnforcedStyle: trailing_conditional
+
 Style/Encoding:
   Enabled: true
 
@@ -515,9 +534,15 @@ Style/FetchEnvVar:
 Style/FileEmpty:
   Enabled: true
 
+Style/FileNull:
+  Enabled: true
+
 Style/FileRead:
   Enabled: true
 
+Style/FileTouch:
+  Enabled: true
+
 Style/FileWrite:
   Enabled: true
 
@@ -614,12 +639,18 @@ Style/HashEachMethods:
 Style/HashExcept:
   Enabled: true
 
+Style/HashFetchChain:
+  Enabled: true
+
 Style/HashLikeCase:
   Enabled: true
   # `MinBranchesCount` defines the number of branches `case` needs to have
   # to trigger this cop
   MinBranchesCount: 3
 
+Style/HashSlice:
+  Enabled: true
+
 Style/HashSyntax:
   Enabled: true
   EnforcedStyle: ruby19_no_mixed_keys
@@ -745,6 +776,17 @@ Style/IpAddresses:
     - '**/Gemfile'
     - '**/gems.rb'
     - '**/*.gemspec'
+    - '**/rack_attack.rb'
+
+Style/ItAssignment:
+  Enabled: <%= ENV['RUBY_MAJOR'].to_f >= 3.4 %>
+
+Style/ItBlockParameter:
+  Enabled: true
+  EnforcedStyle: disallow
+
+Style/KeywordArgumentsMergin:
+  Enabled: true
 
 Style/KeywordParametersOrder:
   Enabled: true
@@ -1173,6 +1215,9 @@ Style/RedundantArgument:
 Style/RedundantArrayConstructor:
   Enabled: true
 
+Style/RedundantArrayFlatten:
+  Enabled: true
+
 Style/RedundantAssignment:
   Enabled: true
 
@@ -1216,6 +1261,9 @@ Style/RedundantFileExtensionInRequire:
 Style/RedundantFilterChain:
   Enabled: true
 
+Style/RedundantFormat:
+  Enabled: true
+
 Style/RedundantFreeze:
   Enabled: true
 
@@ -1229,6 +1277,9 @@ Style/RedundantInitialize:
 Style/RedundantInterpolation:
   Enabled: true
 
+Style/RedundantInterpolationUnfreeze:
+  Enabled: <%= ENV['RUBY_MAJOR'].to_i >= 3 %
+
 Style/RedundantLineContinuation:
   Enabled: true
 
@@ -1328,6 +1379,9 @@ Style/SafeNavigation:
   # Maximum length of method chains for register an offense.
   MaxChainLength: 2
 
+Style/SafeNavigationChainLength:
+  Enabled: false
+
 Style/Sample:
   Enabled: true
 

data/config/thread_safety.yml

@@ -0,0 +1,27 @@
+plugins: rubocop-thread_safety
+
+ThreadSafety/ClassAndModuleAttributes:
+  Enabled: true
+
+ThreadSafety/ClassInstanceVariable:
+  Enabled: true
+
+ThreadSafety/DirChdir:
+  Enabled: true
+  AllowCallWithBlock: true
+
+ThreadSafety/MutableClassInstanceVariable:
+  Enabled: true
+  EnforcedStyle: strict
+
+ThreadSafety/NewThread:
+  Enabled: true
+
+ThreadSafety/RackMiddlewareInstanceVariable:
+  Enabled: true
+  Include:
+    - app/middleware/**/*.rb
+    - lib/middleware/**/*.rb
+    - app/middlewares/**/*.rb
+    - lib/middlewares/**/*.rb
+  AllowedIdentifiers: [ ]

data/lib/rubocop/rubomatic/plugin.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require 'lint_roller'
+
+module RuboCop
+  module Rubomatic
+    # A plugin that integrates RuboCop Performance with RuboCop's plugin system.
+    class Plugin < LintRoller::Plugin
+      # :nodoc:
+      def about
+        LintRoller::About.new(
+          name: 'rubocop-rubomatic',
+          version: VERSION.to_s,
+          homepage: 'https://github.com/BrandsInsurance/rubocop-rubomatic/',
+          description: 'A collection of RuboCop cops to check for performance optimizations in Ruby code.'
+        )
+      end
+
+      # :nodoc:
+      def supported?(context)
+        context.engine == :rubocop
+      end
+
+      # :nodoc:
+      def rules(_context)
+        LintRoller::Rules.new(
+          type: :path,
+          config_format: :rubocop,
+          value: Pathname.new(__dir__).join('../../../config/default.yml')
+        )
+      end
+    end
+  end
+end

data/lib/rubocop/rubomatic/version.rb

@@ -2,6 +2,20 @@
 
 module RuboCop
   module Rubomatic
-    VERSION = '1.5.1'
+    module VERSION
+      MAJOR = 1
+      MINOR = 6
+      TINY = 0
+
+      # Set PRE to nil unless it's a pre-release (beta, rc, etc.)
+      PRE = 'rc.pre.2'
+
+      STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.').freeze
+
+      # @return [String]
+      def self.to_s
+        STRING
+      end
+    end
   end
 end

data/lib/rubocop-rubomatic.rb

@@ -4,9 +4,7 @@ require 'rubocop'
 
 require_relative 'rubocop/cop/rubomatic/generator'
 require_relative 'rubocop/rubomatic'
-require_relative 'rubocop/rubomatic/inject'
+require_relative 'rubocop/rubomatic/plugin'
 require_relative 'rubocop/rubomatic/version'
 
-RuboCop::Rubomatic::Inject.defaults!
-
 require_relative 'rubocop/cop/rubomatic_cops'

metadata

@@ -1,55 +1,91 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rubomatic
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.6.0.rc.pre.2
 platform: ruby
 authors:
 - Brands Insurance
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-10-22 00:00:00.000000000 Z
+date: 2025-06-12 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: lint_roller
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.65.0
+        version: 1.76.0
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.65.1
+        version: 1.76.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.65.0
+        version: 1.76.0
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.65.1
+        version: 1.76.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-packaging
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.6.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.22.0
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.22.1
+        version: 1.25.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.22.0
-    - - ">="
+        version: 1.25.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-thread_safety
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.7.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.22.1
+        version: 0.7.2
 description: 
 email:
 - documents@brandsinsurance.com
@@ -76,6 +112,7 @@ files:
 - config/rubomatic/style.yml
 - config/security.yml
 - config/style.yml
+- config/thread_safety.yml
 - docs/cops/layout/README.adoc
 - docs/cops/layout/multiline_array_line_breaks/README.adoc
 - docs/cops/style/README.adoc
@@ -88,12 +125,13 @@ files:
 - lib/rubocop/cop/rubomatic/style/disallowed_methods.rb
 - lib/rubocop/cop/rubomatic_cops.rb
 - lib/rubocop/rubomatic.rb
-- lib/rubocop/rubomatic/inject.rb
+- lib/rubocop/rubomatic/plugin.rb
 - lib/rubocop/rubomatic/version.rb
 homepage: https://github.com/BrandsInsurance/rubocop-rubomatic/
 licenses:
 - MIT
 metadata:
+  default_lint_roller_plugin: RuboCop::Rubomatic::Plugin
   rubygems_mfa_required: 'true'
   homepage_uri: https://github.com/BrandsInsurance/rubocop-rubomatic/
   source_code_uri: https://github.com/BrandsInsurance/rubocop-rubomatic/tree/main
@@ -109,9 +147,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 3.0.1
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.2.15
 signing_key: 

data/lib/rubocop/rubomatic/inject.rb

@@ -1,21 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Rubomatic
-    module Inject
-      # This was a generated method from https://github.com/rubocop/rubocop-extension-generator
-      #
-      def self.defaults!
-        path = CONFIG_DEFAULT.to_s
-        hash = ConfigLoader.__send__(:load_yaml_configuration, path)
-        config = Config.new(hash, path).tap(&:make_excludes_absolute)
-
-        puts("configuration from #{path}") if ConfigLoader.debug?
-
-        config = ConfigLoader.merge_with_default(config, path)
-
-        ConfigLoader.instance_variable_set(:@default_configuration, config)
-      end
-    end
-  end
-end