rubocop-rubomatic-rails 1.5.0 → 1.6.0.rc.pre.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6c6b2774e2c0c9c9138db48d7035b19ec507f7964099d72eed02a5738fc8bc23
-  data.tar.gz: e177210a10c03fd02b3adfcd916385519a016aa8ac8f497f4867ce12ee1c3cdd
+  metadata.gz: 7fcb51a26550c302447f465a8393c373ff54c2ba4bbe380e156e311379e9d1e7
+  data.tar.gz: '00581c764412c2c596685853b96f82473cf7665f2fec887b744aa0591b5d4ca9'
 SHA512:
-  metadata.gz: e4f8eee96ba8d6887e82a0efc97e2c391d0e002481c452b0d2a2c957fd74cc141c79ea8acec8173b26e095f6a7cb0c12ad866d8591612100c33fe5bbd33e2ac0
-  data.tar.gz: 91b49d8479276cf07590936663c9d4a270ef87b0f6597d8aaa059dce3f34f83e0957f5930697a2c93cc6348d749d366d8d7d2fd6b23668c7ca3b31cea1ebb148
+  metadata.gz: 1d7e9af433910670a30fa46c90a57777d151aac4663c92cc9ea50b717b9569a9527550229b041e8c6b1cea6de6665a2474dc9f84668d1757c0c990f792e141f9
+  data.tar.gz: aefce1c2c725002a602f001a97b24ebcc578ca5d463751bbbbed667f5f637a7b9a881cd0147a15f6f5b612507bf52e1e764218c5a2cb9ac2ed750537804f9562

data/CHANGELOG.adoc

@@ -1,3 +1,20 @@
+== 1.6.0 (2025-06-12)
+
+* Upgrade to ``ruobcop-rubomatic 1.6.0``
+** This includes the change from ``require:`` to ``plugins:``.
+While ``require:`` will still work, there will be a deprecation warning
+* Upgrade to ``rubocop-rails 2.32.0``
+** Enabled ``Rails/MultipleRoutePaths``
+** Enabled ``Rails/StrongParametersExpect`` (Only in ``Rails 8+``)
+* Added ``rubocop-rspec_rails 2.31.0``
+** Enabled ``RSpecRails/AvoidSetupHook``
+** Enabled ``RSpecRails/HaveHttpStatus``
+** Enabled ``RSpecRails/HttpStatus``
+** Enabled ``RSpecRails/InferredSpecType``
+** Enabled ``RSpecRails/MinitestAssertions``
+** Enabled ``RSpecRails/NegationBeValid``
+** Enabled ``RSpecRails/TravelAround``
+
 == 1.5.0 (2024-10-23)
 
 === Cops

data/config/rails.yml

@@ -1,4 +1,4 @@
-require: rubocop-rails
+plugins: rubocop-rails
 
 Rails/ActionControllerFlashBeforeRender:
   Enabled: true
@@ -351,6 +351,13 @@ Rails/MigrationClassName:
   Include:
     - db/migrate/*.rb
 
+Rails/MultipleRoutePaths:
+  Enabled: true
+  Severity: error
+  Include:
+    - '**/config/routes.rb'
+    - '**/config/routes/**/*.rb'
+
 Rails/NegateInclude:
   Enabled: true
 
@@ -573,6 +580,11 @@ Rails/SquishedSQLHeredocs:
 Rails/StripHeredoc:
   Enabled: true
 
+Rails/StrongParametersExpect:
+  Enabled: <%= `rails -v`.split(' ').last.to_i >= 8 %>
+  Include:
+    - '**/app/controllers/**/*.rb'
+
 Rails/TableNameAssignment:
   Enabled: true
   Include:

data/config/rspec_rails.yml

@@ -0,0 +1,43 @@
+plugins: rubocop-rspec_rails
+
+RSpecRails/AvoidSetupHook:
+  Enabled: true
+
+RSpecRails/HaveHttpStatus:
+  Enabled: true
+  ResponseMethods:
+    - response
+    - last_response
+
+RSpecRails/HttpStatus:
+  Enabled: true
+  EnforcedStyle: symbolic
+
+RSpecRails/InferredSpecType:
+  Enabled: true
+  Inferences:
+    channels: channel
+    controllers: controller
+    features: feature
+    generator: generator
+    helpers: helper
+    jobs: job
+    mailboxes: mailbox
+    mailers: mailer
+    models: model
+    requests: request
+    integration: request
+    api: request
+    routing: routing
+    system: system
+    views: view
+
+RSpecRails/MinitestAssertions:
+  Enabled: true
+
+RSpecRails/NegationBeValid:
+  Enabled: true
+  EnforcedStyle: be_invalid
+
+RSpecRails/TravelAround:
+  Enabled: true

data/config/rubocop.yml

@@ -1,5 +1,6 @@
 inherit_from:
   - ./rails.yml
+  - ./rspec_rails.yml
 
 inherit_gem:
   rubocop-rubomatic: config/rubocop.yml
@@ -23,6 +24,7 @@ AllCops:
     - '.irbrc'
     - 'db/schema.rb'
   TargetRubyVersion: <%= ENV['RUBY_MAJOR'] %>
+  TargetRailsVersion: <%= `rails -v`.split(' ').last.to_f %>
   SuggestExtensions: false
   StyleGuideBaseURL: https://github.com/BrandsInsurance/expert-chainsaw/blob/main/ruby/RUBY_STYLE_GUIDE.adoc
   ActiveSupportExtensionsEnabled: true

data/lib/rubocop/cop/rubomatic-rails/generator/cop_readme_injector.rb

@@ -10,7 +10,7 @@ module RuboCop
 
           # :nodoc:
           def initialize(badge:, **kwargs)
-            super(badge: badge, **kwargs)
+            super
 
             @cop = badge.cop_name
           end

data/lib/rubocop/rubomatic-rails/plugin.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require 'lint_roller'
+
+module RuboCop
+  module RubomaticRails
+    # A plugin that integrates RuboCop Performance with RuboCop's plugin system.
+    class Plugin < LintRoller::Plugin
+      # :nodoc:
+      def about
+        LintRoller::About.new(
+          name: 'rubocop-rubomatic-rails',
+          version: VERSION::STRING,
+          homepage: 'https://github.com/BrandsInsurance/rubocop-rubomatic-rails',
+          description: 'A collection of RuboCop cops to check for performance optimizations in Ruby code.'
+        )
+      end
+
+      # :nodoc:
+      def supported?(context)
+        context.engine == :rubocop
+      end
+
+      # :nodoc:
+      def rules(_context)
+        LintRoller::Rules.new(
+          type: :path,
+          config_format: :rubocop,
+          value: Pathname.new(__dir__).join('../../../config/default.yml')
+        )
+      end
+    end
+  end
+end

data/lib/rubocop/rubomatic-rails/version.rb

@@ -2,6 +2,20 @@
 
 module RuboCop
   module RubomaticRails
-    VERSION = '1.5.0'
+    module VERSION
+      MAJOR = 1
+      MINOR = 6
+      TINY = 0
+
+      # Set PRE to nil unless it's a pre-release (beta, rc, etc.)
+      PRE = 'rc.pre.2'
+
+      STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.').freeze
+
+      # @return [String]
+      def self.to_s
+        STRING
+      end
+    end
   end
 end

data/lib/rubocop-rubomatic-rails.rb

@@ -4,9 +4,7 @@ require 'rubocop'
 
 require_relative 'rubocop/cop/rubomatic-rails/generator'
 require_relative 'rubocop/rubomatic-rails'
-require_relative 'rubocop/rubomatic-rails/inject'
+require_relative 'rubocop/rubomatic-rails/plugin'
 require_relative 'rubocop/rubomatic-rails/version'
 
-RuboCop::RubomaticRails::Inject.defaults!
-
 require_relative 'rubocop/cop/rubomatic_rails_cops'

metadata

@@ -1,43 +1,71 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rubomatic-rails
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.6.0.rc.pre.2
 platform: ruby
 authors:
 - Brands Insurance
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-10-23 00:00:00.000000000 Z
+date: 2025-06-12 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: lint_roller
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.26.2
+        version: 2.32.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.26.2
+        version: 2.32.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec_rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.31.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.31.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rubomatic
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 1.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 1.6.0
 description: 
 email:
 - documents@brandsinsurance.com
@@ -50,6 +78,7 @@ files:
 - README.adoc
 - config/default.yml
 - config/rails.yml
+- config/rspec_rails.yml
 - config/rubocop.yml
 - lib/rubocop-rubomatic-rails.rb
 - lib/rubocop/cop/rubomatic-rails/generator.rb
@@ -57,12 +86,13 @@ files:
 - lib/rubocop/cop/rubomatic-rails/generator/dept_readme_injector.rb
 - lib/rubocop/cop/rubomatic_rails_cops.rb
 - lib/rubocop/rubomatic-rails.rb
-- lib/rubocop/rubomatic-rails/inject.rb
+- lib/rubocop/rubomatic-rails/plugin.rb
 - lib/rubocop/rubomatic-rails/version.rb
 homepage: https://github.com/BrandsInsurance/rubocop-rubomatic-rails
 licenses:
 - MIT
 metadata:
+  default_lint_roller_plugin: RuboCop::RubomaticRails::Plugin
   rubygems_mfa_required: 'true'
   homepage_uri: https://github.com/BrandsInsurance/rubocop-rubomatic-rails
   source_code_uri: https://github.com/BrandsInsurance/rubocop-rubomatic-rails
@@ -78,9 +108,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 3.0.1
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.2.15
 signing_key: 

data/lib/rubocop/rubomatic-rails/inject.rb

@@ -1,21 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module RubomaticRails
-    module Inject
-      # This was a generated method from https://github.com/rubocop/rubocop-extension-generator
-      #
-      def self.defaults!
-        path = CONFIG_DEFAULT.to_s
-        hash = ConfigLoader.__send__(:load_yaml_configuration, path)
-        config = Config.new(hash, path).tap(&:make_excludes_absolute)
-
-        puts("configuration from #{path}") if ConfigLoader.debug?
-
-        config = ConfigLoader.merge_with_default(config, path)
-
-        ConfigLoader.instance_variable_set(:@default_configuration, config)
-      end
-    end
-  end
-end