rubocop-rspec_rails 2.28.1 → 2.28.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 587b169f8af3fab4b25bd367cfc9fe3deffcbee837ca9c49fa6742795f19ef48
-  data.tar.gz: 3b6e3fe95ea4d76bb08528e1fe28bded0436fe1b1173e635bc36c0c5b33abbd0
+  metadata.gz: bb6fd80f5adfc6edb60fb77ecfa69b4aeba6b7a1011d30c70a1e6fee6bb2d417
+  data.tar.gz: 6cc5cd4b185823f7fa4f114f3d4b911789d997774c40207132d4ba1d6ab7ce01
 SHA512:
-  metadata.gz: 932cdb891ef272752fb4bf842eb5f03e9a23e2cf314a0d30024c41ec9de6781cd412699dd6afbf7c514e55f8f47571e58c5ce5f3d4e2f424e15a928e55af77a2
-  data.tar.gz: 6dce99442ffcbbd9c83eb0ad6650e1427be723d32213c1945e86231ac79b1ad5a63e3b373b31f0e20604ff26860a2342305bf499532f82df6d0822b28a8e1dbc
+  metadata.gz: 30246a5475ac1ebf858bf1f0765c01a5e6d740fd70fe23b09f5c45ab87dfe673d2983a8826569d0cc9dc678e4be1e52ac2da704cd4f6e950689e862aa6862e5b
+  data.tar.gz: 1ba553cf7599cb25c86435f2d50fdb2d005703d855e568fc4fb3b9ef843679ef5f7477a95d37b96573884958a0a2196c36b97b317c8faec96f9db4a0e313abf5

data/CHANGELOG.md

@@ -2,6 +2,16 @@
 
 ## Master (Unreleased)
 
+## 2.28.3 (2024-04-11)
+
+- Fix an error for Ambiguous cop name `RSpec/Rails/HttpStatus`. ([@ydah])
+
+## 2.28.2 (2024-03-31)
+
+- Fix a `NameError` by Cross-Referencing. ([@ydah])
+- Fix an error for `RSpecRails/HttpStatus` when no rack gem is loaded with rubocop-rspec. ([@ydah])
+- Fix an error for unrecognized cop or department `RSpecRails/HttpStatus` when also using rubocop-rails. ([@ydah])
+
 ## 2.28.1 (2024-03-29)
 
 - Implicit dependency on RuboCop RSpec. Note that if you use rubocop-rspec_rails, you must also explicitly add rubocop-rspec to the Gemfile, because you are changing to an implicit dependency on RuboCop RSpec. ([@ydah])

data/lib/rubocop/cop/rspec_rails/avoid_setup_hook.rb

@@ -16,7 +16,7 @@ module RuboCop
       #     allow(foo).to receive(:bar)
       #   end
       #
-      class AvoidSetupHook < ::RuboCop::Cop::RSpec::Base
+      class AvoidSetupHook < ::RuboCop::Cop::Base
         extend AutoCorrector
 
         MSG = 'Use `before` instead of `setup`.'

data/lib/rubocop/cop/rspec_rails/http_status.rb

@@ -1,6 +1,10 @@
 # frozen_string_literal: true
 
-require 'rack/utils'
+begin
+  require 'rack/utils'
+rescue LoadError
+  # RSpecRails/HttpStatus cannot be loaded if rack/utils is unavailable.
+end
 
 module RuboCop
   module Cop
@@ -53,7 +57,7 @@ module RuboCop
       #   it { is_expected.to have_http_status :success }
       #   it { is_expected.to have_http_status :error }
       #
-      class HttpStatus < ::RuboCop::Cop::RSpec::Base
+      class HttpStatus < ::RuboCop::Cop::Base
         extend AutoCorrector
         include ConfigurableEnforcedStyle
         RESTRICT_ON_SEND = %i[have_http_status].freeze
@@ -64,6 +68,8 @@ module RuboCop
         PATTERN
 
         def on_send(node)
+          return unless defined?(::Rack::Utils::SYMBOL_TO_STATUS_CODE)
+
           http_status(node) do |arg|
             return if arg.str_type? && arg.heredoc?
 

data/lib/rubocop/cop/rspec_rails/minitest_assertions.rb

@@ -29,7 +29,7 @@ module RuboCop
       #   expect(a).to be(true)
       #   expect(a).to be(false)
       #
-      class MinitestAssertions < ::RuboCop::Cop::RSpec::Base
+      class MinitestAssertions < ::RuboCop::Cop::Base
         extend AutoCorrector
 
         # :nodoc:

data/lib/rubocop/cop/rspec_rails/negation_be_valid.rb

@@ -29,7 +29,7 @@ module RuboCop
       #   # good (with method chain)
       #   expect(foo).to be_invalid.or be_even
       #
-      class NegationBeValid < ::RuboCop::Cop::RSpec::Base
+      class NegationBeValid < ::RuboCop::Cop::Base
         extend AutoCorrector
         include ConfigurableEnforcedStyle
 

data/lib/rubocop/cop/rspec_rails/travel_around.rb

@@ -23,7 +23,7 @@ module RuboCop
       #
       #   # good
       #   before { freeze_time }
-      class TravelAround < ::RuboCop::Cop::RSpec::Base
+      class TravelAround < ::RuboCop::Cop::Base
         extend AutoCorrector
 
         MSG = 'Prefer to travel in `before` rather than `around`.'

data/lib/rubocop/cop/rspec_rails_cops.rb

@@ -2,12 +2,8 @@
 
 require_relative 'rspec_rails/avoid_setup_hook'
 require_relative 'rspec_rails/have_http_status'
-require_relative 'rspec_rails/negation_be_valid'
-begin
-  require_relative 'rspec_rails/http_status'
-rescue LoadError
-  # RSpecRails/HttpStatus cannot be loaded if rack/utils is unavailable.
-end
+require_relative 'rspec_rails/http_status'
 require_relative 'rspec_rails/inferred_spec_type'
 require_relative 'rspec_rails/minitest_assertions'
+require_relative 'rspec_rails/negation_be_valid'
 require_relative 'rspec_rails/travel_around'

data/lib/rubocop/rspec_rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpecRails
     # Version information for the RSpec Rails RuboCop plugin.
     module Version
-      STRING = '2.28.1'
+      STRING = '2.28.3'
     end
   end
 end

data/lib/rubocop-rspec_rails.rb

@@ -4,11 +4,32 @@ require 'pathname'
 require 'yaml'
 
 require 'rubocop'
-require 'rubocop-rspec'
+
+require 'rubocop/rspec/language/node_pattern'
+
+require 'rubocop/rspec/language'
 
 require_relative 'rubocop/rspec_rails/version'
 
+require 'rubocop/cop/rspec/base'
 require_relative 'rubocop/cop/rspec_rails_cops'
 
 project_root = File.join(__dir__, '..')
 RuboCop::ConfigLoader.inject_defaults!(project_root)
+
+# FIXME: This is a workaround for the following issue:
+# https://github.com/rubocop/rubocop-rspec_rails/issues/8
+module RuboCop
+  module Cop
+    class Registry # rubocop:disable Style/Documentation
+      prepend(Module.new do
+        def qualified_cop_name(name, path, warn: true)
+          return super unless name == 'RSpec/Rails/HttpStatus'
+
+          badge = Badge.parse(name)
+          resolve_badge(badge, qualify_badge(badge).first, path)
+        end
+      end)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec_rails
 version: !ruby/object:Gem::Version
-  version: 2.28.1
+  version: 2.28.3
 platform: ruby
 authors:
 - Benjamin Quorning
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-28 00:00:00.000000000 Z
+date: 2024-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -76,7 +76,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.7
+rubygems_version: 3.5.3
 signing_key:
 specification_version: 4
 summary: Code style checking for RSpec Rails files