rubocop-rspec_rails 2.28.0 → 2.28.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53524a3483350f80d17572e3e221a777dabb1421999fbbcb37ad30cb182358b1
-  data.tar.gz: af8ff0697f66b78c197fc34e8dbd207e75a64473075ccb1b65d00650582d80d5
+  metadata.gz: 8d6875c71432f95fd0af755bec47d07f7e4bab2dfb5a5e900452c937701b7238
+  data.tar.gz: 6aea2975dd7cd16af9dc1e8016a3a541c918b27464e883cbcfc102de0a968b5c
 SHA512:
-  metadata.gz: 6b42314769301898bd8723c2c8d5e29eee29cb1952b70e3e4abb892f75e8a13c2129933a3a99de8247510030f208925ab70c5a0a1f1ebaf950595a5c7d540152
-  data.tar.gz: 9ad058ef82208bb685249e7ed847da8fc4b06b6718033d9153adc6544d28845e91454524531a72f67f25497325876ed140d543e7173b839f72d12044ef37c429
+  metadata.gz: 2e579a37fd41b132dc1af257d7b2235aba4e4be5d5a4ff0789a57d93ae4f499991e589acadbd4455ddb7d93423bb09ee07faac5127483a1dfe941a40829164f3
+  data.tar.gz: 3284eaf43b60448e2048db7374ccb97a54258a4c646fe951d4f9e57af453ff928bbe34719e9fb78d35d91d93c3aab3b5ccd77e2292b260a22277ea38af1aa484

data/CHANGELOG.md

@@ -2,6 +2,16 @@
 
 ## Master (Unreleased)
 
+## 2.28.2 (2024-03-31)
+
+- Fix a `NameError` by Cross-Referencing. ([@ydah])
+- Fix an error for `RSpecRails/HttpStatus` when no rack gem is loaded with rubocop-rspec. ([@ydah])
+- Fix an error for unrecognized cop or department `RSpecRails/HttpStatus` when also using rubocop-rails. ([@ydah])
+
+## 2.28.1 (2024-03-29)
+
+- Implicit dependency on RuboCop RSpec. Note that if you use rubocop-rspec_rails, you must also explicitly add rubocop-rspec to the Gemfile, because you are changing to an implicit dependency on RuboCop RSpec. ([@ydah])
+
 ## 2.28.0 (2024-03-28)
 
 - Extracted from `rubocop-rspec` into a separate repository. ([@ydah])

data/README.md

@@ -9,15 +9,17 @@
 
 ## Installation
 
-Just install the `rubocop-rspec_rails` gem
+**This gem implicitly depends on the `rubocop-rspec` gem, so you should install it first.**
+Just install the `rubocop-rspec` and `rubocop-rspec_rails` gem
 
 ```bash
-gem install rubocop-rspec_rails
+gem install rubocop-rspec rubocop-rspec_rails
 ```
 
 or if you use bundler put this in your `Gemfile`
 
 ```ruby
+gem 'rubocop-rspec', require: false
 gem 'rubocop-rspec_rails', require: false
 ```
 

data/lib/rubocop/cop/rspec_rails/http_status.rb

@@ -1,6 +1,10 @@
 # frozen_string_literal: true
 
-require 'rack/utils'
+begin
+  require 'rack/utils'
+rescue LoadError
+  # RSpecRails/HttpStatus cannot be loaded if rack/utils is unavailable.
+end
 
 module RuboCop
   module Cop
@@ -64,6 +68,8 @@ module RuboCop
         PATTERN
 
         def on_send(node)
+          return unless defined?(::Rack::Utils::SYMBOL_TO_STATUS_CODE)
+
           http_status(node) do |arg|
             return if arg.str_type? && arg.heredoc?
 

data/lib/rubocop/cop/rspec_rails_cops.rb

@@ -2,12 +2,8 @@
 
 require_relative 'rspec_rails/avoid_setup_hook'
 require_relative 'rspec_rails/have_http_status'
-require_relative 'rspec_rails/negation_be_valid'
-begin
-  require_relative 'rspec_rails/http_status'
-rescue LoadError
-  # RSpecRails/HttpStatus cannot be loaded if rack/utils is unavailable.
-end
+require_relative 'rspec_rails/http_status'
 require_relative 'rspec_rails/inferred_spec_type'
 require_relative 'rspec_rails/minitest_assertions'
+require_relative 'rspec_rails/negation_be_valid'
 require_relative 'rspec_rails/travel_around'

data/lib/rubocop/rspec_rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpecRails
     # Version information for the RSpec Rails RuboCop plugin.
     module Version
-      STRING = '2.28.0'
+      STRING = '2.28.2'
     end
   end
 end

data/lib/rubocop-rspec_rails.rb

@@ -4,11 +4,32 @@ require 'pathname'
 require 'yaml'
 
 require 'rubocop'
-require 'rubocop-rspec'
+
+require 'rubocop/rspec/language/node_pattern'
+
+require 'rubocop/rspec/language'
 
 require_relative 'rubocop/rspec_rails/version'
 
+require 'rubocop/cop/rspec/base'
 require_relative 'rubocop/cop/rspec_rails_cops'
 
 project_root = File.join(__dir__, '..')
 RuboCop::ConfigLoader.inject_defaults!(project_root)
+
+# FIXME: This is a workaround for the following issue:
+# https://github.com/rubocop/rubocop-rspec_rails/issues/8
+module RuboCop
+  module Cop
+    class AmbiguousCopName # rubocop:disable Style/Documentation
+      prepend(Module.new do
+        def qualified_cop_name(name, path, warn: true)
+          return super unless name == 'RSpec/Rails/HttpStatus'
+
+          badge = Badge.parse(name)
+          resolve_badge(badge, qualify_badge(badge).first, path)
+        end
+      end)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec_rails
 version: !ruby/object:Gem::Version
-  version: 2.28.0
+  version: 2.28.2
 platform: ruby
 authors:
 - Benjamin Quorning
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-28 00:00:00.000000000 Z
+date: 2024-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -27,20 +27,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.40'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.27'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.27'
 description: |
   Code style checking for RSpec Rails files.
   A plugin for the RuboCop code style enforcing & linting tool.
@@ -90,7 +76,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.3
+rubygems_version: 3.5.7
 signing_key:
 specification_version: 4
 summary: Code style checking for RSpec Rails files