rubocop-rspec_parity 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c258389ca56666df76d2865c8fee4ecca3dec132d02b7295d6e245747dbc4896
-  data.tar.gz: 02612dbd491de04d9819742f61bcdb47933837a6b3211d9888765e9eea94ef36
+  metadata.gz: 888fb83446806d8a28fecfc45aaeef7c72183e95214cc9e12b63d3f98e0c746a
+  data.tar.gz: 56d460393929a8ca3e990cef75441f49fa0be2cf0c814e151ab911b0392e2162
 SHA512:
-  metadata.gz: 6fb8521af37136c1449fc5292fcc7658966f42f538197081d5a9ff53985dc4901c70e5e17c7a93c3204c8be0dc179c10c909ec2499ced966251d7ffc124e14e9
-  data.tar.gz: d18fc9c48f6063187c20472ada669bbf374192687dce5ae7e91d5bfceb2dc7b282340e623e72165363ad398d4e8cb43251dc8ef7820306cab73279ef71c92c41
+  metadata.gz: 4dbc71657523c23118ff2bd823991ceea9aa635b02f35e3da8324e3e0dafc851c263af485991e9897ebf4efbaffc15518099a1c6a2ed69c84b290968229e3d4a
+  data.tar.gz: ce9de4bb85bf234ea735755b65b28ba6021eb5fd99a054a483c18e4c82d67d37ab51454b77e7750a5aa15ba163eb62e243ac3478f7766ea0676ba7744e1b365d

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## [Unreleased]
 
+## [2.0.2] - 2026-06-18
+
+Fixed: `PublicMethodHasSpec` now treats a public class method and a public instance method that share a name (the service-object `def self.call` delegating to `def call`) as one logical method — a single `describe '.call'` or `describe '#call'` satisfies both instead of each requiring its own.
+Fixed: `PublicMethodHasSpec` offense message no longer repeats a describe alias (e.g. `describe '#call' or describe '.call' or describe '.call'`) when a configured alias collides with the flexible-prefix expansion.
+
 ## [2.0.1] - 2026-06-18
 
 Fixed: `PublicMethodHasSpec` relaxed validation for single-public-method classes (e.g. service objects) no longer passes when the spec's only method-style `describe`/`context` covers a different method — if a method describe is present it must describe the actual public method.

data/lib/rubocop/cop/rspec_parity/public_method_has_spec.rb

@@ -29,7 +29,7 @@ module RuboCop
           return if inside_inner_class?(node)
 
           instance_method = !inside_eigenclass?(node) && !inside_class_methods_block?(node)
-          flexible_prefix = instance_method && module_with_dual_access?(node)
+          flexible_prefix = (instance_method && module_with_dual_access?(node)) || dual_scope_method?(node)
           check_method_has_spec(node, instance_method: instance_method, flexible_prefix: flexible_prefix)
         end
 
@@ -38,7 +38,7 @@ module RuboCop
           return if EXCLUDED_HOOK_METHODS.include?(node.method_name.to_s)
           return if inside_inner_class?(node)
 
-          check_method_has_spec(node, instance_method: false)
+          check_method_has_spec(node, instance_method: false, flexible_prefix: dual_scope_method?(node))
         end
 
         private
@@ -151,6 +151,42 @@ module RuboCop
           node.each_ancestor.find { |n| n.class_type? || n.module_type? }
         end
 
+        # A class method and an instance method that share a name (the common
+        # service-object `def self.call` -> `new(...).call` plus the `def call`
+        # it delegates to) describe one logical operation. A single
+        # `describe '.call'` or `describe '#call'` should satisfy both, so we
+        # check the method with a flexible `#`/`.` prefix.
+        def dual_scope_method?(node)
+          class_node = find_class_or_module(node)
+          return false unless class_node&.body
+
+          instance_names, class_names = scope_method_names(class_node)
+          name = node.method_name
+          instance_names.include?(name) && class_names.include?(name)
+        end
+
+        def scope_method_names(class_node)
+          instance = []
+          klass = []
+          scope_children(class_node).each { |child| classify_scope_method(child, instance, klass) }
+          [instance, klass]
+        end
+
+        def classify_scope_method(child, instance, klass)
+          case child&.type
+          when :def then instance << child.method_name
+          when :defs then klass << child.method_name if child.children.first&.self_type?
+          when :sclass then collect_eigenclass_method_names(child, klass)
+          end
+        end
+
+        def collect_eigenclass_method_names(node, klass)
+          return unless node.children.first&.self_type? && node.body
+
+          body_children = node.body.begin_type? ? node.body.children : [node.body]
+          body_children.each { |child| klass << child.method_name if child.def_type? }
+        end
+
         def targeted_visibility(scope, method_name)
           return nil unless scope.body
 
@@ -285,7 +321,7 @@ module RuboCop
               describes << "describe '#{alias_desc}'"
             end
           end
-          describes.join(" or ")
+          describes.uniq.join(" or ")
         end
 
         def prefixes_for(instance_method, flexible_prefix)

data/lib/rubocop/rspec_parity/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module RSpecParity
-    VERSION = "2.0.1"
+    VERSION = "2.0.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec_parity
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Povilas Jurcys