rubocop-rspec_parity 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2bda6248c84f44ce1e039baac11b9e6b3075c3feb13bb4e06a9e804ff26436a6
-  data.tar.gz: ebc0e696c427bd033637609d7f1ad4aaa66c603a9ca1ed82adb09d2857c99161
+  metadata.gz: c258389ca56666df76d2865c8fee4ecca3dec132d02b7295d6e245747dbc4896
+  data.tar.gz: 02612dbd491de04d9819742f61bcdb47933837a6b3211d9888765e9eea94ef36
 SHA512:
-  metadata.gz: 102aceedd06b6db82be97c0a45d95a57e22cb1b1ab7427875c6137f98dcfcc87b862cd2cc26dfc14d8f5604a24702166db12b6f94c1835f7e0395fd98082d556
-  data.tar.gz: ca83d65bb73322941c49160de66943b2e1c6c93f35db372ef8cb559e5ea2cf3bdf1d3cc31151e654c8d19b620ceb1f4ee2f6dbf5ef8a8213277bd243c7104111
+  metadata.gz: 6fb8521af37136c1449fc5292fcc7658966f42f538197081d5a9ff53985dc4901c70e5e17c7a93c3204c8be0dc179c10c909ec2499ced966251d7ffc124e14e9
+  data.tar.gz: d18fc9c48f6063187c20472ada669bbf374192687dce5ae7e91d5bfceb2dc7b282340e623e72165363ad398d4e8cb43251dc8ef7820306cab73279ef71c92c41

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [2.0.1] - 2026-06-18
+
+Fixed: `PublicMethodHasSpec` relaxed validation for single-public-method classes (e.g. service objects) no longer passes when the spec's only method-style `describe`/`context` covers a different method — if a method describe is present it must describe the actual public method.
+
 ## [2.0.0] - 2026-06-18
 
 Added: `SufficientContexts` now pinpoints which branch is untested — its message names one uncovered branch and the `# rspec_parity:covers <branch>` annotation to add, and the bundled `rspec-parity-cover` executable lists all of a method's gaps as paste-ready context stubs. Annotations are opt-in (new `CoversAnnotations` config key, default `true`).

data/README.md

@@ -249,7 +249,24 @@ context 'when staff' do # rspec_parity:covers user.staff?
 end
 ```
 
-Re-run and the message advances to the next uncovered branch. Annotations are opt-in and only ever raise coverage — they never create a new violation, and each one covers exactly one branch. A mistyped label is reported with a did-you-mean suggestion.
+Re-run and the message advances to the next uncovered branch. Annotations are opt-in and only ever raise coverage — they never create a new violation. A mistyped label is reported with a did-you-mean suggestion.
+
+Each annotation covers exactly one branch, and the normal expectation is one annotation per context — one context, one scenario, one branch. In rare cases a single context genuinely exercises several branches at once; you can then list more than one branch on it, either as separate comments or with a `;`-separated list:
+
+```ruby
+context 'when fully privileged' do
+  # rspec_parity:covers user.admin?
+  # rspec_parity:covers user.staff?
+  it { is_expected.to be_allowed }
+end
+
+# or, equivalently, on one line:
+context 'when fully privileged' do # rspec_parity:covers user.admin?; user.staff?
+  it { is_expected.to be_allowed }
+end
+```
+
+Reach for this only when the branches really are covered together — multiple annotations on a context that only tests one path inflate coverage and defeat the point of the check.
 
 Long conditions can push the comment past `Layout/LineLength`; exempt these comments rather than editing the label:
 

data/lib/rubocop/cop/rspec_parity/public_method_has_spec.rb

@@ -219,8 +219,9 @@ module RuboCop
 
           # Check if relaxed validation applies
           if matches_skip_path? && count_public_methods(node) == 1
-            # For single-method classes in configured paths, just check for examples
-            return if spec_paths.any? { |spec_path| spec_has_examples?(spec_path, class_name) }
+            # For single-method classes in configured paths, the method describe is optional —
+            # but if one is present, it must describe the actual public method, not a private/random one.
+            return if relaxed_spec_valid?(spec_paths, class_name, method_name, instance_method, flexible_prefix)
           elsif spec_paths.any? do |sp|
                   spec_covers_method?(sp, method_name, instance_method, flexible_prefix: flexible_prefix)
                 end
@@ -233,6 +234,25 @@ module RuboCop
         end
         # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
 
+        # Relaxed validation for single-public-method classes in skip paths.
+        # Passes when the spec describes the class with examples AND either has no
+        # method-style describe/context block at all, or has one that covers the public method.
+        def relaxed_spec_valid?(spec_paths, class_name, method_name, instance_method, flexible_prefix)
+          return false unless spec_paths.any? { |sp| spec_has_examples?(sp, class_name) }
+          return true unless spec_paths.any? { |sp| spec_has_method_describe?(sp) }
+
+          spec_paths.any? do |sp|
+            spec_covers_method?(sp, method_name, instance_method, flexible_prefix: flexible_prefix)
+          end
+        end
+
+        # Detects a method-style block, e.g. describe '#foo' / context '.bar'
+        # (the char right after the quote is a `#` or `.` prefix), as opposed to a
+        # plain descriptive string or a class constant.
+        def spec_has_method_describe?(spec_path)
+          File.read(spec_path).match?(/(?:describe|context)\s+['"][#.][^'"]+['"]/)
+        end
+
         def spec_covers_method?(spec_path, method_name, instance_method, flexible_prefix: false)
           return true if method_tested_in_spec?(spec_path, method_name, instance_method)
           return true if flexible_prefix && method_tested_in_spec?(spec_path, method_name, !instance_method)

data/lib/rubocop/rspec_parity/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module RSpecParity
-    VERSION = "2.0.0"
+    VERSION = "2.0.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec_parity
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Povilas Jurcys