rubocop-rspec_parity 1.3.2 → 1.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe061c7b11557dedba1714eeb2df39a1030bf990a509501dda39781277557aca
-  data.tar.gz: aff7a164338bc4f5b23a9aacf1a3b04c91e040f18bccd7cbdbdc0e931b6bb8b5
+  metadata.gz: b634068a8fe93d9576c210988a5ebab48f22f25058cf7c50e21710de1b7fb775
+  data.tar.gz: 9ac6bd2fc8503e43013e25e03413cb32dd8eb3d6ee44480f1a243f41e006781f
 SHA512:
-  metadata.gz: b1989fb64fc261fb90ce9a3f0a8493715cf7f36015679424dd1a5e746f8cb47682901222c8f1ca078ccc310441a03b8c7671b77e331ae659933d863cfab55449
-  data.tar.gz: 8e173ee1fd7e2aa65e29efe31ed30d5c05fac453579d79bcf3e53c8a7ad9617de435be3cd7b86ae4d5e3cc46815c913bffa939ac36ff3321944b5d2796443267
+  metadata.gz: ab0f3101fd7603ec83438f91772b6991446c9fbb2102cc32ebb948a02df1cfe8a6217e71b2629ba695135b717322d9ba6bd686bfe1a9f58fbe292ea1b70357ba
+  data.tar.gz: d30491decd3a61710bf1c873bbd268aad7d5a40e6d209b46676bf469871c54087e13a6111a47ad83437d5becb6416e5075cec6ca6a0e00a7b7657c873bb44ce2

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 ## [Unreleased]
 
+## [1.3.4] - 2026-02-23
+
+Added: `PublicMethodHasSpec` now treats methods inside `class_methods do` blocks (ActiveSupport::Concern) as class methods, expecting `.method_name` in specs
+
+## [1.3.3] - 2026-02-20
+
+Fixed: `PublicMethodHasSpec` offense message now shows correct method prefix (`#` for instance methods, `.` for class methods) and includes configured `DescribeAliases` in the expected describes
+Fixed: `PublicMethodHasSpec` no longer reports methods in inner classes (class nested inside another class) as needing specs
+
 ## [1.3.2] - 2026-02-20
 
 Fixed: `PublicMethodHasSpec` now recognizes specs that use module wrapping (e.g., `module Foo; RSpec.describe Bar`) instead of fully qualified class names

data/lib/rubocop/cop/rspec_parity/public_method_has_spec.rb

@@ -16,7 +16,7 @@ module RuboCop
         include SpecFileFinder
 
         MSG = "Missing spec for public method `%<method_name>s`. " \
-              "Expected describe '#%<method_name>s' or describe '.%<method_name>s' in %<spec_path>s"
+              "Expected %<expected>s in %<spec_path>s"
 
         COVERED_DIRECTORIES = %w[models controllers services jobs mailers helpers].freeze
         EXCLUDED_METHODS = %w[initialize].freeze
@@ -32,13 +32,15 @@ module RuboCop
 
         def on_def(node)
           return unless checkable_method?(node) && public_method?(node)
+          return if inside_inner_class?(node)
 
-          check_method_has_spec(node, instance_method: !inside_eigenclass?(node))
+          check_method_has_spec(node, instance_method: !inside_eigenclass?(node) && !inside_class_methods_block?(node))
         end
 
         def on_defs(node)
           return unless checkable_method?(node) && public_class_method?(node)
           return if EXCLUDED_HOOK_METHODS.include?(node.method_name.to_s)
+          return if inside_inner_class?(node)
 
           check_method_has_spec(node, instance_method: false)
         end
@@ -75,6 +77,36 @@ module RuboCop
           node.each_ancestor.any? { |a| a.sclass_type? && a.children.first&.self_type? }
         end
 
+        def inside_class_methods_block?(node)
+          node.each_ancestor(:block).any? do |block_node|
+            block_node.send_node.method_name == :class_methods
+          end
+        end
+
+        def inside_inner_class?(node)
+          enclosing = find_class_or_module(node)
+          return false unless enclosing
+
+          enclosing.each_ancestor.any? { |a| a.class_type? && class_has_methods?(a) }
+        end
+
+        def class_has_methods?(class_node)
+          return false unless class_node.body
+
+          children = class_node.body.begin_type? ? class_node.body.children : [class_node.body]
+          children.any? { |child| child.def_type? || child.defs_type? || eigenclass_with_methods?(child) }
+        end
+
+        def eigenclass_with_methods?(node)
+          return false unless node.sclass_type? && node.children.first&.self_type?
+
+          body = node.body
+          return false unless body
+
+          body_children = body.begin_type? ? body.children : [body]
+          body_children.any?(&:def_type?)
+        end
+
         def should_check_file?
           path = processed_source.file_path
           return false if path.nil? || !path.include?("/app/") || path.end_with?("_spec.rb")
@@ -101,7 +133,13 @@ module RuboCop
         end
 
         def find_enclosing_scope(node)
-          node.each_ancestor.find { |n| n.class_type? || n.module_type? || n.sclass_type? }
+          node.each_ancestor.find do |n|
+            n.class_type? || n.module_type? || n.sclass_type? || class_methods_block?(n)
+          end
+        end
+
+        def class_methods_block?(node)
+          node.block_type? && node.send_node.method_name == :class_methods
         end
 
         def find_class_or_module(node)
@@ -175,7 +213,7 @@ module RuboCop
             return
           end
 
-          add_method_offense(node, method_name, spec_paths.first)
+          add_method_offense(node, method_name, spec_paths.first, instance_method: instance_method)
         end
         # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
 
@@ -191,13 +229,23 @@ module RuboCop
           end
         end
 
-        def add_method_offense(node, method_name, spec_path)
+        def add_method_offense(node, method_name, spec_path, instance_method:)
+          prefix = instance_method ? "#" : "."
+          expected = expected_describes(prefix, method_name)
           add_offense(
             node.loc.keyword.join(node.loc.name),
-            message: format(MSG, method_name: method_name, spec_path: relative_spec_path(spec_path))
+            message: format(MSG, method_name: method_name, expected: expected, spec_path: relative_spec_path(spec_path))
           )
         end
 
+        def expected_describes(prefix, method_name)
+          describes = ["describe '#{prefix}#{method_name}'"]
+          describe_aliases_for("#{prefix}#{method_name}").each do |alias_desc|
+            describes << "describe '#{alias_desc}'"
+          end
+          describes.join(" or ")
+        end
+
         def method_tested_in_spec?(spec_path, method_name, instance_method)
           spec_content = File.read(spec_path)
           prefix = instance_method ? "#" : "."

data/lib/rubocop/rspec_parity/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module RSpecParity
-    VERSION = "1.3.2"
+    VERSION = "1.3.4"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec_parity
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.4
 platform: ruby
 authors:
 - Povilas Jurcys