rubocop-rspec_parity 1.2.0 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2d2f62960e2b46b31972221b577d79aed5b54db2f90b6d9cf277dcaa9b432e92
-  data.tar.gz: 320594b7e229f9910535fe7e30233a1f0d56a286676cc8fc636cd782f1c8f113
+  metadata.gz: 7f6cb712ad716f1a6c82659cd5114785bd93f7ed7344fb2ba6317de8bae3d37e
+  data.tar.gz: 2588d5b16c636142a361c2d0723d049099e7e1da76ed30b72b0c78b211734fb9
 SHA512:
-  metadata.gz: da7f6916ecd8946f04ffdf8d67af1c566cbee961d120e2e1ad8fd2d78c8b0238989d4321b5eb5f3179aee0d28197bc88284283bffed042019001cffbaf2d2fc3
-  data.tar.gz: 43653613dfcef10d0a7c21485171a9532c045372354fc1df0ae244d436e4076568696b3b38591e015d0cd75360d39762d19243bd9ab1424a089530f2b04cd693
+  metadata.gz: a2d8de79c7cf285c21e656b96ac473037aabd21c9d206753d44c863b6844d9393217bdf1850b21646f96996355270467e07d711230702fbbb6ed51b4c3536699
+  data.tar.gz: 65836a3ae64470aa713d5c3492fb33b993d137f66f1be2d464104a3ce75a22733dd0a055fd2875f6d7ad24c25b407869d42bfebb9d494c3416a4d7003813d8b8

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 ## [Unreleased]
 
+## [1.2.2] - 2026-02-10
+
+Added: `PublicMethodHasSpec` now skips class methods marked with `private_class_method` (both inline and post-hoc forms)
+
+## [1.2.1] - 2026-02-09
+
+Fixed: Detect tested methods correctly for classes nested inside modules (e.g. `Calendar::UserCreator`)
+
 ## [1.2.0] - 2026-02-09
 
 Added: `SufficientContexts` now counts direct `it` blocks alongside `context` blocks as an additional implicit context

data/lib/rubocop/cop/rspec_parity/public_method_has_spec.rb

@@ -36,13 +36,35 @@ module RuboCop
         end
 
         def on_defs(node)
-          return unless checkable_method?(node)
+          return unless checkable_method?(node) && public_class_method?(node)
 
           check_method_has_spec(node, instance_method: false)
         end
 
         private
 
+        def public_class_method?(node)
+          # Inline form: private_class_method def self.method_name
+          return false if node.parent&.send_type? && node.parent.method_name == :private_class_method
+
+          # Post-hoc form: private_class_method :method_name
+          class_node = find_class_or_module(node)
+          return true unless class_node&.body
+
+          !private_class_method_declared?(class_node, node.method_name)
+        end
+
+        def private_class_method_declared?(class_node, method_name)
+          children = class_node.body.begin_type? ? class_node.body.children : [class_node.body]
+          children.any? { |child| private_class_method_call?(child, method_name) }
+        end
+
+        def private_class_method_call?(node, method_name)
+          node&.send_type? &&
+            node.method_name == :private_class_method &&
+            node.arguments.any? { |arg| arg.sym_type? && arg.value == method_name }
+        end
+
         def checkable_method?(node)
           should_check_file? && !excluded_method?(node.method_name.to_s)
         end

data/lib/rubocop/cop/rspec_parity/spec_file_finder.rb

@@ -11,15 +11,27 @@ module RuboCop
           class_node = find_class_or_module(node)
 
           if class_node
-            # Get the class/module name from the AST
             const_node = class_node.children[0]
-            return const_node.const_name if const_node.const_type?
+            return fully_qualified_class_name(class_node) if const_node.const_type?
           end
 
           # Fallback: infer class name from file path
           infer_class_name_from_path
         end
 
+        def fully_qualified_class_name(class_node)
+          names = [class_node.children[0].const_name]
+          current = class_node
+
+          while (ancestor = current.each_ancestor.find { |n| n.class_type? || n.module_type? })
+            ancestor_const = ancestor.children[0]
+            names.unshift(ancestor_const.const_name) if ancestor_const.const_type?
+            current = ancestor
+          end
+
+          names.join("::")
+        end
+
         def find_class_or_module(node)
           node.each_ancestor.find { |n| n.class_type? || n.module_type? }
         end

data/lib/rubocop/rspec_parity/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module RSpecParity
-    VERSION = "1.2.0"
+    VERSION = "1.2.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec_parity
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.2
 platform: ruby
 authors:
 - Povilas Jurcys