rubocop-rspec 2.12.1 → 2.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a543787a865d7e8062e0b746c1b5dd641214bd17b17d25182a58b4a646c4bfb6
-  data.tar.gz: 57ddde6cfed19062929b00c729dd7403955bf3c92a8b5354cb3704bd7382c5ef
+  metadata.gz: 31d7e881e40be6a9b27f78f77789f1ecc5056bb073f5028a5c3dc0c6e1fe81ad
+  data.tar.gz: 7ad05e5a9ecfa1230aabfa54c7e6f9d7649f428017c405a9ed68d4da95218dd2
 SHA512:
-  metadata.gz: d4a03f557f7f2e7a7a24f01e14db9e7599ce08c7921618d877b807fd37ef065d97556b428931c4129b19ef1d791e072828fd0f3705797d1ec98c69eb7f25cf45
-  data.tar.gz: 0d7bacaeb99c2c60594d507158434e8740c5b2a96032f73db4247cd16ff0963b46de2313d3bf76cf6bb0ed3d33b1751f663062e00cef095ab4310642a4e5153c
+  metadata.gz: dfa4fca8f641da881b6014b91f5df8678af96c60e937339a81a64efd0bd87859ddc5876f977a995ae52a844e88bd53d46d50e0b37fd933b37e18da830991f245
+  data.tar.gz: f7779621a7c6fc6e33bf47b6823cfe7c4be08cc0f32ac02465cd4cbe35a1b8d4ed280a71c33f6fcfd7195a65191f68c9f9c13cdb0f8624a0a3e80be56af4dd50

data/CHANGELOG.md

@@ -2,6 +2,29 @@
 
 ## Master (Unreleased)
 
+## 2.13.0 (2022-09-12)
+
+* Fix `RSpec/FilePath` cop missing mismatched expanded namespace. ([@sl4vr][])
+* Add new `AllowConsecutiveOneLiners` (default true) option for `Rspec/EmptyLineAfterHook` cop. ([@ngouy][])
+* Add autocorrect support for `RSpec/EmptyExampleGroup`. ([@r7kamura][])
+* Fix `RSpec/ChangeByZero` with compound expressions using `&` or `|` operators. ([@BrianHawley][])
+* Add `RSpec/NoExpectationExample`. ([@r7kamura][])
+* Add some expectation methods to default configuration. ([@r7kamura][])
+* Fix a false positive for `RSpec/Capybara/SpecificMatcher`. ([@ydah][])
+* Fix a false negative for `RSpec/Capybara/SpecificMatcher` for `have_field`. ([@ydah][])
+* Fix a false positive for `RSpec/Capybara/SpecificMatcher` when may not have a `href` by `have_link`. ([@ydah][])
+* Add `NegatedMatcher` configuration option to `RSpec/ChangeByZero`. ([@ydah][])
+* Add new `RSpec/Capybara/SpecificFinders` cop. ([@ydah][])
+* Add support for numblocks to `RSpec/AroundBlock`, `RSpec/EmptyLineAfterHook`, `RSpec/ExpectInHook`, `RSpec/HookArgument`, `RSpec/HooksBeforeExamples`, `RSpec/IteratedExpectation`, and `RSpec/NoExpectationExample`. ([@ydah][])
+* Fix incorrect documentation URLs when using `rubocop --show-docs-url`. ([@r7kamura][])
+* Add `AllowedGroups` configuration option to `RSpec/NestedGroups`. ([@ydah][])
+* Deprecate `IgnoredPatterns` option in favor of the `AllowedPatterns` options. ([@ydah][])
+* Add `AllowedPatterns` configuration option to `RSpec/ContextWording`. ([@ydah][])
+* Add `RSpec/ClassCheck` cop. ([@r7kamura][])
+* Fix a false positive for `RSpec/Capybara/SpecificMatcher` when pseudo-classes. ([@ydah][])
+* Fix a false negative for `RSpec/SubjectStub` when the subject is declared with the `subject!` method and called by name. ([@eikes][])
+* Support `Array.new(n)` on `RSpec/FactoryBot/CreateList` cop. ([@r7kamura][])
+
 ## 2.12.1 (2022-07-03)
 
 * Fix a false positive for `RSpec/Capybara/SpecificMatcher`. ([@ydah][])
@@ -603,114 +626,115 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 * Split `UnitSpecNaming` cop into `RSpecDescribeClass`, `RSpecDescribeMethod` and `RSpecFileName` and enabled them all by default. ([@geniou][])
 * Add `RSpecExampleWording` cop to prevent to use of should at the beginning of the spec description. ([@geniou][])
 * Fix `RSpecFileName` cop for non-class specs. ([@geniou][])
-* Adapt `RSpecFileName` cop to commen naming convention and skip spec with multiple top level describes. ([@geniou][])
+* Adapt `RSpecFileName` cop to common naming convention and skip spec with multiple top level describes. ([@geniou][])
 * Add `RSpecMultipleDescribes` cop to check for multiple top level describes. ([@geniou][])
 * Add `RSpecDescribedClass` to promote the use of `described_class`. ([@geniou][])
 * Add `RSpecInstanceVariable` cop to check for the usage of instance variables. ([@geniou][])
 
-<!-- Contributors -->
+<!-- Contributors (alphabetically) -->
 
+[@abrom]: https://github.com/abrom
+[@ahukkanen]: https://github.com/ahukkanen
+[@akiomik]: https://github.com/akiomik
+[@AlexWayfer]: https://github.com/AlexWayfer
+[@andrykonchin]: https://github.com/andrykonchin
 [@andyw8]: https://github.com/andyw8
+[@anthony-robin]: https://github.com/anthony-robin
+[@aried3r]: https://github.com/aried3r
+[@baberthal]: https://github.com/baberthal
 [@backus]: https://github.com/backus
+[@biinari]: https://github.com/biinari
+[@bmorrall]: https://github.com/bmorrall
 [@bquorning]: https://github.com/bquorning
+[@BrentWheeldon]: https://github.com/BrentWheeldon
+[@BrianHawley]: https://github.com/BrianHawley
+[@cfabianski]: https://github.com/cfabianski
+[@clupprich]: https://github.com/clupprich
+[@composerinteralia]: https://github.com/composerinteralia
+[@Darhazer]: https://github.com/Darhazer
+[@daveworth]: https://github.com/daveworth
+[@dduugg]: https://github.com/dduugg
 [@deivid-rodriguez]: https://github.com/deivid-rodriguez
+[@dgollahon]: https://github.com/dgollahon
+[@Drowze]: https://github.com/Drowze
+[@dswij]: https://github.com/dswij
+[@dvandersluis]: https://github.com/dvandersluis
+[@edgibbs]: https://github.com/edgibbs
+[@eikes]: https://github.com/eikes
+[@eitoball]: https://github.com/eitoball
+[@elebow]: https://github.com/elebow
+[@EliseFitz15]: https://github.com/EliseFitz15
+[@elliterate]: https://github.com/elliterate
+[@foton]: https://github.com/foton
+[@francois-ferrandis]: https://github.com/francois-ferrandis
+[@G-Rath]: https://github.com/G-Rath
 [@geniou]: https://github.com/geniou
+[@gsamokovarov]: https://github.com/gsamokovarov
+[@harry-graham]: https://github.com/harry-graham
+[@harrylewis]: https://github.com/harrylewis
+[@hosamaly]: https://github.com/hosamaly
 [@jaredbeck]: https://github.com/jaredbeck
-[@jawshooah]: https://github.com/jawshooah
-[@nevir]: https://github.com/nevir
-[@nijikon]: https://github.com/nijikon
-[@pstengel]: https://github.com/pstengel
-[@miguelfteixeira]: https://github.com/miguelfteixeira
-[@mlarraz]: https://github.com/mlarraz
-[@renanborgescampos]: https://github.com/renanborgescampos
 [@jaredmoody]: https://github.com/jaredmoody
-[@baberthal]: https://github.com/baberthal
 [@jeffreyc]: https://github.com/jeffreyc
-[@clupprich]: https://github.com/clupprich
-[@onk]: https://github.com/onk
-[@Darhazer]: https://github.com/Darhazer
-[@redross]: https://github.com/redross
-[@cfabianski]: https://github.com/cfabianski
-[@dgollahon]: https://github.com/dgollahon
-[@rspeicher]: https://github.com/rspeicher
-[@jonatas]: https://github.com/jonatas
-[@pocke]: https://github.com/pocke
-[@bmorrall]: https://github.com/bmorrall
-[@zverok]: https://github.com/zverok
-[@timrogers]: https://github.com/timrogers
-[@yevhene]: https://github.com/yevhene
-[@walf443]: https://github.com/walf443
-[@pirj]: https://github.com/pirj
-[@telmofcosta]: https://github.com/telmofcosta
-[@EliseFitz15]: https://github.com/EliseFitz15
-[@anthony-robin]: https://github.com/anthony-robin
+[@jfragoulis]: https://github.com/jfragoulis
+[@johnny-miyake]: https://github.com/johnny-miyake
 [@jojos003]: https://github.com/jojos003
-[@abrom]: https://github.com/abrom
-[@patrickomatic]: https://github.com/patrickomatic
-[@tdeo]: https://github.com/tdeo
-[@composerinteralia]: https://github.com/composerinteralia
-[@seanpdoyle]: https://github.com/seanpdoyle
-[@vzvu3k6k]: https://github.com/vzvu3k6k
-[@BrentWheeldon]: https://github.com/BrentWheeldon
-[@daveworth]: https://github.com/daveworth
-[@RST-J]: https://github.com/RST-J
-[@ypresto]: https://github.com/ypresto
+[@jonatas]: https://github.com/jonatas
+[@jtannas]: https://github.com/jtannas
+[@kellysutton]: https://github.com/kellysutton
+[@koic]: https://github.com/koic
+[@lazycoder9]: https://github.com/lazycoder9
+[@leoarnold]: https://github.com/leoarnold
+[@lokhi]: https://github.com/lokhi
+[@luke-hill]: https://github.com/luke-hill
+[@M-Yamashita01]: https://github.com/M-Yamashita01
+[@miguelfteixeira]: https://github.com/miguelfteixeira
 [@mkenyon]: https://github.com/mkenyon
-[@gsamokovarov]: https://github.com/gsamokovarov
-[@schmijos]: https://github.com/schmijos
-[@foton]: https://github.com/foton
+[@mkrawc]: https://github.com/mkrawc
+[@mlarraz]: https://github.com/mlarraz
+[@mockdeep]: https://github.com/mockdeep
+[@MothOnMars]: https://github.com/MothOnMars
 [@nc-holodakg]: https://github.com/nc-holodakg
-[@onumis]: https://github.com/onumis
+[@nevir]: https://github.com/nevir
+[@ngouy]: https://github.com/ngouy
 [@nickcampbell18]: https://github.com/nickcampbell18
+[@nijikon]: https://github.com/nijikon
+[@onk]: https://github.com/onk
+[@onumis]: https://github.com/onumis
+[@oshiro3]: https://github.com/oshiro3
+[@patrickomatic]: https://github.com/patrickomatic
+[@paydaylight]: https://github.com/paydaylight
+[@PhilCoggins]: https://github.com/PhilCoggins
+[@pirj]: https://github.com/pirj
+[@pocke]: https://github.com/pocke
+[@pstengel]: https://github.com/pstengel
 [@QQism]: https://github.com/QQism
-[@kellysutton]: https://github.com/kellysutton
-[@mkrawc]: https://github.com/mkrawc
-[@jfragoulis]: https://github.com/jfragoulis
-[@ybiquitous]: https://github.com/ybiquitous
-[@dduugg]: https://github.com/dduugg
-[@lazycoder9]: https://github.com/lazycoder9
-[@elebow]: https://github.com/elebow
-[@eitoball]: https://github.com/eitoball
-[@aried3r]: https://github.com/aried3r
-[@AlexWayfer]: https://github.com/AlexWayfer
-[@tejasbubane]: https://github.com/tejasbubane
-[@twalpole]: https://github.com/twalpole
-[@zdennis]: https://github.com/zdennis
+[@r7kamura]: https://github.com/r7kamura
+[@Rafix02]: https://github.com/Rafix02
+[@redross]: https://github.com/redross
+[@renanborgescampos]: https://github.com/renanborgescampos
 [@robotdana]: https://github.com/robotdana
 [@rolfschmidt]: https://github.com/rolfschmidt
-[@andrykonchin]: https://github.com/andrykonchin
-[@harrylewis]: https://github.com/harrylewis
-[@elliterate]: https://github.com/elliterate
-[@jtannas]: https://github.com/jtannas
-[@mockdeep]: https://github.com/mockdeep
-[@biinari]: https://github.com/biinari
-[@koic]: https://github.com/koic
-[@Rafix02]: https://github.com/Rafix02
-[@PhilCoggins]: https://github.com/PhilCoggins
+[@rrosenblum]: https://github.com/rrosenblum
+[@rspeicher]: https://github.com/rspeicher
+[@RST-J]: https://github.com/RST-J
+[@schmijos]: https://github.com/schmijos
+[@seanpdoyle]: https://github.com/seanpdoyle
 [@sl4vr]: https://github.com/sl4vr
-[@ahukkanen]: https://github.com/ahukkanen
-[@dvandersluis]: https://github.com/dvandersluis
-[@hosamaly]: https://github.com/hosamaly
 [@stephannv]: https://github.com/stephannv
+[@t3h2mas]: https://github.com/t3h2mas
+[@tdeo]: https://github.com/tdeo
+[@tejasbubane]: https://github.com/tejasbubane
+[@telmofcosta]: https://github.com/telmofcosta
 [@Tietew]: https://github.com/Tietew
-[@rrosenblum]: https://github.com/rrosenblum
-[@paydaylight]: https://github.com/paydaylight
+[@timrogers]: https://github.com/timrogers
 [@topalovic]: https://github.com/topalovic
-[@lokhi]: https://github.com/lokhi
-[@MothOnMars]: https://github.com/MothOnMars
-[@G-Rath]: https://github.com/G-Rath
-[@dswij]: https://github.com/dswij
-[@francois-ferrandis]: https://github.com/francois-ferrandis
-[@r7kamura]: https://github.com/r7kamura
-[@leoarnold]: https://github.com/leoarnold
-[@harry-graham]: https://github.com/harry-graham
-[@oshiro3]: https://github.com/oshiro3
+[@twalpole]: https://github.com/twalpole
+[@vzvu3k6k]: https://github.com/vzvu3k6k
+[@walf443]: https://github.com/walf443
+[@ybiquitous]: https://github.com/ybiquitous
 [@ydah]: https://github.com/ydah
-[@t3h2mas]: https://github.com/t3h2mas
-[@M-Yamashita01]: https://github.com/M-Yamashita01
-[@luke-hill]: https://github.com/luke-hill
-[@johnny-miyake]: https://github.com/johnny-miyake
-[@ngouy]: https://github.com/ngouy
-[@edgibbs]: https://github.com/edgibbs
-[@Drowze]: https://github.com/Drowze
-[@akiomik]: https://github.com/akiomik
+[@yevhene]: https://github.com/yevhene
+[@ypresto]: https://github.com/ypresto
+[@zdennis]: https://github.com/zdennis
+[@zverok]: https://github.com/zverok

data/config/default.yml

@@ -2,6 +2,7 @@
 RSpec:
   Enabled: true
   StyleGuideBaseURL: https://rspec.rubystyle.guide
+  DocumentationBaseURL: https://docs.rubocop.org/rubocop-rspec
   Include: &1
     - "**/*_spec.rb"
     - "**/spec/**/*"
@@ -61,9 +62,14 @@ RSpec:
       Pending:
         - pending
     Expectations:
+      - are_expected
       - expect
-      - is_expected
       - expect_any_instance_of
+      - is_expected
+      - should
+      - should_not
+      - should_not_receive
+      - should_receive
     Helpers:
       - let
       - let!
@@ -187,8 +193,21 @@ RSpec/BeforeAfterAll:
 RSpec/ChangeByZero:
   Description: Prefer negated matchers over `to change.by(0)`.
   Enabled: pending
-  VersionAdded: 2.11.0
+  VersionAdded: '2.11'
+  VersionChanged: '2.13'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ChangeByZero
+  NegatedMatcher: ~
+
+RSpec/ClassCheck:
+  Description: Enforces consistent use of `be_a` or `be_kind_of`.
+  StyleGuide: "#is-a-vs-kind-of"
+  Enabled: pending
+  VersionAdded: '2.13'
+  EnforcedStyle: be_a
+  SupportedStyles:
+    - be_a
+    - be_kind_of
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ClassCheck
 
 RSpec/ContextMethod:
   Description: "`context` should not be used for specifying methods."
@@ -204,8 +223,9 @@ RSpec/ContextWording:
     - when
     - with
     - without
+  AllowedPatterns: []
   VersionAdded: '1.20'
-  VersionChanged: 1.20.1
+  VersionChanged: '2.13'
   StyleGuide: https://rspec.rubystyle.guide/#context-descriptions
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ContextWording
 
@@ -279,8 +299,9 @@ RSpec/Dialect:
 RSpec/EmptyExampleGroup:
   Description: Checks if an example group does not include any tests.
   Enabled: true
+  SafeAutoCorrect: false
   VersionAdded: '1.7'
-  VersionChanged: '2.0'
+  VersionChanged: '2.13'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyExampleGroup
 
 RSpec/EmptyHook:
@@ -315,8 +336,10 @@ RSpec/EmptyLineAfterHook:
   Description: Checks if there is an empty line after hook blocks.
   Enabled: true
   VersionAdded: '1.27'
+  VersionChanged: '2.13'
   StyleGuide: https://rspec.rubystyle.guide/#empty-line-after-let
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterHook
+  AllowConsecutiveOneLiners: true
 
 RSpec/EmptyLineAfterSubject:
   Description: Checks if there is an empty line after subject block.
@@ -607,10 +630,18 @@ RSpec/NestedGroups:
   Description: Checks for nested example groups.
   Enabled: true
   Max: 3
+  AllowedGroups: []
   VersionAdded: '1.7'
-  VersionChanged: '1.10'
+  VersionChanged: '2.13'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NestedGroups
 
+RSpec/NoExpectationExample:
+  Description: Checks if an example contains any expectation.
+  Enabled: pending
+  Safe: false
+  VersionAdded: '2.13'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NoExpectationExample
+
 RSpec/NotToNot:
   Description: Checks for consistent method usage for negating expectations.
   Enabled: true
@@ -775,9 +806,10 @@ RSpec/VariableName:
   SupportedStyles:
     - snake_case
     - camelCase
+  AllowedPatterns: []
   IgnoredPatterns: []
   VersionAdded: '1.40'
-  VersionChanged: '1.43'
+  VersionChanged: '2.13'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/VariableName
 
 RSpec/VerifiedDoubleReference:
@@ -834,6 +866,12 @@ RSpec/Capybara/FeatureMethods:
   VersionChanged: '2.0'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/FeatureMethods
 
+RSpec/Capybara/SpecificFinders:
+  Description: Checks if there is a more specific finder offered by Capybara.
+  Enabled: pending
+  VersionAdded: '2.13'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/SpecificFinders
+
 RSpec/Capybara/SpecificMatcher:
   Description: Checks for there is a more specific matcher offered by Capybara.
   Enabled: pending

data/lib/rubocop/cop/rspec/align_left_let_brace.rb

@@ -6,16 +6,15 @@ module RuboCop
       # Checks that left braces for adjacent single line lets are aligned.
       #
       # @example
+      #   # bad
+      #   let(:foobar) { blahblah }
+      #   let(:baz) { bar }
+      #   let(:a) { b }
       #
-      #     # bad
-      #     let(:foobar) { blahblah }
-      #     let(:baz) { bar }
-      #     let(:a) { b }
-      #
-      #     # good
-      #     let(:foobar) { blahblah }
-      #     let(:baz)    { bar }
-      #     let(:a)      { b }
+      #   # good
+      #   let(:foobar) { blahblah }
+      #   let(:baz)    { bar }
+      #   let(:a)      { b }
       #
       class AlignLeftLetBrace < Base
         extend AutoCorrector

data/lib/rubocop/cop/rspec/align_right_let_brace.rb

@@ -6,16 +6,15 @@ module RuboCop
       # Checks that right braces for adjacent single line lets are aligned.
       #
       # @example
+      #   # bad
+      #   let(:foobar) { blahblah }
+      #   let(:baz)    { bar }
+      #   let(:a)      { b }
       #
-      #     # bad
-      #     let(:foobar) { blahblah }
-      #     let(:baz)    { bar }
-      #     let(:a)      { b }
-      #
-      #     # good
-      #     let(:foobar) { blahblah }
-      #     let(:baz)    { bar      }
-      #     let(:a)      { b        }
+      #   # good
+      #   let(:foobar) { blahblah }
+      #   let(:baz)    { bar      }
+      #   let(:a)      { b        }
       #
       class AlignRightLetBrace < Base
         extend AutoCorrector

data/lib/rubocop/cop/rspec/any_instance.rb

@@ -22,6 +22,7 @@ module RuboCop
       #       allow(my_instance).to receive(:foo)
       #     end
       #   end
+      #
       class AnyInstance < Base
         MSG = 'Avoid stubbing using `%<method>s`.'
         RESTRICT_ON_SEND = %i[

data/lib/rubocop/cop/rspec/around_block.rb

@@ -25,23 +25,29 @@ module RuboCop
       #     some_method
       #     test.run
       #   end
+      #
       class AroundBlock < Base
         MSG_NO_ARG     = 'Test object should be passed to around block.'
         MSG_UNUSED_ARG = 'You should call `%<arg>s.call` ' \
                          'or `%<arg>s.run`.'
 
-        # @!method hook(node)
-        def_node_matcher :hook, <<-PATTERN
+        # @!method hook_block(node)
+        def_node_matcher :hook_block, <<-PATTERN
           (block (send nil? :around sym ?) (args $...) ...)
         PATTERN
 
+        # @!method hook_numblock(node)
+        def_node_matcher :hook_numblock, <<-PATTERN
+          (numblock (send nil? :around sym ?) ...)
+        PATTERN
+
         # @!method find_arg_usage(node)
         def_node_search :find_arg_usage, <<-PATTERN
           {(send $... {:call :run}) (send _ _ $...) (yield $...) (block-pass $...)}
         PATTERN
 
         def on_block(node)
-          hook(node) do |(example_proxy)|
+          hook_block(node) do |(example_proxy)|
             if example_proxy.nil?
               add_no_arg_offense(node)
             else
@@ -50,6 +56,12 @@ module RuboCop
           end
         end
 
+        def on_numblock(node)
+          hook_numblock(node) do
+            check_for_numblock(node)
+          end
+        end
+
         private
 
         def add_no_arg_offense(node)
@@ -68,6 +80,17 @@ module RuboCop
             message: format(MSG_UNUSED_ARG, arg: name)
           )
         end
+
+        def check_for_numblock(block)
+          find_arg_usage(block) do |usage|
+            return if usage.include?(s(:lvar, :_1))
+          end
+
+          add_offense(
+            block.children.last,
+            message: format(MSG_UNUSED_ARG, arg: :_1)
+          )
+        end
       end
     end
   end

data/lib/rubocop/cop/rspec/be.rb

@@ -10,7 +10,6 @@ module RuboCop
       # cases it's better to specify what exactly is the expected value.
       #
       # @example
-      #
       #   # bad
       #   expect(foo).to be
       #

data/lib/rubocop/cop/rspec/be_eq.rb

@@ -10,7 +10,6 @@ module RuboCop
       # the `be` matcher is preferable as it is a more strict test.
       #
       # @example
-      #
       #   # bad
       #   expect(foo).to eq(true)
       #   expect(foo).to eq(false)

data/lib/rubocop/cop/rspec/be_eql.rb

@@ -11,7 +11,6 @@ module RuboCop
       # preferable as it is a more strict test.
       #
       # @example
-      #
       #   # bad
       #   expect(foo).to eql(1)
       #   expect(foo).to eql(1.0)

data/lib/rubocop/cop/rspec/before_after_all.rb

@@ -23,6 +23,7 @@ module RuboCop
       #     before(:each) { Widget.create }
       #     after(:each) { Widget.delete_all }
       #   end
+      #
       class BeforeAfterAll < Base
         MSG = 'Beware of using `%<hook>s` as it may cause state to leak ' \
               'between tests. If you are using `rspec-rails`, and ' \

data/lib/rubocop/cop/rspec/capybara/current_path_expectation.rb

@@ -14,14 +14,20 @@ module RuboCop
         # which ensures that preceding actions (like `click_link`) have
         # completed.
         #
+        # This cop does not support autocorrection in some cases.
+        #
         # @example
         #   # bad
         #   expect(current_path).to eq('/callback')
-        #   expect(page.current_path).to match(/widgets/)
         #
         #   # good
-        #   expect(page).to have_current_path("/callback")
-        #   expect(page).to have_current_path(/widgets/)
+        #   expect(page).to have_current_path('/callback')
+        #
+        #   # bad (does not support autocorrection)
+        #   expect(page.current_path).to match(variable)
+        #
+        #   # good
+        #   expect(page).to have_current_path('/callback')
         #
         class CurrentPathExpectation < Base
           extend AutoCorrector

data/lib/rubocop/cop/rspec/capybara/feature_methods.rb

@@ -40,6 +40,7 @@ module RuboCop
         #       # ...
         #     end
         #   end
+        #
         class FeatureMethods < Base
           extend AutoCorrector
           include InsideExampleGroup
@@ -68,7 +69,7 @@ module RuboCop
             ...)
           PATTERN
 
-          def on_block(node)
+          def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
             return unless inside_example_group?(node)
 
             feature_method(node) do |send_node, match|

data/lib/rubocop/cop/rspec/capybara/specific_finders.rb

@@ -0,0 +1,86 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      module Capybara
+        # Checks if there is a more specific finder offered by Capybara.
+        #
+        # @example
+        #   # bad
+        #   find('#some-id')
+        #   find('[visible][id=some-id]')
+        #
+        #   # good
+        #   find_by_id('some-id')
+        #   find_by_id('some-id', visible: true)
+        #
+        class SpecificFinders < Base
+          extend AutoCorrector
+
+          include RangeHelp
+
+          MSG = 'Prefer `find_by` over `find`.'
+          RESTRICT_ON_SEND = %i[find].freeze
+
+          # @!method find_argument(node)
+          def_node_matcher :find_argument, <<~PATTERN
+            (send _ :find (str $_) ...)
+          PATTERN
+
+          def on_send(node)
+            find_argument(node) do |arg|
+              next if CssSelector.multiple_selectors?(arg)
+
+              on_attr(node, arg) if attribute?(arg)
+              on_id(node, arg) if CssSelector.id?(arg)
+            end
+          end
+
+          private
+
+          def on_attr(node, arg)
+            return unless (id = CssSelector.attributes(arg)['id'])
+
+            register_offense(node, replaced_arguments(arg, id))
+          end
+
+          def on_id(node, arg)
+            register_offense(node, "'#{arg.to_s.delete('#')}'")
+          end
+
+          def attribute?(arg)
+            CssSelector.attribute?(arg) &&
+              CssSelector.common_attributes?(arg)
+          end
+
+          def register_offense(node, arg_replacement)
+            add_offense(offense_range(node)) do |corrector|
+              corrector.replace(node.loc.selector, 'find_by_id')
+              corrector.replace(node.first_argument.loc.expression,
+                                arg_replacement)
+            end
+          end
+
+          def replaced_arguments(arg, id)
+            options = to_options(CssSelector.attributes(arg))
+            options.empty? ? id : "#{id}, #{options}"
+          end
+
+          def to_options(attrs)
+            attrs.each.map do |key, value|
+              next if key == 'id'
+
+              "#{key}: #{value}"
+            end.compact.join(', ')
+          end
+
+          def offense_range(node)
+            range_between(node.loc.selector.begin_pos,
+                          node.loc.end.end_pos)
+          end
+        end
+      end
+    end
+  end
+end