rubocop-rspec 2.12.1 → 2.13.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/CHANGELOG.md +110 -86
- data/config/default.yml +44 -6
- data/lib/rubocop/cop/rspec/align_left_let_brace.rb +8 -9
- data/lib/rubocop/cop/rspec/align_right_let_brace.rb +8 -9
- data/lib/rubocop/cop/rspec/any_instance.rb +1 -0
- data/lib/rubocop/cop/rspec/around_block.rb +26 -3
- data/lib/rubocop/cop/rspec/be.rb +0 -1
- data/lib/rubocop/cop/rspec/be_eq.rb +0 -1
- data/lib/rubocop/cop/rspec/be_eql.rb +0 -1
- data/lib/rubocop/cop/rspec/before_after_all.rb +1 -0
- data/lib/rubocop/cop/rspec/capybara/current_path_expectation.rb +9 -3
- data/lib/rubocop/cop/rspec/capybara/feature_methods.rb +2 -1
- data/lib/rubocop/cop/rspec/capybara/specific_finders.rb +86 -0
- data/lib/rubocop/cop/rspec/capybara/specific_matcher.rb +91 -10
- data/lib/rubocop/cop/rspec/capybara/visibility_matcher.rb +0 -1
- data/lib/rubocop/cop/rspec/change_by_zero.rb +60 -5
- data/lib/rubocop/cop/rspec/class_check.rb +101 -0
- data/lib/rubocop/cop/rspec/context_method.rb +2 -1
- data/lib/rubocop/cop/rspec/context_wording.rb +49 -18
- data/lib/rubocop/cop/rspec/describe_class.rb +1 -1
- data/lib/rubocop/cop/rspec/describe_method.rb +1 -0
- data/lib/rubocop/cop/rspec/described_class.rb +4 -14
- data/lib/rubocop/cop/rspec/dialect.rb +1 -0
- data/lib/rubocop/cop/rspec/empty_example_group.rb +19 -4
- data/lib/rubocop/cop/rspec/empty_hook.rb +2 -1
- data/lib/rubocop/cop/rspec/empty_line_after_example.rb +4 -9
- data/lib/rubocop/cop/rspec/empty_line_after_example_group.rb +1 -1
- data/lib/rubocop/cop/rspec/empty_line_after_final_let.rb +2 -1
- data/lib/rubocop/cop/rspec/empty_line_after_hook.rb +32 -2
- data/lib/rubocop/cop/rspec/empty_line_after_subject.rb +2 -1
- data/lib/rubocop/cop/rspec/example_length.rb +2 -1
- data/lib/rubocop/cop/rspec/example_without_description.rb +2 -1
- data/lib/rubocop/cop/rspec/example_wording.rb +2 -1
- data/lib/rubocop/cop/rspec/excessive_docstring_spacing.rb +1 -0
- data/lib/rubocop/cop/rspec/expect_actual.rb +3 -0
- data/lib/rubocop/cop/rspec/expect_change.rb +1 -1
- data/lib/rubocop/cop/rspec/expect_in_hook.rb +4 -1
- data/lib/rubocop/cop/rspec/expect_output.rb +1 -0
- data/lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb +2 -1
- data/lib/rubocop/cop/rspec/factory_bot/create_list.rb +26 -12
- data/lib/rubocop/cop/rspec/factory_bot/factory_class_name.rb +1 -0
- data/lib/rubocop/cop/rspec/file_path.rb +6 -3
- data/lib/rubocop/cop/rspec/focus.rb +18 -0
- data/lib/rubocop/cop/rspec/hook_argument.rb +7 -2
- data/lib/rubocop/cop/rspec/hooks_before_examples.rb +10 -9
- data/lib/rubocop/cop/rspec/identical_equality_assertion.rb +0 -1
- data/lib/rubocop/cop/rspec/implicit_block_expectation.rb +1 -0
- data/lib/rubocop/cop/rspec/implicit_expect.rb +0 -2
- data/lib/rubocop/cop/rspec/instance_spy.rb +1 -1
- data/lib/rubocop/cop/rspec/instance_variable.rb +0 -1
- data/lib/rubocop/cop/rspec/it_behaves_like.rb +1 -0
- data/lib/rubocop/cop/rspec/iterated_expectation.rb +16 -0
- data/lib/rubocop/cop/rspec/leading_subject.rb +15 -15
- data/lib/rubocop/cop/rspec/let_before_examples.rb +7 -8
- data/lib/rubocop/cop/rspec/let_setup.rb +4 -4
- data/lib/rubocop/cop/rspec/message_chain.rb +1 -1
- data/lib/rubocop/cop/rspec/missing_example_group_argument.rb +2 -1
- data/lib/rubocop/cop/rspec/mixin/css_selector.rb +99 -0
- data/lib/rubocop/cop/rspec/mixin/namespace.rb +23 -0
- data/lib/rubocop/cop/rspec/multiple_describes.rb +1 -0
- data/lib/rubocop/cop/rspec/multiple_expectations.rb +1 -5
- data/lib/rubocop/cop/rspec/multiple_memoized_helpers.rb +1 -3
- data/lib/rubocop/cop/rspec/multiple_subjects.rb +17 -2
- data/lib/rubocop/cop/rspec/named_subject.rb +2 -1
- data/lib/rubocop/cop/rspec/nested_groups.rb +45 -25
- data/lib/rubocop/cop/rspec/no_expectation_example.rb +64 -0
- data/lib/rubocop/cop/rspec/not_to_not.rb +1 -2
- data/lib/rubocop/cop/rspec/overwriting_setup.rb +2 -1
- data/lib/rubocop/cop/rspec/pending.rb +1 -0
- data/lib/rubocop/cop/rspec/predicate_matcher.rb +2 -1
- data/lib/rubocop/cop/rspec/rails/avoid_setup_hook.rb +1 -2
- data/lib/rubocop/cop/rspec/receive_counts.rb +14 -15
- data/lib/rubocop/cop/rspec/receive_never.rb +4 -5
- data/lib/rubocop/cop/rspec/repeated_description.rb +25 -26
- data/lib/rubocop/cop/rspec/repeated_example.rb +1 -1
- data/lib/rubocop/cop/rspec/repeated_example_group_body.rb +28 -29
- data/lib/rubocop/cop/rspec/repeated_example_group_description.rb +28 -29
- data/lib/rubocop/cop/rspec/repeated_include_example.rb +32 -33
- data/lib/rubocop/cop/rspec/return_from_stub.rb +1 -1
- data/lib/rubocop/cop/rspec/scattered_let.rb +1 -5
- data/lib/rubocop/cop/rspec/scattered_setup.rb +1 -1
- data/lib/rubocop/cop/rspec/shared_context.rb +1 -1
- data/lib/rubocop/cop/rspec/stubbed_mock.rb +0 -1
- data/lib/rubocop/cop/rspec/subject_declaration.rb +0 -1
- data/lib/rubocop/cop/rspec/subject_stub.rb +2 -2
- data/lib/rubocop/cop/rspec/unspecified_exception.rb +15 -15
- data/lib/rubocop/cop/rspec/variable_definition.rb +1 -0
- data/lib/rubocop/cop/rspec/variable_name.rb +6 -7
- data/lib/rubocop/cop/rspec/verified_doubles.rb +1 -0
- data/lib/rubocop/cop/rspec/void_expect.rb +2 -1
- data/lib/rubocop/cop/rspec/yield.rb +2 -1
- data/lib/rubocop/cop/rspec_cops.rb +3 -0
- data/lib/rubocop/rspec/config_formatter.rb +14 -3
- data/lib/rubocop/rspec/inject.rb +1 -3
- data/lib/rubocop/rspec/language/node_pattern.rb +4 -0
- data/lib/rubocop/rspec/language.rb +6 -1
- data/lib/rubocop/rspec/version.rb +1 -1
- data/lib/rubocop/rspec/wording.rb +2 -2
- data/lib/rubocop/rspec.rb +14 -0
- data/lib/rubocop-rspec.rb +3 -0
- metadata +10 -88
@@ -6,44 +6,43 @@ module RuboCop
|
|
6
6
|
# Check for repeated description strings in example groups.
|
7
7
|
#
|
8
8
|
# @example
|
9
|
+
# # bad
|
10
|
+
# RSpec.describe User do
|
11
|
+
# it 'is valid' do
|
12
|
+
# # ...
|
13
|
+
# end
|
9
14
|
#
|
10
|
-
#
|
11
|
-
#
|
12
|
-
# it 'is valid' do
|
13
|
-
# # ...
|
14
|
-
# end
|
15
|
-
#
|
16
|
-
# it 'is valid' do
|
17
|
-
# # ...
|
18
|
-
# end
|
15
|
+
# it 'is valid' do
|
16
|
+
# # ...
|
19
17
|
# end
|
18
|
+
# end
|
20
19
|
#
|
21
|
-
#
|
22
|
-
#
|
23
|
-
#
|
24
|
-
#
|
25
|
-
#
|
20
|
+
# # good
|
21
|
+
# RSpec.describe User do
|
22
|
+
# it 'is valid when first and last name are present' do
|
23
|
+
# # ...
|
24
|
+
# end
|
26
25
|
#
|
27
|
-
#
|
28
|
-
#
|
29
|
-
# end
|
26
|
+
# it 'is valid when last name only is present' do
|
27
|
+
# # ...
|
30
28
|
# end
|
29
|
+
# end
|
31
30
|
#
|
32
|
-
#
|
33
|
-
#
|
34
|
-
#
|
35
|
-
#
|
36
|
-
#
|
31
|
+
# # good
|
32
|
+
# RSpec.describe User do
|
33
|
+
# it 'is valid' do
|
34
|
+
# # ...
|
35
|
+
# end
|
37
36
|
#
|
38
|
-
#
|
39
|
-
#
|
40
|
-
# end
|
37
|
+
# it 'is valid', :flag do
|
38
|
+
# # ...
|
41
39
|
# end
|
40
|
+
# end
|
42
41
|
#
|
43
42
|
class RepeatedDescription < Base
|
44
43
|
MSG = "Don't repeat descriptions within an example group."
|
45
44
|
|
46
|
-
def on_block(node)
|
45
|
+
def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
|
47
46
|
return unless example_group?(node)
|
48
47
|
|
49
48
|
repeated_descriptions(node).each do |repeated_description|
|
@@ -18,7 +18,7 @@ module RuboCop
|
|
18
18
|
class RepeatedExample < Base
|
19
19
|
MSG = "Don't repeat examples within an example group."
|
20
20
|
|
21
|
-
def on_block(node)
|
21
|
+
def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
|
22
22
|
return unless example_group?(node)
|
23
23
|
|
24
24
|
repeated_examples(node).each do |repeated_example|
|
@@ -6,42 +6,41 @@ module RuboCop
|
|
6
6
|
# Check for repeated describe and context block body.
|
7
7
|
#
|
8
8
|
# @example
|
9
|
+
# # bad
|
10
|
+
# describe 'cool feature x' do
|
11
|
+
# it { cool_predicate }
|
12
|
+
# end
|
9
13
|
#
|
10
|
-
#
|
11
|
-
#
|
12
|
-
#
|
13
|
-
# end
|
14
|
+
# describe 'cool feature y' do
|
15
|
+
# it { cool_predicate }
|
16
|
+
# end
|
14
17
|
#
|
15
|
-
#
|
16
|
-
#
|
17
|
-
#
|
18
|
+
# # good
|
19
|
+
# describe 'cool feature' do
|
20
|
+
# it { cool_predicate }
|
21
|
+
# end
|
18
22
|
#
|
19
|
-
#
|
20
|
-
#
|
21
|
-
#
|
22
|
-
# end
|
23
|
+
# describe 'another cool feature' do
|
24
|
+
# it { another_predicate }
|
25
|
+
# end
|
23
26
|
#
|
24
|
-
#
|
25
|
-
#
|
26
|
-
#
|
27
|
+
# # good
|
28
|
+
# context 'when case x', :tag do
|
29
|
+
# it { cool_predicate }
|
30
|
+
# end
|
27
31
|
#
|
28
|
-
#
|
29
|
-
#
|
30
|
-
#
|
31
|
-
# end
|
32
|
+
# context 'when case y' do
|
33
|
+
# it { cool_predicate }
|
34
|
+
# end
|
32
35
|
#
|
33
|
-
#
|
34
|
-
#
|
35
|
-
#
|
36
|
+
# # good
|
37
|
+
# context Array do
|
38
|
+
# it { is_expected.to respond_to :each }
|
39
|
+
# end
|
36
40
|
#
|
37
|
-
#
|
38
|
-
#
|
39
|
-
#
|
40
|
-
# end
|
41
|
-
#
|
42
|
-
# context Hash do
|
43
|
-
# it { is_expected.to respond_to :each }
|
44
|
-
# end
|
41
|
+
# context Hash do
|
42
|
+
# it { is_expected.to respond_to :each }
|
43
|
+
# end
|
45
44
|
#
|
46
45
|
class RepeatedExampleGroupBody < Base
|
47
46
|
MSG = 'Repeated %<group>s block body on line(s) %<loc>s'
|
@@ -6,42 +6,41 @@ module RuboCop
|
|
6
6
|
# Check for repeated example group descriptions.
|
7
7
|
#
|
8
8
|
# @example
|
9
|
+
# # bad
|
10
|
+
# describe 'cool feature' do
|
11
|
+
# # example group
|
12
|
+
# end
|
9
13
|
#
|
10
|
-
#
|
11
|
-
#
|
12
|
-
#
|
13
|
-
# end
|
14
|
+
# describe 'cool feature' do
|
15
|
+
# # example group
|
16
|
+
# end
|
14
17
|
#
|
15
|
-
#
|
16
|
-
#
|
17
|
-
#
|
18
|
+
# # bad
|
19
|
+
# context 'when case x' do
|
20
|
+
# # example group
|
21
|
+
# end
|
18
22
|
#
|
19
|
-
#
|
20
|
-
#
|
21
|
-
#
|
22
|
-
# end
|
23
|
+
# describe 'when case x' do
|
24
|
+
# # example group
|
25
|
+
# end
|
23
26
|
#
|
24
|
-
#
|
25
|
-
#
|
26
|
-
#
|
27
|
+
# # good
|
28
|
+
# describe 'cool feature' do
|
29
|
+
# # example group
|
30
|
+
# end
|
27
31
|
#
|
28
|
-
#
|
29
|
-
#
|
30
|
-
#
|
31
|
-
# end
|
32
|
+
# describe 'another cool feature' do
|
33
|
+
# # example group
|
34
|
+
# end
|
32
35
|
#
|
33
|
-
#
|
34
|
-
#
|
35
|
-
#
|
36
|
+
# # good
|
37
|
+
# context 'when case x' do
|
38
|
+
# # example group
|
39
|
+
# end
|
36
40
|
#
|
37
|
-
#
|
38
|
-
#
|
39
|
-
#
|
40
|
-
# end
|
41
|
-
#
|
42
|
-
# context 'when another case' do
|
43
|
-
# # example group
|
44
|
-
# end
|
41
|
+
# context 'when another case' do
|
42
|
+
# # example group
|
43
|
+
# end
|
45
44
|
#
|
46
45
|
class RepeatedExampleGroupDescription < Base
|
47
46
|
MSG = 'Repeated %<group>s block description on line(s) %<loc>s'
|
@@ -6,45 +6,44 @@ module RuboCop
|
|
6
6
|
# Check for repeated include of shared examples.
|
7
7
|
#
|
8
8
|
# @example
|
9
|
+
# # bad
|
10
|
+
# describe 'foo' do
|
11
|
+
# include_examples 'cool stuff'
|
12
|
+
# include_examples 'cool stuff'
|
13
|
+
# end
|
9
14
|
#
|
10
|
-
#
|
11
|
-
#
|
12
|
-
#
|
13
|
-
#
|
14
|
-
#
|
15
|
+
# # bad
|
16
|
+
# describe 'foo' do
|
17
|
+
# it_behaves_like 'a cool', 'thing'
|
18
|
+
# it_behaves_like 'a cool', 'thing'
|
19
|
+
# end
|
15
20
|
#
|
16
|
-
#
|
17
|
-
#
|
18
|
-
#
|
19
|
-
#
|
20
|
-
#
|
21
|
+
# # bad
|
22
|
+
# context 'foo' do
|
23
|
+
# it_should_behave_like 'a duck'
|
24
|
+
# it_should_behave_like 'a duck'
|
25
|
+
# end
|
21
26
|
#
|
22
|
-
#
|
23
|
-
#
|
24
|
-
#
|
25
|
-
#
|
26
|
-
# end
|
27
|
+
# # good
|
28
|
+
# describe 'foo' do
|
29
|
+
# include_examples 'cool stuff'
|
30
|
+
# end
|
27
31
|
#
|
28
|
-
#
|
29
|
-
#
|
30
|
-
#
|
31
|
-
# end
|
32
|
+
# describe 'bar' do
|
33
|
+
# include_examples 'cool stuff'
|
34
|
+
# end
|
32
35
|
#
|
33
|
-
#
|
34
|
-
#
|
35
|
-
#
|
36
|
+
# # good
|
37
|
+
# describe 'foo' do
|
38
|
+
# it_behaves_like 'a cool', 'thing'
|
39
|
+
# it_behaves_like 'a cool', 'person'
|
40
|
+
# end
|
36
41
|
#
|
37
|
-
#
|
38
|
-
#
|
39
|
-
#
|
40
|
-
#
|
41
|
-
#
|
42
|
-
#
|
43
|
-
# # good
|
44
|
-
# context 'foo' do
|
45
|
-
# it_should_behave_like 'a duck'
|
46
|
-
# it_should_behave_like 'a goose'
|
47
|
-
# end
|
42
|
+
# # good
|
43
|
+
# context 'foo' do
|
44
|
+
# it_should_behave_like 'a duck'
|
45
|
+
# it_should_behave_like 'a goose'
|
46
|
+
# end
|
48
47
|
#
|
49
48
|
class RepeatedIncludeExample < Base
|
50
49
|
MSG = 'Repeated include of shared_examples %<name>s ' \
|
@@ -31,7 +31,7 @@ module RuboCop
|
|
31
31
|
|
32
32
|
MSG = 'Group all let/let! blocks in the example group together.'
|
33
33
|
|
34
|
-
def on_block(node)
|
34
|
+
def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
|
35
35
|
return unless example_group_with_body?(node)
|
36
36
|
|
37
37
|
check_let_declarations(node.body)
|
@@ -53,10 +53,6 @@ module RuboCop
|
|
53
53
|
end
|
54
54
|
end
|
55
55
|
end
|
56
|
-
|
57
|
-
def find_first_let(node)
|
58
|
-
node.children.find { |child| let?(child) }
|
59
|
-
end
|
60
56
|
end
|
61
57
|
end
|
62
58
|
end
|
@@ -26,7 +26,7 @@ module RuboCop
|
|
26
26
|
MSG = 'Do not define multiple `%<hook_name>s` hooks in the same ' \
|
27
27
|
'example group (also defined on %<lines>s).'
|
28
28
|
|
29
|
-
def on_block(node)
|
29
|
+
def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
|
30
30
|
return unless example_group?(node)
|
31
31
|
|
32
32
|
repeated_hooks(node).each do |occurrences|
|
@@ -79,7 +79,7 @@ module RuboCop
|
|
79
79
|
def_node_matcher :shared_example,
|
80
80
|
block_pattern('#SharedGroups.examples')
|
81
81
|
|
82
|
-
def on_block(node)
|
82
|
+
def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
|
83
83
|
context_with_only_examples(node) do
|
84
84
|
add_offense(node.send_node, message: MSG_EXAMPLES) do |corrector|
|
85
85
|
corrector.replace(node.send_node.loc.selector, 'shared_examples')
|
@@ -11,7 +11,7 @@ module RuboCop
|
|
11
11
|
# when subject is also defined in parent example groups.
|
12
12
|
#
|
13
13
|
# @see https://robots.thoughtbot.com/don-t-stub-the-system-under-test
|
14
|
-
# @see https://
|
14
|
+
# @see https://penelope.zone/2015/12/27/introducing-rspec-smells-and-where-to-find-them.html#smell-1-stubjec
|
15
15
|
# @see https://github.com/rubocop-hq/rspec-style-guide#dont-stub-subject
|
16
16
|
#
|
17
17
|
# @example
|
@@ -72,7 +72,7 @@ module RuboCop
|
|
72
72
|
def_node_matcher :subject?, <<-PATTERN
|
73
73
|
(block
|
74
74
|
(send nil?
|
75
|
-
{
|
75
|
+
{ #Subjects.all (sym $_) | $#Subjects.all }
|
76
76
|
) args ...)
|
77
77
|
PATTERN
|
78
78
|
|
@@ -10,26 +10,26 @@ module RuboCop
|
|
10
10
|
# to `raise_error`
|
11
11
|
#
|
12
12
|
# @example
|
13
|
+
# # bad
|
14
|
+
# expect {
|
15
|
+
# raise StandardError.new('error')
|
16
|
+
# }.to raise_error
|
13
17
|
#
|
14
|
-
#
|
15
|
-
#
|
16
|
-
#
|
17
|
-
#
|
18
|
+
# # good
|
19
|
+
# expect {
|
20
|
+
# raise StandardError.new('error')
|
21
|
+
# }.to raise_error(StandardError)
|
18
22
|
#
|
19
|
-
#
|
20
|
-
#
|
21
|
-
#
|
22
|
-
# }.to raise_error(StandardError)
|
23
|
+
# expect {
|
24
|
+
# raise StandardError.new('error')
|
25
|
+
# }.to raise_error('error')
|
23
26
|
#
|
24
|
-
#
|
25
|
-
#
|
26
|
-
#
|
27
|
+
# expect {
|
28
|
+
# raise StandardError.new('error')
|
29
|
+
# }.to raise_error(/err/)
|
27
30
|
#
|
28
|
-
#
|
29
|
-
# raise StandardError.new('error')
|
30
|
-
# }.to raise_error(/err/)
|
31
|
+
# expect { do_something }.not_to raise_error
|
31
32
|
#
|
32
|
-
# expect { do_something }.not_to raise_error
|
33
33
|
class UnspecifiedException < Base
|
34
34
|
MSG = 'Specify the exception being captured'
|
35
35
|
RESTRICT_ON_SEND = %i[to].freeze
|
@@ -5,7 +5,7 @@ module RuboCop
|
|
5
5
|
module RSpec
|
6
6
|
# Checks that memoized helper names use the configured style.
|
7
7
|
#
|
8
|
-
# Variables can be excluded from checking using the `
|
8
|
+
# Variables can be excluded from checking using the `AllowedPatterns`
|
9
9
|
# option.
|
10
10
|
#
|
11
11
|
# @example EnforcedStyle: snake_case (default)
|
@@ -26,22 +26,21 @@ module RuboCop
|
|
26
26
|
# subject(:userName1) { 'Adam' }
|
27
27
|
# let(:userName2) { 'Adam' }
|
28
28
|
#
|
29
|
-
# @example
|
30
|
-
#
|
29
|
+
# @example AllowedPatterns configuration
|
31
30
|
# # rubocop.yml
|
32
31
|
# # RSpec/VariableName:
|
33
32
|
# # EnforcedStyle: snake_case
|
34
|
-
# #
|
33
|
+
# # AllowedPatterns:
|
35
34
|
# # - ^userFood
|
36
35
|
#
|
37
36
|
# @example
|
38
|
-
# # okay because it matches the `^userFood` regex in `
|
37
|
+
# # okay because it matches the `^userFood` regex in `AllowedPatterns`
|
39
38
|
# subject(:userFood_1) { 'spaghetti' }
|
40
39
|
# let(:userFood_2) { 'fettuccine' }
|
41
40
|
#
|
42
41
|
class VariableName < Base
|
43
42
|
include ConfigurableNaming
|
44
|
-
include
|
43
|
+
include AllowedPattern
|
45
44
|
include Variable
|
46
45
|
|
47
46
|
MSG = 'Use %<style>s for variable names.'
|
@@ -49,7 +48,7 @@ module RuboCop
|
|
49
48
|
def on_send(node)
|
50
49
|
variable_definition?(node) do |variable|
|
51
50
|
return if variable.dstr_type? || variable.dsym_type?
|
52
|
-
return if
|
51
|
+
return if matches_allowed_pattern?(variable.value)
|
53
52
|
|
54
53
|
check_name(node, variable.value, variable.loc.expression)
|
55
54
|
end
|
@@ -11,6 +11,7 @@ module RuboCop
|
|
11
11
|
#
|
12
12
|
# # good
|
13
13
|
# expect(something).to be(1)
|
14
|
+
#
|
14
15
|
class VoidExpect < Base
|
15
16
|
MSG = 'Do not use `expect()` without `.to` or `.not_to`. ' \
|
16
17
|
'Chain the methods or remove it.'
|
@@ -32,7 +33,7 @@ module RuboCop
|
|
32
33
|
check_expect(node)
|
33
34
|
end
|
34
35
|
|
35
|
-
def on_block(node)
|
36
|
+
def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
|
36
37
|
return unless expect_block?(node)
|
37
38
|
|
38
39
|
check_expect(node)
|
@@ -11,6 +11,7 @@ module RuboCop
|
|
11
11
|
#
|
12
12
|
# # good
|
13
13
|
# expect(foo).to receive(:bar).and_yield(1)
|
14
|
+
#
|
14
15
|
class Yield < Base
|
15
16
|
extend AutoCorrector
|
16
17
|
include RangeHelp
|
@@ -26,7 +27,7 @@ module RuboCop
|
|
26
27
|
# @!method block_call?(node)
|
27
28
|
def_node_matcher :block_call?, '(send (lvar %) :call ...)'
|
28
29
|
|
29
|
-
def on_block(node)
|
30
|
+
def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
|
30
31
|
return unless method_on_stub?(node.send_node)
|
31
32
|
|
32
33
|
block_arg(node.arguments) do |block|
|
@@ -2,6 +2,7 @@
|
|
2
2
|
|
3
3
|
require_relative 'rspec/capybara/current_path_expectation'
|
4
4
|
require_relative 'rspec/capybara/feature_methods'
|
5
|
+
require_relative 'rspec/capybara/specific_finders'
|
5
6
|
require_relative 'rspec/capybara/specific_matcher'
|
6
7
|
require_relative 'rspec/capybara/visibility_matcher'
|
7
8
|
|
@@ -28,6 +29,7 @@ require_relative 'rspec/be_eql'
|
|
28
29
|
require_relative 'rspec/be_nil'
|
29
30
|
require_relative 'rspec/before_after_all'
|
30
31
|
require_relative 'rspec/change_by_zero'
|
32
|
+
require_relative 'rspec/class_check'
|
31
33
|
require_relative 'rspec/context_method'
|
32
34
|
require_relative 'rspec/context_wording'
|
33
35
|
require_relative 'rspec/describe_class'
|
@@ -77,6 +79,7 @@ require_relative 'rspec/multiple_memoized_helpers'
|
|
77
79
|
require_relative 'rspec/multiple_subjects'
|
78
80
|
require_relative 'rspec/named_subject'
|
79
81
|
require_relative 'rspec/nested_groups'
|
82
|
+
require_relative 'rspec/no_expectation_example'
|
80
83
|
require_relative 'rspec/not_to_not'
|
81
84
|
require_relative 'rspec/overwriting_setup'
|
82
85
|
require_relative 'rspec/pending'
|
@@ -21,17 +21,18 @@ module RuboCop
|
|
21
21
|
.gsub(EXTENSION_ROOT_DEPARTMENT, "\n\\1")
|
22
22
|
.gsub(*AMENDMENTS, "\n\\0")
|
23
23
|
.gsub(/^(\s+)- /, '\1 - ')
|
24
|
+
.gsub('"~"', '~')
|
24
25
|
end
|
25
26
|
|
26
27
|
private
|
27
28
|
|
28
29
|
def unified_config
|
29
30
|
cops.each_with_object(config.dup) do |cop, unified|
|
30
|
-
next if SUBDEPARTMENTS.include?(cop)
|
31
|
-
next if AMENDMENTS.include?(cop)
|
31
|
+
next if SUBDEPARTMENTS.include?(cop) || AMENDMENTS.include?(cop)
|
32
32
|
|
33
|
+
replace_nil(unified[cop])
|
33
34
|
unified[cop].merge!(descriptions.fetch(cop))
|
34
|
-
unified[cop]['Reference'] =
|
35
|
+
unified[cop]['Reference'] = reference(cop)
|
35
36
|
end
|
36
37
|
end
|
37
38
|
|
@@ -39,6 +40,16 @@ module RuboCop
|
|
39
40
|
(descriptions.keys | config.keys).grep(EXTENSION_ROOT_DEPARTMENT)
|
40
41
|
end
|
41
42
|
|
43
|
+
def replace_nil(config)
|
44
|
+
config.each do |key, value|
|
45
|
+
config[key] = '~' if value.nil?
|
46
|
+
end
|
47
|
+
end
|
48
|
+
|
49
|
+
def reference(cop)
|
50
|
+
COP_DOC_BASE_URL + cop.sub('RSpec/', '')
|
51
|
+
end
|
52
|
+
|
42
53
|
attr_reader :config, :descriptions
|
43
54
|
end
|
44
55
|
end
|
data/lib/rubocop/rspec/inject.rb
CHANGED
@@ -6,9 +6,7 @@ module RuboCop
|
|
6
6
|
# bit of our configuration.
|
7
7
|
module Inject
|
8
8
|
def self.defaults!
|
9
|
-
|
10
|
-
config_default = project_root.join('config', 'default.yml')
|
11
|
-
path = config_default.to_s
|
9
|
+
path = CONFIG_DEFAULT.to_s
|
12
10
|
hash = ConfigLoader.send(:load_yaml_configuration, path)
|
13
11
|
config = RuboCop::Config.new(hash, path)
|
14
12
|
puts "configuration from #{path}" if ConfigLoader.debug?
|
@@ -41,7 +41,12 @@ module RuboCop
|
|
41
41
|
def_node_matcher :example?, block_pattern('#Examples.all')
|
42
42
|
|
43
43
|
# @!method hook?(node)
|
44
|
-
def_node_matcher :hook?,
|
44
|
+
def_node_matcher :hook?, <<-PATTERN
|
45
|
+
{
|
46
|
+
#{block_pattern('#Hooks.all')}
|
47
|
+
#{numblock_pattern('#Hooks.all')}
|
48
|
+
}
|
49
|
+
PATTERN
|
45
50
|
|
46
51
|
# @!method let?(node)
|
47
52
|
def_node_matcher :let?, <<-PATTERN
|
@@ -31,8 +31,8 @@ module RuboCop
|
|
31
31
|
attr_reader :text, :ignores, :replacements
|
32
32
|
|
33
33
|
def replace_prefix(pattern, replacement)
|
34
|
-
text.sub(pattern) do |
|
35
|
-
uppercase?(
|
34
|
+
text.sub(pattern) do |matched|
|
35
|
+
uppercase?(matched) ? replacement.upcase : replacement
|
36
36
|
end
|
37
37
|
end
|
38
38
|
|