rubocop-rspec 3.6.0 → 3.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e4727f136d1a399d3108fd010c76ac61f7fce57e3c89cb2d97ad121d558af44
-  data.tar.gz: dcc8c7f61c420d5938807dae3a610f53c6be8c657687e38542f701db2aec4ce2
+  metadata.gz: abe85fc893e4ec59cb9b5f1e999d35bb41692feacc4dba579d135b3eefd6e4c7
+  data.tar.gz: 953ba29bf3fce28b79943e69039b638574d74432dac8b896f3dc8e589a20581c
 SHA512:
-  metadata.gz: 651f8b53a0b70738f9dc084df5bdf471ce65ae4d7f0c2db8cc2eb557178fd541f317bee36ae062b8109aed72b452f69eb1c965db923d5d9875c86de9ab84f23e
-  data.tar.gz: f189ec83b4b663df4e3aca303f2f273fded6d5529e689d7f9421f379dd46203da95236a4f649414466b0f6050b0d9e7d952df003b4b63ed45722c1764fd1a094
+  metadata.gz: acdf813781e2081ec34540e83a9a48fc289dab5cc8bff69d9610beb4a3f21c30955794eb4226d40b9f0460a04d38665c2aa4ce0857f35d8bd3a7325d91a861be
+  data.tar.gz: 752074b0fdce204596efc71e2358982c73c2fccff07da5da364c88b8ad5e99d5a8bfdbc855a9dd422169adeddf278266352f732092b5aa86d14502016ca77837

data/CHANGELOG.md

@@ -2,6 +2,26 @@
 
 ## Master (Unreleased)
 
+## 3.8.0 (2025-11-12)
+
+- Add new cop `RSpec/LeakyLocalVariable`. ([@lovro-bikic])
+- Bump RuboCop requirement to +1.81. ([@ydah])
+- Fix a false positive for `RSpec/LetSetup` when `let!` used in outer scope. ([@ydah])
+- Fix a false positive for `RSpec/ReceiveNever` cop when `allow(...).to receive(...).never`. ([@ydah])
+- Fix detection of nameless doubles with methods in `RSpec/VerifiedDoubles`. ([@ushi-as])
+- Improve an offense message for `RSpec/RepeatedExample` cop. ([@ydah])
+- Let `RSpec/SpecFilePathFormat` leverage ActiveSupport inflections when configured. ([@corsonknowles], [@bquorning])
+
+## 3.7.0 (2025-09-01)
+
+- Mark `RSpec/IncludeExamples` as `SafeAutoCorrect: false`. ([@yujideveloper])
+- Fix a false positive for `RSpec/LeakyConstantDeclaration` when defining constants in explicit namespaces. ([@naveg])
+- Add support for error matchers (`raise_exception` and `raise_error`) to `RSpec/Dialect`. ([@lovro-bikic])
+- Don't register offenses for `RSpec/DescribedClass` within `Data.define` blocks. ([@lovro-bikic])
+- Add autocorrection support for `RSpec/IteratedExpectation` for single expectations. ([@lovro-bikic])
+- Exclude all cops from inspecting factorybot files, except if explicitly included. ([@Mth0158])
+- Fix a false positive for `RSpec/ExcessiveDocstringSpacing` when receivers are not RSpec methods. ([@ydah])
+
 ## 3.6.0 (2025-04-18)
 
 - Fix false positive in `RSpec/Pending`, where it would mark the default block `it` as an offense. ([@bquorning])
@@ -1021,6 +1041,7 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@mlarraz]: https://github.com/mlarraz
 [@mockdeep]: https://github.com/mockdeep
 [@mothonmars]: https://github.com/MothOnMars
+[@mth0158]: https://github.com/Mth0158
 [@mvz]: https://github.com/mvz
 [@naveg]: https://github.com/naveg
 [@nc-holodakg]: https://github.com/nc-holodakg
@@ -1066,6 +1087,7 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@tmaier]: https://github.com/tmaier
 [@topalovic]: https://github.com/topalovic
 [@twalpole]: https://github.com/twalpole
+[@ushi-as]: https://github.com/ushi-as
 [@vzvu3k6k]: https://github.com/vzvu3k6k
 [@walf443]: https://github.com/walf443
 [@yasu551]: https://github.com/yasu551
@@ -1073,5 +1095,6 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@ydah]: https://github.com/ydah
 [@yevhene]: https://github.com/yevhene
 [@ypresto]: https://github.com/ypresto
+[@yujideveloper]: https://github.com/yujideveloper
 [@zdennis]: https://github.com/zdennis
 [@zverok]: https://github.com/zverok

data/config/default.yml

@@ -6,6 +6,10 @@ RSpec:
   Include:
     - "**/*_spec.rb"
     - "**/spec/**/*"
+  Exclude:
+    - "**/spec/factories.rb"
+    - "**/spec/factories/**/*.rb"
+    - "**/features/support/factories/**/*.rb"
   Language:
     inherit_mode:
       merge:
@@ -79,6 +83,9 @@ RSpec:
       - prepend_after
       - after
       - append_after
+    ErrorMatchers:
+      - raise_error
+      - raise_exception
     Includes:
       inherit_mode:
         merge:
@@ -535,7 +542,9 @@ RSpec/ImplicitSubject:
 RSpec/IncludeExamples:
   Description: Checks for usage of `include_examples`.
   Enabled: pending
+  SafeAutoCorrect: false
   VersionAdded: '3.6'
+  VersionChanged: '3.7'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IncludeExamples
 
 RSpec/IndexedLet:
@@ -601,6 +610,12 @@ RSpec/LeakyConstantDeclaration:
   StyleGuide: https://rspec.rubystyle.guide/#declare-constants
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LeakyConstantDeclaration
 
+RSpec/LeakyLocalVariable:
+  Description: Checks for local variables from outer scopes used inside examples.
+  Enabled: pending
+  VersionAdded: '3.8'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LeakyLocalVariable
+
 RSpec/LetBeforeExamples:
   Description: Checks for `let` definitions that come after an example.
   Enabled: true
@@ -782,7 +797,7 @@ RSpec/ReceiveCounts:
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ReceiveCounts
 
 RSpec/ReceiveMessages:
-  Description: Checks for multiple messages stubbed on the same object.
+  Description: Prefer `receive_messages` over multiple `receive`s on the same object.
   Enabled: true
   SafeAutoCorrect: false
   VersionAdded: '2.23'
@@ -924,7 +939,13 @@ RSpec/SpecFilePathFormat:
   IgnoreMethods: false
   IgnoreMetadata:
     type: routing
+  InflectorPath: "./config/initializers/inflections.rb"
+  SupportedInflectors:
+    - default
+    - active_support
+  EnforcedInflector: default
   VersionAdded: '2.24'
+  VersionChanged: '3.8'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/SpecFilePathFormat
 
 RSpec/SpecFilePathSuffix:

data/lib/rubocop/cop/rspec/context_wording.rb

@@ -67,7 +67,7 @@ module RuboCop
 
         # @!method context_wording(node)
         def_node_matcher :context_wording, <<~PATTERN
-          (block (send #rspec? { :context :shared_context } $({str dstr xstr} ...) ...) ...)
+          (block (send #rspec? { :context :shared_context } $(any_str ...) ...) ...)
         PATTERN
 
         def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler

data/lib/rubocop/cop/rspec/described_class.rb

@@ -13,6 +13,20 @@ module RuboCop
       # `OnlyStaticConstants` is only relevant when `EnforcedStyle` is
       # `described_class`.
       #
+      # There's a known caveat with rspec-rails's `controller` helper that
+      # runs its block in a different context, and `described_class` is not
+      # available to it. `SkipBlocks` option excludes detection in all
+      # non-RSpec related blocks.
+      #
+      # To narrow down this setting to only a specific directory, it is
+      # possible to use an overriding configuration file local to that
+      # directory.
+      #
+      # @safety
+      #   Autocorrection is unsafe when `SkipBlocks: false` because
+      #   `described_class` might not be available within the block (for
+      #   example, in rspec-rails's `controller` helper).
+      #
       # @example `EnforcedStyle: described_class` (default)
       #   # bad
       #   describe MyClass do
@@ -47,15 +61,6 @@ module RuboCop
       #     subject { MyClass.do_something }
       #   end
       #
-      # There's a known caveat with rspec-rails's `controller` helper that
-      # runs its block in a different context, and `described_class` is not
-      # available to it. `SkipBlocks` option excludes detection in all
-      # non-RSpec related blocks.
-      #
-      # To narrow down this setting to only a specific directory, it is
-      # possible to use an overriding configuration file local to that
-      # directory.
-      #
       # @example `SkipBlocks: true`
       #   # spec/controllers/.rubocop.yml
       #   # RSpec/DescribedClass:
@@ -78,7 +83,13 @@ module RuboCop
 
         # @!method common_instance_exec_closure?(node)
         def_node_matcher :common_instance_exec_closure?, <<~PATTERN
-          (block (send (const nil? {:Class :Module :Struct}) :new ...) ...)
+          (block
+            {
+              (send (const nil? {:Class :Module :Struct}) :new ...)
+              (send (const nil? :Data) :define ...)
+            }
+            ...
+          )
         PATTERN
 
         # @!method rspec_block?(node)

data/lib/rubocop/cop/rspec/dialect.rb

@@ -21,6 +21,7 @@ module RuboCop
       # - let, let!
       # - subject, subject!
       # - expect, is_expected, expect_any_instance_of
+      # - raise_error, raise_exception
       #
       # By default all of the RSpec methods and aliases are allowed. By setting
       # a config like:

data/lib/rubocop/cop/rspec/example_wording.rb

@@ -10,8 +10,19 @@ module RuboCop
       #
       # @see http://betterspecs.org/#should
       #
-      # The autocorrect is experimental - use with care! It can be configured
-      # with CustomTransform (e.g. have => has) and IgnoredWords (e.g. only).
+      # @safety
+      #   The autocorrect is experimental - use with care! It can be configured
+      #   with CustomTransform (e.g. have => has) and IgnoredWords (e.g. only).
+      #
+      #   While the autocorrect will not break your code (it only modifies test
+      #   description strings, not the actual test logic), it may produce
+      #   grammatically incorrect English in some cases. Always review the diff
+      #   when using autocorrect to ensure the descriptions remain natural and
+      #   accurate.
+      #
+      #   This is not classified as an unsafe autocorrect because it does not
+      #   affect code behavior, but manual review of changes is strongly
+      #   recommended.
       #
       # Use the DisallowedExamples setting to prevent unclear or insufficient
       # descriptions. Please note that this config will not be treated as

data/lib/rubocop/cop/rspec/excessive_docstring_spacing.rb

@@ -30,7 +30,7 @@ module RuboCop
 
         # @!method example_description(node)
         def_node_matcher :example_description, <<~PATTERN
-          (send _ {#Examples.all #ExampleGroups.all} ${
+          (send #rspec? {#Examples.all #ExampleGroups.all} ${
             $str
             $(dstr ({str dstr `sym} ...) ...)
           } ...)

data/lib/rubocop/cop/rspec/include_examples.rb

@@ -12,6 +12,57 @@ module RuboCop
       #
       # Prefer using `it_behaves_like` instead.
       #
+      # @safety
+      #   `include_examples` and `it_behaves_like` have different scoping
+      #   behaviors.
+      #   Changing `include_examples` to `it_behaves_like` creates a new
+      #   context, altering setup dependencies, which can lead to unexpected
+      #   test failures.
+      #   Specifically, the scope of hooks (`before`, `after`, `around`)
+      #   changes, which may prevent expected setup from being inherited
+      #   correctly.
+      #
+      #   Additionally, `let` and `subject` are affected by scoping rules.
+      #   When `include_examples` is used, `let` and `subject` defined within
+      #   `shared_examples` are evaluated in the caller's context, allowing
+      #   access to their values.
+      #   In contrast, `it_behaves_like` creates a new context, preventing
+      #   access to `let` or `subject` values from the caller's context.
+      #
+      #   [source,ruby]
+      #   ----
+      #   shared_examples "mock behavior" do
+      #     before do
+      #       allow(service).to receive(:call).and_return("mocked response")
+      #     end
+      #
+      #     it "returns mocked response" do
+      #       expect(service.call).to eq "mocked response"
+      #     end
+      #   end
+      #
+      #   context "working example with include_examples" do
+      #     let(:service) { double(:service) }
+      #
+      #     include_examples "mock behavior"
+      #
+      #     it "uses the mocked service" do
+      #       expect(service.call).to eq "mocked response" # Passes
+      #     end
+      #   end
+      #
+      #   context "broken example with it_behaves_like" do
+      #     let(:service) { double(:service) }
+      #
+      #     it_behaves_like "mock behavior"
+      #
+      #     it "unexpectedly does not use the mocked service" do
+      #       # Fails because `it_behaves_like` does not apply the mock setup
+      #       expect(service.call).to eq "mocked response"
+      #     end
+      #   end
+      #   ----
+      #
       # @example
       #   # bad
       #   include_examples 'examples'

data/lib/rubocop/cop/rspec/iterated_expectation.rb

@@ -17,6 +17,8 @@ module RuboCop
       #   end
       #
       class IteratedExpectation < Base
+        extend AutoCorrector
+
         MSG = 'Prefer using the `all` matcher instead ' \
               'of iterating over an array.'
 
@@ -25,14 +27,14 @@ module RuboCop
           (block
             (send ... :each)
             (args (arg $_))
-            $(...)
+            (...)
           )
         PATTERN
 
         # @!method each_numblock?(node)
         def_node_matcher :each_numblock?, <<~PATTERN
           (numblock
-            (send ... :each) _ $(...)
+            (send ... :each) _ (...)
           )
         PATTERN
 
@@ -42,23 +44,43 @@ module RuboCop
         PATTERN
 
         def on_block(node)
-          each?(node) do |arg, body|
-            if single_expectation?(body, arg) || only_expectations?(body, arg)
-              add_offense(node.send_node)
-            end
+          each?(node) do |arg|
+            check_offense(node, arg)
           end
         end
 
         def on_numblock(node)
-          each_numblock?(node) do |body|
-            if single_expectation?(body, :_1) || only_expectations?(body, :_1)
-              add_offense(node.send_node)
-            end
+          each_numblock?(node) do
+            check_offense(node, :_1)
           end
         end
 
         private
 
+        def check_offense(node, argument)
+          if single_expectation?(node.body, argument)
+            add_offense(node.send_node) do |corrector|
+              next unless node.body.arguments.one?
+              next if uses_argument_in_matcher?(node, argument)
+
+              corrector.replace(node, single_expectation_replacement(node))
+            end
+          elsif only_expectations?(node.body, argument)
+            add_offense(node.send_node)
+          end
+        end
+
+        def single_expectation_replacement(node)
+          collection = node.receiver.source
+          matcher = node.body.first_argument.source
+
+          "expect(#{collection}).to all(#{matcher})"
+        end
+
+        def uses_argument_in_matcher?(node, argument)
+          node.body.first_argument.each_descendant.any?(s(:lvar, argument))
+        end
+
         def single_expectation?(body, arg)
           expectation?(body, arg)
         end

data/lib/rubocop/cop/rspec/leaky_constant_declaration.rb

@@ -100,18 +100,21 @@ module RuboCop
 
         def on_casgn(node)
           return unless inside_describe_block?(node)
+          return if explicit_namespace?(node.namespace)
 
           add_offense(node, message: MSG_CONST)
         end
 
         def on_class(node)
           return unless inside_describe_block?(node)
+          return if explicit_namespace?(node.identifier.namespace)
 
           add_offense(node, message: MSG_CLASS)
         end
 
         def on_module(node)
           return unless inside_describe_block?(node)
+          return if explicit_namespace?(node.identifier.namespace)
 
           add_offense(node, message: MSG_MODULE)
         end
@@ -121,6 +124,10 @@ module RuboCop
         def inside_describe_block?(node)
           node.each_ancestor(:block).any? { |ancestor| spec_group?(ancestor) }
         end
+
+        def explicit_namespace?(namespace)
+          !namespace.nil?
+        end
       end
     end
   end

data/lib/rubocop/cop/rspec/leaky_local_variable.rb

@@ -0,0 +1,138 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks for local variables from outer scopes used inside examples.
+      #
+      # Local variables assigned outside an example but used within it act
+      # as shared state, which can make tests non-deterministic.
+      #
+      # @example
+      #   # bad - outside variable used in a hook
+      #   user = create(:user)
+      #
+      #   before { user.update(admin: true) }
+      #
+      #   # good
+      #   let(:user) { create(:user) }
+      #
+      #   before { user.update(admin: true) }
+      #
+      #   # bad - outside variable used in an example
+      #   user = create(:user)
+      #
+      #   it 'is persisted' do
+      #     expect(user).to be_persisted
+      #   end
+      #
+      #   # good
+      #   let(:user) { create(:user) }
+      #
+      #   it 'is persisted' do
+      #     expect(user).to be_persisted
+      #   end
+      #
+      #   # also good - assigning the variable within the example
+      #   it 'is persisted' do
+      #     user = create(:user)
+      #
+      #     expect(user).to be_persisted
+      #   end
+      #
+      #   # bad - outside variable passed to included examples
+      #   attrs = ['foo', 'bar']
+      #
+      #   it_behaves_like 'some examples', attrs
+      #
+      #   # good
+      #   it_behaves_like 'some examples' do
+      #     let(:attrs) { ['foo', 'bar'] }
+      #   end
+      #
+      #   # good - when variable is used only as example description
+      #   attribute = 'foo'
+      #
+      #   it "#{attribute} is persisted" do
+      #     expectations
+      #   end
+      #
+      #   # good - when variable is used only to include other examples
+      #   examples = foo ? 'some examples' : 'other examples'
+      #
+      #   it_behaves_like examples, another_argument
+      #
+      class LeakyLocalVariable < Base
+        MSG = 'Do not use local variables defined outside of ' \
+              'examples inside of them.'
+
+        # @!method example_method?(node)
+        def_node_matcher :example_method?, <<~PATTERN
+          (send nil? #Examples.all _)
+        PATTERN
+
+        # @!method includes_method?(node)
+        def_node_matcher :includes_method?, <<~PATTERN
+          (send nil? #Includes.all ...)
+        PATTERN
+
+        def self.joining_forces
+          VariableForce
+        end
+
+        def after_leaving_scope(scope, _variable_table)
+          scope.variables.each_value { |variable| check_references(variable) }
+        end
+
+        private
+
+        def check_references(variable)
+          variable.assignments.each do |assignment|
+            next if part_of_example_scope?(assignment.node)
+
+            assignment.references.each do |reference|
+              next unless inside_describe_block?(reference)
+              next unless part_of_example_scope?(reference)
+              next if allowed_reference?(reference)
+
+              add_offense(assignment.node)
+            end
+          end
+        end
+
+        def allowed_reference?(node)
+          node.each_ancestor.any? do |ancestor|
+            next true if example_method?(ancestor)
+            if includes_method?(ancestor)
+              next allowed_includes_arguments?(ancestor, node)
+            end
+
+            false
+          end
+        end
+
+        def allowed_includes_arguments?(node, argument)
+          node.arguments[1..].all? do |argument_node|
+            next true if argument_node.type?(:dstr, :dsym)
+
+            argument_node != argument &&
+              argument_node.each_descendant.none?(argument)
+          end
+        end
+
+        def part_of_example_scope?(node)
+          node.each_ancestor.any? { |ancestor| example_scope?(ancestor) }
+        end
+
+        def example_scope?(node)
+          subject?(node) || let?(node) || hook?(node) || example?(node) ||
+            include?(node)
+        end
+
+        def inside_describe_block?(node)
+          node.each_ancestor(:block).any? { |ancestor| spec_group?(ancestor) }
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/let_setup.rb

@@ -25,6 +25,18 @@ module RuboCop
       #   it 'counts widgets' do
       #     expect(Widget.count).to eq(1)
       #   end
+      #
+      #   # good
+      #   describe 'a widget' do
+      #     let!(:my_widget) { create(:widget) }
+      #     context 'when visiting its page' do
+      #       let!(:my_widget) { create(:widget, name: 'Special') }
+      #       it 'counts widgets' do
+      #         expect(Widget.count).to eq(1)
+      #       end
+      #     end
+      #   end
+      #
       class LetSetup < Base
         MSG = 'Do not use `let!` to setup objects not referenced in tests.'
 
@@ -59,6 +71,8 @@ module RuboCop
 
         def unused_let_bang(node)
           child_let_bang(node) do |method_send, method_name|
+            next if overrides_outer_let_bang?(node, method_name)
+
             yield(method_send) unless method_called?(node, method_name.to_sym)
           end
         end
@@ -68,6 +82,22 @@ module RuboCop
             let_bang(let, &block)
           end
         end
+
+        def overrides_outer_let_bang?(node, method_name)
+          node.each_ancestor(:block).any? do |ancestor|
+            next unless example_or_shared_group_or_including?(ancestor)
+
+            outer_let_bang?(ancestor, method_name)
+          end
+        end
+
+        def outer_let_bang?(ancestor_node, method_name)
+          RuboCop::RSpec::ExampleGroup.new(ancestor_node).lets.any? do |let|
+            let_bang(let) do |_send, name|
+              name == method_name
+            end
+          end
+        end
       end
     end
   end

data/lib/rubocop/cop/rspec/mixin/final_end_location.rb

@@ -7,7 +7,7 @@ module RuboCop
       module FinalEndLocation
         def final_end_location(start_node)
           heredoc_endings =
-            start_node.each_node(:str, :dstr, :xstr)
+            start_node.each_node(:any_str)
               .select(&:heredoc?)
               .map { |node| node.loc.heredoc_end }
 

data/lib/rubocop/cop/rspec/mixin/variable.rb

@@ -13,7 +13,7 @@ module RuboCop
         # @!method variable_definition?(node)
         def_node_matcher :variable_definition?, <<~PATTERN
           (send nil? {#Subjects.all #Helpers.all}
-            $({sym str dsym dstr} ...) ...)
+            $({any_sym str dstr} ...) ...)
         PATTERN
       end
     end

data/lib/rubocop/cop/rspec/predicate_matcher.rb

@@ -181,9 +181,7 @@ module RuboCop
         end
 
         def heredoc_argument?(matcher)
-          matcher.arguments.select do |arg|
-            arg.type?(:str, :dstr, :xstr)
-          end.any?(&:heredoc?)
+          matcher.arguments.select(&:any_str_type?).any?(&:heredoc?)
         end
 
         # @!method predicate_matcher?(node)

data/lib/rubocop/cop/rspec/receive_messages.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module RSpec
-      # Checks for multiple messages stubbed on the same object.
+      # Prefer `receive_messages` over multiple `receive`s on the same object.
       #
       # @safety
       #   The autocorrection is marked as unsafe, because it may change the

data/lib/rubocop/cop/rspec/receive_never.rb

@@ -5,6 +5,11 @@ module RuboCop
     module RSpec
       # Prefer `not_to receive(...)` over `receive(...).never`.
       #
+      # This cop only flags usage with `expect`. It ignores `allow` because
+      # `allow(...).to receive(...).never` is a valid way to ensure a method
+      # is not called, while `allow(...).not_to receive(...)` would have
+      # different semantics.
+      #
       # @example
       #   # bad
       #   expect(foo).to receive(:bar).never
@@ -12,6 +17,9 @@ module RuboCop
       #   # good
       #   expect(foo).not_to receive(:bar)
       #
+      #   # not flagged by this cop
+      #   allow(foo).to receive(:bar).never
+      #
       class ReceiveNever < Base
         extend AutoCorrector
         MSG = 'Use `not_to receive` instead of `never`.'
@@ -20,8 +28,20 @@ module RuboCop
         # @!method method_on_stub?(node)
         def_node_search :method_on_stub?, '(send nil? :receive ...)'
 
+        # @!method expect_to_receive?(node)
+        def_node_matcher :expect_to_receive?, <<~PATTERN
+          (send
+            {
+              (send #rspec? {:expect :expect_any_instance_of} ...)
+              (block (send #rspec? :expect) ...)
+              (send nil? :is_expected)
+            }
+            :to ...)
+        PATTERN
+
         def on_send(node)
           return unless node.method?(:never) && method_on_stub?(node)
+          return unless used_with_expect?(node)
 
           add_offense(node.loc.selector) do |corrector|
             autocorrect(corrector, node)
@@ -30,6 +50,12 @@ module RuboCop
 
         private
 
+        def used_with_expect?(node)
+          node.each_ancestor(:send).any? do |ancestor|
+            expect_to_receive?(ancestor)
+          end
+        end
+
         def autocorrect(corrector, node)
           corrector.replace(node.parent.loc.selector, 'not_to')
           range = node.loc.dot.with(end_pos: node.loc.selector.end_pos)

data/lib/rubocop/cop/rspec/repeated_example.rb

@@ -16,36 +16,55 @@ module RuboCop
       #   end
       #
       class RepeatedExample < Base
-        MSG = "Don't repeat examples within an example group."
+        MSG = "Don't repeat examples within an example group. " \
+              'Repeated on line(s) %<lines>s.'
 
         def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
           return unless example_group?(node)
 
-          repeated_examples(node).each do |repeated_example|
-            add_offense(repeated_example)
+          find_repeated_examples(node).each do |repeated_examples|
+            add_offenses_for_repeated_group(repeated_examples)
           end
         end
 
         private
 
-        def repeated_examples(node)
-          RuboCop::RSpec::ExampleGroup.new(node)
-            .examples
-            .group_by { |example| example_signature(example) }
+        def find_repeated_examples(node)
+          examples = RuboCop::RSpec::ExampleGroup.new(node).examples
+
+          examples
+            .group_by { |example| build_example_signature(example) }
             .values
-            .reject(&:one?)
-            .flatten
-            .map(&:to_node)
+            .select { |group| group.size > 1 }
         end
 
-        def example_signature(example)
-          key_parts = [example.metadata, example.implementation]
-
+        def build_example_signature(example)
+          signature = [example.metadata, example.implementation]
           if example.definition.method?(:its)
-            key_parts << example.definition.arguments
+            signature << example.definition.arguments
+          end
+          signature
+        end
+
+        def add_offenses_for_repeated_group(repeated_examples)
+          repeated_examples.each do |example|
+            other_lines = extract_other_lines(repeated_examples, example)
+            add_offense(example.to_node, message: message(other_lines))
           end
+        end
+
+        def extract_other_lines(examples_group, current_example)
+          current_node = current_example.to_node
+
+          examples_group
+            .reject { |ex| ex.to_node.equal?(current_node) }
+            .map { |ex| ex.to_node.first_line }
+            .uniq
+            .sort
+        end
 
-          key_parts
+        def message(other_lines)
+          format(MSG, lines: other_lines.join(', '))
         end
       end
     end

data/lib/rubocop/cop/rspec/sort_metadata.rb

@@ -30,7 +30,7 @@ module RuboCop
 
         # @!method match_ambiguous_trailing_metadata?(node)
         def_node_matcher :match_ambiguous_trailing_metadata?, <<~PATTERN
-          (send _ _ _ ... !{hash sym str dstr xstr})
+          (send _ _ _ ... !{hash sym any_str})
         PATTERN
 
         def on_metadata(args, hash)

data/lib/rubocop/cop/rspec/spec_file_path_format.rb

@@ -32,6 +32,12 @@ module RuboCop
       #   # good
       #   whatever_spec.rb         # describe MyClass, type: :routing do; end
       #
+      # @example `EnforcedInflector: active_support`
+      #   # Enable to use ActiveSupport's inflector for custom acronyms
+      #   # like HTTP, etc. Set to "default" by default.
+      #   # Configure `InflectorPath` with the path to the inflector file.
+      #   # The default is ./config/initializers/inflections.rb.
+      #
       class SpecFilePathFormat < Base
         include TopLevelGroup
         include Namespace
@@ -59,6 +65,53 @@ module RuboCop
 
         private
 
+        # Inflector module that uses ActiveSupport for advanced inflection rules
+        module ActiveSupportInflector
+          def self.call(string)
+            ActiveSupport::Inflector.underscore(string)
+          end
+
+          def self.prepare_availability(config)
+            return if @prepared
+
+            @prepared = true
+
+            inflector_path = config.fetch('InflectorPath')
+
+            unless File.exist?(inflector_path)
+              raise "The configured `InflectorPath` #{inflector_path} does " \
+                    'not exist.'
+            end
+
+            require 'active_support/inflector'
+            require inflector_path
+          end
+        end
+
+        # Inflector module that uses basic regex-based conversion
+        module DefaultInflector
+          def self.call(string)
+            string
+              .gsub(/([^A-Z])([A-Z]+)/, '\1_\2')
+              .gsub(/([A-Z])([A-Z][^A-Z\d]+)/, '\1_\2')
+              .downcase
+          end
+        end
+
+        def inflector
+          case cop_config.fetch('EnforcedInflector')
+          when 'active_support'
+            ActiveSupportInflector.prepare_availability(cop_config)
+            ActiveSupportInflector
+          when 'default'
+            DefaultInflector
+          else
+            # :nocov:
+            :noop
+            # :nocov:
+          end
+        end
+
         def ensure_correct_file_path(send_node, class_name, arguments)
           pattern = correct_path_pattern(class_name, arguments)
           return if filename_ends_with?(pattern)
@@ -106,10 +159,7 @@ module RuboCop
         end
 
         def camel_to_snake_case(string)
-          string
-            .gsub(/([^A-Z])([A-Z]+)/, '\1_\2')
-            .gsub(/([A-Z])([A-Z][^A-Z\d]+)/, '\1_\2')
-            .downcase
+          inflector.call(string)
         end
 
         def custom_transform

data/lib/rubocop/cop/rspec/variable_definition.rb

@@ -60,16 +60,8 @@ module RuboCop
         end
 
         def style_offense?(variable)
-          (style == :symbols && string?(variable)) ||
-            (style == :strings && symbol?(variable))
-        end
-
-        def string?(node)
-          node.str_type?
-        end
-
-        def symbol?(node)
-          node.type?(:sym, :dsym)
+          (style == :symbols && variable.str_type?) ||
+            (style == :strings && variable.any_sym_type?)
         end
       end
     end

data/lib/rubocop/cop/rspec/verified_doubles.rb

@@ -10,12 +10,12 @@ module RuboCop
       # @example
       #   # bad
       #   let(:foo) do
-      #     double(method_name: 'returned value')
+      #     double("ClassName", method_name: 'returned value')
       #   end
       #
       #   # bad
       #   let(:foo) do
-      #     double("ClassName", method_name: 'returned value')
+      #     spy("ClassName", method_name: 'returned value')
       #   end
       #
       #   # good
@@ -23,6 +23,50 @@ module RuboCop
       #     instance_double("ClassName", method_name: 'returned value')
       #   end
       #
+      #   # good
+      #   let(:foo) do
+      #     class_double("ClassName", method_name: 'returned value')
+      #   end
+      #
+      #   # good
+      #   let(:foo) do
+      #     object_double("some object", method_name: 'returned value')
+      #   end
+      #
+      # @example `IgnoreNameless: true (default)`
+      #   # good
+      #   let(:foo) do
+      #     double(method_name: 'returned value')
+      #   end
+      #
+      #   # good
+      #   let(:foo) do
+      #     double
+      #   end
+      #
+      # @example `IgnoreNameless: false`
+      #   # bad
+      #   let(:foo) do
+      #     double(method_name: 'returned value')
+      #   end
+      #
+      #   # bad
+      #   let(:foo) do
+      #     double
+      #   end
+      #
+      # @example `IgnoreSymbolicNames: false (default)`
+      #   # bad
+      #   let(:foo) do
+      #     double(:foo)
+      #   end
+      #
+      # @example `IgnoreSymbolicNames: true`
+      #   # good
+      #   let(:foo) do
+      #     double(:foo)
+      #   end
+      #
       class VerifiedDoubles < Base
         MSG = 'Prefer using verifying doubles over normal doubles.'
         RESTRICT_ON_SEND = %i[double spy].freeze
@@ -34,7 +78,7 @@ module RuboCop
 
         def on_send(node)
           unverified_double(node) do |name, *_args|
-            return if name.nil? && cop_config['IgnoreNameless']
+            return if (name.nil? || hash?(name)) && cop_config['IgnoreNameless']
             return if symbol?(name) && cop_config['IgnoreSymbolicNames']
 
             add_offense(node)
@@ -46,6 +90,10 @@ module RuboCop
         def symbol?(name)
           name&.sym_type?
         end
+
+        def hash?(arg)
+          arg.hash_type?
+        end
       end
     end
   end

data/lib/rubocop/cop/rspec_cops.rb

@@ -57,6 +57,7 @@ require_relative 'rspec/it_behaves_like'
 require_relative 'rspec/iterated_expectation'
 require_relative 'rspec/leading_subject'
 require_relative 'rspec/leaky_constant_declaration'
+require_relative 'rspec/leaky_local_variable'
 require_relative 'rspec/let_before_examples'
 require_relative 'rspec/let_setup'
 require_relative 'rspec/match_array'

data/lib/rubocop/rspec/language.rb

@@ -72,6 +72,12 @@ module RuboCop
       # @!method subject?(node)
       def_node_matcher :subject?, '(block (send nil? #Subjects.all ...) ...)'
 
+      module ErrorMatchers # :nodoc:
+        def self.all(element)
+          Language.config['ErrorMatchers'].include?(element.to_s)
+        end
+      end
+
       module ExampleGroups # :nodoc:
         class << self
           def all(element)
@@ -200,14 +206,14 @@ module RuboCop
       # This is used in Dialect and DescribeClass cops to detect RSpec blocks.
       module ALL # :nodoc:
         def self.all(element)
-          [ExampleGroups, Examples, Expectations, Helpers, Hooks, Includes,
-           Runners, SharedGroups, Subjects]
+          [ErrorMatchers, ExampleGroups, Examples, Expectations, Helpers, Hooks,
+           Includes, Runners, SharedGroups, Subjects]
             .find { |concept| concept.all(element) }
         end
       end
 
-      private_constant :ExampleGroups, :Examples, :Expectations, :Hooks,
-                       :Includes, :Runners, :SharedGroups, :ALL
+      private_constant :ErrorMatchers, :ExampleGroups, :Examples, :Expectations,
+                       :Hooks, :Includes, :Runners, :SharedGroups, :ALL
     end
   end
 end

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '3.6.0'
+      STRING = '3.8.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 3.6.0
+  version: 3.8.0
 platform: ruby
 authors:
 - John Backus
@@ -31,20 +31,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.72'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.72.1
+        version: '1.81'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.72'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.72.1
+        version: '1.81'
 description: |
   Code style checking for RSpec files.
   A plugin for the RuboCop code style enforcing & linting tool.
@@ -123,6 +117,7 @@ files:
 - lib/rubocop/cop/rspec/iterated_expectation.rb
 - lib/rubocop/cop/rspec/leading_subject.rb
 - lib/rubocop/cop/rspec/leaky_constant_declaration.rb
+- lib/rubocop/cop/rspec/leaky_local_variable.rb
 - lib/rubocop/cop/rspec/let_before_examples.rb
 - lib/rubocop/cop/rspec/let_setup.rb
 - lib/rubocop/cop/rspec/match_array.rb
@@ -227,7 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Code style checking for RSpec files
 test_files: []