rubocop-rspec 2.31.0 → 3.0.1

data/lib/rubocop/cop/rspec/rails/http_status.rb

@@ -1,61 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module RSpec
-      module Rails
-        # @!parse
-        #   # Enforces use of symbolic or numeric value to describe HTTP status.
-        #   #
-        #   # This cop inspects only `have_http_status` calls.
-        #   # So, this cop does not check if a method starting with `be_*` is
-        #   # used when setting for `EnforcedStyle: symbolic` or
-        #   # `EnforcedStyle: numeric`.
-        #   #
-        #   # @example `EnforcedStyle: symbolic` (default)
-        #   #   # bad
-        #   #   it { is_expected.to have_http_status 200 }
-        #   #   it { is_expected.to have_http_status 404 }
-        #   #   it { is_expected.to have_http_status "403" }
-        #   #
-        #   #   # good
-        #   #   it { is_expected.to have_http_status :ok }
-        #   #   it { is_expected.to have_http_status :not_found }
-        #   #   it { is_expected.to have_http_status :forbidden }
-        #   #   it { is_expected.to have_http_status :success }
-        #   #   it { is_expected.to have_http_status :error }
-        #   #
-        #   # @example `EnforcedStyle: numeric`
-        #   #   # bad
-        #   #   it { is_expected.to have_http_status :ok }
-        #   #   it { is_expected.to have_http_status :not_found }
-        #   #   it { is_expected.to have_http_status "forbidden" }
-        #   #
-        #   #   # good
-        #   #   it { is_expected.to have_http_status 200 }
-        #   #   it { is_expected.to have_http_status 404 }
-        #   #   it { is_expected.to have_http_status 403 }
-        #   #   it { is_expected.to have_http_status :success }
-        #   #   it { is_expected.to have_http_status :error }
-        #   #
-        #   # @example `EnforcedStyle: be_status`
-        #   #   # bad
-        #   #   it { is_expected.to have_http_status :ok }
-        #   #   it { is_expected.to have_http_status :not_found }
-        #   #   it { is_expected.to have_http_status "forbidden" }
-        #   #   it { is_expected.to have_http_status 200 }
-        #   #   it { is_expected.to have_http_status 404 }
-        #   #   it { is_expected.to have_http_status "403" }
-        #   #
-        #   #   # good
-        #   #   it { is_expected.to be_ok }
-        #   #   it { is_expected.to be_not_found }
-        #   #   it { is_expected.to have_http_status :success }
-        #   #   it { is_expected.to have_http_status :error }
-        #   #
-        #   class HttpStatus < RuboCop::Cop::RSpec::Base; end
-        HttpStatus = ::RuboCop::Cop::RSpecRails::HttpStatus
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec/rails/inferred_spec_type.rb

@@ -1,62 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module RSpec
-      module Rails
-        # @!parse
-        #   # Identifies redundant spec type.
-        #   #
-        #   # After setting up rspec-rails, you will have enabled
-        #   # `config.infer_spec_type_from_file_location!` by default in
-        #   # spec/rails_helper.rb. This cop works in conjunction with
-        #   # this config.
-        #   # If you disable this config, disable this cop as well.
-        #   #
-        #   # @safety
-        #   #   This cop is marked as unsafe because
-        #   #   `config.infer_spec_type_from_file_location!` may not be enabled.
-        #   #
-        #   # @example
-        #   #   # bad
-        #   #   # spec/models/user_spec.rb
-        #   #   RSpec.describe User, type: :model do
-        #   #   end
-        #   #
-        #   #   # good
-        #   #   # spec/models/user_spec.rb
-        #   #   RSpec.describe User do
-        #   #   end
-        #   #
-        #   #   # good
-        #   #   # spec/models/user_spec.rb
-        #   #   RSpec.describe User, type: :common do
-        #   #   end
-        #   #
-        #   # @example `Inferences` configuration
-        #   #   # .rubocop.yml
-        #   #   # RSpec/Rails/InferredSpecType:
-        #   #   #   Inferences:
-        #   #   #     services: service
-        #   #
-        #   #   # bad
-        #   #   # spec/services/user_spec.rb
-        #   #   RSpec.describe User, type: :service do
-        #   #   end
-        #   #
-        #   #   # good
-        #   #   # spec/services/user_spec.rb
-        #   #   RSpec.describe User do
-        #   #   end
-        #   #
-        #   #   # good
-        #   #   # spec/services/user_spec.rb
-        #   #   RSpec.describe User, type: :common do
-        #   #   end
-        #   #
-        #   class InferredSpecType < RuboCop::Cop::RSpec::Base; end
-        InferredSpecType = ::RuboCop::Cop::RSpecRails::InferredSpecType
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec/rails/minitest_assertions.rb

@@ -1,39 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module RSpec
-      module Rails
-        # @!parse
-        #   # Check if using Minitest-like matchers.
-        #   #
-        #   # Check the use of minitest-like matchers
-        #   # starting with `assert_` or `refute_`.
-        #   #
-        #   # @example
-        #   #   # bad
-        #   #   assert_equal(a, b)
-        #   #   assert_equal a, b, "must be equal"
-        #   #   assert_not_includes a, b
-        #   #   refute_equal(a, b)
-        #   #   assert_nil a
-        #   #   refute_empty(b)
-        #   #   assert_true(a)
-        #   #   assert_false(a)
-        #   #
-        #   #   # good
-        #   #   expect(b).to eq(a)
-        #   #   expect(b).to(eq(a), "must be equal")
-        #   #   expect(a).not_to include(b)
-        #   #   expect(b).not_to eq(a)
-        #   #   expect(a).to eq(nil)
-        #   #   expect(a).not_to be_empty
-        #   #   expect(a).to be(true)
-        #   #   expect(a).to be(false)
-        #   #
-        #   class MinitestAssertions < RuboCop::Cop::RSpec::Base; end
-        MinitestAssertions = ::RuboCop::Cop::RSpecRails::MinitestAssertions
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec/rails/negation_be_valid.rb

@@ -1,39 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module RSpec
-      module Rails
-        # @!parse
-        #   # Enforces use of `be_invalid` or `not_to` for negated be_valid.
-        #   #
-        #   # @safety
-        #   #   This cop is unsafe because it cannot guarantee that
-        #   #   the test target is an instance of `ActiveModel::Validations``.
-        #   #
-        #   # @example EnforcedStyle: not_to (default)
-        #   #   # bad
-        #   #   expect(foo).to be_invalid
-        #   #
-        #   #   # good
-        #   #   expect(foo).not_to be_valid
-        #   #
-        #   #   # good (with method chain)
-        #   #   expect(foo).to be_invalid.and be_odd
-        #   #
-        #   # @example EnforcedStyle: be_invalid
-        #   #   # bad
-        #   #   expect(foo).not_to be_valid
-        #   #
-        #   #   # good
-        #   #   expect(foo).to be_invalid
-        #   #
-        #   #   # good (with method chain)
-        #   #   expect(foo).to be_invalid.or be_even
-        #   #
-        #   class NegationBeValid < RuboCop::Cop::RSpec::Base; end
-        NegationBeValid = ::RuboCop::Cop::RSpecRails::NegationBeValid
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec/rails/travel_around.rb

@@ -1,34 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module RSpec
-      module Rails
-        # @!parse
-        #   # Prefer to travel in `before` rather than `around`.
-        #   #
-        #   # @safety
-        #   #   This cop is unsafe because the automatic `travel_back` is only
-        #   #   run on test cases that are considered as Rails related.
-        #   #
-        #   #   And also, this cop's autocorrection is unsafe because the order
-        #   #   of execution will change if other steps exist before traveling
-        #   #   in `around`.
-        #   #
-        #   # @example
-        #   #   # bad
-        #   #   around do |example|
-        #   #     freeze_time do
-        #   #       example.run
-        #   #     end
-        #   #   end
-        #   #
-        #   #   # good
-        #   #   before { freeze_time }
-        #   #
-        #   class TravelAround < RuboCop::Cop::RSpec::Base; end
-        TravelAround = ::RuboCop::Cop::RSpecRails::TravelAround
-      end
-    end
-  end
-end

data/lib/rubocop/rspec/language/node_pattern.rb

@@ -1,48 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module RSpec
-    module Language
-      # Helper methods to detect RSpec DSL used with send and block
-      # @deprecated Prefer using Node Pattern directly
-      #   Use `'(block (send nil? #Example.all ...) ...)'` instead of
-      #   `block_pattern('#Example.all')`
-      module NodePattern
-        # @deprecated Prefer using Node Pattern directly
-        def send_pattern(string)
-          deprecation_warning __method__
-          "(send #rspec? #{string} ...)"
-        end
-
-        # @deprecated Prefer using Node Pattern directly
-        def block_pattern(string)
-          deprecation_warning __method__
-          "(block #{send_pattern(string)} ...)"
-        end
-
-        # @deprecated Prefer using Node Pattern directly
-        def numblock_pattern(string)
-          deprecation_warning __method__
-          "(numblock #{send_pattern(string)} ...)"
-        end
-
-        # @deprecated Prefer using Node Pattern directly
-        def block_or_numblock_pattern(string)
-          deprecation_warning __method__
-          "{#{block_pattern(string)} #{numblock_pattern(string)}}"
-        end
-
-        private
-
-        def deprecation_warning(method)
-          # Only warn in derived extensions' specs
-          return unless defined?(::RSpec)
-
-          Kernel.warn <<~MESSAGE, uplevel: 2
-            Usage of #{method} is deprecated. Use node pattern explicitly.
-          MESSAGE
-        end
-      end
-    end
-  end
-end