rubocop-rspec 2.21.0 → 3.0.1

data/lib/rubocop/cop/rspec/rails/minitest_assertions.rb

@@ -1,60 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module RSpec
-      module Rails
-        # Check if using Minitest matchers.
-        #
-        # @example
-        #   # bad
-        #   assert_equal(a, b)
-        #   assert_equal a, b, "must be equal"
-        #   refute_equal(a, b)
-        #
-        #   # good
-        #   expect(b).to eq(a)
-        #   expect(b).to(eq(a), "must be equal")
-        #   expect(b).not_to eq(a)
-        #
-        class MinitestAssertions < Base
-          extend AutoCorrector
-
-          MSG = 'Use `%<prefer>s`.'
-          RESTRICT_ON_SEND = %i[assert_equal refute_equal].freeze
-
-          # @!method minitest_assertion(node)
-          def_node_matcher :minitest_assertion, <<-PATTERN
-          (send nil? {:assert_equal :refute_equal} $_ $_ $_?)
-          PATTERN
-
-          def on_send(node)
-            minitest_assertion(node) do |expected, actual, failure_message|
-              prefer = replacement(node, expected, actual,
-                                   failure_message.first)
-              add_offense(node, message: message(prefer)) do |corrector|
-                corrector.replace(node, prefer)
-              end
-            end
-          end
-
-          private
-
-          def replacement(node, expected, actual, failure_message)
-            runner = node.method?(:assert_equal) ? 'to' : 'not_to'
-            if failure_message.nil?
-              "expect(#{actual.source}).#{runner} eq(#{expected.source})"
-            else
-              "expect(#{actual.source}).#{runner}(eq(#{expected.source}), " \
-                "#{failure_message.source})"
-            end
-          end
-
-          def message(prefer)
-            format(MSG, prefer: prefer)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec/rails/travel_around.rb

@@ -1,92 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module RSpec
-      module Rails
-        # Prefer to travel in `before` rather than `around`.
-        #
-        # @safety
-        #   This cop is unsafe because the automatic `travel_back` is only run
-        #   on test cases that are considered as Rails related.
-        #
-        #   And also, this cop's autocorrection is unsafe because the order of
-        #   execution will change if other steps exist before traveling in
-        #   `around`.
-        #
-        # @example
-        #   # bad
-        #   around do |example|
-        #     freeze_time do
-        #       example.run
-        #     end
-        #   end
-        #
-        #   # good
-        #   before { freeze_time }
-        class TravelAround < Base
-          extend AutoCorrector
-
-          MSG = 'Prefer to travel in `before` rather than `around`.'
-
-          TRAVEL_METHOD_NAMES = %i[
-            freeze_time
-            travel
-            travel_to
-          ].to_set.freeze
-
-          # @!method extract_run_in_travel(node)
-          def_node_matcher :extract_run_in_travel, <<~PATTERN
-            (block
-              $(send nil? TRAVEL_METHOD_NAMES ...)
-              (args ...)
-              (send _ :run)
-            )
-          PATTERN
-
-          # @!method match_around_each?(node)
-          def_node_matcher :match_around_each?, <<~PATTERN
-            (block
-              (send _ :around (sym :each)?)
-              ...
-            )
-          PATTERN
-
-          def on_block(node)
-            run_node = extract_run_in_travel(node)
-            return unless run_node
-
-            around_node = extract_surrounding_around_block(run_node)
-            return unless around_node
-
-            add_offense(node) do |corrector|
-              autocorrect(corrector, node, run_node, around_node)
-            end
-          end
-          alias on_numblock on_block
-
-          private
-
-          def autocorrect(corrector, node, run_node, around_node)
-            corrector.replace(
-              node,
-              node.body.source
-            )
-            corrector.insert_before(
-              around_node,
-              "before { #{run_node.source} }\n\n"
-            )
-          end
-
-          # @param node [RuboCop::AST::BlockNode]
-          # @return [RuboCop::AST::BlockNode, nil]
-          def extract_surrounding_around_block(node)
-            node.each_ancestor(:block).find do |ancestor|
-              match_around_each?(ancestor)
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/rspec/factory_bot/language.rb

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module RSpec
-    module FactoryBot
-      # Contains node matchers for common FactoryBot DSL.
-      module Language
-        extend RuboCop::NodePattern::Macros
-
-        METHODS = %i[
-          attributes_for
-          attributes_for_list
-          attributes_for_pair
-          build
-          build_list
-          build_pair
-          build_stubbed
-          build_stubbed_list
-          build_stubbed_pair
-          create
-          create_list
-          create_pair
-          generate
-          generate_list
-          null
-          null_list
-          null_pair
-        ].to_set.freeze
-
-        # @!method factory_bot?(node)
-        def_node_matcher :factory_bot?, <<~PATTERN
-          (const {nil? cbase} {:FactoryGirl :FactoryBot})
-        PATTERN
-      end
-    end
-  end
-end

data/lib/rubocop/rspec/factory_bot.rb

@@ -1,64 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module RSpec
-    # RuboCop FactoryBot project namespace
-    module FactoryBot
-      ATTRIBUTE_DEFINING_METHODS = %i[
-        factory
-        ignore
-        trait
-        traits_for_enum
-        transient
-      ].freeze
-
-      UNPROXIED_METHODS = %i[
-        __send__
-        __id__
-        nil?
-        send
-        object_id
-        extend
-        instance_eval
-        initialize
-        block_given?
-        raise
-        caller
-        method
-      ].freeze
-
-      DEFINITION_PROXY_METHODS = %i[
-        add_attribute
-        after
-        association
-        before
-        callback
-        ignore
-        initialize_with
-        sequence
-        skip_create
-        to_create
-      ].freeze
-
-      RESERVED_METHODS =
-        DEFINITION_PROXY_METHODS +
-        UNPROXIED_METHODS +
-        ATTRIBUTE_DEFINING_METHODS
-
-      private_constant(
-        :ATTRIBUTE_DEFINING_METHODS,
-        :UNPROXIED_METHODS,
-        :DEFINITION_PROXY_METHODS,
-        :RESERVED_METHODS
-      )
-
-      def self.attribute_defining_methods
-        ATTRIBUTE_DEFINING_METHODS
-      end
-
-      def self.reserved_methods
-        RESERVED_METHODS
-      end
-    end
-  end
-end

data/lib/rubocop/rspec/language/node_pattern.rb

@@ -1,48 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module RSpec
-    module Language
-      # Helper methods to detect RSpec DSL used with send and block
-      # @deprecated Prefer using Node Pattern directly
-      #   Use `'(block (send nil? #Example.all ...) ...)'` instead of
-      #   `block_pattern('#Example.all')`
-      module NodePattern
-        # @deprecated Prefer using Node Pattern directly
-        def send_pattern(string)
-          deprecation_warning __method__
-          "(send #rspec? #{string} ...)"
-        end
-
-        # @deprecated Prefer using Node Pattern directly
-        def block_pattern(string)
-          deprecation_warning __method__
-          "(block #{send_pattern(string)} ...)"
-        end
-
-        # @deprecated Prefer using Node Pattern directly
-        def numblock_pattern(string)
-          deprecation_warning __method__
-          "(numblock #{send_pattern(string)} ...)"
-        end
-
-        # @deprecated Prefer using Node Pattern directly
-        def block_or_numblock_pattern(string)
-          deprecation_warning __method__
-          "{#{block_pattern(string)} #{numblock_pattern(string)}}"
-        end
-
-        private
-
-        def deprecation_warning(method)
-          # Only warn in derived extensions' specs
-          return unless defined?(::RSpec)
-
-          Kernel.warn <<~MESSAGE, uplevel: 2
-            Usage of #{method} is deprecated. Use node pattern explicitly.
-          MESSAGE
-        end
-      end
-    end
-  end
-end