rubocop-rspec 2.18.1 → 2.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b2ef643f2d262910bba4db8e0e6a722b96d0cb6424d04d4261326155176f321
-  data.tar.gz: 29ae9b634075bd3dc11d44969fb00a7542aad3302f3a1aa360a2637e3875a3bc
+  metadata.gz: 1ebfcc955ecfa8b3437defde668d955020f03a2dbba2c9337f0b75a8fb9a3c26
+  data.tar.gz: 7a547b1e24c278de072b2c912be27e1dc5fb1450b6fa65d563278d0f054d6d1d
 SHA512:
-  metadata.gz: b14f91843dcbc6cd8abfca82a8f21244991aacb79d09a92e975c1eb6d36e554adc44bd1d8b14d2d014fed60b6383f1e102f5142c4a771532be1b60db47c01df1
-  data.tar.gz: 0626b43df05da5b5f386d18be195d2aaa14347a7f70cd99d2d1731e9f9107536c8a0076897b78d9f2f4e69cdeb2a79bc0caaab488a6bee822ea08add9b083fe9
+  metadata.gz: f8942cdf262718de32bfbc765e3f2aac9eae49e364d7a2d866300b77e0bd39fd24b168d513577a1a95a82ce10a0f325a66c6b2914da71dd3951011c2399b0b3e
+  data.tar.gz: 89c8fce01b42c53c50460b9411cd44f96b99663ce3a2e7735e6cb0f260c1cc3a86ba0daba553b4ebeba25625dde25f41d8b2129929cf92514e06e0f0f8191ec5

data/CHANGELOG.md

@@ -2,6 +2,38 @@
 
 ## Master (Unreleased)
 
+## 2.20.0 (2023-04-18)
+
+- Add new `RSpec/IndexedLet` cop. ([@dmitrytsepelev])
+- Add new `RSpec/BeEmpty` cop. ([@ydah], [@bquorning])
+- Add autocorrect support for `RSpec/ScatteredSetup`. ([@ydah])
+- Add support `be_status` style for `RSpec/Rails/HttpStatus`. ([@ydah])
+- Add support for shared example groups to `RSpec/EmptyLineAfterExampleGroup`. ([@pirj])
+- Add support for `RSpec/HaveHttpStatus` when using `response.code`. ([@ydah])
+- Fix order of expected and actual in correction for `RSpec/Rails/MinitestAssertions` ([@mvz])
+- Fix a false positive for `RSpec/DescribedClassModuleWrapping` when RSpec.describe numblock is nested within a module. ([@ydah])
+- Fix a false positive for `RSpec/FactoryBot/ConsistentParenthesesStyle` inside `&&`, `||` and `:?` when `omit_parentheses` is on ([@dmitrytsepelev])
+- Fix a false positive for `RSpec/PendingWithoutReason` when pending/skip has a reason inside an example group. ([@ydah])
+- Fix a false negative for `RSpec/RedundantAround` when redundant numblock `around`. ([@ydah])
+- Change `RSpec/ContainExactly` to ignore calls with no arguments, and change `RSpec/MatchArray` to ignore calls with an empty array literal argument. ([@ydah], [@bquorning])
+- Make `RSpec/MatchArray` and `RSpec/ContainExactly` pending. ([@ydah])
+
+## 2.19.0 (2023-03-06)
+
+- Fix a false positive for `RSpec/ContextWording` when context is interpolated string literal or execute string. ([@ydah])
+- Fix a false positive for `RSpec/DescribeMethod` when multi-line describe without `#` and `.` at the beginning. ([@ydah], [@pirj])
+- Fix a false positive for `RSpec/VariableName` when inside non-spec code. ([@ydah])
+- Fix a false positive for `RSpec/VariableDefinition` when inside non-spec code. ([@ydah])
+- Add new `RSpec/PendingBlockInsideExample` cop. ([@ydah])
+- Add `RSpec/RedundantAround` cop. ([@r7kamura])
+- Add `RSpec/Rails/TravelAround` cop. ([@r7kamura])
+- Add `RSpec/ContainExactly` and `RSpec/MatchArray` cops. ([@faucct])
+- Fix a false positive for `RSpec/PendingWithoutReason` when not inside example and pending/skip with block. ([@ydah], [@pirj])
+- Fix a false positive for `RSpec/PendingWithoutReason` when `skip` is passed a block inside example. ([@ydah], [@pirj])
+- Rename `RSpec/PendingBlockInsideExample` cop to `RSpec/SkipBlockInsideExample`. ([@pirj])
+- Deprecate `send_pattern`/`block_pattern`/`numblock_pattern` helpers in favour of using node pattern explicitly. ([@pirj], [@ydah])
+- Fix an incorrect autocorrect for `RSpec/VerifiedDoubleReference` when namespaced class. ([@ydah])
+
 ## 2.18.1 (2023-01-19)
 
 - Add `rubocop-capybara` version constraint to prevent sudden cop enabling when it hits 3.0. ([@pirj])
@@ -313,7 +345,7 @@
 ## 1.37.0 (2019-11-25)
 
 - Implement `RSpec/DescribedClassModuleWrapping` to disallow RSpec statements within a module. ([@kellysutton])
-- Fix documentation rake task to support Rubocop 0.75. ([@nickcampbell18])
+- Fix documentation rake task to support RuboCop 0.75. ([@nickcampbell18])
 - Fix `RSpec/SubjectStub` to detect implicit subjects stubbed. ([@QQism])
 - Fix `RSpec/Pending` not flagging `skip` with string values. ([@pirj])
 - Add `AllowedExplicitMatchers` config option for `RSpec/PredicateMatcher`. ([@mkrawc])
@@ -644,7 +676,7 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 - Skip `DescribeClass` cop for view specs. ([@andyw8])
 - Skip `FilePath` cop for Rails routing specs. ([@andyw8])
 - Add cop to check for focused specs. ([@renanborgescampos], [@jaredmoody])
-- Clean-up `RSpec::NotToNot` to use same configuration semantics as other Rubocop cops, add autocorrect support for `RSpec::NotToNot`. ([@baberthal])
+- Clean-up `RSpec::NotToNot` to use same configuration semantics as other RuboCop cops, add autocorrect support for `RSpec::NotToNot`. ([@baberthal])
 - Update to rubocop 0.40.0. ([@nijikon])
 
 ## 1.4.1 (2016-04-03)
@@ -742,6 +774,7 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@dduugg]: https://github.com/dduugg
 [@deivid-rodriguez]: https://github.com/deivid-rodriguez
 [@dgollahon]: https://github.com/dgollahon
+[@dmitrytsepelev]: https://github.com/dmitrytsepelev
 [@drowze]: https://github.com/Drowze
 [@dswij]: https://github.com/dswij
 [@dvandersluis]: https://github.com/dvandersluis
@@ -751,6 +784,7 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@elebow]: https://github.com/elebow
 [@elisefitz15]: https://github.com/EliseFitz15
 [@elliterate]: https://github.com/elliterate
+[@faucct]: https://github.com/faucct
 [@foton]: https://github.com/foton
 [@francois-ferrandis]: https://github.com/francois-ferrandis
 [@g-rath]: https://github.com/G-Rath
@@ -783,6 +817,7 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@mlarraz]: https://github.com/mlarraz
 [@mockdeep]: https://github.com/mockdeep
 [@mothonmars]: https://github.com/MothOnMars
+[@mvz]: https://github.com/mvz
 [@nc-holodakg]: https://github.com/nc-holodakg
 [@nevir]: https://github.com/nevir
 [@ngouy]: https://github.com/ngouy

data/README.md

@@ -4,7 +4,7 @@
 [![Gem Version](https://badge.fury.io/rb/rubocop-rspec.svg)](https://rubygems.org/gems/rubocop-rspec)
 ![CI](https://github.com/rubocop/rubocop-rspec/workflows/CI/badge.svg)
 
-RSpec-specific analysis for your projects, as an extension to
+[RSpec](https://rspec.info/)-specific analysis for your projects, as an extension to
 [RuboCop](https://github.com/rubocop/rubocop).
 
 ## Installation

data/config/default.yml

@@ -144,6 +144,12 @@ RSpec/Be:
   StyleGuide: https://rspec.rubystyle.guide/#be-matcher
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Be
 
+RSpec/BeEmpty:
+  Description: Prefer using `be_empty` when checking for an empty array.
+  Enabled: pending
+  VersionAdded: '2.20'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeEmpty
+
 RSpec/BeEq:
   Description: Check for expectations where `be(...)` can replace `eq(...)`.
   Enabled: pending
@@ -201,6 +207,12 @@ RSpec/ClassCheck:
     - be_kind_of
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ClassCheck
 
+RSpec/ContainExactly:
+  Description: Checks where `contain_exactly` is used.
+  Enabled: pending
+  VersionAdded: '2.19'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ContainExactly
+
 RSpec/ContextMethod:
   Description: "`context` should not be used for specifying methods."
   Enabled: true
@@ -497,6 +509,13 @@ RSpec/ImplicitSubject:
   VersionChanged: '2.13'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ImplicitSubject
 
+RSpec/IndexedLet:
+  Description: Do not set up test data using indexes (e.g., `item_1`, `item_2`).
+  Enabled: pending
+  VersionAdded: '2.20'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IndexedLet
+  Max: 1
+
 RSpec/InstanceSpy:
   Description: Checks for `instance_double` used with `have_received`.
   Enabled: true
@@ -556,6 +575,12 @@ RSpec/LetSetup:
   VersionAdded: '1.7'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetSetup
 
+RSpec/MatchArray:
+  Description: Checks where `match_array` is used.
+  Enabled: pending
+  VersionAdded: '2.19'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MatchArray
+
 RSpec/MessageChain:
   Description: Check that chains of messages are not being stubbed.
   Enabled: true
@@ -706,6 +731,12 @@ RSpec/ReceiveNever:
   VersionAdded: '1.28'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ReceiveNever
 
+RSpec/RedundantAround:
+  Description: Remove redundant `around` hook.
+  Enabled: pending
+  VersionAdded: '2.19'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RedundantAround
+
 RSpec/RepeatedDescription:
   Description: Check for repeated description strings in example groups.
   Enabled: true
@@ -779,6 +810,12 @@ RSpec/SingleArgumentMessageChain:
   VersionChanged: '1.10'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/SingleArgumentMessageChain
 
+RSpec/SkipBlockInsideExample:
+  Description: Checks for passing a block to `skip` within examples.
+  Enabled: pending
+  VersionAdded: '2.19'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/SkipBlockInsideExample
+
 RSpec/SortMetadata:
   Description: Sort RSpec metadata alphabetically.
   Enabled: pending
@@ -1024,8 +1061,9 @@ RSpec/Rails/HttpStatus:
   SupportedStyles:
     - numeric
     - symbolic
+    - be_status
   VersionAdded: '1.23'
-  VersionChanged: '2.0'
+  VersionChanged: '2.20'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus
 
 RSpec/Rails/InferredSpecType:
@@ -1056,3 +1094,10 @@ RSpec/Rails/MinitestAssertions:
   Enabled: pending
   VersionAdded: '2.17'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/MinitestAssertions
+
+RSpec/Rails/TravelAround:
+  Description: Prefer to travel in `before` rather than `around`.
+  Enabled: pending
+  Safe: false
+  VersionAdded: '2.19'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/TravelAround

data/lib/rubocop/cop/rspec/be_empty.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Prefer using `be_empty` when checking for an empty array.
+      #
+      # @example
+      #   # bad
+      #   expect(array).to contain_exactly
+      #   expect(array).to match_array([])
+      #
+      #   # good
+      #   expect(array).to be_empty
+      #
+      class BeEmpty < Base
+        extend AutoCorrector
+
+        MSG = 'Use `be_empty` matchers for checking an empty array.'
+        RESTRICT_ON_SEND = %i[contain_exactly match_array].freeze
+
+        # @!method expect_array_matcher?(node)
+        def_node_matcher :expect_array_matcher?, <<~PATTERN
+          (send
+            (send nil? :expect _)
+            #Runners.all
+            ${
+              (send nil? :match_array (array))
+              (send nil? :contain_exactly)
+            }
+          )
+        PATTERN
+
+        def on_send(node)
+          expect_array_matcher?(node.parent) do |expect|
+            add_offense(expect) do |corrector|
+              corrector.replace(expect, 'be_empty')
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/be_nil.rb

@@ -57,7 +57,7 @@ module RuboCop
           return unless be_nil_matcher?(node)
 
           add_offense(node, message: BE_MSG) do |corrector|
-            corrector.replace(node.loc.expression, 'be(nil)')
+            corrector.replace(node, 'be(nil)')
           end
         end
 
@@ -65,7 +65,7 @@ module RuboCop
           return unless nil_value_expectation?(node)
 
           add_offense(node, message: BE_NIL_MSG) do |corrector|
-            corrector.replace(node.loc.expression, 'be_nil')
+            corrector.replace(node, 'be_nil')
           end
         end
       end

data/lib/rubocop/cop/rspec/change_by_zero.rb

@@ -99,7 +99,7 @@ module RuboCop
         private
 
         def check_offense(node)
-          expression = node.loc.expression
+          expression = node.source_range
           if compound_expectations?(node)
             add_offense(expression, message: message_compound) do |corrector|
               autocorrect_compound(corrector, node)
@@ -117,7 +117,7 @@ module RuboCop
 
         def autocorrect(corrector, node)
           corrector.replace(node.parent.loc.selector, 'not_to')
-          range = node.loc.dot.with(end_pos: node.loc.expression.end_pos)
+          range = node.loc.dot.with(end_pos: node.source_range.end_pos)
           corrector.remove(range)
         end
 
@@ -126,7 +126,7 @@ module RuboCop
 
           change_nodes(node) do |change_node|
             corrector.replace(change_node.loc.selector, negated_matcher)
-            range = node.loc.dot.with(end_pos: node.loc.expression.end_pos)
+            range = node.loc.dot.with(end_pos: node.source_range.end_pos)
             corrector.remove(range)
           end
         end

data/lib/rubocop/cop/rspec/contain_exactly.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks where `contain_exactly` is used.
+      #
+      # This cop checks for the following:
+      # - Prefer `match_array` when matching array values.
+      # - Prefer `be_empty` when using `contain_exactly` with no arguments.
+      #
+      # @example
+      #   # bad
+      #   it { is_expected.to contain_exactly(*array1, *array2) }
+      #
+      #   # good
+      #   it { is_expected.to match_array(array1 + array2) }
+      #
+      #   # good
+      #   it { is_expected.to contain_exactly(content, *array) }
+      #
+      class ContainExactly < Base
+        extend AutoCorrector
+
+        MSG = 'Prefer `match_array` when matching array values.'
+        RESTRICT_ON_SEND = %i[contain_exactly].freeze
+
+        def on_send(node)
+          return if node.arguments.empty?
+
+          check_populated_collection(node)
+        end
+
+        private
+
+        def check_populated_collection(node)
+          return unless node.each_child_node.all?(&:splat_type?)
+
+          add_offense(node) do |corrector|
+            autocorrect_for_populated_array(node, corrector)
+          end
+        end
+
+        def autocorrect_for_populated_array(node, corrector)
+          arrays = node.arguments.map do |splat_node|
+            splat_node.children.first
+          end
+          corrector.replace(
+            node,
+            "match_array(#{arrays.map(&:source).join(' + ')})"
+          )
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/context_wording.rb

@@ -62,12 +62,12 @@ module RuboCop
 
         # @!method context_wording(node)
         def_node_matcher :context_wording, <<-PATTERN
-          (block (send #rspec? { :context :shared_context } $(str $_) ...) ...)
+          (block (send #rspec? { :context :shared_context } $({str dstr xstr} ...) ...) ...)
         PATTERN
 
         def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
-          context_wording(node) do |context, description|
-            if bad_pattern?(description)
+          context_wording(node) do |context|
+            if bad_pattern?(context)
               message = format(MSG, patterns: expect_patterns)
               add_offense(context, message: message)
             end
@@ -84,10 +84,18 @@ module RuboCop
           @prefix_regexes ||= prefixes.map { |pre| /^#{Regexp.escape(pre)}\b/ }
         end
 
-        def bad_pattern?(description)
+        def bad_pattern?(node)
           return false if allowed_patterns.empty?
 
-          !matches_allowed_pattern?(description)
+          !matches_allowed_pattern?(description(node))
+        end
+
+        def description(context)
+          if context.xstr_type?
+            context.value.value
+          else
+            context.value
+          end
         end
 
         def expect_patterns

data/lib/rubocop/cop/rspec/describe_method.rb

@@ -23,20 +23,28 @@ module RuboCop
         MSG = 'The second argument to describe should be the method ' \
               "being tested. '#instance' or '.class'."
 
-        # @!method second_argument(node)
-        def_node_matcher :second_argument, <<~PATTERN
+        # @!method second_string_literal_argument(node)
+        def_node_matcher :second_string_literal_argument, <<~PATTERN
           (block
-            (send #rspec? :describe _first_argument $(str _) ...) ...
-          )
+            (send #rspec? :describe _first_argument ${str dstr} ...)
+          ...)
+        PATTERN
+
+        # @!method method_name?(node)
+        def_node_matcher :method_name?, <<~PATTERN
+          {(str #method_name_prefix?) (dstr (str #method_name_prefix?) ...)}
         PATTERN
 
         def on_top_level_group(node)
-          second_argument = second_argument(node)
+          second_string_literal_argument(node) do |argument|
+            add_offense(argument) unless method_name?(argument)
+          end
+        end
 
-          return unless second_argument
-          return if second_argument.str_content.start_with?('#', '.')
+        private
 
-          add_offense(second_argument)
+        def method_name_prefix?(description)
+          description.start_with?('.', '#')
         end
       end
     end

data/lib/rubocop/cop/rspec/described_class.rb

@@ -68,7 +68,8 @@ module RuboCop
         PATTERN
 
         # @!method rspec_block?(node)
-        def_node_matcher :rspec_block?, block_pattern('#ALL.all')
+        def_node_matcher :rspec_block?,
+                         '({block numblock} (send #rspec? #ALL.all ...) ...)'
 
         # @!method scope_changing_syntax?(node)
         def_node_matcher :scope_changing_syntax?, '{def class module}'

data/lib/rubocop/cop/rspec/described_class_module_wrapping.rb

@@ -22,13 +22,15 @@ module RuboCop
       class DescribedClassModuleWrapping < Base
         MSG = 'Avoid opening modules and defining specs within them.'
 
-        # @!method find_rspec_blocks(node)
-        def_node_search :find_rspec_blocks, block_pattern('#ExampleGroups.all')
+        # @!method include_rspec_blocks?(node)
+        def_node_search :include_rspec_blocks?, <<~PATTERN
+          ({block numblock} (send #explicit_rspec? #ExampleGroups.all ...) ...)
+        PATTERN
 
         def on_module(node)
-          find_rspec_blocks(node) do
-            add_offense(node)
-          end
+          return unless include_rspec_blocks?(node)
+
+          add_offense(node)
         end
       end
     end

data/lib/rubocop/cop/rspec/dialect.rb

@@ -49,7 +49,7 @@ module RuboCop
         MSG = 'Prefer `%<prefer>s` over `%<current>s`.'
 
         # @!method rspec_method?(node)
-        def_node_matcher :rspec_method?, send_pattern('#ALL.all')
+        def_node_matcher :rspec_method?, '(send #rspec? #ALL.all ...)'
 
         def on_send(node)
           return unless rspec_method?(node)

data/lib/rubocop/cop/rspec/duplicated_metadata.rb

@@ -39,7 +39,7 @@ module RuboCop
           corrector.remove(
             range_with_surrounding_comma(
               range_with_surrounding_space(
-                node.location.expression,
+                node.source_range,
                 side: :left
               ),
               :left

data/lib/rubocop/cop/rspec/empty_example_group.rb

@@ -53,7 +53,7 @@ module RuboCop
         #   @param node [RuboCop::AST::Node]
         #   @yield [RuboCop::AST::Node] example group body
         def_node_matcher :example_group_body, <<~PATTERN
-          (block #{send_pattern('#ExampleGroups.all')} args $_)
+          (block (send #rspec? #ExampleGroups.all ...) args $_)
         PATTERN
 
         # @!method example_or_group_or_include?(node)
@@ -72,10 +72,10 @@ module RuboCop
         #   @return [Array<RuboCop::AST::Node>] matching nodes
         def_node_matcher :example_or_group_or_include?, <<~PATTERN
           {
-            #{block_pattern(
-              '{#Examples.all #ExampleGroups.all #Includes.all}'
-            )}
-            #{send_pattern('{#Examples.all #Includes.all}')}
+            (block
+              (send #rspec? {#Examples.all #ExampleGroups.all #Includes.all} ...)
+            ...)
+            (send nil? {#Examples.all #Includes.all} ...)
           }
         PATTERN
 
@@ -95,7 +95,7 @@ module RuboCop
         #   @param node [RuboCop::AST::Node]
         #   @return [Array<RuboCop::AST::Node>] matching nodes
         def_node_matcher :examples_inside_block?, <<~PATTERN
-          (block !#{send_pattern('#Hooks.all')} _ #examples?)
+          (block !(send nil? #Hooks.all ...) _ #examples?)
         PATTERN
 
         # @!method examples_directly_or_in_block?(node)
@@ -174,7 +174,7 @@ module RuboCop
 
         def removed_range(node)
           range_by_whole_lines(
-            node.location.expression,
+            node.source_range,
             include_final_newline: true
           )
         end

data/lib/rubocop/cop/rspec/empty_hook.rb

@@ -31,14 +31,14 @@ module RuboCop
 
         # @!method empty_hook?(node)
         def_node_matcher :empty_hook?, <<~PATTERN
-          (block $#{send_pattern('#Hooks.all')} _ nil?)
+          (block $(send nil? #Hooks.all ...) _ nil?)
         PATTERN
 
         def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
           empty_hook?(node) do |hook|
             add_offense(hook) do |corrector|
               corrector.remove(
-                range_with_surrounding_space(node.loc.expression, side: :left)
+                range_with_surrounding_space(node.source_range, side: :left)
               )
             end
           end

data/lib/rubocop/cop/rspec/empty_line_after_example_group.rb

@@ -30,7 +30,7 @@ module RuboCop
         MSG = 'Add an empty line after `%<example_group>s`.'
 
         def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
-          return unless example_group?(node)
+          return unless spec_group?(node)
 
           missing_separating_line_offense(node) do |method|
             format(MSG, example_group: method)

data/lib/rubocop/cop/rspec/example_wording.rb

@@ -88,7 +88,7 @@ module RuboCop
         end
 
         def docstring(node)
-          expr = node.loc.expression
+          expr = node.source_range
 
           Parser::Source::Range.new(
             expr.source_buffer,

data/lib/rubocop/cop/rspec/excessive_docstring_spacing.rb

@@ -74,7 +74,7 @@ module RuboCop
         end
 
         def docstring(node)
-          expr = node.loc.expression
+          expr = node.source_range
 
           Parser::Source::Range.new(
             expr.source_buffer,

data/lib/rubocop/cop/rspec/expect_actual.rb

@@ -93,8 +93,8 @@ module RuboCop
         end
 
         def swap(corrector, actual, expected)
-          corrector.replace(actual.source_range, expected.source)
-          corrector.replace(expected.source_range, actual.source)
+          corrector.replace(actual, expected.source)
+          corrector.replace(expected, actual.source)
         end
       end
     end

data/lib/rubocop/cop/rspec/expect_in_hook.rb

@@ -25,7 +25,7 @@ module RuboCop
         MSG = 'Do not use `%<expect>s` in `%<hook>s` hook'
 
         # @!method expectation(node)
-        def_node_search :expectation, send_pattern('#Expectations.all')
+        def_node_search :expectation, '(send nil? #Expectations.all ...)'
 
         def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
           return unless hook?(node)

data/lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb

@@ -96,7 +96,7 @@ module RuboCop
             left_braces, right_braces = braces(node)
 
             argument = node.first_argument
-            expression = argument.location.expression
+            expression = argument.source_range
             corrector.insert_before(expression, left_braces)
             corrector.insert_after(expression, right_braces)
           end

data/lib/rubocop/cop/rspec/factory_bot/consistent_parentheses_style.rb

@@ -100,10 +100,10 @@ module RuboCop
             end
           end
 
+          AMBIGUOUS_TYPES = %i[send pair array and or if].freeze
+
           def ambiguous_without_parentheses?(node)
-            node.parent&.send_type? ||
-              node.parent&.pair_type? ||
-              node.parent&.array_type?
+            node.parent && AMBIGUOUS_TYPES.include?(node.parent.type)
           end
 
           def remove_parentheses(corrector, node)

data/lib/rubocop/cop/rspec/factory_bot/syntax_methods.rb

@@ -71,14 +71,14 @@ module RuboCop
 
           def crime_scene(node)
             range_between(
-              node.loc.expression.begin_pos,
+              node.source_range.begin_pos,
               node.loc.selector.end_pos
             )
           end
 
           def offense(node)
             range_between(
-              node.loc.expression.begin_pos,
+              node.source_range.begin_pos,
               node.loc.selector.begin_pos
             )
           end

data/lib/rubocop/cop/rspec/file_path.rb

@@ -165,7 +165,7 @@ module RuboCop
         end
 
         def expanded_file_path
-          File.expand_path(processed_source.buffer.name)
+          File.expand_path(processed_source.file_path)
         end
       end
     end