rubocop-rspec 2.16.0 → 2.24.1

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 2.16.0
+  version: 2.24.1
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-12-13 00:00:00.000000000 Z
+date: 2023-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -26,6 +26,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.33'
+- !ruby/object:Gem::Dependency
+  name: rubocop-capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.17'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.17'
+- !ruby/object:Gem::Dependency
+  name: rubocop-factory_bot
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.22'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.22'
 description: |2
       Code style checking for RSpec files.
       A plugin for the RuboCop code style enforcing & linting tool.
@@ -52,12 +80,14 @@ files:
 - lib/rubocop/cop/rspec/around_block.rb
 - lib/rubocop/cop/rspec/base.rb
 - lib/rubocop/cop/rspec/be.rb
+- lib/rubocop/cop/rspec/be_empty.rb
 - lib/rubocop/cop/rspec/be_eq.rb
 - lib/rubocop/cop/rspec/be_eql.rb
 - lib/rubocop/cop/rspec/be_nil.rb
 - lib/rubocop/cop/rspec/before_after_all.rb
 - lib/rubocop/cop/rspec/capybara/current_path_expectation.rb
 - lib/rubocop/cop/rspec/capybara/feature_methods.rb
+- lib/rubocop/cop/rspec/capybara/match_style.rb
 - lib/rubocop/cop/rspec/capybara/negation_matcher.rb
 - lib/rubocop/cop/rspec/capybara/specific_actions.rb
 - lib/rubocop/cop/rspec/capybara/specific_finders.rb
@@ -65,6 +95,7 @@ files:
 - lib/rubocop/cop/rspec/capybara/visibility_matcher.rb
 - lib/rubocop/cop/rspec/change_by_zero.rb
 - lib/rubocop/cop/rspec/class_check.rb
+- lib/rubocop/cop/rspec/contain_exactly.rb
 - lib/rubocop/cop/rspec/context_method.rb
 - lib/rubocop/cop/rspec/context_wording.rb
 - lib/rubocop/cop/rspec/describe_class.rb
@@ -81,6 +112,8 @@ files:
 - lib/rubocop/cop/rspec/empty_line_after_final_let.rb
 - lib/rubocop/cop/rspec/empty_line_after_hook.rb
 - lib/rubocop/cop/rspec/empty_line_after_subject.rb
+- lib/rubocop/cop/rspec/empty_metadata.rb
+- lib/rubocop/cop/rspec/eq.rb
 - lib/rubocop/cop/rspec/example_length.rb
 - lib/rubocop/cop/rspec/example_without_description.rb
 - lib/rubocop/cop/rspec/example_wording.rb
@@ -103,6 +136,7 @@ files:
 - lib/rubocop/cop/rspec/implicit_block_expectation.rb
 - lib/rubocop/cop/rspec/implicit_expect.rb
 - lib/rubocop/cop/rspec/implicit_subject.rb
+- lib/rubocop/cop/rspec/indexed_let.rb
 - lib/rubocop/cop/rspec/instance_spy.rb
 - lib/rubocop/cop/rspec/instance_variable.rb
 - lib/rubocop/cop/rspec/it_behaves_like.rb
@@ -111,16 +145,18 @@ files:
 - lib/rubocop/cop/rspec/leaky_constant_declaration.rb
 - lib/rubocop/cop/rspec/let_before_examples.rb
 - lib/rubocop/cop/rspec/let_setup.rb
+- lib/rubocop/cop/rspec/match_array.rb
 - lib/rubocop/cop/rspec/message_chain.rb
 - lib/rubocop/cop/rspec/message_expectation.rb
 - lib/rubocop/cop/rspec/message_spies.rb
+- lib/rubocop/cop/rspec/metadata_style.rb
 - lib/rubocop/cop/rspec/missing_example_group_argument.rb
-- lib/rubocop/cop/rspec/mixin/capybara_help.rb
 - lib/rubocop/cop/rspec/mixin/comments_help.rb
-- lib/rubocop/cop/rspec/mixin/css_selector.rb
 - lib/rubocop/cop/rspec/mixin/empty_line_separation.rb
+- lib/rubocop/cop/rspec/mixin/file_help.rb
 - lib/rubocop/cop/rspec/mixin/final_end_location.rb
 - lib/rubocop/cop/rspec/mixin/inside_example_group.rb
+- lib/rubocop/cop/rspec/mixin/location_help.rb
 - lib/rubocop/cop/rspec/mixin/metadata.rb
 - lib/rubocop/cop/rspec/mixin/namespace.rb
 - lib/rubocop/cop/rspec/mixin/skip_or_pending.rb
@@ -142,8 +178,13 @@ files:
 - lib/rubocop/cop/rspec/rails/have_http_status.rb
 - lib/rubocop/cop/rspec/rails/http_status.rb
 - lib/rubocop/cop/rspec/rails/inferred_spec_type.rb
+- lib/rubocop/cop/rspec/rails/minitest_assertions.rb
+- lib/rubocop/cop/rspec/rails/negation_be_valid.rb
+- lib/rubocop/cop/rspec/rails/travel_around.rb
 - lib/rubocop/cop/rspec/receive_counts.rb
+- lib/rubocop/cop/rspec/receive_messages.rb
 - lib/rubocop/cop/rspec/receive_never.rb
+- lib/rubocop/cop/rspec/redundant_around.rb
 - lib/rubocop/cop/rspec/repeated_description.rb
 - lib/rubocop/cop/rspec/repeated_example.rb
 - lib/rubocop/cop/rspec/repeated_example_group_body.rb
@@ -155,7 +196,10 @@ files:
 - lib/rubocop/cop/rspec/shared_context.rb
 - lib/rubocop/cop/rspec/shared_examples.rb
 - lib/rubocop/cop/rspec/single_argument_message_chain.rb
+- lib/rubocop/cop/rspec/skip_block_inside_example.rb
 - lib/rubocop/cop/rspec/sort_metadata.rb
+- lib/rubocop/cop/rspec/spec_file_path_format.rb
+- lib/rubocop/cop/rspec/spec_file_path_suffix.rb
 - lib/rubocop/cop/rspec/stubbed_mock.rb
 - lib/rubocop/cop/rspec/subject_declaration.rb
 - lib/rubocop/cop/rspec/subject_stub.rb
@@ -175,8 +219,6 @@ files:
 - lib/rubocop/rspec/description_extractor.rb
 - lib/rubocop/rspec/example.rb
 - lib/rubocop/rspec/example_group.rb
-- lib/rubocop/rspec/factory_bot.rb
-- lib/rubocop/rspec/factory_bot/language.rb
 - lib/rubocop/rspec/hook.rb
 - lib/rubocop/rspec/inject.rb
 - lib/rubocop/rspec/language.rb
@@ -200,14 +242,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.4.12
 signing_key:
 specification_version: 4
 summary: Code style checking for RSpec files

data/lib/rubocop/cop/rspec/mixin/capybara_help.rb

@@ -1,80 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module RSpec
-      # Help methods for capybara.
-      module CapybaraHelp
-        module_function
-
-        # @param node [RuboCop::AST::SendNode]
-        # @param locator [String]
-        # @param element [String]
-        # @return [Boolean]
-        def specific_option?(node, locator, element)
-          attrs = CssSelector.attributes(locator).keys
-          return false unless replaceable_element?(node, element, attrs)
-
-          attrs.all? do |attr|
-            CssSelector.specific_options?(element, attr)
-          end
-        end
-
-        # @param locator [String]
-        # @return [Boolean]
-        def specific_pseudo_classes?(locator)
-          CssSelector.pseudo_classes(locator).all? do |pseudo_class|
-            replaceable_pseudo_class?(pseudo_class, locator)
-          end
-        end
-
-        # @param pseudo_class [String]
-        # @param locator [String]
-        # @return [Boolean]
-        def replaceable_pseudo_class?(pseudo_class, locator)
-          return false unless CssSelector.specific_pesudo_classes?(pseudo_class)
-
-          case pseudo_class
-          when 'not()' then replaceable_pseudo_class_not?(locator)
-          else true
-          end
-        end
-
-        # @param locator [String]
-        # @return [Boolean]
-        def replaceable_pseudo_class_not?(locator)
-          locator.scan(/not\(.*?\)/).all? do |negation|
-            CssSelector.attributes(negation).values.all? do |v|
-              v.is_a?(TrueClass) || v.is_a?(FalseClass)
-            end
-          end
-        end
-
-        # @param node [RuboCop::AST::SendNode]
-        # @param element [String]
-        # @param attrs [Array<String>]
-        # @return [Boolean]
-        def replaceable_element?(node, element, attrs)
-          case element
-          when 'link' then replaceable_to_link?(node, attrs)
-          else true
-          end
-        end
-
-        # @param node [RuboCop::AST::SendNode]
-        # @param attrs [Array<String>]
-        # @return [Boolean]
-        def replaceable_to_link?(node, attrs)
-          include_option?(node, :href) || attrs.include?('href')
-        end
-
-        # @param node [RuboCop::AST::SendNode]
-        # @param option [Symbol]
-        # @return [Boolean]
-        def include_option?(node, option)
-          node.each_descendant(:sym).find { |opt| opt.value == option }
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec/mixin/css_selector.rb

@@ -1,146 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module RSpec
-      # Helps parsing css selector.
-      module CssSelector
-        COMMON_OPTIONS = %w[
-          above below left_of right_of near count minimum maximum between text
-          id class style visible obscured exact exact_text normalize_ws match
-          wait filter_set focused
-        ].freeze
-        SPECIFIC_OPTIONS = {
-          'button' => (
-            COMMON_OPTIONS + %w[disabled name value title type]
-          ).freeze,
-          'link' => (
-            COMMON_OPTIONS + %w[href alt title download]
-          ).freeze,
-          'table' => (
-            COMMON_OPTIONS + %w[
-              caption with_cols cols with_rows rows
-            ]
-          ).freeze,
-          'select' => (
-            COMMON_OPTIONS + %w[
-              disabled name placeholder options enabled_options
-              disabled_options selected with_selected multiple with_options
-            ]
-          ).freeze,
-          'field' => (
-            COMMON_OPTIONS + %w[
-              checked unchecked disabled valid name placeholder
-              validation_message readonly with type multiple
-            ]
-          ).freeze
-        }.freeze
-        SPECIFIC_PSEUDO_CLASSES = %w[
-          not() disabled enabled checked unchecked
-        ].freeze
-
-        module_function
-
-        # @param element [String]
-        # @param attribute [String]
-        # @return [Boolean]
-        # @example
-        #   specific_pesudo_classes?('button', 'name') # => true
-        #   specific_pesudo_classes?('link', 'invalid') # => false
-        def specific_options?(element, attribute)
-          SPECIFIC_OPTIONS.fetch(element, []).include?(attribute)
-        end
-
-        # @param pseudo_class [String]
-        # @return [Boolean]
-        # @example
-        #   specific_pesudo_classes?('disabled') # => true
-        #   specific_pesudo_classes?('first-of-type') # => false
-        def specific_pesudo_classes?(pseudo_class)
-          SPECIFIC_PSEUDO_CLASSES.include?(pseudo_class)
-        end
-
-        # @param selector [String]
-        # @return [Boolean]
-        # @example
-        #   id?('#some-id') # => true
-        #   id?('.some-class') # => false
-        def id?(selector)
-          selector.start_with?('#')
-        end
-
-        # @param selector [String]
-        # @return [Boolean]
-        # @example
-        #   attribute?('[attribute]') # => true
-        #   attribute?('attribute') # => false
-        def attribute?(selector)
-          selector.start_with?('[')
-        end
-
-        # @param selector [String]
-        # @return [Array<String>]
-        # @example
-        #   attributes('a[foo-bar_baz]') # => {"foo-bar_baz=>true}
-        #   attributes('button[foo][bar]') # => {"foo"=>true, "bar"=>true}
-        #   attributes('table[foo=bar]') # => {"foo"=>"'bar'"}
-        def attributes(selector)
-          selector.scan(/\[(.*?)\]/).flatten.to_h do |attr|
-            key, value = attr.split('=')
-            [key, normalize_value(value)]
-          end
-        end
-
-        # @param selector [String]
-        # @return [Boolean]
-        # @example
-        #   common_attributes?('a[focused]') # => true
-        #   common_attributes?('button[focused][visible]') # => true
-        #   common_attributes?('table[id=some-id]') # => true
-        #   common_attributes?('h1[invalid]') # => false
-        def common_attributes?(selector)
-          attributes(selector).keys.difference(COMMON_OPTIONS).none?
-        end
-
-        # @param selector [String]
-        # @return [Array<String>]
-        # @example
-        #   pseudo_classes('button:not([disabled])') # => ['not()']
-        #   pseudo_classes('a:enabled:not([valid])') # => ['enabled', 'not()']
-        def pseudo_classes(selector)
-          # Attributes must be excluded or else the colon in the `href`s URL
-          # will also be picked up as pseudo classes.
-          # "a:not([href='http://example.com']):enabled" => "a:not():enabled"
-          ignored_attribute = selector.gsub(/\[.*?\]/, '')
-          # "a:not():enabled" => ["not()", "enabled"]
-          ignored_attribute.scan(/:([^:]*)/).flatten
-        end
-
-        # @param selector [String]
-        # @return [Boolean]
-        # @example
-        #   multiple_selectors?('a.cls b#id') # => true
-        #   multiple_selectors?('a.cls') # => false
-        def multiple_selectors?(selector)
-          selector.match?(/[ >,+~]/)
-        end
-
-        # @param value [String]
-        # @return [Boolean, String]
-        # @example
-        #   normalize_value('true') # => true
-        #   normalize_value('false') # => false
-        #   normalize_value(nil) # => false
-        #   normalize_value("foo") # => "'foo'"
-        def normalize_value(value)
-          case value
-          when 'true' then true
-          when 'false' then false
-          when nil then true
-          else "'#{value}'"
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/rspec/factory_bot/language.rb

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module RSpec
-    module FactoryBot
-      # Contains node matchers for common FactoryBot DSL.
-      module Language
-        extend RuboCop::NodePattern::Macros
-
-        METHODS = %i[
-          attributes_for
-          attributes_for_list
-          attributes_for_pair
-          build
-          build_list
-          build_pair
-          build_stubbed
-          build_stubbed_list
-          build_stubbed_pair
-          create
-          create_list
-          create_pair
-          generate
-          generate_list
-          null
-          null_list
-          null_pair
-        ].to_set.freeze
-
-        # @!method factory_bot?(node)
-        def_node_matcher :factory_bot?, <<~PATTERN
-          (const {nil? cbase} {:FactoryGirl :FactoryBot})
-        PATTERN
-      end
-    end
-  end
-end

data/lib/rubocop/rspec/factory_bot.rb

@@ -1,64 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module RSpec
-    # RuboCop FactoryBot project namespace
-    module FactoryBot
-      ATTRIBUTE_DEFINING_METHODS = %i[
-        factory
-        ignore
-        trait
-        traits_for_enum
-        transient
-      ].freeze
-
-      UNPROXIED_METHODS = %i[
-        __send__
-        __id__
-        nil?
-        send
-        object_id
-        extend
-        instance_eval
-        initialize
-        block_given?
-        raise
-        caller
-        method
-      ].freeze
-
-      DEFINITION_PROXY_METHODS = %i[
-        add_attribute
-        after
-        association
-        before
-        callback
-        ignore
-        initialize_with
-        sequence
-        skip_create
-        to_create
-      ].freeze
-
-      RESERVED_METHODS =
-        DEFINITION_PROXY_METHODS +
-        UNPROXIED_METHODS +
-        ATTRIBUTE_DEFINING_METHODS
-
-      private_constant(
-        :ATTRIBUTE_DEFINING_METHODS,
-        :UNPROXIED_METHODS,
-        :DEFINITION_PROXY_METHODS,
-        :RESERVED_METHODS
-      )
-
-      def self.attribute_defining_methods
-        ATTRIBUTE_DEFINING_METHODS
-      end
-
-      def self.reserved_methods
-        RESERVED_METHODS
-      end
-    end
-  end
-end