rubocop-rspec 2.15.0 → 2.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1e120f8d06ef760cbe4f3a3d077ca6cd8ceeb274a26042a6e1469fe9a280c969
-  data.tar.gz: 0c80cc155e8f64b03a97de1327e454d9ff2efb1a75b02e3b098f868afed30d17
+  metadata.gz: 803b0cb494f6f1204fdb3ec31f7d4a4113b57fb2384066fb322e84107abbc65a
+  data.tar.gz: cb5a6a141c0af43cf179ac9d3e568e8bc3b5764abf4fda4e8a09340e7d311161
 SHA512:
-  metadata.gz: e982f97a23de2473c5cae6cd20bb653bcbcee806abddf0dda09c7b30692193858fc105c7b46ce3c004f28a7f680d1b3a475298c7b10d0e1499d5b80333fde504
-  data.tar.gz: c3b79b39a2c98d9103cb4edbf6c2d8e2cc957790fd8fa617e1fdece172f3dfaaf652bf482e7236a1da663f3b9afae943c17efee1e4a5f0293acc771bbc1c3c43
+  metadata.gz: 263c0f3e23a10ba54a9fc888646ab9f4e55ea4a08e0adb5b2b32db14c1fc773ed3fa956df3c7a12794c7c3ebea4415e68a42a5d7d109e2da6b88d623417e2102
+  data.tar.gz: d976c48d81cfd2d33b4857f08c9860d3857d5f8b51017f99c5ae650102184884dc76d95096d1efc2b70472a063a1887ef4d8e72dc7a6d003b131bf4ca67c4c5e

data/CHANGELOG.md

@@ -2,6 +2,26 @@
 
 ## Master (Unreleased)
 
+## 2.17.0 (2023-01-13)
+
+- Fix a false positive for `RSpec/PendingWithoutReason` when pending/skip is argument of methods. ([@ydah])
+- Add new `RSpec/Capybara/MatchStyle` cop. ([@ydah])
+- Add new `RSpec/Rails/MinitestAssertions` cop. ([@ydah])
+- Fix a false positive for `RSpec/PendingWithoutReason` when not inside example. ([@ydah])
+- Fix a false negative for `RSpec/PredicateMatcher` when using `include` and `respond_to`. ([@ydah])
+- Fix a false positive for `RSpec/StubbedMock` when stubbed message expectation with a block and block parameter. ([@ydah])
+
+## 2.16.0 (2022-12-13)
+
+- Add new `RSpec/FactoryBot/FactoryNameStyle` cop. ([@ydah])
+- Improved processing speed for `RSpec/Be`, `RSpec/ExpectActual`, `RSpec/ImplicitExpect`, `RSpec/MessageSpies`, `RSpec/PredicateMatcher` and `RSpec/Rails/HaveHttpStatus`. ([@ydah])
+- Fix wrong autocorrection in `n_times` style on `RSpec/FactoryBot/CreateList`. ([@r7kamura])
+- Fix a false positive for `RSpec/FactoryBot/ConsistentParenthesesStyle` when using `generate` with multiple arguments. ([@ydah])
+- Mark `RSpec/BeEq` as `Safe: false` ([@r7kamura])
+- Add `RSpec/DuplicatedMetadata` cop. ([@r7kamura])
+- Mark `RSpec/BeEql` as `Safe: false`. ([@r7kamura])
+- Add `RSpec/PendingWithoutReason` cop. ([@r7kamura])
+
 ## 2.15.0 (2022-11-03)
 
 - Fix a false positive for `RSpec/RepeatedDescription` when different its block expectations are used. ([@ydah])

data/README.md

@@ -2,7 +2,7 @@
 
 [![Join the chat at https://gitter.im/rubocop-rspec/Lobby](https://badges.gitter.im/rubocop-rspec/Lobby.svg)](https://gitter.im/rubocop-rspec/Lobby)
 [![Gem Version](https://badge.fury.io/rb/rubocop-rspec.svg)](https://rubygems.org/gems/rubocop-rspec)
-![CI](https://github.com/rubocop-hq/rubocop-rspec/workflows/CI/badge.svg)
+![CI](https://github.com/rubocop/rubocop-rspec/workflows/CI/badge.svg)
 
 RSpec-specific analysis for your projects, as an extension to
 [RuboCop](https://github.com/rubocop/rubocop).

data/config/default.yml

@@ -147,13 +147,17 @@ RSpec/Be:
 RSpec/BeEq:
   Description: Check for expectations where `be(...)` can replace `eq(...)`.
   Enabled: pending
+  Safe: false
   VersionAdded: 2.9.0
+  VersionChanged: '2.16'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeEq
 
 RSpec/BeEql:
   Description: Check for expectations where `be(...)` can replace `eql(...)`.
   Enabled: true
+  Safe: false
   VersionAdded: '1.7'
+  VersionChanged: '2.16'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeEql
 
 RSpec/BeNil:
@@ -284,6 +288,12 @@ RSpec/Dialect:
   VersionAdded: '1.33'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Dialect
 
+RSpec/DuplicatedMetadata:
+  Description: Avoid duplicated metadata.
+  Enabled: pending
+  VersionAdded: '2.16'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DuplicatedMetadata
+
 RSpec/EmptyExampleGroup:
   Description: Checks if an example group does not include any tests.
   Enabled: true
@@ -356,12 +366,6 @@ RSpec/ExampleWithoutDescription:
   VersionAdded: '1.22'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWithoutDescription
 
-RSpec/ExcessiveDocstringSpacing:
-  Description: Checks for excessive whitespace in example descriptions.
-  Enabled: pending
-  VersionAdded: '2.5'
-  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExcessiveDocstringSpacing
-
 RSpec/ExampleWording:
   Description: Checks for common mistakes in example descriptions.
   Enabled: true
@@ -378,6 +382,12 @@ RSpec/ExampleWording:
   StyleGuide: https://rspec.rubystyle.guide/#should-in-example-docstrings
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
 
+RSpec/ExcessiveDocstringSpacing:
+  Description: Checks for excessive whitespace in example descriptions.
+  Enabled: pending
+  VersionAdded: '2.5'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExcessiveDocstringSpacing
+
 RSpec/ExpectActual:
   Description: Checks for `expect(...)` calls containing literal values.
   Enabled: true
@@ -664,6 +674,12 @@ RSpec/Pending:
   VersionAdded: '1.25'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Pending
 
+RSpec/PendingWithoutReason:
+  Description: Checks for pending or skipped examples without reason.
+  Enabled: pending
+  VersionAdded: '2.16'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PendingWithoutReason
+
 RSpec/PredicateMatcher:
   Description: Prefer using predicate matcher over using predicate method directly.
   Enabled: true
@@ -871,6 +887,12 @@ RSpec/Capybara/FeatureMethods:
   VersionChanged: '2.0'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/FeatureMethods
 
+RSpec/Capybara/MatchStyle:
+  Description: Checks for usage of deprecated style methods.
+  Enabled: pending
+  VersionAdded: '2.17'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/MatchStyle
+
 RSpec/Capybara/NegationMatcher:
   Description: Enforces use of `have_no_*` or `not_to` for negated expectations.
   Enabled: pending
@@ -960,6 +982,16 @@ RSpec/FactoryBot/FactoryClassName:
   VersionChanged: '2.0'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/FactoryClassName
 
+RSpec/FactoryBot/FactoryNameStyle:
+  Description: Checks for name style for argument of FactoryBot::Syntax::Methods.
+  Enabled: pending
+  VersionAdded: '2.16'
+  EnforcedStyle: symbol
+  SupportedStyles:
+    - symbol
+    - string
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/FactoryNameStyle
+
 RSpec/FactoryBot/SyntaxMethods:
   Description: Use shorthands from `FactoryBot::Syntax::Methods` in your specs.
   Enabled: pending
@@ -985,6 +1017,17 @@ RSpec/Rails/HaveHttpStatus:
   VersionAdded: '2.12'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HaveHttpStatus
 
+RSpec/Rails/HttpStatus:
+  Description: Enforces use of symbolic or numeric value to describe HTTP status.
+  Enabled: true
+  EnforcedStyle: symbolic
+  SupportedStyles:
+    - numeric
+    - symbolic
+  VersionAdded: '1.23'
+  VersionChanged: '2.0'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus
+
 RSpec/Rails/InferredSpecType:
   Description: Identifies redundant spec type.
   Enabled: pending
@@ -1008,13 +1051,8 @@ RSpec/Rails/InferredSpecType:
     system: system
     views: view
 
-RSpec/Rails/HttpStatus:
-  Description: Enforces use of symbolic or numeric value to describe HTTP status.
-  Enabled: true
-  EnforcedStyle: symbolic
-  SupportedStyles:
-    - numeric
-    - symbolic
-  VersionAdded: '1.23'
-  VersionChanged: '2.0'
-  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus
+RSpec/Rails/MinitestAssertions:
+  Description: Check if using Minitest matchers.
+  Enabled: pending
+  VersionAdded: '2.17'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/MinitestAssertions

data/lib/rubocop/cop/rspec/be.rb

@@ -21,6 +21,8 @@ module RuboCop
       class Be < Base
         MSG = "Don't use `be` without an argument."
 
+        RESTRICT_ON_SEND = Runners.all
+
         # @!method be_without_args(node)
         def_node_matcher :be_without_args, <<-PATTERN
           (send _ #Runners.all $(send nil? :be))

data/lib/rubocop/cop/rspec/be_eq.rb

@@ -9,6 +9,9 @@ module RuboCop
       # using `==`. Booleans and nil can be compared by identity and therefore
       # the `be` matcher is preferable as it is a more strict test.
       #
+      # @safety
+      #   This cop is unsafe because it changes how values are compared.
+      #
       # @example
       #   # bad
       #   expect(foo).to eq(true)

data/lib/rubocop/cop/rspec/be_eql.rb

@@ -10,6 +10,9 @@ module RuboCop
       # can be compared by identity and therefore the `be` matcher is
       # preferable as it is a more strict test.
       #
+      # @safety
+      #   This cop is unsafe because it changes how values are compared.
+      #
       # @example
       #   # bad
       #   expect(foo).to eql(1)

data/lib/rubocop/cop/rspec/capybara/current_path_expectation.rb

@@ -29,7 +29,7 @@ module RuboCop
         #   # good
         #   expect(page).to have_current_path('/callback')
         #
-        class CurrentPathExpectation < Base
+        class CurrentPathExpectation < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           MSG = 'Do not set an RSpec expectation on `current_path` in ' \
@@ -47,14 +47,14 @@ module RuboCop
           # @!method as_is_matcher(node)
           def_node_matcher :as_is_matcher, <<-PATTERN
             (send
-              #expectation_set_on_current_path $#Runners.all
+              #expectation_set_on_current_path ${:to :to_not :not_to}
               ${(send nil? :eq ...) (send nil? :match (regexp ...))})
           PATTERN
 
           # @!method regexp_str_matcher(node)
           def_node_matcher :regexp_str_matcher, <<-PATTERN
             (send
-              #expectation_set_on_current_path $#Runners.all
+              #expectation_set_on_current_path ${:to :to_not :not_to}
               $(send nil? :match (str $_)))
           PATTERN
 

data/lib/rubocop/cop/rspec/capybara/match_style.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      module Capybara
+        # Checks for usage of deprecated style methods.
+        #
+        # @example when using `assert_style`
+        #   # bad
+        #   page.find(:css, '#first').assert_style(display: 'block')
+        #
+        #   # good
+        #   page.find(:css, '#first').assert_matches_style(display: 'block')
+        #
+        # @example when using `has_style?`
+        #   # bad
+        #   expect(page.find(:css, 'first')
+        #     .has_style?(display: 'block')).to be true
+        #
+        #   # good
+        #   expect(page.find(:css, 'first')
+        #     .matches_style?(display: 'block')).to be true
+        #
+        # @example when using `have_style`
+        #   # bad
+        #   expect(page).to have_style(display: 'block')
+        #
+        #   # good
+        #   expect(page).to match_style(display: 'block')
+        #
+        class MatchStyle < Base
+          extend AutoCorrector
+
+          MSG = 'Use `%<good>s` instead of `%<bad>s`.'
+          RESTRICT_ON_SEND = %i[assert_style has_style? have_style].freeze
+          PREFERRED_METHOD = {
+            'assert_style' => 'assert_matches_style',
+            'has_style?' => 'matches_style?',
+            'have_style' => 'match_style'
+          }.freeze
+
+          def on_send(node)
+            method_node = node.loc.selector
+            add_offense(method_node) do |corrector|
+              corrector.replace(method_node,
+                                PREFERRED_METHOD[method_node.source])
+            end
+          end
+
+          private
+
+          def message(node)
+            format(MSG, good: PREFERRED_METHOD[node.source], bad: node.source)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/capybara/negation_matcher.rb

@@ -24,7 +24,7 @@ module RuboCop
         #   expect(page).to have_no_selector
         #   expect(page).to have_no_css('a')
         #
-        class NegationMatcher < Base
+        class NegationMatcher < ::RuboCop::Cop::Base
           extend AutoCorrector
           include ConfigurableEnforcedStyle
 

data/lib/rubocop/cop/rspec/capybara/specific_actions.rb

@@ -20,7 +20,7 @@ module RuboCop
         #   click_link(exact_text: 'foo')
         #   find('div').click_button
         #
-        class SpecificActions < Base
+        class SpecificActions < ::RuboCop::Cop::Base
           MSG = "Prefer `%<good_action>s` over `find('%<selector>s').click`."
           RESTRICT_ON_SEND = %i[click].freeze
           SPECIFIC_ACTION = {

data/lib/rubocop/cop/rspec/capybara/specific_finders.rb

@@ -15,7 +15,7 @@ module RuboCop
         #   find_by_id('some-id')
         #   find_by_id('some-id', visible: true)
         #
-        class SpecificFinders < Base
+        class SpecificFinders < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           include RangeHelp

data/lib/rubocop/cop/rspec/capybara/specific_matcher.rb

@@ -26,9 +26,7 @@ module RuboCop
         #   expect(page).to have_select
         #   expect(page).to have_field('foo')
         #
-        class SpecificMatcher < Base
-          include CapybaraHelp
-
+        class SpecificMatcher < ::RuboCop::Cop::Base
           MSG = 'Prefer `%<good_matcher>s` over `%<bad_matcher>s`.'
           RESTRICT_ON_SEND = %i[have_selector have_no_selector have_css
                                 have_no_css].freeze
@@ -49,8 +47,8 @@ module RuboCop
             first_argument(node) do |arg|
               next unless (matcher = specific_matcher(arg))
               next if CssSelector.multiple_selectors?(arg)
-              next unless specific_option?(node, arg, matcher)
-              next unless specific_pseudo_classes?(arg)
+              next unless CapybaraHelp.specific_option?(node, arg, matcher)
+              next unless CapybaraHelp.specific_pseudo_classes?(arg)
 
               add_offense(node, message: message(node, matcher))
             end

data/lib/rubocop/cop/rspec/capybara/visibility_matcher.rb

@@ -26,7 +26,7 @@ module RuboCop
         #   expect(page).to have_css('.foo', visible: :all)
         #   expect(page).to have_link('my link', visible: :hidden)
         #
-        class VisibilityMatcher < Base
+        class VisibilityMatcher < ::RuboCop::Cop::Base
           MSG_FALSE = 'Use `:all` or `:hidden` instead of `false`.'
           MSG_TRUE = 'Use `:visible` instead of `true`.'
           CAPYBARA_MATCHER_METHODS = %w[

data/lib/rubocop/cop/rspec/context_wording.rb

@@ -10,7 +10,6 @@ module RuboCop
       # include `if`, `unless`, `for`, `before`, `after`, or `during`.
       # They may consist of multiple words if desired.
       #
-      # @see https://rspec.rubystyle.guide/#context-descriptions
       # @see http://www.betterspecs.org/#contexts
       #
       # @example `Prefixes` configuration

data/lib/rubocop/cop/rspec/duplicated_metadata.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Avoid duplicated metadata.
+      #
+      # @example
+      #   # bad
+      #   describe 'Something', :a, :a
+      #
+      #   # good
+      #   describe 'Something', :a
+      class DuplicatedMetadata < Base
+        extend AutoCorrector
+
+        include Metadata
+        include RangeHelp
+
+        MSG = 'Avoid duplicated metadata.'
+
+        def on_metadata(symbols, _pairs)
+          symbols.each do |symbol|
+            on_metadata_symbol(symbol)
+          end
+        end
+
+        private
+
+        def on_metadata_symbol(node)
+          return unless duplicated?(node)
+
+          add_offense(node) do |corrector|
+            autocorrect(corrector, node)
+          end
+        end
+
+        def autocorrect(corrector, node)
+          corrector.remove(
+            range_with_surrounding_comma(
+              range_with_surrounding_space(
+                node.location.expression,
+                side: :left
+              ),
+              :left
+            )
+          )
+        end
+
+        def duplicated?(node)
+          node.left_siblings.any? do |sibling|
+            sibling.eql?(node)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/empty_line_after_example.rb

@@ -55,6 +55,8 @@ module RuboCop
           end
         end
 
+        private
+
         def allowed_one_liner?(node)
           consecutive_one_liner?(node) && allow_consecutive_one_liners?
         end

data/lib/rubocop/cop/rspec/expect_actual.rb

@@ -26,6 +26,8 @@ module RuboCop
 
         MSG = 'Provide the actual you are testing to `expect(...)`.'
 
+        RESTRICT_ON_SEND = Runners.all
+
         SIMPLE_LITERALS = %i[
           true
           false

data/lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb

@@ -25,7 +25,7 @@ module RuboCop
         #   # good
         #   count { 1 }
         #
-        class AttributeDefinedStatically < Base
+        class AttributeDefinedStatically < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           MSG = 'Use a block to declare attribute values.'

data/lib/rubocop/cop/rspec/factory_bot/consistent_parentheses_style.rb

@@ -40,7 +40,7 @@ module RuboCop
         #     name: 'foo'
         #   )
         #
-        class ConsistentParenthesesStyle < Base
+        class ConsistentParenthesesStyle < ::RuboCop::Cop::Base
           extend AutoCorrector
           include ConfigurableEnforcedStyle
           include RuboCop::RSpec::FactoryBot::Language
@@ -69,6 +69,8 @@ module RuboCop
             return if ambiguous_without_parentheses?(node)
 
             factory_call(node) do
+              return if node.method?(:generate) && node.arguments.count > 1
+
               if node.parenthesized?
                 process_with_parentheses(node)
               else
@@ -77,6 +79,8 @@ module RuboCop
             end
           end
 
+          private
+
           def process_with_parentheses(node)
             return unless style == :omit_parentheses
             return unless same_line?(node, node.first_argument)
@@ -102,8 +106,6 @@ module RuboCop
               node.parent&.array_type?
           end
 
-          private
-
           def remove_parentheses(corrector, node)
             corrector.replace(node.location.begin, ' ')
             corrector.remove(node.location.end)

data/lib/rubocop/cop/rspec/factory_bot/create_list.rb

@@ -31,7 +31,7 @@ module RuboCop
         #   # good
         #   3.times { create :user }
         #
-        class CreateList < Base
+        class CreateList < ::RuboCop::Cop::Base
           extend AutoCorrector
           include ConfigurableEnforcedStyle
           include RuboCop::RSpec::FactoryBot::Language
@@ -143,7 +143,7 @@ module RuboCop
 
             def call(corrector)
               replacement = generate_n_times_block(node)
-              corrector.replace(node, replacement)
+              corrector.replace(node.block_node || node, replacement)
             end
 
             private
@@ -159,8 +159,15 @@ module RuboCop
 
               replacement = format_receiver(node.receiver)
               replacement += format_method_call(node, 'create', arguments)
+              replacement += " #{factory_call_block_source}" if node.block_node
               "#{count.source}.times { #{replacement} }"
             end
+
+            def factory_call_block_source
+              node.block_node.location.begin.with(
+                end_pos: node.block_node.location.end.end_pos
+              ).source
+            end
           end
 
           # :nodoc:

data/lib/rubocop/cop/rspec/factory_bot/factory_class_name.rb

@@ -20,7 +20,7 @@ module RuboCop
         #   factory :foo, class: 'Foo' do
         #   end
         #
-        class FactoryClassName < Base
+        class FactoryClassName < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           MSG = "Pass '%<class_name>s' string instead of `%<class_name>s` " \

data/lib/rubocop/cop/rspec/factory_bot/factory_name_style.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      module FactoryBot
+        # Checks for name style for argument of FactoryBot::Syntax::Methods.
+        #
+        # @example EnforcedStyle: symbol (default)
+        #   # bad
+        #   create('user')
+        #   build "user", username: "NAME"
+        #
+        #   # good
+        #   create(:user)
+        #   build :user, username: "NAME"
+        #
+        # @example EnforcedStyle: string
+        #   # bad
+        #   create(:user)
+        #   build :user, username: "NAME"
+        #
+        #   # good
+        #   create('user')
+        #   build "user", username: "NAME"
+        #
+        class FactoryNameStyle < ::RuboCop::Cop::Base
+          extend AutoCorrector
+          include ConfigurableEnforcedStyle
+          include RuboCop::RSpec::FactoryBot::Language
+
+          MSG = 'Use %<prefer>s to refer to a factory.'
+          FACTORY_CALLS = RuboCop::RSpec::FactoryBot::Language::METHODS
+          RESTRICT_ON_SEND = FACTORY_CALLS
+
+          # @!method factory_call(node)
+          def_node_matcher :factory_call, <<-PATTERN
+          (send
+            {#factory_bot? nil?} %FACTORY_CALLS
+            ${str sym} ...
+          )
+          PATTERN
+
+          def on_send(node)
+            factory_call(node) do |name|
+              if offense_for_symbol_style?(name)
+                register_offense(name, name.value.to_sym.inspect)
+              elsif offense_for_string_style?(name)
+                register_offense(name, name.value.to_s.inspect)
+              end
+            end
+          end
+
+          private
+
+          def offense_for_symbol_style?(name)
+            name.str_type? && style == :symbol
+          end
+
+          def offense_for_string_style?(name)
+            name.sym_type? && style == :string
+          end
+
+          def register_offense(name, prefer)
+            add_offense(name,
+                        message: format(MSG, prefer: style.to_s)) do |corrector|
+              corrector.replace(name, prefer)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/implicit_expect.rb

@@ -28,6 +28,8 @@ module RuboCop
 
         MSG = 'Prefer `%<good>s` over `%<bad>s`.'
 
+        RESTRICT_ON_SEND = Runners.all + %i[should should_not]
+
         # @!method implicit_expect(node)
         def_node_matcher :implicit_expect, <<-PATTERN
           {

data/lib/rubocop/cop/rspec/leading_subject.rb

@@ -44,6 +44,8 @@ module RuboCop
           check_previous_nodes(node)
         end
 
+        private
+
         def check_previous_nodes(node)
           offending_node(node) do |offender|
             msg = format(MSG, offending: offender.method_name)
@@ -53,8 +55,6 @@ module RuboCop
           end
         end
 
-        private
-
         def offending_node(node)
           parent(node).each_child_node.find do |sibling|
             break if sibling.equal?(node)

data/lib/rubocop/cop/rspec/message_spies.rb

@@ -41,6 +41,8 @@ module RuboCop
 
         SUPPORTED_STYLES = %w[have_received receive].freeze
 
+        RESTRICT_ON_SEND = Runners.all
+
         # @!method message_expectation(node)
         def_node_matcher :message_expectation, %(
           (send (send nil? :expect $_) #Runners.all ...)