rubocop-rspec 2.14.2 → 2.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bbd70ea9708a7d87e0a1307234e3ac5cc37cc6197e6b1cc72487342b772ec6f1
-  data.tar.gz: 0c50303e8a0d4218508c51e778d5cb6633b54fe6f823951ea5f8df68d162dfda
+  metadata.gz: c31ad963289938a78bf4a8439ad44c6f1a2eaf852a25d715be483ebe71e622fc
+  data.tar.gz: 70b4e942004dd6654fa12c3ecaf7367c1f6bcf4bcd122573129984f5f0a66ff5
 SHA512:
-  metadata.gz: 2e1a6e55fb7aeef036448fe57f03b2d80b796e6971fbd22cd63db496e61b1e211a64e89e987cccc74f5124746713581fb621c805d458f7ff273d436432599483
-  data.tar.gz: 76655025092f103fbd6ca3eda6d466236a8a9857f207e11bc3f8e51c38238367346971c4a0f3feeca6b9069a53fa48bf8281d5dff61f68c6562edce4405a10f0
+  metadata.gz: 250a68082a8e6406df3934035e5ccba4e1a7f9a13e021e196911c15981a2f4557e7b7a98efa93f995ad164d2a52e41bf948f4c1fa7c9637829c3c219c8116f74
+  data.tar.gz: 7ce965fc56bf214eb65b63d2138cc710766ac16b476a63399271cc5562fb259cefc81cddcf3878f6324faf104d6552e48efcba2eff1fa0865bf463963e5a1a8e

data/CHANGELOG.md

@@ -2,6 +2,27 @@
 
 ## Master (Unreleased)
 
+## 2.16.0 (2022-12-13)
+
+- Add new `RSpec/FactoryBot/FactoryNameStyle` cop. ([@ydah])
+- Improved processing speed for `RSpec/Be`, `RSpec/ExpectActual`, `RSpec/ImplicitExpect`, `RSpec/MessageSpies`, `RSpec/PredicateMatcher` and `RSpec/Rails/HaveHttpStatus`. ([@ydah])
+- Fix wrong autocorrection in `n_times` style on `RSpec/FactoryBot/CreateList`. ([@r7kamura])
+- Fix a false positive for `RSpec/FactoryBot/ConsistentParenthesesStyle` when using `generate` with multiple arguments. ([@ydah])
+- Mark `RSpec/BeEq` as `Safe: false` ([@r7kamura])
+- Add `RSpec/DuplicatedMetadata` cop. ([@r7kamura])
+- Mark `RSpec/BeEql` as `Safe: false`. ([@r7kamura])
+- Add `RSpec/PendingWithoutReason` cop. ([@r7kamura])
+
+## 2.15.0 (2022-11-03)
+
+- Fix a false positive for `RSpec/RepeatedDescription` when different its block expectations are used. ([@ydah])
+- Add `named_only` style to `RSpec/NamedSubject`. ([@kuahyeow])
+- Fix `RSpec/FactoryBot/ConsistentParenthesesStyle` to ignore calls without the first positional argument. ([@pirj])
+- Fix `RSpec/FactoryBot/ConsistentParenthesesStyle` to ignore calls inside a Hash or an Array. ([@pirj])
+- Fix `RSpec/NestedGroups` to correctly use `AllowedGroups` config. ([@samrjenkins])
+- Remove `Runners` and `HookScopes` RSpec DSL elements from configuration. ([@pirj])
+- Add `with default RSpec/Language config` helper to `lib` (under `rubocop/rspec/shared_contexts/default_rspec_language_config_context`), to allow use for downstream cops based on `RuboCop::Cop::RSpec::Base`. ([@smcgivern])
+
 ## 2.14.2 (2022-10-25)
 
 - Fix an incorrect autocorrect for `FactoryBot/ConsistentParenthesesStyle` with `omit_parentheses` option when method name and first argument are not on same line. ([@ydah])
@@ -724,6 +745,7 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@jtannas]: https://github.com/jtannas
 [@kellysutton]: https://github.com/kellysutton
 [@koic]: https://github.com/koic
+[@kuahyeow]: https://github.com/kuahyeow
 [@lazycoder9]: https://github.com/lazycoder9
 [@leoarnold]: https://github.com/leoarnold
 [@liberatys]: https://github.com/Liberatys
@@ -760,9 +782,11 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@rrosenblum]: https://github.com/rrosenblum
 [@rspeicher]: https://github.com/rspeicher
 [@rst-j]: https://github.com/RST-J
+[@samrjenkins]: https://github.com/samrjenkins
 [@schmijos]: https://github.com/schmijos
 [@seanpdoyle]: https://github.com/seanpdoyle
 [@sl4vr]: https://github.com/sl4vr
+[@smcgivern]: https://github.com/smcgivern
 [@stephannv]: https://github.com/stephannv
 [@t3h2mas]: https://github.com/t3h2mas
 [@tdeo]: https://github.com/tdeo

data/config/default.yml

@@ -12,8 +12,6 @@ RSpec:
         - Expectations
         - Helpers
         - Hooks
-        - HookScopes
-        - Runners
         - Subjects
     ExampleGroups:
       inherit_mode:
@@ -81,12 +79,6 @@ RSpec:
       - prepend_after
       - after
       - append_after
-    HookScopes:
-      - each
-      - example
-      - context
-      - all
-      - suite
     Includes:
       inherit_mode:
         merge:
@@ -98,10 +90,6 @@ RSpec:
         - include_examples
       Context:
         - include_context
-    Runners:
-      - to
-      - to_not
-      - not_to
     SharedGroups:
       inherit_mode:
         merge:
@@ -159,13 +147,17 @@ RSpec/Be:
 RSpec/BeEq:
   Description: Check for expectations where `be(...)` can replace `eq(...)`.
   Enabled: pending
+  Safe: false
   VersionAdded: 2.9.0
+  VersionChanged: '2.16'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeEq
 
 RSpec/BeEql:
   Description: Check for expectations where `be(...)` can replace `eql(...)`.
   Enabled: true
+  Safe: false
   VersionAdded: '1.7'
+  VersionChanged: '2.16'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeEql
 
 RSpec/BeNil:
@@ -296,6 +288,12 @@ RSpec/Dialect:
   VersionAdded: '1.33'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Dialect
 
+RSpec/DuplicatedMetadata:
+  Description: Avoid duplicated metadata.
+  Enabled: pending
+  VersionAdded: '2.16'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DuplicatedMetadata
+
 RSpec/EmptyExampleGroup:
   Description: Checks if an example group does not include any tests.
   Enabled: true
@@ -368,12 +366,6 @@ RSpec/ExampleWithoutDescription:
   VersionAdded: '1.22'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWithoutDescription
 
-RSpec/ExcessiveDocstringSpacing:
-  Description: Checks for excessive whitespace in example descriptions.
-  Enabled: pending
-  VersionAdded: '2.5'
-  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExcessiveDocstringSpacing
-
 RSpec/ExampleWording:
   Description: Checks for common mistakes in example descriptions.
   Enabled: true
@@ -390,6 +382,12 @@ RSpec/ExampleWording:
   StyleGuide: https://rspec.rubystyle.guide/#should-in-example-docstrings
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
 
+RSpec/ExcessiveDocstringSpacing:
+  Description: Checks for excessive whitespace in example descriptions.
+  Enabled: pending
+  VersionAdded: '2.5'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExcessiveDocstringSpacing
+
 RSpec/ExpectActual:
   Description: Checks for `expect(...)` calls containing literal values.
   Enabled: true
@@ -624,8 +622,13 @@ RSpec/MultipleSubjects:
 RSpec/NamedSubject:
   Description: Checks for explicitly referenced test subjects.
   Enabled: true
+  EnforcedStyle: always
+  SupportedStyles:
+    - always
+    - named_only
   IgnoreSharedExamples: true
   VersionAdded: 1.5.3
+  VersionChanged: '2.15'
   StyleGuide: https://rspec.rubystyle.guide/#use-subject
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NamedSubject
 
@@ -671,6 +674,12 @@ RSpec/Pending:
   VersionAdded: '1.25'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Pending
 
+RSpec/PendingWithoutReason:
+  Description: Checks for pending or skipped examples without reason.
+  Enabled: pending
+  VersionAdded: '2.16'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PendingWithoutReason
+
 RSpec/PredicateMatcher:
   Description: Prefer using predicate matcher over using predicate method directly.
   Enabled: true
@@ -967,6 +976,16 @@ RSpec/FactoryBot/FactoryClassName:
   VersionChanged: '2.0'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/FactoryClassName
 
+RSpec/FactoryBot/FactoryNameStyle:
+  Description: Checks for name style for argument of FactoryBot::Syntax::Methods.
+  Enabled: pending
+  VersionAdded: '2.16'
+  EnforcedStyle: symbol
+  SupportedStyles:
+    - symbol
+    - string
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/FactoryNameStyle
+
 RSpec/FactoryBot/SyntaxMethods:
   Description: Use shorthands from `FactoryBot::Syntax::Methods` in your specs.
   Enabled: pending
@@ -992,6 +1011,17 @@ RSpec/Rails/HaveHttpStatus:
   VersionAdded: '2.12'
   Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HaveHttpStatus
 
+RSpec/Rails/HttpStatus:
+  Description: Enforces use of symbolic or numeric value to describe HTTP status.
+  Enabled: true
+  EnforcedStyle: symbolic
+  SupportedStyles:
+    - numeric
+    - symbolic
+  VersionAdded: '1.23'
+  VersionChanged: '2.0'
+  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus
+
 RSpec/Rails/InferredSpecType:
   Description: Identifies redundant spec type.
   Enabled: pending
@@ -1014,14 +1044,3 @@ RSpec/Rails/InferredSpecType:
     routing: routing
     system: system
     views: view
-
-RSpec/Rails/HttpStatus:
-  Description: Enforces use of symbolic or numeric value to describe HTTP status.
-  Enabled: true
-  EnforcedStyle: symbolic
-  SupportedStyles:
-    - numeric
-    - symbolic
-  VersionAdded: '1.23'
-  VersionChanged: '2.0'
-  Reference: https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/HttpStatus

data/lib/rubocop/cop/rspec/be.rb

@@ -21,6 +21,8 @@ module RuboCop
       class Be < Base
         MSG = "Don't use `be` without an argument."
 
+        RESTRICT_ON_SEND = Runners.all
+
         # @!method be_without_args(node)
         def_node_matcher :be_without_args, <<-PATTERN
           (send _ #Runners.all $(send nil? :be))

data/lib/rubocop/cop/rspec/be_eq.rb

@@ -9,6 +9,9 @@ module RuboCop
       # using `==`. Booleans and nil can be compared by identity and therefore
       # the `be` matcher is preferable as it is a more strict test.
       #
+      # @safety
+      #   This cop is unsafe because it changes how values are compared.
+      #
       # @example
       #   # bad
       #   expect(foo).to eq(true)

data/lib/rubocop/cop/rspec/be_eql.rb

@@ -10,6 +10,9 @@ module RuboCop
       # can be compared by identity and therefore the `be` matcher is
       # preferable as it is a more strict test.
       #
+      # @safety
+      #   This cop is unsafe because it changes how values are compared.
+      #
       # @example
       #   # bad
       #   expect(foo).to eql(1)

data/lib/rubocop/cop/rspec/capybara/current_path_expectation.rb

@@ -29,7 +29,7 @@ module RuboCop
         #   # good
         #   expect(page).to have_current_path('/callback')
         #
-        class CurrentPathExpectation < Base
+        class CurrentPathExpectation < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           MSG = 'Do not set an RSpec expectation on `current_path` in ' \
@@ -47,14 +47,14 @@ module RuboCop
           # @!method as_is_matcher(node)
           def_node_matcher :as_is_matcher, <<-PATTERN
             (send
-              #expectation_set_on_current_path $#Runners.all
+              #expectation_set_on_current_path ${:to :to_not :not_to}
               ${(send nil? :eq ...) (send nil? :match (regexp ...))})
           PATTERN
 
           # @!method regexp_str_matcher(node)
           def_node_matcher :regexp_str_matcher, <<-PATTERN
             (send
-              #expectation_set_on_current_path $#Runners.all
+              #expectation_set_on_current_path ${:to :to_not :not_to}
               $(send nil? :match (str $_)))
           PATTERN
 

data/lib/rubocop/cop/rspec/capybara/negation_matcher.rb

@@ -24,7 +24,7 @@ module RuboCop
         #   expect(page).to have_no_selector
         #   expect(page).to have_no_css('a')
         #
-        class NegationMatcher < Base
+        class NegationMatcher < ::RuboCop::Cop::Base
           extend AutoCorrector
           include ConfigurableEnforcedStyle
 

data/lib/rubocop/cop/rspec/capybara/specific_actions.rb

@@ -20,7 +20,7 @@ module RuboCop
         #   click_link(exact_text: 'foo')
         #   find('div').click_button
         #
-        class SpecificActions < Base
+        class SpecificActions < ::RuboCop::Cop::Base
           MSG = "Prefer `%<good_action>s` over `find('%<selector>s').click`."
           RESTRICT_ON_SEND = %i[click].freeze
           SPECIFIC_ACTION = {

data/lib/rubocop/cop/rspec/capybara/specific_finders.rb

@@ -15,7 +15,7 @@ module RuboCop
         #   find_by_id('some-id')
         #   find_by_id('some-id', visible: true)
         #
-        class SpecificFinders < Base
+        class SpecificFinders < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           include RangeHelp

data/lib/rubocop/cop/rspec/capybara/specific_matcher.rb

@@ -26,9 +26,7 @@ module RuboCop
         #   expect(page).to have_select
         #   expect(page).to have_field('foo')
         #
-        class SpecificMatcher < Base
-          include CapybaraHelp
-
+        class SpecificMatcher < ::RuboCop::Cop::Base
           MSG = 'Prefer `%<good_matcher>s` over `%<bad_matcher>s`.'
           RESTRICT_ON_SEND = %i[have_selector have_no_selector have_css
                                 have_no_css].freeze
@@ -49,8 +47,8 @@ module RuboCop
             first_argument(node) do |arg|
               next unless (matcher = specific_matcher(arg))
               next if CssSelector.multiple_selectors?(arg)
-              next unless specific_option?(node, arg, matcher)
-              next unless specific_pseudo_classes?(arg)
+              next unless CapybaraHelp.specific_option?(node, arg, matcher)
+              next unless CapybaraHelp.specific_pseudo_classes?(arg)
 
               add_offense(node, message: message(node, matcher))
             end

data/lib/rubocop/cop/rspec/capybara/visibility_matcher.rb

@@ -26,7 +26,7 @@ module RuboCop
         #   expect(page).to have_css('.foo', visible: :all)
         #   expect(page).to have_link('my link', visible: :hidden)
         #
-        class VisibilityMatcher < Base
+        class VisibilityMatcher < ::RuboCop::Cop::Base
           MSG_FALSE = 'Use `:all` or `:hidden` instead of `false`.'
           MSG_TRUE = 'Use `:visible` instead of `true`.'
           CAPYBARA_MATCHER_METHODS = %w[

data/lib/rubocop/cop/rspec/duplicated_metadata.rb

@@ -0,0 +1,58 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Avoid duplicated metadata.
+      #
+      # @example
+      #   # bad
+      #   describe 'Something', :a, :a
+      #
+      #   # good
+      #   describe 'Something', :a
+      class DuplicatedMetadata < Base
+        extend AutoCorrector
+
+        include Metadata
+        include RangeHelp
+
+        MSG = 'Avoid duplicated metadata.'
+
+        def on_metadata(symbols, _pairs)
+          symbols.each do |symbol|
+            on_metadata_symbol(symbol)
+          end
+        end
+
+        private
+
+        def on_metadata_symbol(node)
+          return unless duplicated?(node)
+
+          add_offense(node) do |corrector|
+            autocorrect(corrector, node)
+          end
+        end
+
+        def autocorrect(corrector, node)
+          corrector.remove(
+            range_with_surrounding_comma(
+              range_with_surrounding_space(
+                node.location.expression,
+                side: :left
+              ),
+              :left
+            )
+          )
+        end
+
+        def duplicated?(node)
+          node.left_siblings.any? do |sibling|
+            sibling.eql?(node)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/empty_line_after_example.rb

@@ -55,6 +55,8 @@ module RuboCop
           end
         end
 
+        private
+
         def allowed_one_liner?(node)
           consecutive_one_liner?(node) && allow_consecutive_one_liners?
         end

data/lib/rubocop/cop/rspec/expect_actual.rb

@@ -26,6 +26,8 @@ module RuboCop
 
         MSG = 'Provide the actual you are testing to `expect(...)`.'
 
+        RESTRICT_ON_SEND = Runners.all
+
         SIMPLE_LITERALS = %i[
           true
           false

data/lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb

@@ -25,7 +25,7 @@ module RuboCop
         #   # good
         #   count { 1 }
         #
-        class AttributeDefinedStatically < Base
+        class AttributeDefinedStatically < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           MSG = 'Use a block to declare attribute values.'

data/lib/rubocop/cop/rspec/factory_bot/consistent_parentheses_style.rb

@@ -40,7 +40,7 @@ module RuboCop
         #     name: 'foo'
         #   )
         #
-        class ConsistentParenthesesStyle < Base
+        class ConsistentParenthesesStyle < ::RuboCop::Cop::Base
           extend AutoCorrector
           include ConfigurableEnforcedStyle
           include RuboCop::RSpec::FactoryBot::Language
@@ -55,17 +55,22 @@ module RuboCop
 
           FACTORY_CALLS = RuboCop::RSpec::FactoryBot::Language::METHODS
 
+          RESTRICT_ON_SEND = FACTORY_CALLS
+
           # @!method factory_call(node)
           def_node_matcher :factory_call, <<-PATTERN
-              (send
-                ${#factory_bot? nil?} %FACTORY_CALLS
-              $...)
+            (send
+              {#factory_bot? nil?} %FACTORY_CALLS
+              {sym str send lvar} _*
+            )
           PATTERN
 
           def on_send(node)
-            return if nested_call?(node) # prevent from nested matching
+            return if ambiguous_without_parentheses?(node)
 
             factory_call(node) do
+              return if node.method?(:generate) && node.arguments.count > 1
+
               if node.parenthesized?
                 process_with_parentheses(node)
               else
@@ -74,6 +79,8 @@ module RuboCop
             end
           end
 
+          private
+
           def process_with_parentheses(node)
             return unless style == :omit_parentheses
             return unless same_line?(node, node.first_argument)
@@ -93,12 +100,12 @@ module RuboCop
             end
           end
 
-          def nested_call?(node)
-            node.parent&.send_type?
+          def ambiguous_without_parentheses?(node)
+            node.parent&.send_type? ||
+              node.parent&.pair_type? ||
+              node.parent&.array_type?
           end
 
-          private
-
           def remove_parentheses(corrector, node)
             corrector.replace(node.location.begin, ' ')
             corrector.remove(node.location.end)

data/lib/rubocop/cop/rspec/factory_bot/create_list.rb

@@ -31,7 +31,7 @@ module RuboCop
         #   # good
         #   3.times { create :user }
         #
-        class CreateList < Base
+        class CreateList < ::RuboCop::Cop::Base
           extend AutoCorrector
           include ConfigurableEnforcedStyle
           include RuboCop::RSpec::FactoryBot::Language
@@ -143,7 +143,7 @@ module RuboCop
 
             def call(corrector)
               replacement = generate_n_times_block(node)
-              corrector.replace(node, replacement)
+              corrector.replace(node.block_node || node, replacement)
             end
 
             private
@@ -159,8 +159,15 @@ module RuboCop
 
               replacement = format_receiver(node.receiver)
               replacement += format_method_call(node, 'create', arguments)
+              replacement += " #{factory_call_block_source}" if node.block_node
               "#{count.source}.times { #{replacement} }"
             end
+
+            def factory_call_block_source
+              node.block_node.location.begin.with(
+                end_pos: node.block_node.location.end.end_pos
+              ).source
+            end
           end
 
           # :nodoc:

data/lib/rubocop/cop/rspec/factory_bot/factory_class_name.rb

@@ -20,7 +20,7 @@ module RuboCop
         #   factory :foo, class: 'Foo' do
         #   end
         #
-        class FactoryClassName < Base
+        class FactoryClassName < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           MSG = "Pass '%<class_name>s' string instead of `%<class_name>s` " \

data/lib/rubocop/cop/rspec/factory_bot/factory_name_style.rb

@@ -0,0 +1,74 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      module FactoryBot
+        # Checks for name style for argument of FactoryBot::Syntax::Methods.
+        #
+        # @example EnforcedStyle: symbol (default)
+        #   # bad
+        #   create('user')
+        #   build "user", username: "NAME"
+        #
+        #   # good
+        #   create(:user)
+        #   build :user, username: "NAME"
+        #
+        # @example EnforcedStyle: string
+        #   # bad
+        #   create(:user)
+        #   build :user, username: "NAME"
+        #
+        #   # good
+        #   create('user')
+        #   build "user", username: "NAME"
+        #
+        class FactoryNameStyle < ::RuboCop::Cop::Base
+          extend AutoCorrector
+          include ConfigurableEnforcedStyle
+          include RuboCop::RSpec::FactoryBot::Language
+
+          MSG = 'Use %<prefer>s to refer to a factory.'
+          FACTORY_CALLS = RuboCop::RSpec::FactoryBot::Language::METHODS
+          RESTRICT_ON_SEND = FACTORY_CALLS
+
+          # @!method factory_call(node)
+          def_node_matcher :factory_call, <<-PATTERN
+          (send
+            {#factory_bot? nil?} %FACTORY_CALLS
+            ${str sym} ...
+          )
+          PATTERN
+
+          def on_send(node)
+            factory_call(node) do |name|
+              if offense_for_symbol_style?(name)
+                register_offense(name, name.value.to_sym.inspect)
+              elsif offense_for_string_style?(name)
+                register_offense(name, name.value.to_s.inspect)
+              end
+            end
+          end
+
+          private
+
+          def offense_for_symbol_style?(name)
+            name.str_type? && style == :symbol
+          end
+
+          def offense_for_string_style?(name)
+            name.sym_type? && style == :string
+          end
+
+          def register_offense(name, prefer)
+            add_offense(name,
+                        message: format(MSG, prefer: style.to_s)) do |corrector|
+              corrector.replace(name, prefer)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/implicit_expect.rb

@@ -28,6 +28,8 @@ module RuboCop
 
         MSG = 'Prefer `%<good>s` over `%<bad>s`.'
 
+        RESTRICT_ON_SEND = Runners.all + %i[should should_not]
+
         # @!method implicit_expect(node)
         def_node_matcher :implicit_expect, <<-PATTERN
           {

data/lib/rubocop/cop/rspec/leading_subject.rb

@@ -44,6 +44,8 @@ module RuboCop
           check_previous_nodes(node)
         end
 
+        private
+
         def check_previous_nodes(node)
           offending_node(node) do |offender|
             msg = format(MSG, offending: offender.method_name)
@@ -53,8 +55,6 @@ module RuboCop
           end
         end
 
-        private
-
         def offending_node(node)
           parent(node).each_child_node.find do |sibling|
             break if sibling.equal?(node)

data/lib/rubocop/cop/rspec/message_spies.rb

@@ -41,6 +41,8 @@ module RuboCop
 
         SUPPORTED_STYLES = %w[have_received receive].freeze
 
+        RESTRICT_ON_SEND = Runners.all
+
         # @!method message_expectation(node)
         def_node_matcher :message_expectation, %(
           (send (send nil? :expect $_) #Runners.all ...)