rubocop-rspec 1.9.1 → 1.10.0

data/spec/rubocop/cop/rspec/repeated_example_spec.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+describe RuboCop::Cop::RSpec::RepeatedExample do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offense for repeated example' do
+    expect_violation(<<-RUBY)
+      describe 'doing x' do
+        it "does x" do
+        ^^^^^^^^^^^^^^ Don't repeat examples within an example group.
+          expect(foo).to be(bar)
+        end
+
+        it "does y" do
+        ^^^^^^^^^^^^^^ Don't repeat examples within an example group.
+          expect(foo).to be(bar)
+        end
+      end
+    RUBY
+  end
+
+  it 'does not register a violation if rspec tag magic is involved' do
+    expect_no_violations(<<-RUBY)
+      describe 'doing x' do
+        it "does x" do
+          expect(foo).to be(bar)
+        end
+
+        it "does y", :focus do
+          expect(foo).to be(bar)
+        end
+      end
+    RUBY
+  end
+
+  it 'does not flag examples with different implementations' do
+    expect_no_violations(<<-RUBY)
+      describe 'doing x' do
+        it "does x" do
+          expect(foo).to have_attribute(foo: 1)
+        end
+
+        it "does y" do
+          expect(foo).to have_attribute(bar: 2)
+        end
+      end
+    RUBY
+  end
+
+  it 'does not flag repeated examples in different scopes' do
+    expect_no_violations(<<-RUBY)
+      describe 'doing x' do
+        it "does x" do
+          expect(foo).to be(bar)
+        end
+
+        context 'when the scope changes' do
+          it 'does not flag anything' do
+            expect(foo).to be(bar)
+          end
+        end
+      end
+    RUBY
+  end
+end

data/spec/rubocop/cop/rspec/scattered_setup_spec.rb

@@ -0,0 +1,96 @@
+describe RuboCop::Cop::RSpec::ScatteredSetup do
+  subject(:cop) { described_class.new }
+
+  it 'flags multiple hooks in the same example group' do
+    expect_violation(<<-RUBY)
+      describe Foo do
+        before { bar }
+        ^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
+        before { baz }
+        ^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
+      end
+    RUBY
+  end
+
+  it 'flags multiple hooks of the same scope with different symbols' do
+    expect_violation(<<-RUBY)
+      describe Foo do
+        before { bar }
+        ^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
+        before(:each) { baz }
+        ^^^^^^^^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
+        before(:example) { baz }
+        ^^^^^^^^^^^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
+      end
+    RUBY
+  end
+
+  it 'flags multiple before(:all) hooks in the same example group' do
+    expect_violation(<<-RUBY)
+      describe Foo do
+        before(:all) { bar }
+        ^^^^^^^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
+        before(:all) { baz }
+        ^^^^^^^^^^^^^^^^^^^^ Do not define multiple hooks in the same example group.
+      end
+    RUBY
+  end
+
+  it 'does not flag different hooks' do
+    expect_no_violations(<<-RUBY)
+      describe Foo do
+        before { bar }
+        after { baz }
+        around { qux }
+      end
+    RUBY
+  end
+
+  it 'does not flag different hook types' do
+    expect_no_violations(<<-RUBY)
+      describe Foo do
+        before { bar }
+        before(:all) { baz }
+        before(:suite) { baz }
+      end
+    RUBY
+  end
+
+  it 'does not flag hooks in different example groups' do
+    expect_no_violations(<<-RUBY)
+      describe Foo do
+        before { bar }
+
+        describe '.baz' do
+          before { baz }
+        end
+      end
+    RUBY
+  end
+
+  it 'does not flag hooks in different shared contexts' do
+    expect_no_violations(<<-RUBY)
+      describe Foo do
+        shared_context 'one' do
+          before { bar }
+        end
+
+        shared_context 'two' do
+          before { baz }
+        end
+      end
+    RUBY
+  end
+
+  it 'does not flag similar method names inside of examples' do
+    expect_no_violations(<<-RUBY)
+      describe Foo do
+        before { bar }
+
+        it 'uses an instance method called before' do
+          expect(before { tricky }).to_not confuse_rubocop_rspec
+        end
+      end
+    RUBY
+  end
+end

data/spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb

@@ -11,6 +11,12 @@ describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
       RUBY
     end
 
+    include_examples(
+      'autocorrect',
+      'before { allow(foo).to receive_message_chain(:one) { :two } }',
+      'before { allow(foo).to receive(:one) { :two } }'
+    )
+
     it 'accepts multi-argument calls' do
       expect_no_violations(<<-RUBY)
         before do
@@ -28,6 +34,12 @@ describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
       RUBY
     end
 
+    include_examples(
+      'autocorrect',
+      'before { allow(foo).to receive_message_chain("one") { :two } }',
+      'before { allow(foo).to receive("one") { :two } }'
+    )
+
     it 'accepts multi-argument string calls' do
       expect_no_violations(<<-RUBY)
         before do
@@ -47,6 +59,12 @@ describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
       RUBY
     end
 
+    include_examples(
+      'autocorrect',
+      'before { foo.stub_chain(:one) { :two } }',
+      'before { foo.stub(:one) { :two } }'
+    )
+
     it 'accepts multi-argument calls' do
       expect_no_violations(<<-RUBY)
         before do
@@ -58,16 +76,22 @@ describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
     it 'reports single-argument string calls' do
       expect_violation(<<-RUBY)
         before do
-          allow(foo).to stub_chain("one") { :two }
-                        ^^^^^^^^^^ Use `stub` instead of calling `stub_chain` with a single argument
+          foo.stub_chain("one") { :two }
+              ^^^^^^^^^^ Use `stub` instead of calling `stub_chain` with a single argument
         end
       RUBY
     end
 
+    include_examples(
+      'autocorrect',
+      'before { foo.stub_chain("one") { :two } }',
+      'before { foo.stub("one") { :two } }'
+    )
+
     it 'accepts multi-argument string calls' do
       expect_no_violations(<<-RUBY)
         before do
-          allow(foo).to stub_chain("one.two") { :three }
+          foo.stub_chain("one.two") { :three }
         end
       RUBY
     end

data/spec/rubocop/rspec/description_extractor_spec.rb

@@ -39,7 +39,7 @@ RSpec.describe RuboCop::RSpec::DescriptionExtractor do
   def stub_cop_const(name)
     stub_const(
       "RuboCop::Cop::RSpec::#{name}",
-      Class.new(RuboCop::Cop::Cop)
+      Class.new(RuboCop::Cop.const_get(:WorkaroundCop))
     )
   end
 

data/spec/rubocop/rspec/example_group_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::RSpec::ExampleGroup do
-  include RuboCop::Sexp
+  include RuboCop::AST::Sexp
 
   subject(:group) { described_class.new(parse_source(source).ast) }
 

data/spec/rubocop/rspec/example_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 RSpec.describe RuboCop::RSpec::Example do
-  include RuboCop::Sexp
+  include RuboCop::AST::Sexp
 
   def example(source)
     described_class.new(parse_source(source).ast)
@@ -23,7 +23,7 @@ RSpec.describe RuboCop::RSpec::Example do
 
   it 'extracts keywords' do
     expect(example("it('foo', :bar, baz: :qux) { a }").metadata)
-      .to eql([s(:sym, :bar), s(:hash, s(:pair, s(:sym, :baz), s(:sym, :qux)))])
+      .to eq([s(:sym, :bar), s(:hash, s(:pair, s(:sym, :baz), s(:sym, :qux)))])
   end
 
   it 'extracts implementation' do

data/spec/rubocop/rspec/hook_spec.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::RSpec::Hook do
+  include RuboCop::AST::Sexp
+
+  def hook(source)
+    described_class.new(parse_source(source).ast)
+  end
+
+  it 'extracts name' do
+    expect(hook('around(:each) { }').name).to be(:around)
+  end
+
+  it 'does not break if a hook is not given a symbol literal' do
+    expect(hook('before(scope) { example_setup }').knowable_scope?).to be(false)
+  end
+
+  it 'knows the scope of a hook with a symbol literal' do
+    expect(hook('before { example_setup }').knowable_scope?).to be(true)
+  end
+
+  it 'ignores other arguments to hooks' do
+    expect(hook('before(:each, :metadata) { example_setup }').scope)
+      .to be(:each)
+  end
+
+  it 'classifies nonstandard hook arguments as invalid' do
+    expect(hook('before(:nothing) { example_setup }').valid_scope?).to be(false)
+  end
+
+  it 'classifies :each as a valid hook argument' do
+    expect(hook('before(:each) { example_setup }').valid_scope?).to be(true)
+  end
+
+  it 'classifies :each as an example hook' do
+    expect(hook('before(:each) { }').example?).to be(true)
+  end
+
+  shared_examples 'standardizes scope' do |source, scope|
+    it "interprets #{source} as having scope #{scope}" do
+      expect(hook(source).scope).to equal(scope)
+    end
+  end
+
+  include_examples 'standardizes scope', 'before(:each) { }',    :each
+  include_examples 'standardizes scope', 'around(:example) { }', :each
+  include_examples 'standardizes scope', 'after { }',            :each
+
+  include_examples 'standardizes scope', 'before(:all) { }',     :context
+  include_examples 'standardizes scope', 'around(:context) { }', :context
+
+  include_examples 'standardizes scope', 'after(:suite) { }', :suite
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.9.1
+  version: 1.10.0
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-03 00:00:00.000000000 Z
+date: 2017-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -154,6 +154,7 @@ files:
 - lib/rubocop/cop/rspec/example_length.rb
 - lib/rubocop/cop/rspec/example_wording.rb
 - lib/rubocop/cop/rspec/expect_actual.rb
+- lib/rubocop/cop/rspec/expect_output.rb
 - lib/rubocop/cop/rspec/file_path.rb
 - lib/rubocop/cop/rspec/focus.rb
 - lib/rubocop/cop/rspec/hook_argument.rb
@@ -170,14 +171,18 @@ files:
 - lib/rubocop/cop/rspec/nested_groups.rb
 - lib/rubocop/cop/rspec/not_to_not.rb
 - lib/rubocop/cop/rspec/repeated_description.rb
+- lib/rubocop/cop/rspec/repeated_example.rb
+- lib/rubocop/cop/rspec/scattered_setup.rb
 - lib/rubocop/cop/rspec/single_argument_message_chain.rb
 - lib/rubocop/cop/rspec/subject_stub.rb
 - lib/rubocop/cop/rspec/verified_doubles.rb
 - lib/rubocop/rspec.rb
+- lib/rubocop/rspec/concept.rb
 - lib/rubocop/rspec/config_formatter.rb
 - lib/rubocop/rspec/description_extractor.rb
 - lib/rubocop/rspec/example.rb
 - lib/rubocop/rspec/example_group.rb
+- lib/rubocop/rspec/hook.rb
 - lib/rubocop/rspec/inject.rb
 - lib/rubocop/rspec/language.rb
 - lib/rubocop/rspec/language/node_pattern.rb
@@ -200,6 +205,7 @@ files:
 - spec/rubocop/cop/rspec/example_length_spec.rb
 - spec/rubocop/cop/rspec/example_wording_spec.rb
 - spec/rubocop/cop/rspec/expect_actual_spec.rb
+- spec/rubocop/cop/rspec/expect_output_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/hook_argument_spec.rb
@@ -216,6 +222,8 @@ files:
 - spec/rubocop/cop/rspec/nested_groups_spec.rb
 - spec/rubocop/cop/rspec/not_to_not_spec.rb
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
+- spec/rubocop/cop/rspec/repeated_example_spec.rb
+- spec/rubocop/cop/rspec/scattered_setup_spec.rb
 - spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb
 - spec/rubocop/cop/rspec/subject_stub_spec.rb
 - spec/rubocop/cop/rspec/verified_doubles_spec.rb
@@ -223,6 +231,7 @@ files:
 - spec/rubocop/rspec/description_extractor_spec.rb
 - spec/rubocop/rspec/example_group_spec.rb
 - spec/rubocop/rspec/example_spec.rb
+- spec/rubocop/rspec/hook_spec.rb
 - spec/rubocop/rspec/language/selector_set_spec.rb
 - spec/rubocop/rspec/util/one_spec.rb
 - spec/rubocop/rspec/wording_spec.rb
@@ -269,6 +278,7 @@ test_files:
 - spec/rubocop/cop/rspec/example_length_spec.rb
 - spec/rubocop/cop/rspec/example_wording_spec.rb
 - spec/rubocop/cop/rspec/expect_actual_spec.rb
+- spec/rubocop/cop/rspec/expect_output_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/hook_argument_spec.rb
@@ -285,6 +295,8 @@ test_files:
 - spec/rubocop/cop/rspec/nested_groups_spec.rb
 - spec/rubocop/cop/rspec/not_to_not_spec.rb
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
+- spec/rubocop/cop/rspec/repeated_example_spec.rb
+- spec/rubocop/cop/rspec/scattered_setup_spec.rb
 - spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb
 - spec/rubocop/cop/rspec/subject_stub_spec.rb
 - spec/rubocop/cop/rspec/verified_doubles_spec.rb
@@ -292,6 +304,7 @@ test_files:
 - spec/rubocop/rspec/description_extractor_spec.rb
 - spec/rubocop/rspec/example_group_spec.rb
 - spec/rubocop/rspec/example_spec.rb
+- spec/rubocop/rspec/hook_spec.rb
 - spec/rubocop/rspec/language/selector_set_spec.rb
 - spec/rubocop/rspec/util/one_spec.rb
 - spec/rubocop/rspec/wording_spec.rb