rubocop-rspec 1.9.0 → 1.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d160e862b58dbfd9bcd2ae0966bd185d1ed13d25
-  data.tar.gz: 3b32f0c16a19b8f110e40d79f4a87d510e3c9226
+  metadata.gz: 7161e38d3d46174e4acad35bf1ab6b7fdd8d62d4
+  data.tar.gz: d9b7e70692513359abc3501795939c31075bd3dc
 SHA512:
-  metadata.gz: b429eb8553d36a1aec8613f57a4f3356518acb89ade8e41f96093dc6ba430b592b3a35899dcefe8df5833a1c0ceb7afa8d3bf1431ad554ffaeb057b2775df622
-  data.tar.gz: 4bc98868826de4ba820c107b5507beb1b57259d147199cec394054c5ac6887786ba1db1ce396bfcfe8ed345387b736b73b18c8b0e1bf0f3b3841f665e7f23064
+  metadata.gz: 7d57d6b57e5333d78635bcc4282ece219f7c2ebc0b7ed394e65da9a4167861752ec69bc4e588038737c21af69b1cfe86959d82fef02cce16e9dccd2ef9718fd0
+  data.tar.gz: d961bdccd80bab88bb0c04f00c2e27003e7203aa212a0ec12f8403455e522d8b85b7171e0fd27e495dd524569df2246f3590dd660db7974997f052160f51c91b

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Master (unreleased)
 
+## 1.9.1 (2017-01-02)
+
+* Fix unintentional regression change in `NestedGroups` reported in #270. ([@backus][])
+* Change `MaxNesting` for `NestedGroups` from 2 to 3. ([@backus][])
+
 ## 1.9.0 (2016-12-29)
 
 * Add `MessageSpies` cop for enforcing consistent style of either `expect(...).to have_received` or `expect(...).to receive`, intended as a replacement for the `MessageExpectation` cop. ([@bquorning][])

data/config/default.yml

@@ -127,7 +127,7 @@ RSpec/NamedSubject:
 RSpec/NestedGroups:
   Description: Checks for nested example groups.
   Enabled: true
-  MaxNesting: 2
+  MaxNesting: 3
 
 RSpec/NotToNot:
   Description: Checks for consistent method usage for negating expectations.

data/lib/rubocop/cop/rspec/multiple_expectations.rb

@@ -77,7 +77,7 @@ module RuboCop
         end
 
         def max_expectations
-          Integer(cop_config.fetch(parameter_name, 1))
+          Integer(cop_config.fetch('Max', 1))
         end
       end
     end

data/lib/rubocop/cop/rspec/nested_groups.rb

@@ -91,11 +91,8 @@ module RuboCop
 
         def_node_search :find_contexts, ExampleGroups::ALL.block_pattern
 
-        def on_block(node)
-          describe, = described_constant(node)
-          return unless describe
-
-          find_nested_contexts(node) do |context|
+        def on_top_level_describe(node, _)
+          find_nested_contexts(node.parent) do |context|
             add_offense(context.children.first, :expression)
           end
         end
@@ -113,7 +110,7 @@ module RuboCop
         end
 
         def max_nesting
-          Integer(cop_config.fetch('MaxNesting', 2))
+          Integer(cop_config.fetch('MaxNesting', 3))
         end
       end
     end

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.9.0'.freeze
+      STRING = '1.9.1'.freeze
     end
   end
 end

data/spec/rubocop/cop/rspec/nested_groups_spec.rb

@@ -8,7 +8,6 @@ describe RuboCop::Cop::RSpec::NestedGroups, :config do
       describe MyClass do
         context 'when foo' do
           context 'when bar' do
-          ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded
             context 'when baz' do
             ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded
             end
@@ -17,7 +16,6 @@ describe RuboCop::Cop::RSpec::NestedGroups, :config do
 
         context 'when qux' do
           context 'when norf' do
-          ^^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded
           end
         end
       end
@@ -35,14 +33,15 @@ describe RuboCop::Cop::RSpec::NestedGroups, :config do
     RUBY
   end
 
-  context 'when MaxNesting is configured as 3' do
-    let(:cop_config) { { 'MaxNesting' => '3' } }
+  context 'when MaxNesting is configured as 2' do
+    let(:cop_config) { { 'MaxNesting' => '2' } }
 
-    it 'only flags third level of nesting' do
+    it 'flags two levels of nesting' do
       expect_violation(<<-RUBY)
         describe MyClass do
           context 'when foo' do
             context 'when bar' do
+            ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded
               context 'when baz' do
               ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded
               end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.9.0
+  version: 1.9.1
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-29 00:00:00.000000000 Z
+date: 2017-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -250,7 +250,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Code style checking for RSpec files