rubocop-rspec 1.5.2 → 1.5.3

data/spec/rubocop/cop/rspec/describe_method_spec.rb

@@ -2,32 +2,31 @@ describe RuboCop::Cop::RSpec::DescribeMethod do
   subject(:cop) { described_class.new }
 
   it 'ignores describes with only a class' do
-    inspect_source(cop, 'describe Some::Class do; end')
-    expect(cop.offenses.empty?).to be(true)
+    expect_no_violations('describe Some::Class do; end')
   end
 
   it 'enforces non-method names' do
-    inspect_source(
-      cop,
-      "describe Some::Class, 'nope', '.incorrect_usage' do; end"
-    )
-
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([1])
-    expect(cop.messages)
-      .to eq(['The second argument to describe should be the method being ' \
-              "tested. '#instance' or '.class'"])
+    expect_violation(<<-RUBY)
+      describe Some::Class, 'nope', '.incorrect_usage' do
+                            ^^^^^^ The second argument to describe should be the method being tested. '#instance' or '.class'
+      end
+    RUBY
   end
 
   it 'skips methods starting with a . or #' do
-    inspect_source(cop, ["describe Some::Class, '.asdf' do; end",
-                         "describe Some::Class, '#fdsa' do; end"])
-    expect(cop.offenses).to be_empty
+    expect_no_violations(<<-RUBY)
+      describe Some::Class, '.asdf' do
+      end
+
+      describe Some::Class, '#fdsa' do
+      end
+    RUBY
   end
 
   it 'skips specs not having a string second argument' do
-    inspect_source(cop, 'describe Some::Class, :config do; end')
-
-    expect(cop.offenses).to be_empty
+    expect_no_violations(<<-RUBY)
+      describe Some::Class, :config do
+      end
+    RUBY
   end
 end

data/spec/rubocop/cop/rspec/described_class_spec.rb

@@ -2,176 +2,126 @@ describe RuboCop::Cop::RSpec::DescribedClass do
   subject(:cop) { described_class.new }
 
   it 'checks for the use of the described class' do
-    inspect_source(
-      cop,
-      [
-        'describe MyClass do',
-        '  include MyClass',
-        '  subject { MyClass.do_something }',
-        '  before { MyClass.do_something }',
-        'end'
-      ]
-    )
-    expect(cop.offenses.size).to eq(3)
-    expect(cop.offenses.map(&:line).sort).to eq([2, 3, 4])
-    expect(cop.messages)
-      .to eq(['Use `described_class` instead of `MyClass`'] * 3)
-    expect(cop.highlights).to eq(['MyClass'] * 3)
+    expect_violation(<<-RUBY)
+      describe MyClass do
+        include MyClass
+                ^^^^^^^ Use `described_class` instead of `MyClass`
+
+        subject { MyClass.do_something }
+                  ^^^^^^^ Use `described_class` instead of `MyClass`
+
+        before { MyClass.do_something }
+                 ^^^^^^^ Use `described_class` instead of `MyClass`
+      end
+    RUBY
   end
 
   it 'ignores described class as string' do
-    inspect_source(
-      cop,
-      [
-        'describe MyClass do',
-        '  subject { "MyClass" }',
-        'end'
-      ]
-    )
-    expect(cop.offenses).to be_empty
+    expect_no_violations(<<-RUBY)
+      describe MyClass do
+        subject { "MyClass" }
+      end
+    RUBY
   end
 
   it 'ignores describe that do not referece to a class' do
-    inspect_source(
-      cop,
-      [
-        'describe "MyClass" do',
-        '  subject { "MyClass" }',
-        'end'
-      ]
-    )
-    expect(cop.offenses).to be_empty
+    expect_no_violations(<<-RUBY)
+      describe "MyClass" do
+        subject { "MyClass" }
+      end
+    RUBY
   end
 
   it 'ignores class if the scope is changing' do
-    inspect_source(
-      cop,
-      [
-        'describe MyClass do',
-        '  def method',
-        '    include MyClass',
-        '  end',
-        '  class OtherClass',
-        '    include MyClass',
-        '  end',
-        '  module MyModle',
-        '    include MyClass',
-        '  end',
-        'end'
-      ]
-    )
-    expect(cop.offenses).to be_empty
+    expect_no_violations(<<-RUBY)
+      describe MyClass do
+        def method
+          include MyClass
+        end
+
+        class OtherClass
+          include MyClass
+        end
+
+        module MyModle
+          include MyClass
+        end
+      end
+    RUBY
   end
 
   it 'only takes class from top level describes' do
-    inspect_source(
-      cop,
-      [
-        'describe MyClass do',
-        '  describe MyClass::Foo do',
-        '    subject { MyClass::Foo }',
-        '    let(:foo) { MyClass }',
-        '  end',
-        'end'
-      ]
-    )
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([4])
-    expect(cop.messages)
-      .to eq(['Use `described_class` instead of `MyClass`'])
-    expect(cop.highlights).to eq(['MyClass'])
+    expect_violation(<<-RUBY)
+      describe MyClass do
+        describe MyClass::Foo do
+          subject { MyClass::Foo }
+
+          let(:foo) { MyClass }
+                      ^^^^^^^ Use `described_class` instead of `MyClass`
+        end
+      end
+    RUBY
   end
 
   it 'ignores subclasses' do
-    inspect_source(
-      cop,
-      [
-        'describe MyClass do',
-        '  subject { MyClass::SubClass }',
-        'end'
-      ]
-    )
-    expect(cop.offenses).to be_empty
+    expect_no_violations(<<-RUBY)
+      describe MyClass do
+        subject { MyClass::SubClass }
+      end
+    RUBY
   end
 
   it 'ignores if namespace is not matching' do
-    inspect_source(
-      cop,
-      [
-        'describe MyNamespace::MyClass do',
-        '  subject { ::MyClass }',
-        '  let(:foo) { MyClass }',
-        'end'
-      ]
-    )
-    expect(cop.offenses).to be_empty
+    expect_no_violations(<<-RUBY)
+      describe MyNamespace::MyClass do
+        subject { ::MyClass }
+        let(:foo) { MyClass }
+      end
+    RUBY
   end
 
   it 'checks for the use of described class with namespace' do
-    inspect_source(
-      cop,
-      [
-        'describe MyNamespace::MyClass do',
-        '  subject { MyNamespace::MyClass }',
-        'end'
-      ]
-    )
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([2])
-    expect(cop.messages)
-      .to eq(['Use `described_class` instead of `MyNamespace::MyClass`'])
-    expect(cop.highlights).to eq(['MyNamespace::MyClass'])
+    expect_violation(<<-RUBY)
+      describe MyNamespace::MyClass do
+        subject { MyNamespace::MyClass }
+                  ^^^^^^^^^^^^^^^^^^^^ Use `described_class` instead of `MyNamespace::MyClass`
+      end
+    RUBY
   end
 
   it 'does not flag violations within a scope change' do
-    inspect_source(
-      cop,
-      [
-        'describe MyNamespace::MyClass do',
-        '  before do',
-        '    class Foo',
-        '      thing = MyNamespace::MyClass.new',
-        '    end',
-        '  end',
-        'end'
-      ]
-    )
-
-    expect(cop.offenses).to be_empty
+    expect_no_violations(<<-RUBY)
+      describe MyNamespace::MyClass do
+        before do
+          class Foo
+            thing = MyNamespace::MyClass.new
+          end
+        end
+      end
+    RUBY
   end
 
   it 'does not flag violations within a scope change' do
-    inspect_source(
-      cop,
-      [
-        'describe do',
-        '  before do',
-        '    MyNamespace::MyClass.new',
-        '  end',
-        'end'
-      ]
-    )
-
-    expect(cop.offenses).to be_empty
+    expect_no_violations(<<-RUBY)
+      describe do
+        before do
+          MyNamespace::MyClass.new
+        end
+      end
+    RUBY
   end
 
   it 'checks for the use of described class with module' do
     skip
-    inspect_source(
-      lcop,
-      [
-        'module MyNamespace',
-        '  describe MyClass do',
-        '    subject { MyNamespace::MyClass }',
-        '  end',
-        'end'
-      ]
-    )
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([2])
-    expect(cop.messages)
-      .to eq(['Use `described_class` instead of `MyNamespace::MyClass`'])
-    expect(cop.highlights).to eq(['MyNamespace::MyClass'])
+
+    expect_violation(<<-RUBY)
+      module MyNamespace
+        describe MyClass do
+          subject { MyNamespace::MyClass }
+                    ^^^^^^^^^^^^^^^^^^^^ Use `described_class` instead of `MyNamespace::MyClass`
+        end
+      end
+    RUBY
   end
 
   it 'autocorrects an offenses' do

data/spec/rubocop/cop/rspec/example_wording_spec.rb

@@ -10,47 +10,38 @@ describe RuboCop::Cop::RSpec::ExampleWording, :config do
     end
 
     it 'ignores non-example blocks' do
-      inspect_source(cop, 'foo "should do something" do; end')
-      expect(cop.offenses).to be_empty
+      expect_no_violations('foo "should do something" do; end')
     end
 
     it 'finds description with `should` at the beginning' do
-      inspect_source(cop, ["it 'should do something' do", 'end'])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.map(&:line).sort).to eq([1])
-      expect(cop.messages)
-        .to eq(['Do not use should when describing your tests.'])
-      expect(cop.highlights).to eq(['should do something'])
+      expect_violation(<<-RUBY)
+        it 'should do something' do
+            ^^^^^^^^^^^^^^^^^^^ Do not use should when describing your tests.
+        end
+      RUBY
     end
 
     it 'finds description with `Should` at the beginning' do
-      inspect_source(cop, ["it 'Should do something' do", 'end'])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.map(&:line).sort).to eq([1])
-      expect(cop.messages)
-        .to eq(['Do not use should when describing your tests.'])
-      expect(cop.highlights).to eq(['Should do something'])
+      expect_violation(<<-RUBY)
+        it 'Should do something' do
+            ^^^^^^^^^^^^^^^^^^^ Do not use should when describing your tests.
+        end
+      RUBY
     end
 
     it 'finds description with `shouldn\'t` at the beginning' do
-      inspect_source(cop, ['it "shouldn\'t do something" do', 'end'])
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.map(&:line).sort).to eq([1])
-      expect(cop.messages)
-        .to eq(['Do not use should when describing your tests.'])
-      expect(cop.highlights).to eq(['shouldn\'t do something'])
+      expect_violation(<<-RUBY)
+        it "shouldn't do something" do
+            ^^^^^^^^^^^^^^^^^^^^^^ Do not use should when describing your tests.
+        end
+      RUBY
     end
 
     it 'skips descriptions without `should` at the beginning' do
-      inspect_source(
-        cop,
-        [
-          "it 'finds no should ' \\",
-          "   'here' do",
-          'end'
-        ]
-      )
-      expect(cop.offenses).to be_empty
+      expect_no_violations(<<-RUBY)
+        it 'finds no should here' do
+        end
+      RUBY
     end
 
     it 'corrects `it "should only have"` to it "only has"' do

data/spec/rubocop/cop/rspec/focus_spec.rb

@@ -1,78 +1,130 @@
 describe RuboCop::Cop::RSpec::Focus do
   subject(:cop) { described_class.new }
 
-  [
-    :example_group, :describe, :context, :xdescribe, :xcontext,
-    :it, :example, :specify, :xit, :xexample, :xspecify,
-    :feature, :scenario, :xfeature, :xscenario
-  ].each do |block_type|
-    it "finds `#{block_type}` blocks with `focus: true`" do
-      inspect_source(
-        cop,
-        [
-          "#{block_type} 'test', meta: true, focus: true do",
-          'end'
-        ]
-      )
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.map(&:line).sort).to eq([1])
-      expect(cop.messages).to eq(['Focused spec found.'])
-      expect(cop.highlights).to eq(['focus: true'])
-    end
+  # rubocop:disable RSpec/ExampleLength
+  it 'flags all rspec example blocks with that include `focus: true`' do
+    expect_violation(<<-RUBY)
+      example 'test', meta: true, focus: true do; end
+                                  ^^^^^^^^^^^ Focused spec found.
+      xit 'test', meta: true, focus: true do; end
+                              ^^^^^^^^^^^ Focused spec found.
+      describe 'test', meta: true, focus: true do; end
+                                   ^^^^^^^^^^^ Focused spec found.
+      it 'test', meta: true, focus: true do; end
+                             ^^^^^^^^^^^ Focused spec found.
+      xspecify 'test', meta: true, focus: true do; end
+                                   ^^^^^^^^^^^ Focused spec found.
+      specify 'test', meta: true, focus: true do; end
+                                  ^^^^^^^^^^^ Focused spec found.
+      example_group 'test', meta: true, focus: true do; end
+                                        ^^^^^^^^^^^ Focused spec found.
+      scenario 'test', meta: true, focus: true do; end
+                                   ^^^^^^^^^^^ Focused spec found.
+      xexample 'test', meta: true, focus: true do; end
+                                   ^^^^^^^^^^^ Focused spec found.
+      xdescribe 'test', meta: true, focus: true do; end
+                                    ^^^^^^^^^^^ Focused spec found.
+      context 'test', meta: true, focus: true do; end
+                                  ^^^^^^^^^^^ Focused spec found.
+      xcontext 'test', meta: true, focus: true do; end
+                                   ^^^^^^^^^^^ Focused spec found.
+      feature 'test', meta: true, focus: true do; end
+                                  ^^^^^^^^^^^ Focused spec found.
+      xfeature 'test', meta: true, focus: true do; end
+                                   ^^^^^^^^^^^ Focused spec found.
+      xscenario 'test', meta: true, focus: true do; end
+                                    ^^^^^^^^^^^ Focused spec found.
+    RUBY
+  end
 
-    it "finds `#{block_type}` blocks with `:focus`" do
-      inspect_source(
-        cop,
-        [
-          "#{block_type} 'test', :focus do",
-          'end'
-        ]
-      )
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.map(&:line).sort).to eq([1])
-      expect(cop.messages).to eq(['Focused spec found.'])
-      expect(cop.highlights).to eq([':focus'])
-    end
+  it 'flags all repec example blocks that include `:focus`' do
+    expect_violation(<<-RUBY)
+      example_group 'test', :focus do; end
+                            ^^^^^^ Focused spec found.
+      feature 'test', :focus do; end
+                      ^^^^^^ Focused spec found.
+      xexample 'test', :focus do; end
+                       ^^^^^^ Focused spec found.
+      xdescribe 'test', :focus do; end
+                        ^^^^^^ Focused spec found.
+      xscenario 'test', :focus do; end
+                        ^^^^^^ Focused spec found.
+      specify 'test', :focus do; end
+                      ^^^^^^ Focused spec found.
+      example 'test', :focus do; end
+                      ^^^^^^ Focused spec found.
+      xfeature 'test', :focus do; end
+                       ^^^^^^ Focused spec found.
+      xspecify 'test', :focus do; end
+                       ^^^^^^ Focused spec found.
+      scenario 'test', :focus do; end
+                       ^^^^^^ Focused spec found.
+      describe 'test', :focus do; end
+                       ^^^^^^ Focused spec found.
+      xit 'test', :focus do; end
+                  ^^^^^^ Focused spec found.
+      context 'test', :focus do; end
+                      ^^^^^^ Focused spec found.
+      xcontext 'test', :focus do; end
+                       ^^^^^^ Focused spec found.
+      it 'test', :focus do; end
+                 ^^^^^^ Focused spec found.
+    RUBY
+  end
 
-    it 'detects no offense when spec is not focused' do
-      inspect_source(
-        cop,
-        [
-          "#{block_type} 'test' do",
-          'end'
-        ]
-      )
-      expect(subject.messages).to be_empty
-    end
+  it 'does not flag unfocused specs' do
+    expect_no_violations(<<-RUBY)
+      xcontext      'test' do; end
+      xscenario     'test' do; end
+      xspecify      'test' do; end
+      describe      'test' do; end
+      example       'test' do; end
+      xexample      'test' do; end
+      scenario      'test' do; end
+      specify       'test' do; end
+      xit           'test' do; end
+      feature       'test' do; end
+      xfeature      'test' do; end
+      context       'test' do; end
+      it            'test' do; end
+      example_group 'test' do; end
+      xdescribe     'test' do; end
+    RUBY
   end
 
   it 'does not flag a method that is focused twice' do
-    inspect_source(cop, 'fit "foo", :focus do; end')
-    expect(cop.offenses.size).to be(1)
+    expect_violation(<<-RUBY)
+      fit "foo", :focus do
+      ^^^^^^^^^^^^^^^^^ Focused spec found.
+      end
+    RUBY
   end
 
   it 'ignores non-rspec code with :focus blocks' do
-    inspect_source(cop, 'some_method "foo", focus: true do; end')
-    expect(cop.offenses).to be_empty
+    expect_no_violations(<<-RUBY)
+      some_method "foo", focus: true do
+      end
+    RUBY
   end
 
-  [
-    :fdescribe, :fcontext,
-    :focus, :fexample, :fit, :fspecify,
-    :ffeature, :fscenario
-  ].each do |block_type|
-    it "finds `#{block_type}` blocks" do
-      inspect_source(
-        cop,
-        [
-          "#{block_type} 'test' do",
-          'end'
-        ]
-      )
-      expect(cop.offenses.size).to eq(1)
-      expect(cop.offenses.map(&:line).sort).to eq([1])
-      expect(cop.messages).to eq(['Focused spec found.'])
-      expect(cop.highlights).to eq(["#{block_type} 'test'"])
-    end
+  it 'flags focused block types' do
+    expect_violation(<<-RUBY)
+      fdescribe 'test' do; end
+      ^^^^^^^^^^^^^^^^ Focused spec found.
+      ffeature 'test' do; end
+      ^^^^^^^^^^^^^^^ Focused spec found.
+      fcontext 'test' do; end
+      ^^^^^^^^^^^^^^^ Focused spec found.
+      fit 'test' do; end
+      ^^^^^^^^^^ Focused spec found.
+      fscenario 'test' do; end
+      ^^^^^^^^^^^^^^^^ Focused spec found.
+      fexample 'test' do; end
+      ^^^^^^^^^^^^^^^ Focused spec found.
+      fspecify 'test' do; end
+      ^^^^^^^^^^^^^^^ Focused spec found.
+      focus 'test' do; end
+      ^^^^^^^^^^^^ Focused spec found.
+    RUBY
   end
 end