rubocop-rspec 1.39.0 → 1.43.1

data/lib/rubocop/rspec/factory_bot.rb

@@ -4,7 +4,13 @@ module RuboCop
   module RSpec
     # RuboCop FactoryBot project namespace
     module FactoryBot
-      ATTRIBUTE_DEFINING_METHODS = %i[factory trait transient ignore].freeze
+      ATTRIBUTE_DEFINING_METHODS = %i[
+        factory
+        ignore
+        trait
+        traits_for_enum
+        transient
+      ].freeze
 
       UNPROXIED_METHODS = %i[
         __send__

data/lib/rubocop/rspec/language.rb

@@ -4,8 +4,6 @@ module RuboCop
   module RSpec
     # RSpec public API methods that are commonly used in cops
     module Language
-      RSPEC = '{(const {nil? cbase} :RSpec) nil?}'
-
       # Set of method selectors
       class SelectorSet
         def initialize(selectors)
@@ -29,7 +27,7 @@ module RuboCop
         end
 
         def block_pass_pattern
-          "(send #{RSPEC} #{node_pattern_union} _ block_pass)"
+          "(send #rspec? #{node_pattern_union} _ block_pass)"
         end
 
         def block_or_block_pass_pattern
@@ -37,7 +35,11 @@ module RuboCop
         end
 
         def send_pattern
-          "(send #{RSPEC} #{node_pattern_union} ...)"
+          "(send #rspec? #{node_pattern_union} ...)"
+        end
+
+        def send_or_block_or_block_pass_pattern
+          "{#{send_pattern} #{block_pattern} #{block_pass_pattern}}"
         end
 
         def node_pattern_union

data/lib/rubocop/rspec/language/node_pattern.rb

@@ -7,10 +7,16 @@ module RuboCop
       module NodePattern
         extend RuboCop::NodePattern::Macros
 
+        def_node_matcher :rspec?, '{(const {nil? cbase} :RSpec) nil?}'
+
         def_node_matcher :example_group?, ExampleGroups::ALL.block_pattern
+        def_node_matcher :shared_group?, SharedGroups::ALL.block_pattern
+
+        spec_groups = ExampleGroups::ALL + SharedGroups::ALL
+        def_node_matcher :spec_group?, spec_groups.block_pattern
 
         def_node_matcher :example_group_with_body?, <<-PATTERN
-          (block #{ExampleGroups::ALL.send_pattern} args [!nil?])
+          (block #{ExampleGroups::ALL.send_pattern} args !nil?)
         PATTERN
 
         def_node_matcher :example?, Examples::ALL.block_pattern
@@ -19,6 +25,9 @@ module RuboCop
 
         def_node_matcher :let?, Helpers::ALL.block_or_block_pass_pattern
 
+        def_node_matcher :include?,
+                         Includes::ALL.send_or_block_or_block_pass_pattern
+
         def_node_matcher :subject?, Subject::ALL.block_pattern
       end
     end

data/lib/rubocop/rspec/top_level_describe.rb

@@ -16,7 +16,7 @@ module RuboCop
       private
 
       def top_level_describe?(node)
-        return false unless node.method_name == :describe
+        return false unless node.method?(:describe)
 
         top_level_nodes.include?(node)
       end
@@ -44,7 +44,7 @@ module RuboCop
 
       def describe_statement_children(node)
         node.each_child_node(:send).select do |element|
-          element.method_name == :describe
+          element.method?(:describe)
         end
       end
     end

data/lib/rubocop/rspec/top_level_group.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module RSpec
+    # Helper methods for top level example group cops
+    module TopLevelGroup
+      extend RuboCop::NodePattern::Macros
+      include RuboCop::RSpec::Language
+
+      def_node_matcher :example_or_shared_group?,
+                       (ExampleGroups::ALL + SharedGroups::ALL).block_pattern
+
+      def on_new_investigation
+        super
+
+        return unless root_node
+
+        top_level_groups.each do |node|
+          example_group?(node, &method(:on_top_level_example_group))
+          on_top_level_group(node)
+        end
+      end
+
+      def top_level_groups
+        @top_level_groups ||=
+          top_level_nodes(root_node).select { |n| example_or_shared_group?(n) }
+      end
+
+      private
+
+      # Dummy methods to be overridden in the consumer
+      def on_top_level_example_group; end
+
+      def on_top_level_group; end
+
+      def top_level_group?(node)
+        top_level_groups.include?(node)
+      end
+
+      def top_level_nodes(node)
+        if node.nil?
+          []
+        elsif node.begin_type?
+          node.children
+        elsif node.module_type? || node.class_type?
+          top_level_nodes(node.body)
+        else
+          [node]
+        end
+      end
+
+      def root_node
+        processed_source.ast
+      end
+    end
+  end
+end

data/lib/rubocop/rspec/variable.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module RSpec
+    # Helps check offenses with variable definitions
+    module Variable
+      include Language
+      extend RuboCop::NodePattern::Macros
+
+      def_node_matcher :variable_definition?, <<~PATTERN
+        (send nil? #{(Helpers::ALL + Subject::ALL).node_pattern_union}
+          $({sym str dsym dstr} ...) ...)
+      PATTERN
+    end
+  end
+end

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.39.0'
+      STRING = '1.43.1'
     end
   end
 end

metadata

@@ -1,31 +1,31 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.39.0
+  version: 1.43.1
 platform: ruby
 authors:
 - John Backus
 - Ian MacLeod
 - Nils Gemeinhardt
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-05-01 00:00:00.000000000 Z
+date: 2020-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.68.1
+        version: '0.87'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.68.1
+        version: '0.87'
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
@@ -68,6 +68,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.4'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.7'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -110,6 +124,7 @@ extra_rdoc_files:
 - README.md
 files:
 - CHANGELOG.md
+- CODE_OF_CONDUCT.md
 - MIT-LICENSE.md
 - README.md
 - config/default.yml
@@ -118,6 +133,7 @@ files:
 - lib/rubocop/cop/rspec/align_right_let_brace.rb
 - lib/rubocop/cop/rspec/any_instance.rb
 - lib/rubocop/cop/rspec/around_block.rb
+- lib/rubocop/cop/rspec/base.rb
 - lib/rubocop/cop/rspec/be.rb
 - lib/rubocop/cop/rspec/be_eql.rb
 - lib/rubocop/cop/rspec/before_after_all.rb
@@ -172,6 +188,7 @@ files:
 - lib/rubocop/cop/rspec/missing_example_group_argument.rb
 - lib/rubocop/cop/rspec/multiple_describes.rb
 - lib/rubocop/cop/rspec/multiple_expectations.rb
+- lib/rubocop/cop/rspec/multiple_memoized_helpers.rb
 - lib/rubocop/cop/rspec/multiple_subjects.rb
 - lib/rubocop/cop/rspec/named_subject.rb
 - lib/rubocop/cop/rspec/nested_groups.rb
@@ -194,17 +211,19 @@ files:
 - lib/rubocop/cop/rspec/single_argument_message_chain.rb
 - lib/rubocop/cop/rspec/subject_stub.rb
 - lib/rubocop/cop/rspec/unspecified_exception.rb
+- lib/rubocop/cop/rspec/variable_definition.rb
+- lib/rubocop/cop/rspec/variable_name.rb
 - lib/rubocop/cop/rspec/verified_doubles.rb
 - lib/rubocop/cop/rspec/void_expect.rb
 - lib/rubocop/cop/rspec/yield.rb
 - lib/rubocop/cop/rspec_cops.rb
 - lib/rubocop/rspec.rb
 - lib/rubocop/rspec/align_let_brace.rb
-- lib/rubocop/rspec/blank_line_separation.rb
 - lib/rubocop/rspec/concept.rb
 - lib/rubocop/rspec/config_formatter.rb
 - lib/rubocop/rspec/corrector/move_node.rb
 - lib/rubocop/rspec/description_extractor.rb
+- lib/rubocop/rspec/empty_line_separation.rb
 - lib/rubocop/rspec/example.rb
 - lib/rubocop/rspec/example_group.rb
 - lib/rubocop/rspec/factory_bot.rb
@@ -215,6 +234,8 @@ files:
 - lib/rubocop/rspec/language/node_pattern.rb
 - lib/rubocop/rspec/node.rb
 - lib/rubocop/rspec/top_level_describe.rb
+- lib/rubocop/rspec/top_level_group.rb
+- lib/rubocop/rspec/variable.rb
 - lib/rubocop/rspec/version.rb
 - lib/rubocop/rspec/wording.rb
 homepage: https://github.com/rubocop-hq/rubocop-rspec
@@ -223,7 +244,7 @@ licenses:
 metadata:
   changelog_uri: https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md
   documentation_uri: https://rubocop-rspec.readthedocs.io/
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -238,8 +259,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.0.3
+signing_key:
 specification_version: 4
 summary: Code style checking for RSpec files
 test_files: []