rubocop-rspec 1.34.0 → 1.34.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b93f9fd4cff11c9b4a47a1bffca8e578bcf0e354320b461d63cdab7d01fad49b
-  data.tar.gz: 31244d48dd90be566b9f3b18dbe3f7c40112de41ef9fe9dbcbc282e20da2c66e
+  metadata.gz: cde39325f1b2c820f9105b689ab70ed80cd0e05bc0255cad156cfd3418e90d33
+  data.tar.gz: f538c3972f746964aca96015ea16e5553589601defe597d7069cbbc5e1a20e24
 SHA512:
-  metadata.gz: ca99737cdb9ebea08757e8412974d678c846623798efab61a3a8e3e35ece75ccde9c3bcb41a2e800eeefa465ea955ee2683e843b62c0eda3698a0fa9f562fa05
-  data.tar.gz: ff707c6bd4b46f289beb68127b4b49a214c490914098aaadacf436c0efbf41511ef942cbeb52f50428310788d05fdeaf43be69a6bfe43bf5383fd50d7fe075d9
+  metadata.gz: dd46062a2e229f7f9af5404399eb08762cb18eb30649af6d9b3e6ea12e5ee56bbc13a8971ca951626e5239502faa06992ea2c67be74687dbb909e41b1fcfcbe7
+  data.tar.gz: 56e6d26667a4c96060fa80cc94795a21db84299272ad0b6ba532bce2e04e3362bbf12c2df53a4ae5db948ef1a1f1441618a201e30eef843aa1463879c0c21809

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Master (Unreleased)
 
+## 1.34.1 (2019-07-31)
+
+* Fix `RSpec/DescribedClass`'s error when a local variable is part of the namespace. ([@pirj][])
+
 ## 1.34.0 (2019-07-23)
 
 * Remove `AggregateFailuresByDefault` config option of `RSpec/MultipleExpectations`. ([@pirj][])

data/lib/rubocop/cop/rspec/described_class.rb

@@ -166,10 +166,10 @@ module RuboCop
           # rubocop:enable InternalAffairs/NodeDestructuring
           if !namespace
             [name]
-          elsif namespace.cbase_type?
-            [nil, name]
-          else
+          elsif namespace.const_type?
             [*const_name(namespace), name]
+          elsif namespace.lvar_type? || namespace.cbase_type?
+            [nil, name]
           end
         end
 

data/lib/rubocop/cop/rspec/leaky_constant_declaration.rb

@@ -47,10 +47,12 @@ module RuboCop
       #   end
       #
       #   # good - anonymous class, no constant needs to be defined
-      #   let(:foo_class) do
-      #     Class.new(described_class) do
-      #       def double_that
-      #         some_base_method * 2
+      #   describe SomeClass do
+      #     let(:foo_class) do
+      #       Class.new(described_class) do
+      #         def double_that
+      #           some_base_method * 2
+      #         end
       #       end
       #     end
       #

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.34.0'
+      STRING = '1.34.1'
     end
   end
 end

data/spec/rubocop/cop/rspec/described_class_spec.rb

@@ -255,6 +255,18 @@ RSpec.describe RuboCop::Cop::RSpec::DescribedClass, :config do
         end
       RUBY
     end
+
+    it 'ignores if a local variable is part of the namespace' do
+      expect_no_offenses(<<-RUBY)
+        describe Broken do
+          [Foo, Bar].each do |klass|
+            describe klass::Baz.name do
+              it { }
+            end
+          end
+        end
+      RUBY
+    end
   end
 
   context 'when EnforcedStyle is :explicit' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.34.0
+  version: 1.34.1
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-23 00:00:00.000000000 Z
+date: 2019-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop