rubocop-rspec 1.30.0 → 1.30.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0a59e8fa42b2cb3434cc923508e5fb7fb23959eea5912588425575216966173c
-  data.tar.gz: e0a0419763273fba02709cd92c1c86c6704398e24947d29d9499df29cf60efec
+  metadata.gz: 89853728f31f151cfe129bc754317563747529c95f5298be06478247b0a91bf0
+  data.tar.gz: 18a0909fe1352450cd69e289323e3c06f69a38cfb15fb54b3bc79b4f22c089d0
 SHA512:
-  metadata.gz: 9bc9fa634cc51edc446f4ea65f8590fedafbcb754b5667383aa3f0b71cc5a8aaff114f40d093d261a43b642efdb23f8ac2a39047fab2b9104c768362ab0c2569
-  data.tar.gz: b5c52f755b673b2f0fd1a3075a1b1a61060f4216f2b1548a24e4622da5a93f9ada94c39d4abc9644d92bae22cd5019c89693a3d1d6cd32952c748dbfdf8b554f
+  metadata.gz: d75b3a00d3da18979fd4a9effd3a8b231b54267695998cb8f61a57c0cae64121dc3d5d740422a8283abf425adee11ea4f6aff9d5247d9e8785971a52d949f6c0
+  data.tar.gz: feedb0ccb5ddc363c7c71fdaf4647316be0a9dc3063079621188fb2fa81b6e3165a1bc0b7ce7850342a10e216bf355ec5df682bcce7a957c40f2ee794394a64e

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Master (Unreleased)
 
+## 1.30.1 (2018-11-01)
+
+* `FactoryBot/CreateList` now ignores `times` blocks with an argument. ([@Darhazer][])
+
 ## 1.30.0 (2018-10-08)
 
 * Add config to `RSpec/VerifiedDoubles` to enforcement of verification on unnamed doubles. ([@BrentWheeldon][])

data/lib/rubocop/cop/rspec/example_wording.rb

@@ -33,8 +33,8 @@ module RuboCop
         MSG_SHOULD = 'Do not use should when describing your tests.'.freeze
         MSG_IT     = "Do not repeat 'it' when describing your tests.".freeze
 
-        SHOULD_PREFIX = /\Ashould(?:n't)?\b/i
-        IT_PREFIX     = /\Ait /i
+        SHOULD_PREFIX = /\Ashould(?:n't)?\b/i.freeze
+        IT_PREFIX     = /\Ait /i.freeze
 
         def_node_matcher(
           :it_description,

data/lib/rubocop/cop/rspec/factory_bot/create_list.rb

@@ -30,9 +30,10 @@ module RuboCop
           MSG_CREATE_LIST = 'Prefer create_list.'.freeze
           MSG_N_TIMES = 'Prefer %<number>s.times.'.freeze
 
-          def_node_matcher :n_times_block?, <<-PATTERN
+          def_node_matcher :n_times_block_without_arg?, <<-PATTERN
             (block
               (send (int _) :times)
+              (args)
               ...
             )
           PATTERN
@@ -47,7 +48,7 @@ module RuboCop
 
           def on_block(node)
             return unless style == :create_list
-            return unless n_times_block?(node)
+            return unless n_times_block_without_arg?(node)
             return unless contains_only_factory?(node.body)
 
             add_offense(node.send_node,

data/lib/rubocop/rspec/config_formatter.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Builds a YAML config file from two config hashes
     class ConfigFormatter
-      NAMESPACES = /^(RSpec|Capybara|FactoryBot|Rails)/
+      NAMESPACES = /^(RSpec|Capybara|FactoryBot|Rails)/.freeze
       STYLE_GUIDE_BASE_URL = 'http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/'.freeze
 
       def initialize(config, descriptions)

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.30.0'.freeze
+      STRING = '1.30.1'.freeze
     end
   end
 end

data/lib/rubocop/rspec/wording.rb

@@ -4,10 +4,10 @@ module RuboCop
   module RSpec
     # RSpec example wording rewriter
     class Wording
-      SHOULDNT_PREFIX    = /\Ashould(?:n't| not)\b/i
-      SHOULDNT_BE_PREFIX = /#{SHOULDNT_PREFIX} be\b/i
-      ES_SUFFIX_PATTERN  = /(?:o|s|x|ch|sh|z)\z/i
-      IES_SUFFIX_PATTERN = /[^aeou]y\z/i
+      SHOULDNT_PREFIX    = /\Ashould(?:n't| not)\b/i.freeze
+      SHOULDNT_BE_PREFIX = /#{SHOULDNT_PREFIX} be\b/i.freeze
+      ES_SUFFIX_PATTERN  = /(?:o|s|x|ch|sh|z)\z/i.freeze
+      IES_SUFFIX_PATTERN = /[^aeou]y\z/i.freeze
 
       def initialize(text, ignore:, replace:)
         @text         = text

data/rubocop-rspec.gemspec

@@ -37,7 +37,7 @@ Gem::Specification.new do |spec|
     'documentation_uri' => 'https://rubocop-rspec.readthedocs.io/'
   }
 
-  spec.add_runtime_dependency 'rubocop', '>= 0.58.0'
+  spec.add_runtime_dependency 'rubocop', '>= 0.60.0'
 
   spec.add_development_dependency 'rack'
   spec.add_development_dependency 'rake'

data/spec/rubocop/cop/rspec/factory_bot/create_list_spec.rb

@@ -41,10 +41,9 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::CreateList, :config do
       RUBY
     end
 
-    it 'flags n.times with argument' do
-      expect_offense(<<-RUBY)
+    it 'ignores n.times with argument' do
+      expect_no_offenses(<<-RUBY)
         3.times { |n| create :user, created_at: n.days.ago }
-        ^^^^^^^ Prefer create_list.
       RUBY
     end
 

data/spec/rubocop/cop/rspec/multiple_expectations_spec.rb

@@ -229,6 +229,6 @@ RSpec.describe RuboCop::Cop::RSpec::MultipleExpectations, :config do
       end
     RUBY
 
-    expect(cop.config_to_allow_offenses).to eq('Max' => 3)
+    expect(cop.config_to_allow_offenses[:exclude_limit]).to eq('Max' => 3)
   end
 end

data/spec/rubocop/cop/rspec/nested_groups_spec.rb

@@ -34,7 +34,7 @@ RSpec.describe RuboCop::Cop::RSpec::NestedGroups, :config do
       end
     RUBY
 
-    expect(cop.config_to_allow_offenses).to eq('Max' => 4)
+    expect(cop.config_to_allow_offenses[:exclude_limit]).to eq('Max' => 4)
   end
 
   it 'ignores non-spec context methods' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.30.0
+  version: 1.30.1
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-08 00:00:00.000000000 Z
+date: 2018-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.58.0
+        version: 0.60.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.58.0
+        version: 0.60.0
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement