rubocop-rspec 1.29.1 → 1.30.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5bb37f4e34447ecf1e1f30484aa0d861a624e71e60b2c21d16c67f5a20d95b13
-  data.tar.gz: db2a1555891ba75ac4ee956c6e9d97e85b95923edde3e7584f818d2fe2cddc85
+  metadata.gz: 0a59e8fa42b2cb3434cc923508e5fb7fb23959eea5912588425575216966173c
+  data.tar.gz: e0a0419763273fba02709cd92c1c86c6704398e24947d29d9499df29cf60efec
 SHA512:
-  metadata.gz: 7db598400632086657e6b590ff999aee6a9ce46e3443edaa133af3e8d0411d0669a2ed360cc05360b8748c6694ad0d5a3dd5783dc39e06be7136dcf8554673e4
-  data.tar.gz: 83815cc74d3261b5e05cb0d3ab760dfa0c5c3448ac0595d70392ed4d45d9ccc388c1026ae4202a72128c5945976d6eba04ac60f0729fc8c0f4df8b5a2c63e2c0
+  metadata.gz: 9bc9fa634cc51edc446f4ea65f8590fedafbcb754b5667383aa3f0b71cc5a8aaff114f40d093d261a43b642efdb23f8ac2a39047fab2b9104c768362ab0c2569
+  data.tar.gz: b5c52f755b673b2f0fd1a3075a1b1a61060f4216f2b1548a24e4622da5a93f9ada94c39d4abc9644d92bae22cd5019c89693a3d1d6cd32952c748dbfdf8b554f

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 ## Master (Unreleased)
 
+## 1.30.0 (2018-10-08)
+
+* Add config to `RSpec/VerifiedDoubles` to enforcement of verification on unnamed doubles. ([@BrentWheeldon][])
+* Fix `FactoryBot/AttributeDefinedStatically` not working when there is a non-symbol key. ([@vzvu3k6k][])
+* Fix false positive in `RSpec/ImplicitSubject` when `is_expected` is used inside `its()` block. ([@Darhazer][])
+* Add `single_statement_only` style to  `RSpec/ImplicitSubject` as a more relaxed alternative to `single_line_only`. ([@Darhazer][])
+* Add `RSpec/UnspecifiedException` as a default cop to encourage more-specific `expect{}.to raise_error(ExceptionType)`, or `raise_exception` style handling of exceptions. ([@daveworth][])
+
 ## 1.29.1 (2018-09-01)
 
 * Fix false negative in `FactoryBot/AttributeDefinedStatically` when attribute is defined on `self`. ([@Darhazer][])
@@ -374,3 +382,6 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@tdeo]: https://github.com/tdeo
 [@composerinteralia]: https://github.com/composerinteralia
 [@seanpdoyle]: https://github.com/seanpdoyle
+[@vzvu3k6k]: https://github.com/vzvu3k6k
+[@BrentWheeldon]: https://github.com/BrentWheeldon
+[@daveworth]: https://github.com/daveworth

data/config/default.yml

@@ -10,16 +10,6 @@ AllCops:
     - spec/factories/**/*.rb
     - features/support/factories/**/*.rb
 
-RSpec/AnyInstance:
-  Description: Check that instances are not being stubbed globally.
-  Enabled: true
-  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/AnyInstance
-
-RSpec/AroundBlock:
-  Description: Checks that around blocks actually run the test.
-  Enabled: true
-  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/AroundBlock
-
 RSpec/AlignLeftLetBrace:
   Description: Checks that left braces for adjacent single line lets are aligned.
   Enabled: false
@@ -30,6 +20,16 @@ RSpec/AlignRightLetBrace:
   Enabled: false
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/AlignRightLetBrace
 
+RSpec/AnyInstance:
+  Description: Check that instances are not being stubbed globally.
+  Enabled: true
+  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/AnyInstance
+
+RSpec/AroundBlock:
+  Description: Checks that around blocks actually run the test.
+  Enabled: true
+  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/AroundBlock
+
 RSpec/Be:
   Description: Check for expectations where `be` is used without argument.
   Enabled: true
@@ -63,16 +63,6 @@ RSpec/DescribeClass:
   Enabled: true
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribeClass
 
-RSpec/DescribedClass:
-  Description: Checks that tests use `described_class`.
-  SkipBlocks: false
-  Enabled: true
-  EnforcedStyle: described_class
-  SupportedStyles:
-  - described_class
-  - explicit
-  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClass
-
 RSpec/DescribeMethod:
   Description: Checks that the second argument to `describe` specifies a method.
   Enabled: true
@@ -83,10 +73,15 @@ RSpec/DescribeSymbol:
   Enabled: true
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribeSymbol
 
-RSpec/IteratedExpectation:
-  Description: Check that `all` matcher is used instead of iterating over an array.
+RSpec/DescribedClass:
+  Description: Checks that tests use `described_class`.
+  SkipBlocks: false
   Enabled: true
-  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IteratedExpectation
+  EnforcedStyle: described_class
+  SupportedStyles:
+  - described_class
+  - explicit
+  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClass
 
 RSpec/EmptyExampleGroup:
   Description: Checks if an example group does not include any tests.
@@ -211,6 +206,7 @@ RSpec/ImplicitSubject:
   EnforcedStyle: single_line_only
   SupportedStyles:
   - single_line_only
+  - single_statement_only
   - disallow
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ImplicitSubject
 
@@ -239,6 +235,11 @@ RSpec/ItBehavesLike:
   - it_should_behave_like
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ItBehavesLike
 
+RSpec/IteratedExpectation:
+  Description: Check that `all` matcher is used instead of iterating over an array.
+  Enabled: true
+  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IteratedExpectation
+
 RSpec/LeadingSubject:
   Description: Enforce that subject is the first definition in the test.
   Enabled: true
@@ -329,6 +330,16 @@ RSpec/Pending:
   Description: Checks for any pending or skipped examples.
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Pending
 
+RSpec/PredicateMatcher:
+  Description: Prefer using predicate matcher over using predicate method directly.
+  Enabled: true
+  Strict: true
+  EnforcedStyle: inflected
+  SupportedStyles:
+  - inflected
+  - explicit
+  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PredicateMatcher
+
 RSpec/ReceiveCounts:
   Enabled: true
   Description: Check for `once` and `twice` receive counts matchers usage.
@@ -358,6 +369,16 @@ RSpec/ReturnFromStub:
   - block
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ReturnFromStub
 
+RSpec/ScatteredLet:
+  Description: Checks for let scattered across the example group.
+  Enabled: true
+  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredLet
+
+RSpec/ScatteredSetup:
+  Description: Checks for setup scattered across multiple hooks in an example group.
+  Enabled: true
+  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredSetup
+
 RSpec/SharedContext:
   Description: Checks for proper shared_context and shared_examples usage.
   Enabled: true
@@ -373,34 +394,20 @@ RSpec/SingleArgumentMessageChain:
   Enabled: true
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/SingleArgumentMessageChain
 
-RSpec/ScatteredLet:
-  Description: Checks for let scattered across the example group.
-  Enabled: true
-  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredLet
-
-RSpec/ScatteredSetup:
-  Description: Checks for setup scattered across multiple hooks in an example group.
-  Enabled: true
-  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredSetup
-
 RSpec/SubjectStub:
   Description: Checks for stubbed test subjects.
   Enabled: true
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/SubjectStub
 
-RSpec/PredicateMatcher:
-  Description: Prefer using predicate matcher over using predicate method directly.
+RSpec/UnspecifiedException:
+  Description: Checks for a specified error in checking raised errors.
   Enabled: true
-  Strict: true
-  EnforcedStyle: inflected
-  SupportedStyles:
-  - inflected
-  - explicit
-  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PredicateMatcher
+  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/UnspecifiedException
 
 RSpec/VerifiedDoubles:
   Description: Prefer using verifying doubles over normal doubles.
   Enabled: true
+  IgnoreNameless: true
   IgnoreSymbolicNames: false
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/VerifiedDoubles
 

data/lib/rubocop-rspec.rb

@@ -18,8 +18,6 @@ require_relative 'rubocop/rspec/example'
 require_relative 'rubocop/rspec/hook'
 require_relative 'rubocop/cop/rspec/cop'
 require_relative 'rubocop/rspec/align_let_brace'
-require_relative 'rubocop/rspec/capybara'
-require_relative 'rubocop/rspec/factory_bot'
 require_relative 'rubocop/rspec/final_end_location'
 require_relative 'rubocop/rspec/blank_line_separation'
 

data/lib/rubocop/cop/rspec/context_wording.rb

@@ -56,6 +56,7 @@ module RuboCop
         def joined_prefixes
           quoted = prefixes.map { |prefix| "'#{prefix}'" }
           return quoted.first if quoted.size == 1
+
           quoted << "or #{quoted.pop}"
           quoted.join(', ')
         end

data/lib/rubocop/cop/rspec/cop.rb

@@ -79,6 +79,7 @@ module RuboCop
 
         def rspec_pattern_config?
           return unless all_cops_config.key?('RSpec')
+
           all_cops_config.fetch('RSpec').key?('Patterns')
         end
 

data/lib/rubocop/cop/rspec/describe_method.rb

@@ -23,11 +23,9 @@ module RuboCop
         MSG = 'The second argument to describe should be the method '\
               "being tested. '#instance' or '.class'.".freeze
 
-        METHOD_STRING_MATCHER = /\A[\#\.].+/
-
         def on_top_level_describe(_node, (_, second_arg))
           return unless second_arg && second_arg.str_type?
-          return if METHOD_STRING_MATCHER =~ second_arg.str_content
+          return if second_arg.str_content.start_with?('#', '.')
 
           add_offense(second_arg, location: :expression)
         end

data/lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb

@@ -73,6 +73,7 @@ module RuboCop
           def on_block(node)
             factory_attributes(node).to_a.flatten.each do |attribute|
               next if proc?(attribute) || association?(attribute)
+
               add_offense(attribute, location: :expression)
             end
           end
@@ -97,7 +98,7 @@ module RuboCop
           end
 
           def factory_key?(hash_node)
-            hash_node.keys.any? { |key| key.value == :factory }
+            hash_node.keys.any? { |key| key.sym_type? && key.value == :factory }
           end
 
           def autocorrect_replacing_parens(node)

data/lib/rubocop/cop/rspec/factory_bot/create_list.rb

@@ -139,6 +139,7 @@ module RuboCop
 
           def format_receiver(receiver)
             return '' unless receiver
+
             "#{receiver.source}."
           end
         end

data/lib/rubocop/cop/rspec/implicit_subject.rb

@@ -56,9 +56,20 @@ module RuboCop
         private
 
         def valid_usage?(node)
-          return false unless style == :single_line_only
           example = node.ancestors.find { |parent| example?(parent) }
-          example && example.single_line?
+          return false if example.nil?
+
+          example.method_name == :its || allowed_by_style?(example)
+        end
+
+        def allowed_by_style?(example)
+          if style == :single_line_only
+            example.single_line?
+          elsif style == :single_statement_only
+            !example.body.begin_type?
+          else
+            false
+          end
         end
       end
     end

data/lib/rubocop/cop/rspec/let_before_examples.rb

@@ -72,6 +72,7 @@ module RuboCop
 
           node.each_child_node do |child|
             next if child.sibling_index < first_example.sibling_index
+
             add_offense(child, location: :expression) if let?(child)
           end
         end

data/lib/rubocop/cop/rspec/overwriting_setup.rb

@@ -58,6 +58,7 @@ module RuboCop
 
         def common_setup?(node)
           return false unless setup?(node)
+
           # Search only for setup with basic_literal arguments (e.g. :sym, :str)
           # or no arguments at all.
           node.send_node.arguments.all?(&:basic_literal?)

data/lib/rubocop/cop/rspec/predicate_matcher.rb

@@ -145,6 +145,7 @@ module RuboCop
           end
 
           return if part_of_ignored_node?(node)
+
           predicate_matcher?(node) do |_actual, matcher|
             add_offense(
               node,
@@ -337,6 +338,7 @@ module RuboCop
         def block_loc(send_node)
           parent = send_node.parent
           return unless parent.block_type?
+
           range_between(
             send_node.loc.expression.end_pos,
             parent.loc.expression.end_pos

data/lib/rubocop/cop/rspec/rails/http_status.rb

@@ -41,6 +41,7 @@ module RuboCop
             http_status(node) do |ast_node|
               checker = checker_class.new(ast_node)
               return unless checker.offensive?
+
               add_offense(checker.node, message: checker.message)
             end
           end

data/lib/rubocop/cop/rspec/scattered_let.rb

@@ -43,6 +43,7 @@ module RuboCop
           first_let = lets.first
           lets.each_with_index do |node, idx|
             next if node.sibling_index == first_let.sibling_index + idx
+
             add_offense(node, location: :expression)
           end
         end

data/lib/rubocop/cop/rspec/subject_stub.rb

@@ -72,6 +72,7 @@ module RuboCop
 
         def expectation?(node)
           return if all_matcher?(node)
+
           receive_message?(node)
         end
 

data/lib/rubocop/cop/rspec/unspecified_exception.rb

@@ -0,0 +1,64 @@
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks for a specified error in checking raised errors.
+      #
+      # Enforces one of an Exception type, a string, or a regular
+      # expression to match against the exception message as a parameter
+      # to `raise_error`
+      #
+      # @example
+      #
+      #     # bad
+      #     expect {
+      #       raise StandardError.new('error')
+      #     }.to raise_error
+      #
+      #     # good
+      #     expect {
+      #       raise StandardError.new('error')
+      #     }.to raise_error(StandardError)
+      #
+      #     expect {
+      #       raise StandardError.new('error')
+      #     }.to raise_error('error')
+      #
+      #     expect {
+      #       raise StandardError.new('error')
+      #     }.to raise_error(/err/)
+      #
+      #     expect { do_something }.not_to raise_error
+      class UnspecifiedException < Cop
+        MSG = 'Specify the exception being captured'.freeze
+
+        def_node_matcher :empty_raise_error_or_exception, <<-PATTERN.freeze
+          (send
+            (block
+                (send nil? :expect) ...)
+            :to
+            (send nil? {:raise_error :raise_exception})
+          )
+        PATTERN
+
+        def on_send(node)
+          return unless empty_exception_matcher?(node)
+
+          add_offense(
+            node.children.last,
+            location: :expression
+          )
+        end
+
+        def empty_exception_matcher?(node)
+          empty_raise_error_or_exception(node) && !block_with_args?(node.parent)
+        end
+
+        def block_with_args?(node)
+          return unless node && node.block_type?
+
+          node.arguments?
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/verified_doubles.rb

@@ -26,16 +26,23 @@ module RuboCop
         MSG = 'Prefer using verifying doubles over normal doubles.'.freeze
 
         def_node_matcher :unverified_double, <<-PATTERN
-          {(send nil? {:double :spy} $_ ...) }
+          {(send nil? {:double :spy} $...)}
         PATTERN
 
         def on_send(node)
-          unverified_double(node) do |name|
-            return if name.sym_type? && cop_config['IgnoreSymbolicNames']
+          unverified_double(node) do |name, *_args|
+            return if name.nil? && cop_config['IgnoreNameless']
+            return if symbol?(name) && cop_config['IgnoreSymbolicNames']
 
             add_offense(node, location: :expression)
           end
         end
+
+        private
+
+        def symbol?(name)
+          name && name.sym_type?
+        end
       end
     end
   end

data/lib/rubocop/cop/rspec/void_expect.rb

@@ -25,11 +25,13 @@ module RuboCop
 
         def on_send(node)
           return unless expect?(node)
+
           check_expect(node)
         end
 
         def on_block(node)
           return unless expect_block?(node)
+
           check_expect(node)
         end
 
@@ -37,6 +39,7 @@ module RuboCop
 
         def check_expect(node)
           return unless void?(node)
+
           add_offense(node, location: :expression)
         end
 

data/lib/rubocop/cop/rspec_cops.rb

@@ -72,5 +72,6 @@ require_relative 'rspec/shared_context'
 require_relative 'rspec/shared_examples'
 require_relative 'rspec/single_argument_message_chain'
 require_relative 'rspec/subject_stub'
+require_relative 'rspec/unspecified_exception'
 require_relative 'rspec/verified_doubles'
 require_relative 'rspec/void_expect'

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.29.1'.freeze
+      STRING = '1.30.0'.freeze
     end
   end
 end

data/spec/project/default_config_spec.rb

@@ -3,13 +3,16 @@ RSpec.describe 'config/default.yml' do
     RuboCop::ConfigLoader.load_file('config/default.yml')
   end
 
-  let(:cop_names) do
-    namespaces = {
+  let(:namespaces) do
+    {
       'rspec' => 'RSpec',
       'capybara' => 'Capybara',
       'factory_bot' => 'FactoryBot',
       'rails' => 'Rails'
     }
+  end
+
+  let(:cop_names) do
     glob = SpecHelper::ROOT.join('lib', 'rubocop', 'cop', 'rspec',
                                  '{,capybara,factory_bot,rails}', '*.rb')
     cop_names =
@@ -38,7 +41,17 @@ RSpec.describe 'config/default.yml' do
   end
 
   it 'has configuration for all cops' do
-    expect(default_config.keys.sort).to eq(config_keys.sort)
+    expect(default_config.keys).to match_array(config_keys)
+  end
+
+  it 'sorts configuration keys alphabetically' do
+    namespaces.each do |_path, prefix|
+      expected = config_keys.select { |key| key.start_with?(prefix) }.sort
+      actual = default_config.keys.select { |key| key.start_with?(prefix) }
+      actual.each_with_index do |key, idx|
+        expect(key).to eq expected[idx]
+      end
+    end
   end
 
   it 'has descriptions for all cops' do

data/spec/rubocop/cop/rspec/factory_bot/attribute_defined_statically_spec.rb

@@ -133,6 +133,7 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::AttributeDefinedStatically do #
         meta_tags(foo: Time.current)
         other_tags({ foo: Time.current })
         options color: :blue
+        other_options Tag::MAGIC => :magic
         self.end Date.tomorrow
 
         trait :old do
@@ -157,6 +158,7 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::AttributeDefinedStatically do #
         meta_tags { { foo: Time.current } }
         other_tags { { foo: Time.current } }
         options { { color: :blue } }
+        other_options { { Tag::MAGIC => :magic } }
         self.end { Date.tomorrow }
 
         trait :old do

data/spec/rubocop/cop/rspec/implicit_subject_spec.rb

@@ -17,6 +17,14 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
       RUBY
     end
 
+    it 'allows `is_expected` inside `its` block, in multi-line examples' do
+      expect_no_offenses(<<-RUBY)
+        its(:quality) do
+          is_expected.to be :high
+        end
+      RUBY
+    end
+
     it 'flags `should` in multi-line examples' do
       expect_offense(<<-RUBY)
         it 'expect subject to be used' do
@@ -92,6 +100,50 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
                      good_code
   end
 
+  context 'with EnforcedStyle `single_statement_only`' do
+    let(:enforced_style) { 'single_statement_only' }
+
+    it 'allows `is_expected` in multi-line example with single statement' do
+      expect_no_offenses(<<-RUBY)
+        it 'expect subject to be used' do
+          is_expected.to be_good
+        end
+      RUBY
+    end
+
+    it 'flags `is_expected` in multi-statement examples' do
+      expect_offense(<<-RUBY)
+        it 'expect subject to be used' do
+          subject.age = 18
+          is_expected.to be_valid
+          ^^^^^^^^^^^ Don't use implicit subject.
+        end
+      RUBY
+    end
+
+    bad_code = <<-RUBY
+      it 'is valid' do
+        subject.age = 18
+        is_expected.to be_valid
+      end
+    RUBY
+
+    good_code = <<-RUBY
+      it 'is valid' do
+        subject.age = 18
+        expect(subject).to be_valid
+      end
+    RUBY
+
+    include_examples 'autocorrect',
+                     bad_code,
+                     good_code
+
+    include_examples 'autocorrect',
+                     bad_code,
+                     good_code
+  end
+
   context 'with EnforcedStyle `disallow`' do
     let(:enforced_style) { 'disallow' }
 
@@ -127,6 +179,12 @@ RSpec.describe RuboCop::Cop::RSpec::ImplicitSubject, :config do
       RUBY
     end
 
+    it 'allows `is_expected` inside `its` block' do
+      expect_no_offenses(<<-RUBY)
+        its(:quality) { is_expected.to be :high }
+      RUBY
+    end
+
     include_examples 'autocorrect',
                      'it { is_expected.to be_truthy }',
                      'it { expect(subject).to be_truthy }'

data/spec/rubocop/cop/rspec/unspecified_exception_spec.rb

@@ -0,0 +1,175 @@
+RSpec.describe RuboCop::Cop::RSpec::UnspecifiedException do
+  subject(:cop) { described_class.new }
+
+  context 'with raise_error matcher' do
+    it 'detects the `unspecified_exception` offense' do
+      expect_offense(<<-RUBY)
+        expect {
+          raise StandardError
+        }.to raise_error
+             ^^^^^^^^^^^ Specify the exception being captured
+      RUBY
+    end
+
+    it 'allows empty exception specification when not expecting an error' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError
+        }.not_to raise_error
+      RUBY
+    end
+
+    it 'allows exception classes' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError
+        }.to raise_error(StandardError)
+      RUBY
+    end
+
+    it 'allows exception messages' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError.new('error')
+        }.to raise_error('error')
+      RUBY
+    end
+
+    it 'allows exception types with messages' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError.new('error')
+        }.to raise_error(StandardError, 'error')
+      RUBY
+    end
+
+    it 'allows exception matching regular expressions' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError.new('error')
+        }.to raise_error(/err/)
+      RUBY
+    end
+
+    it 'allows exception types with matching regular expressions' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError.new('error')
+        }.to raise_error(StandardError, /err/)
+      RUBY
+    end
+
+    it 'allows classes with blocks with braces' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError.new('error')
+        }.to raise_error { |err| err.data }
+      RUBY
+    end
+
+    it 'allows classes with blocks with do/end' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError.new('error')
+        }.to raise_error do |error|
+          error.data
+        end
+      RUBY
+    end
+
+    it 'allows parameterized exceptions' do
+      expect_no_offenses(<<-RUBY)
+        my_exception = StandardError.new('my exception')
+        expect {
+          raise my_exception
+        }.to raise_error(my_exception)
+      RUBY
+    end
+  end
+
+  context 'with raise_exception matcher' do
+    it 'detects the `unspecified_exception` offense' do
+      expect_offense(<<-RUBY)
+        expect {
+          raise StandardError
+        }.to raise_exception
+             ^^^^^^^^^^^^^^^ Specify the exception being captured
+      RUBY
+    end
+
+    it 'allows empty exception specification when not expecting an error' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError
+        }.not_to raise_exception
+      RUBY
+    end
+
+    it 'allows exception classes' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError
+        }.to raise_exception(StandardError)
+      RUBY
+    end
+
+    it 'allows exception messages' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError.new('error')
+        }.to raise_exception('error')
+      RUBY
+    end
+
+    it 'allows exception types with messages' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError.new('error')
+        }.to raise_exception(StandardError, 'error')
+      RUBY
+    end
+
+    it 'allows exception matching regular expressions' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError.new('error')
+        }.to raise_exception(/err/)
+      RUBY
+    end
+
+    it 'allows exception types with matching regular expressions' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError.new('error')
+        }.to raise_exception(StandardError, /err/)
+      RUBY
+    end
+
+    it 'allows classes with blocks with braces' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError.new('error')
+        }.to raise_exception { |err| err.data }
+      RUBY
+    end
+
+    it 'allows classes with blocks with do/end' do
+      expect_no_offenses(<<-RUBY)
+        expect {
+          raise StandardError.new('error')
+        }.to raise_exception do |error|
+          error.data
+        end
+      RUBY
+    end
+
+    it 'allows parameterized exceptions' do
+      expect_no_offenses(<<-RUBY)
+        my_exception = StandardError.new('my exception')
+        expect {
+          raise my_exception
+        }.to raise_exception(my_exception)
+      RUBY
+    end
+  end
+end

data/spec/rubocop/cop/rspec/verified_doubles_spec.rb

@@ -53,14 +53,27 @@ RSpec.describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
     end
   end
 
-  it 'ignores doubles without a name' do
-    expect_no_offenses(<<-RUBY)
+  it 'doubles that have no name specified' do
+    expect_offense(<<-RUBY)
       it do
         foo = double
+              ^^^^^^ Prefer using verifying doubles over normal doubles.
       end
     RUBY
   end
 
+  context 'when configured to ignore nameless doubles' do
+    let(:cop_config) { { 'IgnoreNameless' => true } }
+
+    it 'ignores doubles that have no name specified' do
+      expect_no_offenses(<<-RUBY)
+        it do
+          foo = double
+        end
+      RUBY
+    end
+  end
+
   it 'ignores instance_doubles' do
     expect_no_offenses(<<-RUBY)
       it do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.29.1
+  version: 1.30.0
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-01 00:00:00.000000000 Z
+date: 2018-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -184,19 +184,18 @@ files:
 - lib/rubocop/cop/rspec/shared_examples.rb
 - lib/rubocop/cop/rspec/single_argument_message_chain.rb
 - lib/rubocop/cop/rspec/subject_stub.rb
+- lib/rubocop/cop/rspec/unspecified_exception.rb
 - lib/rubocop/cop/rspec/verified_doubles.rb
 - lib/rubocop/cop/rspec/void_expect.rb
 - lib/rubocop/cop/rspec_cops.rb
 - lib/rubocop/rspec.rb
 - lib/rubocop/rspec/align_let_brace.rb
 - lib/rubocop/rspec/blank_line_separation.rb
-- lib/rubocop/rspec/capybara.rb
 - lib/rubocop/rspec/concept.rb
 - lib/rubocop/rspec/config_formatter.rb
 - lib/rubocop/rspec/description_extractor.rb
 - lib/rubocop/rspec/example.rb
 - lib/rubocop/rspec/example_group.rb
-- lib/rubocop/rspec/factory_bot.rb
 - lib/rubocop/rspec/final_end_location.rb
 - lib/rubocop/rspec/hook.rb
 - lib/rubocop/rspec/inject.rb
@@ -279,6 +278,7 @@ files:
 - spec/rubocop/cop/rspec/shared_examples_spec.rb
 - spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb
 - spec/rubocop/cop/rspec/subject_stub_spec.rb
+- spec/rubocop/cop/rspec/unspecified_exception_spec.rb
 - spec/rubocop/cop/rspec/verified_doubles_spec.rb
 - spec/rubocop/cop/rspec/void_expect_spec.rb
 - spec/rubocop/rspec/config_formatter_spec.rb
@@ -396,6 +396,7 @@ test_files:
 - spec/rubocop/cop/rspec/shared_examples_spec.rb
 - spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb
 - spec/rubocop/cop/rspec/subject_stub_spec.rb
+- spec/rubocop/cop/rspec/unspecified_exception_spec.rb
 - spec/rubocop/cop/rspec/verified_doubles_spec.rb
 - spec/rubocop/cop/rspec/void_expect_spec.rb
 - spec/rubocop/rspec/config_formatter_spec.rb

data/lib/rubocop/rspec/capybara.rb

@@ -1,7 +0,0 @@
-module RuboCop
-  module RSpec
-    # RuboCop Capybara project namespace
-    module Capybara
-    end
-  end
-end

data/lib/rubocop/rspec/factory_bot.rb

@@ -1,7 +0,0 @@
-module RuboCop
-  module RSpec
-    # RuboCop FactoryBot project namespace
-    module FactoryBot
-    end
-  end
-end