rubocop-rspec 1.29.0 → 1.29.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 443658797afd25742895f47e865522055e00c498fb74ca74fda1d09468d86470
-  data.tar.gz: 71e9ab9356e4287df026b2d051bc2de4407517021c62c28cc66dfb5164dda753
+  metadata.gz: 5bb37f4e34447ecf1e1f30484aa0d861a624e71e60b2c21d16c67f5a20d95b13
+  data.tar.gz: db2a1555891ba75ac4ee956c6e9d97e85b95923edde3e7584f818d2fe2cddc85
 SHA512:
-  metadata.gz: 714551b4c0b85485ed5a0b0bdfc67cbca73b16fbb2a1ca5b498f578f928a04fe2ab58d1d9916bd140c64a62e23d81e9ea66944c294a98486776df9f204a2ba8f
-  data.tar.gz: 5b373a20f346018dd9cdf242e615e997b64d5803e77fd4fa434f346cb423366f199ee9597a3bf1515d238a16bf0e1cfc8178980d681e652a3352d78f003f1bbd
+  metadata.gz: 7db598400632086657e6b590ff999aee6a9ce46e3443edaa133af3e8d0411d0669a2ed360cc05360b8748c6694ad0d5a3dd5783dc39e06be7136dcf8554673e4
+  data.tar.gz: 83815cc74d3261b5e05cb0d3ab760dfa0c5c3448ac0595d70392ed4d45d9ccc388c1026ae4202a72128c5945976d6eba04ac60f0729fc8c0f4df8b5a2c63e2c0

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Master (Unreleased)
 
+## 1.29.1 (2018-09-01)
+
+* Fix false negative in `FactoryBot/AttributeDefinedStatically` when attribute is defined on `self`. ([@Darhazer][])
+* `RSpec/FactoryBot` cops will now also inspect the `spec/factories.rb` path by default. ([@bquorning][])
+
 ## 1.29.0 (2018-08-25)
 
 * `RSpec/InstanceVariable` - Recommend local variables in addition to `let`. ([@jaredbeck][])

data/config/default.yml

@@ -6,6 +6,7 @@ AllCops:
     - "(?:^|/)spec/"
   RSpec/FactoryBot:
     Patterns:
+    - spec/factories.rb
     - spec/factories/**/*.rb
     - features/support/factories/**/*.rb
 

data/lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb

@@ -63,7 +63,7 @@ module RuboCop
             ATTRIBUTE_DEFINING_METHODS
 
           def_node_matcher :value_matcher, <<-PATTERN
-            (send nil? !#reserved_method? $...)
+            (send {self nil?} !#reserved_method? $...)
           PATTERN
 
           def_node_search :factory_attributes, <<-PATTERN

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.29.0'.freeze
+      STRING = '1.29.1'.freeze
     end
   end
 end

data/spec/rubocop/cop/rspec/factory_bot/attribute_defined_statically_spec.rb

@@ -54,6 +54,18 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::AttributeDefinedStatically do #
     RUBY
   end
 
+  it 'registers an offense for an attribute defined on `self`' do
+    expect_offense(<<-RUBY)
+      FactoryBot.define do
+        factory :post do
+          self.start { Date.today }
+          self.end Date.tomorrow
+          ^^^^^^^^^^^^^^^^^^^^^^ Use a block to declare attribute values.
+        end
+      end
+    RUBY
+  end
+
   it 'accepts valid factory definitions' do
     expect_no_offenses(<<-RUBY)
       FactoryBot.define do
@@ -121,6 +133,7 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::AttributeDefinedStatically do #
         meta_tags(foo: Time.current)
         other_tags({ foo: Time.current })
         options color: :blue
+        self.end Date.tomorrow
 
         trait :old do
           published_at 1.week.ago
@@ -144,6 +157,7 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::AttributeDefinedStatically do #
         meta_tags { { foo: Time.current } }
         other_tags { { foo: Time.current } }
         options { { color: :blue } }
+        self.end { Date.tomorrow }
 
         trait :old do
           published_at { 1.week.ago }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.29.0
+  version: 1.29.1
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-25 00:00:00.000000000 Z
+date: 2018-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop