rubocop-rspec 1.25.0 → 1.25.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c195bc91134a73125f33d0675230a01fd467747690f3113ff3a924559d7c748c
-  data.tar.gz: 3f9fcaedd22ab9f67542b083ef72a6ab466df04a758c84f3e244176b781a6109
+  metadata.gz: 3aa1fc65d7a5b5430ef4c5a88fa0daa56e09d330dd243225f3ef9b6332b076b3
+  data.tar.gz: 2e56f9dfd5b0b4f11ba040b032bd75ea366a10f15ac7255144971ddfd56027f3
 SHA512:
-  metadata.gz: be3574c7d021a099bdd2869d47a908f4ac5c3ea9e12823030db025a92d24fd3d8008373b422b72e7e666cfefda0a983b3ae6d5f57e62c2dd14f99dc416d48ac3
-  data.tar.gz: 8bcad630c6244f19a896c061c15c94dbe9611f651d72306642bb980c2aa082b0d78d54f54e3b32544b475c4cbbb8a18dbe8631105cdbec4f6d12e0b81851b8b2
+  metadata.gz: a6066bc29073c219f495824ddce3c3b7d2237d1d06c28605ce536c46b2ec11d0240f05438d7ff8d4a03fde39d484816eb479122617cf411dcf91caba0b2d2cad
+  data.tar.gz: f1d974b0e62efee91acc48eef293fee4237ebb7ec3eb25eb210808e10432be9a010867818410e99b9986e518d24d237d77709c8acea41a35b3dab225412168d8

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Master (Unreleased)
 
+## 1.25.1 (2018-04-10)
+
+* Fix false positive in `RSpec/Pending` cop when pending is used as a method name.  ([@Darhazer][])
+* Fix `FactoryBot/DynamicAttributeDefinedStatically` false positive when using symbol proc argument for a sequence. ([@tdeo][])
+
 ## 1.25.0 (2018-04-07)
 
 * Add `RSpec/SharedExamples` cop to enforce consistent usage of string to titleize shared examples. ([@anthony-robin][])
@@ -328,3 +333,4 @@ Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
 [@jojos003]: https://github.com/jojos003
 [@abrom]: https://github.com/abrom
 [@patrickomatic]: https://github.com/patrickomatic
+[@tdeo]: https://github.com/tdeo

data/lib/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically.rb

@@ -31,14 +31,9 @@ module RuboCop
             (block (send nil? {:factory :trait} ...) _ { (begin $...) $(send ...) } )
           PATTERN
 
-          def_node_matcher :callback_with_symbol_proc?, <<-PATTERN
-            (send nil? {:before :after} sym (block_pass sym))
-          PATTERN
-
           def on_block(node)
             factory_attributes(node).to_a.flatten.each do |attribute|
-              next if callback_with_symbol_proc?(attribute) ||
-                  static?(attribute)
+              next if static_or_proc?(attribute)
               add_offense(attribute, location: :expression)
             end
           end
@@ -55,8 +50,10 @@ module RuboCop
 
           private
 
-          def static?(attribute)
-            value_matcher(attribute).to_a.all?(&:recursive_literal_or_const?)
+          def static_or_proc?(attribute)
+            value_matcher(attribute).to_a.all? do |value|
+              value.block_pass_type? || value.recursive_literal_or_const?
+            end
           end
 
           def value_hash_without_braces?(node)

data/lib/rubocop/cop/rspec/pending.rb

@@ -43,8 +43,12 @@ module RuboCop
 
         def_node_matcher :pending_block?, PENDING_EXAMPLES.send_pattern
 
+        def_node_matcher :rspec?, '(send {(const nil? :RSpec) nil?} ...)'
+
         def on_send(node)
           return unless pending_block?(node) || skipped_from_metadata?(node)
+          return unless rspec?(node)
+
           add_offense(node, location: :expression)
         end
 

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.25.0'.freeze
+      STRING = '1.25.1'.freeze
     end
   end
 end

data/spec/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically_spec.rb

@@ -87,6 +87,16 @@ RSpec.describe RuboCop::Cop::RSpec::FactoryBot::DynamicAttributeDefinedStaticall
         RUBY
       end
 
+      it 'accepts valid sequence definition' do
+        expect_no_offenses(<<-RUBY)
+          #{factory_bot}.define do
+            factory :post do
+              sequence :negative_numbers, &:-@
+            end
+          end
+        RUBY
+      end
+
       bad = <<-RUBY
         #{factory_bot}.define do
           factory :post do

data/spec/rubocop/cop/rspec/pending_spec.rb

@@ -106,6 +106,14 @@ RSpec.describe RuboCop::Cop::RSpec::Pending do
     RUBY
   end
 
+  it 'flags pending examples when receiver is explicit' do
+    expect_offense(<<-RUBY)
+      RSpec.xit 'test' do
+      ^^^^^^^^^^^^^^^^ Pending spec found.
+      end
+    RUBY
+  end
+
   it 'does not flag describe' do
     expect_no_offenses(<<-RUBY)
       describe 'test' do; end
@@ -159,4 +167,10 @@ RSpec.describe RuboCop::Cop::RSpec::Pending do
       example_group 'test' do; end
     RUBY
   end
+
+  it 'does not flag method called pending' do
+    expect_no_offenses(<<-RUBY)
+      subject { Project.pending }
+    RUBY
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.25.0
+  version: 1.25.1
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-07 00:00:00.000000000 Z
+date: 2018-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop