rubocop-rspec 1.24.0 → 1.25.0

data/spec/rubocop/cop/rspec/predicate_matcher_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe RuboCop::Cop::RSpec::PredicateMatcher, :config do
   context 'when enforced style is `inflected`' do
     let(:enforced_style) { 'inflected' }
 
-    shared_examples :inflected_common do
+    shared_examples 'inflected common' do
       it 'registers an offense for a predicate method in actual' do
         expect_offense(<<-RUBY)
           expect(foo.empty?).to be_truthy
@@ -90,6 +90,10 @@ RSpec.describe RuboCop::Cop::RSpec::PredicateMatcher, :config do
                        'expect(foo.is_a?(Array)).to be_truthy',
                        'expect(foo).to be_a(Array)'
 
+      include_examples 'autocorrect',
+                       'expect(foo.instance_of?(Array)).to be_truthy',
+                       'expect(foo).to be_an_instance_of(Array)'
+
       include_examples 'autocorrect',
                        'expect(foo.has_something?).to be_truthy',
                        'expect(foo).to have_something'
@@ -148,7 +152,7 @@ RSpec.describe RuboCop::Cop::RSpec::PredicateMatcher, :config do
     context 'when strict is true' do
       let(:strict) { true }
 
-      include_examples :inflected_common
+      include_examples 'inflected common'
 
       it 'accepts strict checking boolean matcher' do
         expect_no_offenses(<<-RUBY)
@@ -164,7 +168,7 @@ RSpec.describe RuboCop::Cop::RSpec::PredicateMatcher, :config do
     context 'when strict is false' do
       let(:strict) { false }
 
-      include_examples :inflected_common
+      include_examples 'inflected common'
 
       it 'registers an offense for a predicate method in actual' do
         expect_offense(<<-RUBY)
@@ -205,7 +209,7 @@ RSpec.describe RuboCop::Cop::RSpec::PredicateMatcher, :config do
   context 'when enforced style is `explicit`' do
     let(:enforced_style) { 'explicit' }
 
-    shared_examples :explicit_common do
+    shared_examples 'explicit common' do
       it 'registers an offense for a predicate mather' do
         expect_offense(<<-RUBY)
           expect(foo).to be_empty
@@ -258,7 +262,7 @@ RSpec.describe RuboCop::Cop::RSpec::PredicateMatcher, :config do
       end
     end
 
-    shared_examples :explicit_autocorrect do |matcher_true, matcher_false|
+    shared_examples 'explicit autocorrect' do |matcher_true, matcher_false|
       include_examples 'autocorrect',
                        'expect(foo).to be_something',
                        "expect(foo.something?).to #{matcher_true}"
@@ -321,15 +325,15 @@ RSpec.describe RuboCop::Cop::RSpec::PredicateMatcher, :config do
     context 'when strict is true' do
       let(:strict) { true }
 
-      include_examples :explicit_common
-      include_examples :explicit_autocorrect, 'be(true)', 'be(false)'
+      include_examples 'explicit common'
+      include_examples 'explicit autocorrect', 'be(true)', 'be(false)'
     end
 
     context 'when strict is false' do
       let(:strict) { false }
 
-      include_examples :explicit_common
-      include_examples :explicit_autocorrect, 'be_truthy', 'be_falsey'
+      include_examples 'explicit common'
+      include_examples 'explicit autocorrect', 'be_truthy', 'be_falsey'
     end
   end
 end

data/spec/rubocop/cop/rspec/return_from_stub_spec.rb

@@ -62,6 +62,15 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
       RUBY
     end
 
+    it 'finds nested constants returned from block' do
+      expect_offense(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar) { {Life::MEANING => 42} }
+                                      ^ Use `and_return` for static values.
+        end
+      RUBY
+    end
+
     it 'ignores dynamic values returned from block' do
       expect_no_offenses(<<-RUBY)
         it do

data/spec/rubocop/cop/rspec/shared_examples_spec.rb

@@ -0,0 +1,93 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::RSpec::SharedExamples do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offense when using symbolic title' do
+    expect_offense(<<-RUBY)
+      it_behaves_like :foo_bar_baz
+                      ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
+      it_should_behave_like :foo_bar_baz
+                            ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
+      shared_examples :foo_bar_baz
+                      ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
+      shared_examples_for :foo_bar_baz
+                          ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
+      include_examples :foo_bar_baz
+                       ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
+      include_examples :foo_bar_baz, 'foo', 'bar'
+                       ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
+
+      shared_examples :foo_bar_baz do |param|
+                      ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
+        # ...
+      end
+
+      RSpec.shared_examples :foo_bar_baz
+                            ^^^^^^^^^^^^ Prefer 'foo bar baz' over `:foo_bar_baz` to titleize shared examples.
+    RUBY
+  end
+
+  it 'does not register an offense when using string title' do
+    expect_no_offenses(<<-RUBY)
+      it_behaves_like 'foo bar baz'
+      it_should_behave_like 'foo bar baz'
+      shared_examples 'foo bar baz'
+      shared_examples_for 'foo bar baz'
+      include_examples 'foo bar baz'
+      include_examples 'foo bar baz', 'foo', 'bar'
+
+      shared_examples 'foo bar baz', 'foo', 'bar' do |param|
+        # ...
+      end
+    RUBY
+  end
+
+  it 'does not register an offense when using Module/Class title' do
+    expect_no_offenses(<<-RUBY)
+      it_behaves_like FooBarBaz
+      it_should_behave_like FooBarBaz
+      shared_examples FooBarBaz
+      shared_examples_for FooBarBaz
+      include_examples FooBarBaz
+      include_examples FooBarBaz, 'foo', 'bar'
+
+      shared_examples FooBarBaz, 'foo', 'bar' do |param|
+        # ...
+      end
+    RUBY
+  end
+
+  include_examples 'autocorrect',
+                   'it_behaves_like :foo_bar_baz',
+                   "it_behaves_like 'foo bar baz'"
+  include_examples 'autocorrect',
+                   'it_should_behave_like :foo_bar_baz',
+                   "it_should_behave_like 'foo bar baz'"
+  include_examples 'autocorrect',
+                   'shared_examples :foo_bar_baz',
+                   "shared_examples 'foo bar baz'"
+  include_examples 'autocorrect',
+                   'shared_examples_for :foo_bar_baz',
+                   "shared_examples_for 'foo bar baz'"
+  include_examples 'autocorrect',
+                   'include_examples :foo_bar_baz',
+                   "include_examples 'foo bar baz'"
+  include_examples 'autocorrect',
+                   "include_examples :foo_bar_baz, 'foo', 'bar'",
+                   "include_examples 'foo bar baz', 'foo', 'bar'"
+
+  bad_code_with_block = <<-RUBY
+    shared_examples :foo_bar_baz, 'foo', 'bar' do |param|
+      # ...
+    end
+  RUBY
+
+  good_code_with_block = <<-RUBY
+    shared_examples 'foo bar baz', 'foo', 'bar' do |param|
+      # ...
+    end
+  RUBY
+
+  include_examples 'autocorrect', bad_code_with_block, good_code_with_block
+end

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@ require 'rubocop'
 
 require 'rubocop/rspec/support'
 
-if ENV['CI']
+if ENV['COVERAGE'] == 'true'
   require 'simplecov'
   SimpleCov.start
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.24.0
+  version: 1.25.0
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-06 00:00:00.000000000 Z
+date: 2018-04-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -120,6 +120,7 @@ files:
 - lib/rubocop/cop/rspec/align_right_let_brace.rb
 - lib/rubocop/cop/rspec/any_instance.rb
 - lib/rubocop/cop/rspec/around_block.rb
+- lib/rubocop/cop/rspec/be.rb
 - lib/rubocop/cop/rspec/be_eql.rb
 - lib/rubocop/cop/rspec/before_after_all.rb
 - lib/rubocop/cop/rspec/capybara/current_path_expectation.rb
@@ -140,6 +141,7 @@ files:
 - lib/rubocop/cop/rspec/expect_change.rb
 - lib/rubocop/cop/rspec/expect_in_hook.rb
 - lib/rubocop/cop/rspec/expect_output.rb
+- lib/rubocop/cop/rspec/factory_bot/create_list.rb
 - lib/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically.rb
 - lib/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically.rb
 - lib/rubocop/cop/rspec/file_path.rb
@@ -164,6 +166,7 @@ files:
 - lib/rubocop/cop/rspec/nested_groups.rb
 - lib/rubocop/cop/rspec/not_to_not.rb
 - lib/rubocop/cop/rspec/overwriting_setup.rb
+- lib/rubocop/cop/rspec/pending.rb
 - lib/rubocop/cop/rspec/predicate_matcher.rb
 - lib/rubocop/cop/rspec/rails/http_status.rb
 - lib/rubocop/cop/rspec/repeated_description.rb
@@ -172,6 +175,7 @@ files:
 - lib/rubocop/cop/rspec/scattered_let.rb
 - lib/rubocop/cop/rspec/scattered_setup.rb
 - lib/rubocop/cop/rspec/shared_context.rb
+- lib/rubocop/cop/rspec/shared_examples.rb
 - lib/rubocop/cop/rspec/single_argument_message_chain.rb
 - lib/rubocop/cop/rspec/subject_stub.rb
 - lib/rubocop/cop/rspec/verified_doubles.rb
@@ -190,6 +194,7 @@ files:
 - lib/rubocop/rspec/inject.rb
 - lib/rubocop/rspec/language.rb
 - lib/rubocop/rspec/language/node_pattern.rb
+- lib/rubocop/rspec/node.rb
 - lib/rubocop/rspec/top_level_describe.rb
 - lib/rubocop/rspec/util.rb
 - lib/rubocop/rspec/version.rb
@@ -203,6 +208,7 @@ files:
 - spec/rubocop/cop/rspec/any_instance_spec.rb
 - spec/rubocop/cop/rspec/around_block_spec.rb
 - spec/rubocop/cop/rspec/be_eql_spec.rb
+- spec/rubocop/cop/rspec/be_spec.rb
 - spec/rubocop/cop/rspec/before_after_all_spec.rb
 - spec/rubocop/cop/rspec/capybara/current_path_expectation_spec.rb
 - spec/rubocop/cop/rspec/capybara/feature_methods_spec.rb
@@ -222,6 +228,7 @@ files:
 - spec/rubocop/cop/rspec/expect_change_spec.rb
 - spec/rubocop/cop/rspec/expect_in_hook_spec.rb
 - spec/rubocop/cop/rspec/expect_output_spec.rb
+- spec/rubocop/cop/rspec/factory_bot/create_list_spec.rb
 - spec/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically_spec.rb
 - spec/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
@@ -246,6 +253,7 @@ files:
 - spec/rubocop/cop/rspec/nested_groups_spec.rb
 - spec/rubocop/cop/rspec/not_to_not_spec.rb
 - spec/rubocop/cop/rspec/overwriting_setup_spec.rb
+- spec/rubocop/cop/rspec/pending_spec.rb
 - spec/rubocop/cop/rspec/predicate_matcher_spec.rb
 - spec/rubocop/cop/rspec/rails/http_status_spec.rb
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
@@ -254,6 +262,7 @@ files:
 - spec/rubocop/cop/rspec/scattered_let_spec.rb
 - spec/rubocop/cop/rspec/scattered_setup_spec.rb
 - spec/rubocop/cop/rspec/shared_context_spec.rb
+- spec/rubocop/cop/rspec/shared_examples_spec.rb
 - spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb
 - spec/rubocop/cop/rspec/subject_stub_spec.rb
 - spec/rubocop/cop/rspec/verified_doubles_spec.rb
@@ -270,10 +279,12 @@ files:
 - spec/shared/detects_style_behavior.rb
 - spec/spec_helper.rb
 - spec/support/expect_offense.rb
-homepage: http://github.com/backus/rubocop-rspec
+homepage: https://github.com/rubocop-rspec/rubocop-rspec
 licenses:
 - MIT
-metadata: {}
+metadata:
+  changelog_uri: https://github.com/rubocop-rspec/rubocop-rspec/blob/master/CHANGELOG.md
+  documentation_uri: https://rubocop-rspec.readthedocs.io/
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -303,6 +314,7 @@ test_files:
 - spec/rubocop/cop/rspec/any_instance_spec.rb
 - spec/rubocop/cop/rspec/around_block_spec.rb
 - spec/rubocop/cop/rspec/be_eql_spec.rb
+- spec/rubocop/cop/rspec/be_spec.rb
 - spec/rubocop/cop/rspec/before_after_all_spec.rb
 - spec/rubocop/cop/rspec/capybara/current_path_expectation_spec.rb
 - spec/rubocop/cop/rspec/capybara/feature_methods_spec.rb
@@ -322,6 +334,7 @@ test_files:
 - spec/rubocop/cop/rspec/expect_change_spec.rb
 - spec/rubocop/cop/rspec/expect_in_hook_spec.rb
 - spec/rubocop/cop/rspec/expect_output_spec.rb
+- spec/rubocop/cop/rspec/factory_bot/create_list_spec.rb
 - spec/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically_spec.rb
 - spec/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
@@ -346,6 +359,7 @@ test_files:
 - spec/rubocop/cop/rspec/nested_groups_spec.rb
 - spec/rubocop/cop/rspec/not_to_not_spec.rb
 - spec/rubocop/cop/rspec/overwriting_setup_spec.rb
+- spec/rubocop/cop/rspec/pending_spec.rb
 - spec/rubocop/cop/rspec/predicate_matcher_spec.rb
 - spec/rubocop/cop/rspec/rails/http_status_spec.rb
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
@@ -354,6 +368,7 @@ test_files:
 - spec/rubocop/cop/rspec/scattered_let_spec.rb
 - spec/rubocop/cop/rspec/scattered_setup_spec.rb
 - spec/rubocop/cop/rspec/shared_context_spec.rb
+- spec/rubocop/cop/rspec/shared_examples_spec.rb
 - spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb
 - spec/rubocop/cop/rspec/subject_stub_spec.rb
 - spec/rubocop/cop/rspec/verified_doubles_spec.rb