rubocop-rspec 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5e1993245da215069d2de0ca4a565ccd0ac9aaa6
-  data.tar.gz: ab550daf4e1f7ea5121d19fbea73e6626b6ae3a2
+  metadata.gz: 781c177bf195bc9ec0663b45b2312aa2a94f6da2
+  data.tar.gz: 44414a1e7ea2f3ee8ac707b8d6e5659e5789588b
 SHA512:
-  metadata.gz: 01f3a531a9acaef8fd91e3f2af343eaecf80d7e74e224e386d2470911189c24a90e27a9e2b717e01250c2f76fc60269ea3bef26c413adac9eb4e71d4c44d4180
-  data.tar.gz: 34ec3b6aeaa188e97066a479ec6c33fbbdc714609afbaccf82dc4aa0e64f8277ab6c376c35be726f52794d3e84c367e7d3222a8afd8a586061e51a1cd968c606
+  metadata.gz: f95537228be6ba9d25328bfcb375091ba5bcfc2bc58ba384c910e6f87fd367a5510dfec4f47cdf07a2e863794a614d657c22b7d744b94380db6e6a67e6f6f78c
+  data.tar.gz: 157e06d0dc76c034b8a2704dad0747d15cb59654412206957fa4c4365686adf8764544de0b8ad1ca6f21c7bc54d6e21b30a0e04526ec51636663d6b2f1dbe176

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change log
 
+## 1.2.1
+
+* Add `RSpec::VerifiedDoubles` cop. ([@andyw8][])
+
 ## 1.2.0
 
 * Drop support of ruby `1.9.2`. ([@geniou][])
@@ -39,6 +43,7 @@
 
 <!-- Contributors -->
 
+[@andyw8]: https://github.com/andyw8
 [@geniou]: https://github.com/geniou
 [@nevir]: https://github.com/nevir
 [@pstengel]: https://github.com/pstengel

data/config/default.yml

@@ -34,3 +34,7 @@ RSpec/FilePath:
   CustomTransform:
     RuboCop: rubocop
     RSpec: rspec
+
+RSpec/VerifiedDoubles:
+  Description: 'Prefer using verifying doubles over normal doubles.'
+  Enabled: false

data/lib/rubocop-rspec.rb

@@ -16,3 +16,4 @@ require 'rubocop/cop/rspec/example_wording'
 require 'rubocop/cop/rspec/file_path'
 require 'rubocop/cop/rspec/instance_variable'
 require 'rubocop/cop/rspec/multiple_describes'
+require 'rubocop/cop/rspec/verified_doubles'

data/lib/rubocop/cop/rspec/example_wording.rb

@@ -20,7 +20,7 @@ module RuboCop
       class ExampleWording < Cop
         MSG = 'Do not use should when describing your tests.'
 
-        def on_block(node)
+        def on_block(node) # rubocop:disable Metrics/AbcSize
           method, _, _ = *node
           _, method_name, *args = *method
 
@@ -63,7 +63,7 @@ module RuboCop
 
           # ends with o s x ch sh or ss
           if %w(o s x]).include?(word[-1]) ||
-            %w(ch sh ss]).include?(word[-2..-1])
+              %w(ch sh ss]).include?(word[-2..-1])
             return "#{word}es"
           end
 

data/lib/rubocop/cop/rspec/instance_variable.rb

@@ -10,13 +10,13 @@ module RuboCop
       #   # bad
       #   describe MyClass do
       #     before { @foo = [] }
-      #     it { expect(@foo).to be_emtpy }
+      #     it { expect(@foo).to be_empty }
       #   end
       #
       #   # good
       #   describe MyClass do
       #     let(:foo) { [] }
-      #     it { expect(foo).to be_emtpy }
+      #     it { expect(foo).to be_empty }
       #   end
       class InstanceVariable < Cop
         MESSAGE = 'Use `let` instead of an instance variable'

data/lib/rubocop/cop/rspec/verified_doubles.rb

@@ -0,0 +1,32 @@
+# encoding: utf-8
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Prefer using verifying doubles over normal doubles.
+      # see: https://relishapp.com/rspec/rspec-mocks/docs/verifying-doubles
+      #
+      # @example
+      #   # bad
+      #   it '...' do
+      #     widget = double("Widget")
+      #   end
+      #
+      #   # good
+      #   it '...' do
+      #     widget = instance_double("Widget")
+      #   end
+      class VerifiedDoubles < Cop
+        MSG = 'Prefer using verifying doubles over normal doubles.'
+
+        def on_send(node)
+          _receiver, method_name, *_args = *node
+          return unless method_name == :double
+          add_offense(node,
+                      :expression,
+                      format(MSG, node.loc.expression.source))
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.2.0'
+      STRING = '1.2.1'
     end
   end
 end

data/spec/project_spec.rb

@@ -1,7 +1,5 @@
 # encoding: utf-8
 
-require 'spec_helper'
-
 describe 'RuboCop Project' do # rubocop:disable RSpec/DescribeClass
   describe 'default configuration file' do
     let(:cop_names) do
@@ -9,7 +7,7 @@ describe 'RuboCop Project' do # rubocop:disable RSpec/DescribeClass
                          'rspec', '*.rb'))
         .map do |file|
           cop_name = File.basename(file, '.rb')
-          .gsub(/(^|_)(.)/) { Regexp.last_match(2).upcase }
+            .gsub(/(^|_)(.)/) { Regexp.last_match(2).upcase }
 
           "RSpec/#{cop_name}"
         end

data/spec/rubocop/cop/rspec/describe_class_spec.rb

@@ -1,7 +1,5 @@
 # encoding: utf-8
 
-require 'spec_helper'
-
 describe RuboCop::Cop::RSpec::DescribeClass do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/describe_method_spec.rb

@@ -1,7 +1,5 @@
 # encoding: utf-8
 
-require 'spec_helper'
-
 describe RuboCop::Cop::RSpec::DescribeMethod do
   subject(:cop) { described_class.new }
 
@@ -10,8 +8,8 @@ describe RuboCop::Cop::RSpec::DescribeMethod do
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([1])
     expect(cop.messages)
-    .to eq(['The second argument to describe should be the method being ' \
-            "tested. '#instance' or '.class'"])
+      .to eq(['The second argument to describe should be the method being ' \
+              "tested. '#instance' or '.class'"])
   end
 
   it 'skips methods starting with a . or #' do

data/spec/rubocop/cop/rspec/described_class_spec.rb

@@ -1,7 +1,5 @@
 # encoding: utf-8
 
-require 'spec_helper'
-
 describe RuboCop::Cop::RSpec::DescribedClass do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/example_wording_spec.rb

@@ -1,13 +1,11 @@
 # encoding: utf-8
 
-require 'spec_helper'
-
 describe RuboCop::Cop::RSpec::ExampleWording, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) do
     {
       'CustomTransform' => { 'have' => 'has', 'not' => 'does not' },
-      'IgnoredWords' => %w(only realy)
+      'IgnoredWords' => %w(only really)
     }
   end
 
@@ -44,7 +42,7 @@ describe RuboCop::Cop::RSpec::ExampleWording, :config do
     'should worry about the future' => 'worries about the future',
     'should pay for pizza' => 'pays for pizza',
     'should miss me' => 'misses me',
-    'should realy only return one item' => 'realy only returns one item'
+    'should really only return one item' => 'really only returns one item'
   }.each do |old, new|
     it 'autocorrects an offenses' do
       new_source = autocorrect_source(cop, ["it '#{old}' do", 'end'])

data/spec/rubocop/cop/rspec/file_path_spec.rb

@@ -1,7 +1,5 @@
 # encoding: utf-8
 
-require 'spec_helper'
-
 describe RuboCop::Cop::RSpec::FilePath, :config do
   subject(:cop) { described_class.new(config) }
   let(:cop_config) { { 'CustomTransform' => { 'FooFoo' => 'foofoo' } } }

data/spec/rubocop/cop/rspec/instance_variable_spec.rb

@@ -1,14 +1,12 @@
 # encoding: utf-8
 
-require 'spec_helper'
-
 describe RuboCop::Cop::RSpec::InstanceVariable do
   subject(:cop) { described_class.new }
 
   it 'finds an instance variable inside a describe' do
     inspect_source(cop, ['describe MyClass do',
                          '  before { @foo = [] }',
-                         '  it { expect(@foo).to be_emtpy }',
+                         '  it { expect(@foo).to be_empty }',
                          'end'])
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([3])
@@ -17,7 +15,7 @@ describe RuboCop::Cop::RSpec::InstanceVariable do
 
   it 'finds an instance variable inside a shared example' do
     inspect_source(cop, ["shared_examples 'shared example' do",
-                         '  it { expect(@foo).to be_emtpy }',
+                         '  it { expect(@foo).to be_empty }',
                          'end'])
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([2])

data/spec/rubocop/cop/rspec/multiple_describes_spec.rb

@@ -1,7 +1,5 @@
 # encoding: utf-8
 
-require 'spec_helper'
-
 describe RuboCop::Cop::RSpec::MultipleDescribes do
   subject(:cop) { described_class.new }
 

data/spec/rubocop/cop/rspec/verified_doubles_spec.rb

@@ -0,0 +1,15 @@
+# encoding: utf-8
+
+describe RuboCop::Cop::RSpec::VerifiedDoubles do
+  subject(:cop) { described_class.new }
+
+  it 'finds `double` instead of a verifying double' do
+    inspect_source(cop, ['it do',
+                         '  foo = double("Widget")',
+                         'end'])
+    expect(cop.messages)
+      .to eq(['Prefer using verifying doubles over normal doubles.'])
+    expect(cop.highlights).to eq(['double("Widget")'])
+    expect(cop.offenses.map(&:line).sort).to eq([2])
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Ian MacLeod
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-02 00:00:00.000000000 Z
+date: 2014-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -93,6 +93,7 @@ files:
 - lib/rubocop/cop/rspec/file_path.rb
 - lib/rubocop/cop/rspec/instance_variable.rb
 - lib/rubocop/cop/rspec/multiple_describes.rb
+- lib/rubocop/cop/rspec/verified_doubles.rb
 - lib/rubocop/rspec/inject.rb
 - lib/rubocop/rspec/top_level_describe.rb
 - lib/rubocop/rspec/version.rb
@@ -105,6 +106,7 @@ files:
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/instance_variable_spec.rb
 - spec/rubocop/cop/rspec/multiple_describes_spec.rb
+- spec/rubocop/cop/rspec/verified_doubles_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/nevir/rubocop-rspec
 licenses:
@@ -139,5 +141,6 @@ test_files:
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/instance_variable_spec.rb
 - spec/rubocop/cop/rspec/multiple_describes_spec.rb
+- spec/rubocop/cop/rspec/verified_doubles_spec.rb
 - spec/spec_helper.rb
 has_rdoc: