rubocop-rspec 1.19.0 → 1.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 98cb4ed6eefcee97bb8b5dea2093bb2cab7abc99
-  data.tar.gz: ce92dd968c520f5dbe633443262235b05f038cf1
+SHA256:
+  metadata.gz: 75a86e91f1a68118254233b1bc1f34b78c8b96ce3e0f807bde3dc7a3450db2b8
+  data.tar.gz: 956ce60a540a49bf96425aeb3a856028600bff19a482dc5e90198e0419879b83
 SHA512:
-  metadata.gz: c89f710f27e3fe8695428c11866a4f853a1397a5adece3f89963d73521edd8ea102f29e625756390d99d27afe2f33d620b0da3e761e361800eac04bef3f450f2
-  data.tar.gz: 3464b491a898fa51fa8709fa632274b221f44529845bd291d892706bdc5e9fc99e1ea234fa54b331b6af1aa6544e57397c68add5cd4c96e37fd68b0f527d91d7
+  metadata.gz: bb066d3c753eb46efffb2acd402f9747a6673af7d8c7748c7c9f7ddec23d67533902dc851315d8750a97f194a8b2266b05c84835c41ff768f3240aa88c8b077d
+  data.tar.gz: 040ec718d9a63756636881881b6f8002ed40f04e1eb2a50efd5c2def669487b9d4184e430e9ecf45b39781f5593d064e1604c5b4549689f9fc575afbe0282c25

data/CHANGELOG.md

@@ -2,6 +2,17 @@
 
 ## Master (Unreleased)
 
+## 1.20.0 (2017-11-09)
+
+* Rename namespace `FactoryGirl` to `FactoryBot` following original library update. ([@walf443][])
+* Fix exception in `RSpec/ReturnFromStub` on empty block. ([@yevhene][])
+* Add `RSpec/ContextWording` cop. ([@pirj][], [@telmofcosta][])
+* Fix `RSpec/SubjectStub` cop matches receive message inside all matcher. ([@walf443][])
+
+## 1.19.0 (2017-10-18)
+
+Compatibility release so users can upgrade RuboCop to 0.51.0. No new features.
+
 ## 1.18.0 (2017-09-29)
 
 * Fix false positive in `Capybara/FeatureMethods`. ([@Darhazer][])
@@ -255,3 +266,7 @@
 [@bmorrall]: https:/github.com/bmorrall
 [@zverok]: https:/github.com/zverok
 [@timrogers]: https://github.com/timrogers
+[@yevhene]: https://github.com/yevhene
+[@walf443]: https://github.com/walf443
+[@pirj]: https://github.com/pirj
+[@telmofcosta]: https://github.com/telmofcosta

data/README.md

@@ -98,11 +98,7 @@ RSpec/FilePath:
 
 ## Contributing
 
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+Checkout the [contribution guidelines](.github/CONTRIBUTING.md)
 
 ## License
 

data/config/default.yml

@@ -4,7 +4,7 @@ AllCops:
     Patterns:
     - _spec.rb
     - "(?:^|/)spec/"
-  RSpec/FactoryGirl:
+  RSpec/FactoryBot:
     Patterns:
     - spec/factories/**/*.rb
     - features/support/factories/**/*.rb
@@ -43,6 +43,14 @@ RSpec/BeforeAfterAll:
   - spec/support/**/*.rb
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/BeforeAfterAll
 
+RSpec/ContextWording:
+  Description: "`context` block descriptions should start with 'when', or 'with'."
+  Enabled: true
+  Prefixes:
+  - when
+  - with
+  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ContextWording
+
 RSpec/DescribeClass:
   Description: Check that the first argument to the top level describe is a constant.
   Enabled: true
@@ -335,7 +343,7 @@ Capybara/FeatureMethods:
   Enabled: true
   StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Capybara/FeatureMethods
 
-FactoryGirl/DynamicAttributeDefinedStatically:
+FactoryBot/DynamicAttributeDefinedStatically:
   Description: Prefer declaring dynamic attribute values in a block.
   Enabled: true
-  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryGirl/DynamicAttributeDefinedStatically
+  StyleGuide: http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FactoryBot/DynamicAttributeDefinedStatically

data/lib/rubocop-rspec.rb

@@ -18,7 +18,7 @@ require 'rubocop/rspec/hook'
 require 'rubocop/cop/rspec/cop'
 require 'rubocop/rspec/align_let_brace'
 require 'rubocop/rspec/capybara'
-require 'rubocop/rspec/factory_girl'
+require 'rubocop/rspec/factory_bot'
 
 RuboCop::RSpec::Inject.defaults!
 
@@ -31,6 +31,7 @@ require 'rubocop/cop/rspec/be_eql'
 require 'rubocop/cop/rspec/before_after_all'
 require 'rubocop/cop/rspec/capybara/current_path_expectation'
 require 'rubocop/cop/rspec/capybara/feature_methods'
+require 'rubocop/cop/rspec/context_wording'
 require 'rubocop/cop/rspec/describe_class'
 require 'rubocop/cop/rspec/describe_method'
 require 'rubocop/cop/rspec/describe_symbol'
@@ -43,7 +44,7 @@ require 'rubocop/cop/rspec/example_wording'
 require 'rubocop/cop/rspec/expect_actual'
 require 'rubocop/cop/rspec/expect_in_hook'
 require 'rubocop/cop/rspec/expect_output'
-require 'rubocop/cop/rspec/factory_girl/dynamic_attribute_defined_statically'
+require 'rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically'
 require 'rubocop/cop/rspec/file_path'
 require 'rubocop/cop/rspec/focus'
 require 'rubocop/cop/rspec/hook_argument'

data/lib/rubocop/cop/rspec/context_wording.rb

@@ -0,0 +1,63 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module RSpec
+      # `context` block descriptions should start with 'when', or 'with'.
+      #
+      # @see https://github.com/reachlocal/rspec-style-guide#context-descriptions
+      # @see http://www.betterspecs.org/#contexts
+      #
+      # @example `Prefixes` configuration option, defaults: 'when', and 'with'
+      #   Prefixes:
+      #     - when
+      #     - with
+      #     - without
+      #
+      # @example
+      #   # bad
+      #   context 'the display name not present' do
+      #     ...
+      #   end
+      #
+      #   # good
+      #   context 'when the display name is not present' do
+      #     ...
+      #   end
+      class ContextWording < Cop
+        MSG = 'Start context description with %<prefixes>s.'.freeze
+
+        def_node_matcher :context_wording, <<-PATTERN
+          (block (send _ { :context :shared_context } $(str #bad_prefix?)) ...)
+        PATTERN
+
+        def on_block(node)
+          context_wording(node) do |context|
+            add_offense(context, message: message)
+          end
+        end
+
+        private
+
+        def bad_prefix?(description)
+          !prefixes.include?(description.split.first)
+        end
+
+        def prefixes
+          cop_config['Prefixes'] || []
+        end
+
+        def message
+          format(MSG, prefixes: joined_prefixes)
+        end
+
+        def joined_prefixes
+          quoted = prefixes.map { |prefix| "'#{prefix}'" }
+          return quoted.first if quoted.size == 1
+          quoted << "or #{quoted.pop}"
+          quoted.join(', ')
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/{factory_girl → factory_bot}/dynamic_attribute_defined_statically.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module RSpec
-      module FactoryGirl
+      module FactoryBot
         # Prefer declaring dynamic attribute values in a block.
         #
         # @example

data/lib/rubocop/cop/rspec/return_from_stub.rb

@@ -72,7 +72,7 @@ module RuboCop
           return unless block
 
           _receiver, _args, body = *block
-          unless dynamic?(body) # rubocop:disable Style/GuardClause
+          unless body && dynamic?(body) # rubocop:disable Style/GuardClause
             add_offense(
               node,
               location: :expression,

data/lib/rubocop/cop/rspec/subject_stub.rb

@@ -55,15 +55,26 @@ module RuboCop
         #     expect(foo).to receive(:bar)
         #     expect(foo).to receive(:bar).with(1)
         #     expect(foo).to receive(:bar).with(1).and_return(2)
+        #
+        #   @example source that not matches
+        #     expect(foo).to all(receive(:bar))
+        #
         def_node_matcher :message_expectation?, <<-PATTERN
           {
             (send nil? :allow (send nil? %))
-            (send (send nil? :expect (send nil? %)) :to #receive_message?)
+            (send (send nil? :expect (send nil? %)) :to #expectation?)
           }
         PATTERN
 
+        def_node_matcher :all_matcher?, '(send nil? :all ...)'
+
         def_node_search :receive_message?, '(send nil? :receive ...)'
 
+        def expectation?(node)
+          return if all_matcher?(node)
+          receive_message?(node)
+        end
+
         def on_block(node)
           return unless example_group?(node)
 

data/lib/rubocop/rspec/config_formatter.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Builds a YAML config file from two config hashes
     class ConfigFormatter
-      NAMESPACES = /^(#{Regexp.union('RSpec', 'Capybara', 'FactoryGirl')})/
+      NAMESPACES = /^(#{Regexp.union('RSpec', 'Capybara', 'FactoryBot')})/
       STYLE_GUIDE_BASE_URL = 'http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/'.freeze
 
       def initialize(config, descriptions)

data/lib/rubocop/rspec/factory_bot.rb

@@ -0,0 +1,7 @@
+module RuboCop
+  module RSpec
+    # RuboCop FactoryBot project namespace
+    module FactoryBot
+    end
+  end
+end

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.19.0'.freeze
+      STRING = '1.20.0'.freeze
     end
   end
 end

data/spec/project/default_config_spec.rb

@@ -7,10 +7,10 @@ RSpec.describe 'config/default.yml' do
     namespaces = {
       'rspec' => 'RSpec',
       'capybara' => 'Capybara',
-      'factory_girl' => 'FactoryGirl'
+      'factory_bot' => 'FactoryBot'
     }
     glob = SpecHelper::ROOT.join('lib', 'rubocop', 'cop',
-                                 'rspec', '{capybara/,,factory_girl/}*.rb')
+                                 'rspec', '{capybara/,,factory_bot/}*.rb')
     cop_names =
       Pathname.glob(glob).map do |file|
         file_name = file.basename('.rb').to_s

data/spec/rubocop/cop/rspec/context_wording_spec.rb

@@ -0,0 +1,62 @@
+RSpec.describe RuboCop::Cop::RSpec::ContextWording, :config do
+  subject(:cop) { described_class.new(config) }
+
+  let(:cop_config) { { 'Prefixes' => %w[when with] } }
+
+  it 'skips describe blocks' do
+    expect_no_offenses(<<-RUBY)
+      describe 'the display name not present' do
+      end
+    RUBY
+  end
+
+  it 'finds context without `when` at the beginning' do
+    expect_offense(<<-RUBY)
+      context 'the display name not present' do
+              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Start context description with 'when', or 'with'.
+      end
+    RUBY
+  end
+
+  it 'finds shared_context without `when` at the beginning' do
+    expect_offense(<<-RUBY)
+      shared_context 'the display name not present' do
+                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Start context description with 'when', or 'with'.
+      end
+    RUBY
+  end
+
+  it "skips descriptions beginning with 'when'" do
+    expect_no_offenses(<<-RUBY)
+      context 'when the display name is not present' do
+      end
+    RUBY
+  end
+
+  it 'finds context without separate `when` at the beginning' do
+    expect_offense(<<-RUBY)
+      context 'whenever you do' do
+              ^^^^^^^^^^^^^^^^^ Start context description with 'when', or 'with'.
+      end
+    RUBY
+  end
+
+  context 'when configured' do
+    let(:cop_config) { { 'Prefixes' => %w[without] } }
+
+    it 'finds context without whitelisted prefixes at the beginning' do
+      expect_offense(<<-RUBY)
+        context 'when display name is present' do
+                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Start context description with 'without'.
+        end
+      RUBY
+    end
+
+    it 'skips descriptions with whitelisted prefixes at the beginning' do
+      expect_no_offenses(<<-RUBY)
+        context 'without a display name' do
+        end
+      RUBY
+    end
+  end
+end

data/spec/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically_spec.rb

@@ -0,0 +1,91 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/LineLength
+RSpec.describe RuboCop::Cop::RSpec::FactoryBot::DynamicAttributeDefinedStatically do
+  subject(:cop) { described_class.new(config) }
+
+  let(:config) { RuboCop::Config.new }
+
+  %w[FactoryBot FactoryGirl].each do |factory_bot|
+    context "when using #{factory_bot}" do
+      it 'registers an offense for offending code' do
+        expect_offense(<<-RUBY)
+          #{factory_bot}.define do
+            factory :post do
+              published_at 1.day.from_now
+              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
+              status [:draft, :published].sample
+              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
+              created_at 1.day.ago
+              ^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
+            end
+          end
+        RUBY
+      end
+
+      it 'registers an offense in a trait' do
+        expect_offense(<<-RUBY)
+          #{factory_bot}.define do
+            factory :post do
+              title "Something"
+              trait :published do
+                published_at 1.day.from_now
+                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
+              end
+            end
+          end
+        RUBY
+      end
+
+      it 'accepts' do
+        expect_no_offenses(<<-RUBY)
+          #{factory_bot}.define do
+            factory :post do
+              trait :published do
+                published_at { 1.day.from_now }
+              end
+              created_at { 1.day.ago }
+              status :draft
+              comments_count 0
+              title "Static"
+              description { FFaker::Lorem.paragraph(10) }
+              tag Tag::MAGIC
+            end
+          end
+        RUBY
+      end
+
+      it 'does not add offense if out of factory girl block' do
+        expect_no_offenses(<<-RUBY)
+          status [:draft, :published].sample
+          published_at 1.day.from_now
+          created_at 1.day.ago
+        RUBY
+      end
+
+      bad = <<-RUBY
+        #{factory_bot}.define do
+          factory :post do
+            status([:draft, :published].sample)
+            published_at 1.day.from_now
+            created_at(1.day.ago)
+            updated_at Time.current
+          end
+        end
+      RUBY
+
+      corrected = <<-RUBY
+        #{factory_bot}.define do
+          factory :post do
+            status { [:draft, :published].sample }
+            published_at { 1.day.from_now }
+            created_at { 1.day.ago }
+            updated_at { Time.current }
+          end
+        end
+      RUBY
+
+      include_examples 'autocorrect', bad, corrected
+    end
+  end
+end

data/spec/rubocop/cop/rspec/return_from_stub_spec.rb

@@ -17,6 +17,15 @@ RSpec.describe RuboCop::Cop::RSpec::ReturnFromStub, :config do
       RUBY
     end
 
+    it 'finds empty values returned from block' do
+      expect_offense(<<-RUBY)
+        it do
+          allow(Foo).to receive(:bar) {}
+                        ^^^^^^^^^^^^^ Use `and_return` for static values.
+        end
+      RUBY
+    end
+
     it 'finds array with only static values returned from block' do
       expect_offense(<<-RUBY)
         it do

data/spec/rubocop/cop/rspec/shared_context_spec.rb

@@ -1,7 +1,7 @@
 RSpec.describe RuboCop::Cop::RSpec::SharedContext do
   subject(:cop) { described_class.new }
 
-  context 'shared_context' do
+  describe 'shared_context' do
     it 'does not register an offense for empty contexts' do
       expect_no_offenses(<<-RUBY)
         shared_context 'empty' do
@@ -55,7 +55,7 @@ RSpec.describe RuboCop::Cop::RSpec::SharedContext do
     end
   end
 
-  context 'shared_examples' do
+  describe 'shared_examples' do
     it 'does not register an offense for empty examples' do
       expect_no_offenses(<<-RUBY)
         shared_examples 'empty' do

data/spec/rubocop/cop/rspec/subject_stub_spec.rb

@@ -59,6 +59,17 @@ RSpec.describe RuboCop::Cop::RSpec::SubjectStub do
     RUBY
   end
 
+  it 'ignores stub when inside all matcher' do
+    expect_no_offenses(<<-RUBY)
+      describe Foo do
+        subject(:foo) { [Object.new] }
+        it 'tries to trick rubocop-rspec' do
+          expect(foo).to all(receive(:baz))
+        end
+      end
+    RUBY
+  end
+
   it 'flags nested subject stubs when nested subject uses same name' do
     expect_offense(<<-RUBY)
       describe Foo do

data/spec/rubocop/rspec/example_spec.rb

@@ -36,7 +36,7 @@ RSpec.describe RuboCop::RSpec::Example do
     expect(described_class.new(node).to_node).to be(node)
   end
 
-  context 'value object semantics' do
+  describe 'value object semantics' do
     it 'compares by value' do
       aggregate_failures 'equality semantics' do
         expect(example('it("foo")')).to eq(example('it("foo")'))

data/spec/rubocop/rspec/language/selector_set_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe RuboCop::RSpec::Language::SelectorSet do
     expect(selector_set).not_to eq(described_class.new(%i[foo bar baz]))
   end
 
-  context '#include?' do
+  describe '#include?' do
     it 'returns false for selectors not in the set' do
       expect(selector_set.include?(:baz)).to be(false)
     end
@@ -21,25 +21,25 @@ RSpec.describe RuboCop::RSpec::Language::SelectorSet do
     end
   end
 
-  context '#node_pattern' do
+  describe '#node_pattern' do
     it 'builds a node pattern' do
       expect(selector_set.node_pattern).to eql(':foo :bar')
     end
   end
 
-  context '#node_pattern_union' do
+  describe '#node_pattern_union' do
     it 'builds a node pattern union' do
       expect(selector_set.node_pattern_union).to eql('{:foo :bar}')
     end
   end
 
-  context '#send_pattern' do
+  describe '#send_pattern' do
     it 'builds a send matching pattern' do
       expect(selector_set.send_pattern).to eql('(send _ {:foo :bar} ...)')
     end
   end
 
-  context '#block_pattern' do
+  describe '#block_pattern' do
     it 'builds a block matching pattern' do
       expect(selector_set.block_pattern).to eql(
         '(block (send _ {:foo :bar} ...) ...)'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.19.0
+  version: 1.20.0
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-19 00:00:00.000000000 Z
+date: 2017-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -110,6 +110,7 @@ files:
 - lib/rubocop/cop/rspec/before_after_all.rb
 - lib/rubocop/cop/rspec/capybara/current_path_expectation.rb
 - lib/rubocop/cop/rspec/capybara/feature_methods.rb
+- lib/rubocop/cop/rspec/context_wording.rb
 - lib/rubocop/cop/rspec/cop.rb
 - lib/rubocop/cop/rspec/describe_class.rb
 - lib/rubocop/cop/rspec/describe_method.rb
@@ -123,7 +124,7 @@ files:
 - lib/rubocop/cop/rspec/expect_actual.rb
 - lib/rubocop/cop/rspec/expect_in_hook.rb
 - lib/rubocop/cop/rspec/expect_output.rb
-- lib/rubocop/cop/rspec/factory_girl/dynamic_attribute_defined_statically.rb
+- lib/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically.rb
 - lib/rubocop/cop/rspec/file_path.rb
 - lib/rubocop/cop/rspec/focus.rb
 - lib/rubocop/cop/rspec/hook_argument.rb
@@ -165,7 +166,7 @@ files:
 - lib/rubocop/rspec/description_extractor.rb
 - lib/rubocop/rspec/example.rb
 - lib/rubocop/rspec/example_group.rb
-- lib/rubocop/rspec/factory_girl.rb
+- lib/rubocop/rspec/factory_bot.rb
 - lib/rubocop/rspec/hook.rb
 - lib/rubocop/rspec/inject.rb
 - lib/rubocop/rspec/language.rb
@@ -186,6 +187,7 @@ files:
 - spec/rubocop/cop/rspec/before_after_all_spec.rb
 - spec/rubocop/cop/rspec/capybara/current_path_expectation_spec.rb
 - spec/rubocop/cop/rspec/capybara/feature_methods_spec.rb
+- spec/rubocop/cop/rspec/context_wording_spec.rb
 - spec/rubocop/cop/rspec/cop_spec.rb
 - spec/rubocop/cop/rspec/describe_class_spec.rb
 - spec/rubocop/cop/rspec/describe_method_spec.rb
@@ -199,7 +201,7 @@ files:
 - spec/rubocop/cop/rspec/expect_actual_spec.rb
 - spec/rubocop/cop/rspec/expect_in_hook_spec.rb
 - spec/rubocop/cop/rspec/expect_output_spec.rb
-- spec/rubocop/cop/rspec/factory_girl/dynamic_attribute_defined_statically_spec.rb
+- spec/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/hook_argument_spec.rb
@@ -265,7 +267,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.2
 signing_key: 
 specification_version: 4
 summary: Code style checking for RSpec files
@@ -281,6 +283,7 @@ test_files:
 - spec/rubocop/cop/rspec/before_after_all_spec.rb
 - spec/rubocop/cop/rspec/capybara/current_path_expectation_spec.rb
 - spec/rubocop/cop/rspec/capybara/feature_methods_spec.rb
+- spec/rubocop/cop/rspec/context_wording_spec.rb
 - spec/rubocop/cop/rspec/cop_spec.rb
 - spec/rubocop/cop/rspec/describe_class_spec.rb
 - spec/rubocop/cop/rspec/describe_method_spec.rb
@@ -294,7 +297,7 @@ test_files:
 - spec/rubocop/cop/rspec/expect_actual_spec.rb
 - spec/rubocop/cop/rspec/expect_in_hook_spec.rb
 - spec/rubocop/cop/rspec/expect_output_spec.rb
-- spec/rubocop/cop/rspec/factory_girl/dynamic_attribute_defined_statically_spec.rb
+- spec/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/hook_argument_spec.rb

data/lib/rubocop/rspec/factory_girl.rb

@@ -1,7 +0,0 @@
-module RuboCop
-  module RSpec
-    # RuboCop FactoryGirl project namespace
-    module FactoryGirl
-    end
-  end
-end

data/spec/rubocop/cop/rspec/factory_girl/dynamic_attribute_defined_statically_spec.rb

@@ -1,87 +0,0 @@
-# frozen_string_literal: true
-
-# rubocop:disable Metrics/LineLength
-RSpec.describe RuboCop::Cop::RSpec::FactoryGirl::DynamicAttributeDefinedStatically do
-  subject(:cop) { described_class.new(config) }
-
-  let(:config) { RuboCop::Config.new }
-
-  it 'registers an offense for offending code' do
-    expect_offense(<<-RUBY)
-      FactoryGirl.define do
-        factory :post do
-          published_at 1.day.from_now
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
-          status [:draft, :published].sample
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
-          created_at 1.day.ago
-          ^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
-        end
-      end
-    RUBY
-  end
-
-  it 'registers an offense in a trait' do
-    expect_offense(<<-RUBY)
-      FactoryGirl.define do
-        factory :post do
-          title "Something"
-          trait :published do
-            published_at 1.day.from_now
-            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
-          end
-        end
-      end
-    RUBY
-  end
-
-  it 'accepts' do
-    expect_no_offenses(<<-RUBY)
-      FactoryGirl.define do
-        factory :post do
-          trait :published do
-            published_at { 1.day.from_now }
-          end
-          created_at { 1.day.ago }
-          status :draft
-          comments_count 0
-          title "Static"
-          description { FFaker::Lorem.paragraph(10) }
-          tag Tag::MAGIC
-        end
-      end
-    RUBY
-  end
-
-  it 'does not add offense if out of factory girl block' do
-    expect_no_offenses(<<-RUBY)
-      status [:draft, :published].sample
-      published_at 1.day.from_now
-      created_at 1.day.ago
-    RUBY
-  end
-
-  bad = <<-RUBY
-    FactoryGirl.define do
-      factory :post do
-        status([:draft, :published].sample)
-        published_at 1.day.from_now
-        created_at(1.day.ago)
-        updated_at Time.current
-      end
-    end
-  RUBY
-
-  corrected = <<-RUBY
-    FactoryGirl.define do
-      factory :post do
-        status { [:draft, :published].sample }
-        published_at { 1.day.from_now }
-        created_at { 1.day.ago }
-        updated_at { Time.current }
-      end
-    end
-  RUBY
-
-  include_examples 'autocorrect', bad, corrected
-end