rubocop-rspec 1.0.rc2 → 1.0.rc3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 08dd700b50fb2adf8683db8ed5868dede6ada896
-  data.tar.gz: d75cd3f9367ebfe7e35df2e7ec641b8d66ea4d68
+  metadata.gz: bed7dbb7d971920ade6ba9925fbb552b01e79d44
+  data.tar.gz: 377e58808853d26bb9a0abdc5a8ceb0e7d613ca0
 SHA512:
-  metadata.gz: 5d930412aa5d760bb7d4ca719ceae3dae07239c92eb795e4057b9e1200962c92f9595c88dec06516b2f3aa337bc6781b9a962c58a19f0fa5eeb1bba89c10ae07
-  data.tar.gz: 74d79a149588115a0845bd5a8e0414bada5c4320a60a057f5fa04def3f31821aeb386af521aeb90f1437355b1cb1a2f0fc41078a88b043485282ad9e3834f2b6
+  metadata.gz: 281eb6abf3b67f2be3bf7ca2ce5f78ed088efec528a91d0a3d404fd7574eea928ada8425d56bf52617ab66af235122762c0fcbbe4c08f039edbbd9b65aee3f16
+  data.tar.gz: fbcc740631f20a639309ac9b96fa060b1d801ff59d117033e16d0a2a2b9e2e51619e53fbeabbea647aa7efeb4b43953ea704495c26ffd6d42d0882766ccfddea

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Change log
 
+## 1.0.rc3
+
+* Update to RuboCop `>= 0.23`. ([@geniou][])
+* Add configuration option for `CustomTransformation` to `FileName` cop. ([@geniou][])
+
 ## 1.0.rc2
 
 * Gem is no longer 20MB (sorry!). ([@nevir][])

data/README.md

@@ -1,5 +1,4 @@
-RuboCop RSpec
-=============
+# RuboCop RSpec
 
 [![Gem Version](https://badge.fury.io/rb/rubocop-rspec.png)](https://rubygems.org/gems/rubocop-rspec)
 [![Dependency Status](https://gemnasium.com/nevir/rubocop-rspec.png)](https://gemnasium.com/nevir/rubocop-rspec)
@@ -11,46 +10,69 @@ RSpec-specific analysis for your projects, as an extension to
 [RuboCop](https://github.com/bbatsov/rubocop).
 
 
-Usage
------
+## Installation
 
-Add it to your bundle, or environment, and then you can load it via:
+Just install the `rubocop-rspec` gem
+
+```bash
+gem install rubocop-rspec
+```
+
+or if you use bundler put this in your `Gemfile`
+
+```
+gem 'rubocop-rspec'
+```
+
+
+## Usage
+
+You need to tell RuboCop to load the RSpec extension. There are three
+ways to do this:
+
+### RuboCop configuration file
+
+Put this into you `.rubocop.yml`.
+
+```
+require: rubocop-rspec
+```
+
+Now you can run `rubocop` and it will autmaticly load the RuboCop RSpec
+cops together with the standard cops.
+
+### Command line
 
 ```bash
 rubocop --require rubocop-rspec
 ```
 
-or as part of your rubocop rake task:
+### Rake task
 
 ```ruby
-Rubocop::RakeTask.new(:style) do |task|
+RuboCop::RakeTask.new do |task|
   task.requires << 'rubocop-rspec'
 end
 ```
 
 
-The Cops
---------
-
-**WARNING: Cop names are under flux and will likely change in the near future.**
-We're hoping to
-[introduce namespaces](https://github.com/bbatsov/rubocop/issues/1097) into the mix.
+## The Cops
 
-All cops are located under [`lib/rubocop/cop`](lib/rubocop/cop), and contain
+All cops are located under
+[`lib/rubocop/cop/spec`](lib/rubocop/cop/rspec), and contain
 examples/documentation.
 
-In your `.rubocop.yml`, you may treat the RSpec cops just like any other cop.
-For example:
+In your `.rubocop.yml`, you may treat the RSpec cops just like any other
+cop. For example:
 
 ```yaml
-RSpecFileName:
+RSpec/FileName:
   Exclude:
   - spec/my_poorly_named_spec_file.rb
 ```
 
 
-License
--------
+## License
 
 `rubocop-rspec` is MIT licensed. [See the accompanying file](MIT-LICENSE.md) for
 the full text.

data/Rakefile

@@ -25,7 +25,7 @@ desc 'Run RuboCop over this gem'
 task :internal_investigation do
   require 'rubocop-rspec'
 
-  result = Rubocop::CLI.new.run
+  result = RuboCop::CLI.new.run
   abort('RuboCop failed!') unless result == 0
 end
 

data/lib/rubocop-rspec.rb

@@ -6,13 +6,13 @@ require 'rubocop/rspec/version'
 require 'rubocop/rspec/inject'
 require 'rubocop/rspec/top_level_describe'
 
-Rubocop::RSpec::Inject.defaults!
+RuboCop::RSpec::Inject.defaults!
 
 # cops
-require 'rubocop/cop/rspec_describe_class'
-require 'rubocop/cop/rspec_describe_method'
-require 'rubocop/cop/rspec_described_class'
-require 'rubocop/cop/rspec_example_wording'
-require 'rubocop/cop/rspec_file_name'
-require 'rubocop/cop/rspec_instance_variable'
-require 'rubocop/cop/rspec_multiple_describes'
+require 'rubocop/cop/rspec/describe_class'
+require 'rubocop/cop/rspec/describe_method'
+require 'rubocop/cop/rspec/described_class'
+require 'rubocop/cop/rspec/example_wording'
+require 'rubocop/cop/rspec/file_name'
+require 'rubocop/cop/rspec/instance_variable'
+require 'rubocop/cop/rspec/multiple_describes'

data/lib/rubocop/cop/rspec/describe_class.rb

@@ -0,0 +1,30 @@
+# encoding: utf-8
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Check that the first argument to the top level describe is the tested
+      # class or module.
+      #
+      # @example
+      #   # bad
+      #   describe 'Do something' do
+      #   end
+      #
+      #   # good
+      #   describe TestedClass do
+      #   end
+      class DescribeClass < Cop
+        include RuboCop::RSpec::TopLevelDescribe
+
+        MESSAGE = 'The first argument to describe should be the class or ' \
+                  'module being tested.'
+
+        def on_top_level_describe(_node, args)
+          return if args.first && args.first.type == :const
+          add_offense(args.first, :expression, MESSAGE)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/describe_method.rb

@@ -0,0 +1,37 @@
+# encoding: utf-8
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks that the second argument to the top level describe is the tested
+      # method name.
+      #
+      # @example
+      #   # bad
+      #   describe MyClass, 'do something' do
+      #   end
+      #
+      #   # good
+      #   describe MyClass, '#my_instance_method' do
+      #   end
+      #
+      #   describe MyClass, '.my_class_method' do
+      #   end
+      class DescribeMethod < Cop
+        include RuboCop::RSpec::TopLevelDescribe
+
+        MESSAGE = 'The second argument to describe should be the method ' \
+                  "being tested. '#instance' or '.class'"
+        METHOD_STRING_MATCHER = /^[\#\.].+/
+
+        def on_top_level_describe(_node, args)
+          second_arg = args[1]
+          return unless second_arg
+          return if METHOD_STRING_MATCHER =~ second_arg.children.first
+
+          add_offense(second_arg, :expression, MESSAGE)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/described_class.rb

@@ -0,0 +1,58 @@
+# encoding: utf-8
+
+module RuboCop
+  module Cop
+    module RSpec
+      # If the first argument of describe is a class, the class is exposed to
+      # each example via described_class - this should be used instead of
+      # repeating the class.
+      #
+      # @example
+      #   # bad
+      #   describe MyClass do
+      #     subject { MyClass.do_something }
+      #   end
+      #
+      #   # good
+      #   describe MyClass do
+      #     subject { described_class.do_something }
+      #   end
+      class DescribedClass < Cop
+        include RuboCop::RSpec::TopLevelDescribe
+
+        MESSAGE = 'Use `described_class` instead of `%s`'
+
+        def on_block(node)
+          method, _args, body = *node
+          return unless top_level_describe?(method)
+
+          _receiver, method_name, object = *method
+          return unless method_name == :describe
+          return unless object && object.type == :const
+
+          inspect_children(body, object)
+        end
+
+        private
+
+        def inspect_children(node, object)
+          return unless node.is_a? Parser::AST::Node
+          return if scope_change?(node) || node.type == :const
+
+          node.children.each do |child|
+            if child == object
+              name =  object.loc.expression.source
+              add_offense(child, :expression, format(MESSAGE, name))
+              break
+            end
+            inspect_children(child, object)
+          end
+        end
+
+        def scope_change?(node)
+          [:def, :class, :module].include?(node.type)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/example_wording.rb

@@ -0,0 +1,35 @@
+# encoding: utf-8
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Do not use should when describing your tests.
+      # see: http://betterspecs.org/#should
+      #
+      # @example
+      #   # bad
+      #   it 'should find nothing' do
+      #   end
+      #
+      #   # good
+      #   it 'finds nothing' do
+      #   end
+      class ExampleWording < Cop
+        MSG = 'Do not use should when describing your tests.'
+
+        def on_block(node)
+          method, _, _ = *node
+          _, method_name, *args = *method
+
+          return unless method_name == :it
+
+          arguments = *(args.first)
+          message = arguments.first.to_s
+          return unless message.start_with?('should')
+
+          add_offense(method, :selector, MSG)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/file_name.rb

@@ -0,0 +1,71 @@
+# encoding: utf-8
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks the path of the spec file and enforces that it reflects the
+      # described class/module and its optionally called out method.
+      #
+      # With the configuration option `CustomTransform` modules or clases can be
+      # specified that should not as usual be transformed from CamelCase to
+      # snake_case (e.g. 'RuboCop' => 'rubocop' ).
+      #
+      # @example
+      #   my_class/method_spec.rb  # describe MyClass, '#method'
+      #   my_class_method_spec.rb  # describe MyClass, '#method'
+      #   my_class_spec.rb         # describe MyClass
+      class FileName < Cop
+        include RuboCop::RSpec::TopLevelDescribe
+
+        MESSAGE = 'Spec path should end with `%s`'
+        METHOD_STRING_MATCHER = /^[\#\.].+/
+
+        def on_top_level_describe(node, args)
+          return unless single_top_level_describe?
+          object = const_name(args.first)
+          return unless object
+
+          path_matcher = matcher(object, args[1])
+          return if source_filename =~ regexp_from_glob(path_matcher)
+
+          add_offense(node, :expression, format(MESSAGE, path_matcher))
+        end
+
+        private
+
+        def matcher(object, method)
+          path = File.join(parts(object))
+          path += '*' + method.children.first.gsub(/\W+/, '') if method
+
+          "#{path}*_spec.rb"
+        end
+
+        def parts(object)
+          object.split('::').map do |p|
+            custom_transform[p] || camel_to_underscore(p)
+          end
+        end
+
+        def source_filename
+          processed_source.buffer.name
+        end
+
+        def camel_to_underscore(string)
+          string.dup.tap do |result|
+            result.gsub!(/([^A-Z])([A-Z]+)/,          '\\1_\\2')
+            result.gsub!(/([A-Z]{2,})([A-Z][^A-Z]+)/, '\\1_\\2')
+            result.downcase!
+          end
+        end
+
+        def regexp_from_glob(glob)
+          Regexp.new(glob.gsub('.', '\\.').gsub('*', '.*') + '$')
+        end
+
+        def custom_transform
+          cop_config['CustomTransform'] || []
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/instance_variable.rb

@@ -0,0 +1,41 @@
+# encoding: utf-8
+
+module RuboCop
+  module Cop
+    module RSpec
+      # When you have to assign a variable instead of using an instance
+      # variable, use let.
+      #
+      # @example
+      #   # bad
+      #   describe MyClass do
+      #     before { @foo = [] }
+      #     it { expect(@foo).to be_emtpy }
+      #   end
+      #
+      #   # good
+      #   describe MyClass do
+      #     let(:foo) { [] }
+      #     it { expect(foo).to be_emtpy }
+      #   end
+      class InstanceVariable < Cop
+        MESSAGE = 'Use `let` instead of an instance variable'
+        EXAMPLE_GROUP_METHODS = [
+          :example_group, :describe, :context, :xdescribe, :xcontext,
+          :fdescribe, :fcontext, :shared_examples, :shared_context,
+          :share_examples_for, :shared_examples_for, :feature
+        ]
+
+        def on_block(node)
+          method, _args, _body = *node
+          _receiver, method_name, _object = *method
+          @in_spec = true if EXAMPLE_GROUP_METHODS.include?(method_name)
+        end
+
+        def on_ivar(node)
+          add_offense(node, :expression, MESSAGE) if @in_spec
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/rspec/multiple_describes.rb

@@ -0,0 +1,37 @@
+# encoding: utf-8
+
+module RuboCop
+  module Cop
+    module RSpec
+      # Checks for multiple top level describes. They should be nested if it is
+      # for the same class or module or seperated into different files.
+      #
+      # @example
+      #   # bad
+      #   describe MyClass, '.do_someting' do
+      #   end
+      #   describe MyClass, '.do_someting_else' do
+      #   end
+      #
+      #   #good
+      #   describe MyClass
+      #     describe '.do_someting' do
+      #     end
+      #     describe '.do_someting_else' do
+      #     end
+      #   end
+      class MultipleDescribes < Cop
+        include RuboCop::RSpec::TopLevelDescribe
+
+        MESSAGE = 'Do not use multiple top level describes - try to nest them.'
+
+        def on_top_level_describe(node, _args)
+          return if single_top_level_describe?
+          return unless top_level_nodes.first == node
+
+          add_offense(node, :expression, MESSAGE)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/rspec/inject.rb

@@ -2,7 +2,7 @@
 
 require 'yaml'
 
-module Rubocop
+module RuboCop
   module RSpec
     # Because RuboCop doesn't yet support plugins, we have to monkey patch in a
     # bit of our configuration.

data/lib/rubocop/rspec/top_level_describe.rb

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   module RSpec
     # Helper methods for top level describe cops
     module TopLevelDescribe

data/lib/rubocop/rspec/version.rb

@@ -1,10 +1,10 @@
 # encoding: utf-8
 
-module Rubocop
+module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.0.rc2'
+      STRING = '1.0.rc3'
     end
   end
 end

data/rubocop-rspec.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
   spec.email = ['ian@nevir.net', 'git@nilsgemeinhardt.de']
   spec.licenses = ['MIT']
 
-  spec.version = Rubocop::RSpec::Version::STRING
+  spec.version = RuboCop::RSpec::Version::STRING
   spec.platform = Gem::Platform::RUBY
   spec.required_ruby_version = '>= 1.9.2'
 
@@ -30,5 +30,5 @@ Gem::Specification.new do |spec|
   spec.test_files = spec.files.grep(/^spec\//)
   spec.extra_rdoc_files = ['MIT-LICENSE.md', 'README.md']
 
-  spec.add_runtime_dependency('rubocop', '~> 0.19', '>= 0.19')
+  spec.add_runtime_dependency('rubocop', '~> 0.23', '>= 0.23')
 end

data/spec/project_spec.rb

@@ -2,20 +2,21 @@
 
 require 'spec_helper'
 
-describe 'RuboCop Project' do # rubocop:disable RSpecDescribeClass
+describe 'RuboCop Project' do # rubocop:disable RSpec/DescribeClass
   describe 'default configuration file' do
     let(:cop_names) do
       Dir.glob(File.join(File.dirname(__FILE__), '..', 'lib', 'rubocop', 'cop',
-                         '*.rb'))
+                         'rspec', '*.rb'))
         .map do |file|
-          File.basename(file, '.rb')
+          cop_name = File.basename(file, '.rb')
           .gsub(/(^|_)(.)/) { Regexp.last_match(2).upcase }
-          .gsub('Rspec', 'RSpec')
+
+          "RSpec/#{cop_name}"
         end
     end
 
     subject(:default_config) do
-      Rubocop::ConfigLoader.load_file('config/default.yml')
+      RuboCop::ConfigLoader.load_file('config/default.yml')
     end
 
     it 'has configuration for all cops' do

data/spec/rubocop/cop/{rspec_describe_class_spec.rb → rspec/describe_class_spec.rb}

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Rubocop::Cop::RSpecDescribeClass do
+describe RuboCop::Cop::RSpec::DescribeClass do
   subject(:cop) { described_class.new }
 
   it 'checks first-line describe statements' do

data/spec/rubocop/cop/{rspec_describe_method_spec.rb → rspec/describe_method_spec.rb}

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Rubocop::Cop::RSpecDescribeMethod do
+describe RuboCop::Cop::RSpec::DescribeMethod do
   subject(:cop) { described_class.new }
 
   it 'enforces non-method names' do

data/spec/rubocop/cop/{rspec_described_class_spec.rb → rspec/described_class_spec.rb}

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Rubocop::Cop::RSpecDescribedClass do
+describe RuboCop::Cop::RSpec::DescribedClass do
   subject(:cop) { described_class.new }
 
   it 'checks for the use of the described class' do

data/spec/rubocop/cop/{rspec_example_wording_spec.rb → rspec/example_wording_spec.rb}

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Rubocop::Cop::RSpecExampleWording do
+describe RuboCop::Cop::RSpec::ExampleWording do
   subject(:cop) { described_class.new }
 
   it 'finds description with `should` at the beginning' do

data/spec/rubocop/cop/{rspec_file_name_spec.rb → rspec/file_name_spec.rb}

@@ -2,8 +2,9 @@
 
 require 'spec_helper'
 
-describe Rubocop::Cop::RSpecFileName do
-  subject(:cop) { described_class.new }
+describe RuboCop::Cop::RSpec::FileName, :config do
+  subject(:cop) { described_class.new(config) }
+  let(:cop_config) { { 'CustomTransform' => { 'FooFoo' => 'foofoo' } } }
 
   it 'checks the path' do
     inspect_source(cop,
@@ -140,4 +141,11 @@ describe Rubocop::Cop::RSpecFileName do
                    'my_class/spaceship_operator_spec.rb')
     expect(cop.offenses).to be_empty
   end
+
+  it 'respects custom module name transformation' do
+    inspect_source(cop,
+                   ["describe FooFoo::Some::Class, '#bar' do; end"],
+                   'foofoo/some/class/bar_spec.rb')
+    expect(cop.offenses).to be_empty
+  end
 end

data/spec/rubocop/cop/{rspec_instance_variable_spec.rb → rspec/instance_variable_spec.rb}

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Rubocop::Cop::RSpecInstanceVariable do
+describe RuboCop::Cop::RSpec::InstanceVariable do
   subject(:cop) { described_class.new }
 
   it 'finds an instance variable inside a describe' do

data/spec/rubocop/cop/{rspec_multiple_describes_spec.rb → rspec/multiple_describes_spec.rb}

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Rubocop::Cop::RSpecMultipleDescribes do
+describe RuboCop::Cop::RSpec::MultipleDescribes do
   subject(:cop) { described_class.new }
 
   it 'finds multiple top level describes with class and method' do

data/spec/spec_helper.rb

@@ -15,12 +15,12 @@ require 'rubocop-rspec'
 def parse_source(source, file = nil)
   source = source.join($RS) if source.is_a?(Array)
   if file.is_a? String
-    Rubocop::SourceParser.parse(source, file)
+    RuboCop::SourceParser.parse(source, file)
   elsif file
     file.write(source)
     file.rewind
-    Rubocop::SourceParser.parse(source, file.path)
+    RuboCop::SourceParser.parse(source, file.path)
   else
-    Rubocop::SourceParser.parse(source)
+    RuboCop::SourceParser.parse(source)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.0.rc2
+  version: 1.0.rc3
 platform: ruby
 authors:
 - Ian MacLeod
@@ -9,28 +9,28 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-21 00:00:00.000000000 Z
+date: 2014-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.19'
-    - - '>='
+        version: '0.23'
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.19'
+        version: '0.23'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.19'
-    - - '>='
+        version: '0.23'
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.19'
+        version: '0.23'
 description: |2
       Code style checking for RSpec files.
       A plugin for the RuboCop code style enforcing & linting tool.
@@ -43,32 +43,32 @@ extra_rdoc_files:
 - MIT-LICENSE.md
 - README.md
 files:
-- lib/rubocop/cop/rspec_describe_class.rb
-- lib/rubocop/cop/rspec_describe_method.rb
-- lib/rubocop/cop/rspec_described_class.rb
-- lib/rubocop/cop/rspec_example_wording.rb
-- lib/rubocop/cop/rspec_file_name.rb
-- lib/rubocop/cop/rspec_instance_variable.rb
-- lib/rubocop/cop/rspec_multiple_describes.rb
+- CHANGELOG.md
+- Gemfile
+- MIT-LICENSE.md
+- README.md
+- Rakefile
+- lib/rubocop-rspec.rb
+- lib/rubocop/cop/rspec/describe_class.rb
+- lib/rubocop/cop/rspec/describe_method.rb
+- lib/rubocop/cop/rspec/described_class.rb
+- lib/rubocop/cop/rspec/example_wording.rb
+- lib/rubocop/cop/rspec/file_name.rb
+- lib/rubocop/cop/rspec/instance_variable.rb
+- lib/rubocop/cop/rspec/multiple_describes.rb
 - lib/rubocop/rspec/inject.rb
 - lib/rubocop/rspec/top_level_describe.rb
 - lib/rubocop/rspec/version.rb
-- lib/rubocop-rspec.rb
+- rubocop-rspec.gemspec
 - spec/project_spec.rb
-- spec/rubocop/cop/rspec_describe_class_spec.rb
-- spec/rubocop/cop/rspec_describe_method_spec.rb
-- spec/rubocop/cop/rspec_described_class_spec.rb
-- spec/rubocop/cop/rspec_example_wording_spec.rb
-- spec/rubocop/cop/rspec_file_name_spec.rb
-- spec/rubocop/cop/rspec_instance_variable_spec.rb
-- spec/rubocop/cop/rspec_multiple_describes_spec.rb
+- spec/rubocop/cop/rspec/describe_class_spec.rb
+- spec/rubocop/cop/rspec/describe_method_spec.rb
+- spec/rubocop/cop/rspec/described_class_spec.rb
+- spec/rubocop/cop/rspec/example_wording_spec.rb
+- spec/rubocop/cop/rspec/file_name_spec.rb
+- spec/rubocop/cop/rspec/instance_variable_spec.rb
+- spec/rubocop/cop/rspec/multiple_describes_spec.rb
 - spec/spec_helper.rb
-- CHANGELOG.md
-- MIT-LICENSE.md
-- README.md
-- rubocop-rspec.gemspec
-- Gemfile
-- Rakefile
 homepage: http://github.com/nevir/rubocop-rspec
 licenses:
 - MIT
@@ -79,27 +79,28 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>'
+  - - ">"
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: Code style checking for RSpec files
 test_files:
 - spec/project_spec.rb
-- spec/rubocop/cop/rspec_describe_class_spec.rb
-- spec/rubocop/cop/rspec_describe_method_spec.rb
-- spec/rubocop/cop/rspec_described_class_spec.rb
-- spec/rubocop/cop/rspec_example_wording_spec.rb
-- spec/rubocop/cop/rspec_file_name_spec.rb
-- spec/rubocop/cop/rspec_instance_variable_spec.rb
-- spec/rubocop/cop/rspec_multiple_describes_spec.rb
+- spec/rubocop/cop/rspec/describe_class_spec.rb
+- spec/rubocop/cop/rspec/describe_method_spec.rb
+- spec/rubocop/cop/rspec/described_class_spec.rb
+- spec/rubocop/cop/rspec/example_wording_spec.rb
+- spec/rubocop/cop/rspec/file_name_spec.rb
+- spec/rubocop/cop/rspec/instance_variable_spec.rb
+- spec/rubocop/cop/rspec/multiple_describes_spec.rb
 - spec/spec_helper.rb
+has_rdoc: 

data/lib/rubocop/cop/rspec_describe_class.rb

@@ -1,28 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    # Check that the first argument to the top level describe is the tested
-    # class or module.
-    #
-    # @example
-    #   # bad
-    #   describe 'Do something' do
-    #   end
-    #
-    #   # good
-    #   describe TestedClass do
-    #   end
-    class RSpecDescribeClass < Cop
-      include RSpec::TopLevelDescribe
-
-      MESSAGE = 'The first argument to describe should be the class or ' \
-                'module being tested.'
-
-      def on_top_level_describe(_node, args)
-        return if args.first && args.first.type == :const
-        add_offense(args.first, :expression, MESSAGE)
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec_describe_method.rb

@@ -1,35 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    # Checks that the second argument to the top level describe is the tested
-    # method name.
-    #
-    # @example
-    #   # bad
-    #   describe MyClass, 'do something' do
-    #   end
-    #
-    #   # good
-    #   describe MyClass, '#my_instance_method' do
-    #   end
-    #
-    #   describe MyClass, '.my_class_method' do
-    #   end
-    class RSpecDescribeMethod < Cop
-      include RSpec::TopLevelDescribe
-
-      MESSAGE = 'The second argument to describe should be the method being ' \
-                "tested. '#instance' or '.class'"
-      METHOD_STRING_MATCHER = /^[\#\.].+/
-
-      def on_top_level_describe(_node, args)
-        second_arg = args[1]
-        return unless second_arg
-        return if METHOD_STRING_MATCHER =~ second_arg.children.first
-
-        add_offense(second_arg, :expression, MESSAGE)
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec_described_class.rb

@@ -1,56 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    # If the first argument of describe is a class, the class is exposed to
-    # each example via described_class - this should be used instead of
-    # repeating the class.
-    #
-    # @example
-    #   # bad
-    #   describe MyClass do
-    #     subject { MyClass.do_something }
-    #   end
-    #
-    #   # good
-    #   describe MyClass do
-    #     subject { described_class.do_something }
-    #   end
-    class RSpecDescribedClass < Cop
-      include RSpec::TopLevelDescribe
-
-      MESSAGE = 'Use `described_class` instead of `%s`'
-
-      def on_block(node)
-        method, _args, body = *node
-        return unless top_level_describe?(method)
-
-        _receiver, method_name, object = *method
-        return unless method_name == :describe
-        return unless object && object.type == :const
-
-        inspect_children(body, object)
-      end
-
-      private
-
-      def inspect_children(node, object)
-        return unless node.is_a? Parser::AST::Node
-        return if scope_change?(node) || node.type == :const
-
-        node.children.each do |child|
-          if child == object
-            name =  object.loc.expression.source
-            add_offense(child, :expression, format(MESSAGE, name))
-            break
-          end
-          inspect_children(child, object)
-        end
-      end
-
-      def scope_change?(node)
-        [:def, :class, :module].include?(node.type)
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec_example_wording.rb

@@ -1,33 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    # Do not use should when describing your tests.
-    # see: http://betterspecs.org/#should
-    #
-    # @example
-    #   # bad
-    #   it 'should find nothing' do
-    #   end
-    #
-    #   # good
-    #   it 'finds nothing' do
-    #   end
-    class RSpecExampleWording < Cop
-      MSG = 'Do not use should when describing your tests.'
-
-      def on_block(node)
-        method, _, _ = *node
-        _, method_name, *args = *method
-
-        return unless method_name == :it
-
-        arguments = *(args.first)
-        message = arguments.first.to_s
-        return unless message.start_with?('should')
-
-        add_offense(method, :selector, MSG)
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec_file_name.rb

@@ -1,54 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    # Checks the path of the spec file and enforces that it reflects the
-    # described class/module and its optionally called out method.
-    #
-    # @example
-    #   my_class/method_spec.rb  # describe MyClass, '#method'
-    #   my_class_spec.rb         # describe MyClass
-    class RSpecFileName < Cop
-      include RSpec::TopLevelDescribe
-
-      MESSAGE = 'Spec path should end with `%s`'
-      METHOD_STRING_MATCHER = /^[\#\.].+/
-
-      def on_top_level_describe(node, args)
-        return unless single_top_level_describe?
-        object = const_name(args.first)
-        return unless object
-
-        path_matcher = matcher(object, args[1])
-        return if source_filename =~ regexp_from_glob(path_matcher)
-
-        add_offense(node, :expression, format(MESSAGE, path_matcher))
-      end
-
-      private
-
-      def matcher(object, method)
-        path = File.join(object.split('::').map { |p| camel_to_underscore(p) })
-        path += '*' + method.children.first.gsub(/\W+/, '') if method
-
-        "#{path}*_spec.rb"
-      end
-
-      def source_filename
-        processed_source.buffer.name
-      end
-
-      def camel_to_underscore(string)
-        string.dup.tap do |result|
-          result.gsub!(/([^A-Z])([A-Z]+)/,          '\\1_\\2')
-          result.gsub!(/([A-Z]{2,})([A-Z][^A-Z]+)/, '\\1_\\2')
-          result.downcase!
-        end
-      end
-
-      def regexp_from_glob(glob)
-        Regexp.new(glob.gsub('.', '\\.').gsub('*', '.*') + '$')
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec_instance_variable.rb

@@ -1,39 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    # When you have to assign a variable instead of using an instance variable,
-    # use let.
-    #
-    # @example
-    #   # bad
-    #   describe MyClass do
-    #     before { @foo = [] }
-    #     it { expect(@foo).to be_emtpy }
-    #   end
-    #
-    #   # good
-    #   describe MyClass do
-    #     let(:foo) { [] }
-    #     it { expect(foo).to be_emtpy }
-    #   end
-    class RSpecInstanceVariable < Cop
-      MESSAGE = 'Use `let` instead of an instance variable'
-      EXAMPLE_GROUP_METHODS = [
-        :example_group, :describe, :context, :xdescribe, :xcontext, :fdescribe,
-        :fcontext, :shared_examples, :shared_context, :share_examples_for,
-        :shared_examples_for, :feature
-      ]
-
-      def on_block(node)
-        method, _args, _body = *node
-        _receiver, method_name, _object = *method
-        @in_spec = true if EXAMPLE_GROUP_METHODS.include?(method_name)
-      end
-
-      def on_ivar(node)
-        add_offense(node, :expression, MESSAGE) if @in_spec
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec_multiple_describes.rb

@@ -1,35 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    # Checks for multiple top level describes. They should be nested if it is
-    # for the same class or module or seperated into different files.
-    #
-    # @example
-    #   # bad
-    #   describe MyClass, '.do_someting' do
-    #   end
-    #   describe MyClass, '.do_someting_else' do
-    #   end
-    #
-    #   #good
-    #   describe MyClass
-    #     describe '.do_someting' do
-    #     end
-    #     describe '.do_someting_else' do
-    #     end
-    #   end
-    class RSpecMultipleDescribes < Cop
-      include RSpec::TopLevelDescribe
-
-      MESSAGE = 'Do not use multiple top level describes - try to nest them.'
-
-      def on_top_level_describe(node, _args)
-        return if single_top_level_describe?
-        return unless top_level_nodes.first == node
-
-        add_offense(node, :expression, MESSAGE)
-      end
-    end
-  end
-end