rubocop-rspec 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b632d4031edbdbf3b9c5725b94b93c1869f93bbe
-  data.tar.gz: 9647cd0ba4cddd8e6835199a18b9e872cfbac3fd
+  metadata.gz: d78e6378d0979625180390c70a6e37d889a67652
+  data.tar.gz: 95a96f1a4def09e03681c8f76600a066556186a4
 SHA512:
-  metadata.gz: 8cf570910495f4e5676ff3919ded08af4eb8cc02ef1ae8d68a2a881b608ac059555951ec8474309d1a5045203eafde5729338b4c3283d2df2334eef7babb21e7
-  data.tar.gz: af4516dd2e81af1063e0a76d934e51fed5bc6f187be0eea955096ac707d3a09cf28b555ef20e1c7a8beb047674b7177f233a1c086118acb97496e5a5190e9a9e
+  metadata.gz: 24074653cb0280bbafea8676c58f3fddca8dea629d79c72ce26655fb8fb7a3440e9665ce6d231701d22f7a8375c36681dd8522ce8f49def8d8d5cbe2ad914b47
+  data.tar.gz: ae19016c5b9ae6385ecc7f56dbc9f5e97daba9c93eff6d0d3f061a35d5407f0c36b713f1adb81bba5db7b65b9bb5a7c3566614a20070fd9cae9c802005456479

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change log
 
+## 1.1.0
+
+* Add `autocorrect` to `RSpec::DescribedClass` cop. ([@geniou][])
+
 ## 1.0.1
 
 * Add `config` folder to gemspec. ([@pstengel][])

data/lib/rubocop/cop/rspec/described_class.rb

@@ -33,6 +33,12 @@ module RuboCop
           inspect_children(body, object)
         end
 
+        def autocorrect(node)
+          @corrections << lambda do |corrector|
+            corrector.replace(node.loc.expression, 'described_class')
+          end
+        end
+
         private
 
         def inspect_children(node, object)

data/lib/rubocop/rspec/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module RSpec
     # Version information for the RSpec RuboCop plugin.
     module Version
-      STRING = '1.0.1'
+      STRING = '1.1.0'
     end
   end
 end

data/spec/rubocop/cop/rspec/described_class_spec.rb

@@ -7,14 +7,15 @@ describe RuboCop::Cop::RSpec::DescribedClass do
 
   it 'checks for the use of the described class' do
     inspect_source(cop, ['describe MyClass do',
+                         '  include MyClass',
                          '  subject { MyClass.do_something }',
                          '  before { MyClass.do_something }',
                          'end'])
-    expect(cop.offenses.size).to eq(2)
-    expect(cop.offenses.map(&:line).sort).to eq([2, 3])
+    expect(cop.offenses.size).to eq(3)
+    expect(cop.offenses.map(&:line).sort).to eq([2, 3, 4])
     expect(cop.messages)
-      .to eq(['Use `described_class` instead of `MyClass`'] * 2)
-    expect(cop.highlights).to eq(['MyClass'] * 2)
+      .to eq(['Use `described_class` instead of `MyClass`'] * 3)
+    expect(cop.highlights).to eq(['MyClass'] * 3)
   end
 
   it 'ignores described class as string' do
@@ -24,24 +25,13 @@ describe RuboCop::Cop::RSpec::DescribedClass do
     expect(cop.offenses).to be_empty
   end
 
-  it 'ignores describes that do not referece to a class' do
+  it 'ignores describe that do not referece to a class' do
     inspect_source(cop, ['describe "MyClass" do',
                          '  subject { "MyClass" }',
                          'end'])
     expect(cop.offenses).to be_empty
   end
 
-  it 'ignores if the scope is changing' do
-    inspect_source(cop, ['describe MyClass do',
-                         '  include MyClass',
-                         'end'])
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.map(&:line).sort).to eq([2])
-    expect(cop.messages)
-      .to eq(['Use `described_class` instead of `MyClass`'])
-    expect(cop.highlights).to eq(['MyClass'])
-  end
-
   it 'ignores class if the scope is changing' do
     inspect_source(cop, ['describe MyClass do',
                          '  def method',
@@ -110,4 +100,17 @@ describe RuboCop::Cop::RSpec::DescribedClass do
       .to eq(['Use `described_class` instead of `MyNamespace::MyClass`'])
     expect(cop.highlights).to eq(['MyNamespace::MyClass'])
   end
+
+  it 'autocorrects an offenses' do
+    new_source = autocorrect_source(cop, ['describe MyClass do',
+                                          '  include MyClass',
+                                          '  subject { MyClass.do_something }',
+                                          '  before { MyClass.do_something }',
+                                          'end'])
+    expect(new_source).to eq(['describe MyClass do',
+                              '  include described_class',
+                              '  subject { described_class.do_something }',
+                              '  before { described_class.do_something }',
+                              'end'].join("\n"))
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Ian MacLeod
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-16 00:00:00.000000000 Z
+date: 2014-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop