rubocop-rspec-guide 0.2.0 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dbcc5261e61c2e9d16ccfa146e62046779e7e48f782a8fdb5003203cd55a99a4
-  data.tar.gz: 3b8c2dae7e97d1d892ba9077944c93de7370803ed3c92edfeb2e43e33a4f9c3f
+  metadata.gz: 9093b8623b631c2b9ddaf15d1b72a1638c499d93e9820687dd37ec6e71f27d30
+  data.tar.gz: '09d4eb92564fcfd55bb9d72b15eaf690a5d1e8ada0621f6f281de369a2c1c683'
 SHA512:
-  metadata.gz: f599508c8ad0870461f04847d6b6c727647557c645231b46df9e8bc63737e2118f50d9590fe7cfbec29668941170fe138187bb939bb0d750938f696c5de4bb2c
-  data.tar.gz: 8c9820bc4f21d0a7e82b1711f3abfc85a7131bc7b27b7b46b72c719f02c9426b4ad53f42512e6050677aa41ba903a1db1d45444fba35cd80fe609f0252b75b56
+  metadata.gz: beaebca72cb64609567dd9bc687961cfe193d228d1a25a50de8371a1e605f8265cc596ed2695e942b0d5f679a1f23d2581ef8a8aec176d7c26a5174c323146eb
+  data.tar.gz: 3783cee1af2fa2d784f0ad67ce7bcf08019aab358e7d6f5c2f9d53f7b26d5bf0dbe9dd55566c0bb347e30c331ae26f0f6467d3c51972cf1071cda15cab1e8d4c

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 ## [Unreleased]
 
+## [0.2.2] - 2025-10-29
+
+### Fixed
+- **RSpecGuide/DuplicateLetValues**: Fix crash when encountering empty let blocks (e.g., `let(:foo) {}`)
+  - Added nil check in `simple_value?` method to handle cases where let block has no body
+
+## [0.2.1] - 2025-10-29
+
+### Changed
+- **RSpecGuide/HappyPathFirst**: Allow corner case contexts when examples (it/specify) appear before first context
+  - Examples before contexts are considered happy path
+  - No offense if at least one example exists before the first context
+
 ## [0.2.0] - 2025-10-28
 
 ### Changed

data/lib/rubocop/cop/rspec_guide/duplicate_let_values.rb

@@ -159,6 +159,8 @@ module RuboCop
         end
 
         def simple_value?(node)
+          return false if node.nil?
+
           # Values we can safely compare by source
           return true if node.sym_type? || node.str_type? || node.int_type? || node.float_type?
           return true if node.true_type? || node.false_type? || node.nil_type?

data/lib/rubocop/cop/rspec_guide/happy_path_first.rb

@@ -6,6 +6,10 @@ module RuboCop
       # Checks that corner cases are not the first context in a describe block.
       # Happy path should come first for better readability.
       #
+      # The cop allows corner case contexts to appear first if there are
+      # example blocks (it/specify) before the first context, as those examples
+      # represent the happy path.
+      #
       # @example
       #   # bad
       #   describe '#process' do
@@ -37,6 +41,17 @@ module RuboCop
       #     end
       #   end
       #
+      #   # good - examples before first context represent happy path
+      #   describe '#add_child' do
+      #     it 'adds child to children collection' do
+      #       # ...
+      #     end
+      #
+      #     context 'but child is already in collection' do
+      #       # ...
+      #     end
+      #   end
+      #
       class HappyPathFirst < Base
         MSG = "Place happy path contexts before corner cases. " \
               "First context appears to be a corner case: %<description>s"
@@ -67,6 +82,10 @@ module RuboCop
           contexts = collect_direct_child_contexts(node)
           return if contexts.size < 2
 
+          # If there are any examples (it/specify) before the first context,
+          # this is a happy path, so no offense
+          return if has_examples_before_first_context?(node, contexts.first)
+
           # Check first context
           context_with_description?(contexts.first) do |description|
             if corner_case_context?(description)
@@ -80,6 +99,30 @@ module RuboCop
 
         private
 
+        def has_examples_before_first_context?(node, first_context)
+          body = node.body
+          return false unless body
+
+          children = body.begin_type? ? body.children : [body]
+
+          children.each do |child|
+            # Stop when we reach the first context
+            break if child == first_context
+
+            # Check if this is an example (it/specify)
+            return true if example?(child)
+          end
+
+          false
+        end
+
+        def example?(node)
+          return false unless node.block_type?
+
+          send_node = node.send_node
+          send_node.method?(:it) || send_node.method?(:specify)
+        end
+
         def collect_direct_child_contexts(node)
           body = node.body
           return [] unless body

data/lib/rubocop/rspec/guide/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module RSpec
     module Guide
-      VERSION = "0.2.0"
+      VERSION = "0.2.2"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec-guide
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.2
 platform: ruby
 authors:
 - Alexey Matskevich