rubocop-rspec-focused 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 18d13e56c465ff7b44a3f971d20354f8317bafbe
-  data.tar.gz: d59941e5b7c8e7167c42fc6cc954be23f3cb3c3e
+  metadata.gz: 77dc402b38ff0555f83ff46c05891ef6eabc19f2
+  data.tar.gz: 278fb1373ce6fb4b4c7ed2842b9c78acf46d3928
 SHA512:
-  metadata.gz: 8138b5bf399d3cccd1a819c0f6c88309fe4d5e56d3eb6de5b0ead1a5d7c0148070c5d888a14c677e91ab73473419484d0a2295d1313d34edc1ff52d54756170c
-  data.tar.gz: 6d28d20175cba0605b9a81caaad880af0dfa2f245b7e46c978edd3dae4a39061cfdb61f7317f73c77a3abf7d30445a7e769a8d60aba74ae6a7db101360360767
+  metadata.gz: 14f6217942dbdfd3bcc81c1e69a7799761b71e9b5894d3e280062e3b76d8d4a96b1b36b7d7a87cc4e013b0ec9f53cc94a4946e1ddd80444bc84df002af56eea2
+  data.tar.gz: 16a7cbe8f6fc304efb61fd76b587056bbe4ccc88ad241fe9abf118a3e219fd11ef7cae0d99ecca2698a9f9850becac8ac9a241663116949caf0733327f2b198d

data/.travis.yml

@@ -0,0 +1,12 @@
+rvm:
+  - 2.0.0
+  - 2.1.0
+  - 2.2.0
+  - rbx-2
+  - ruby-head
+
+cache: bundler
+
+bundler_args: --without dev --jobs=3
+
+script: bundle exec rspec spec

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## master (unreleased)
+
+## 0.0.2
+
+* Support symbols passed as metadata, e.g:
+
+        describe 'foo', :focus do
+        end
+
 ## 0.0.1
 
 * Initial release.

data/README.md

@@ -1,6 +1,17 @@
 # rubocop-rspec-focused
 
-Cop for focused specs.
+[![Build Status](https://travis-ci.org/lovewithfood/rubocop-rspec-focused.svg?branch=master)](https://travis-ci.org/lovewithfood/rubocop-rspec-focused)
+
+RuboCop lint for focused specs.
+
+It finds `focus: true` and the following method calls:
+
+  * `focus`
+  * `fexample`
+  * `fit`
+  * `fspecify`
+  * `fcontext`
+  * `fdescribe`
 
 ```ruby
 # bad
@@ -8,7 +19,17 @@ fit 'does something' do
   expect(foo).to be_empty
 end
 
-it 'does something', focus: true do
+fdescribe Something do
+  it 'does something' do
+    expect(foo).to be_empty
+  end
+end
+
+specify 'does something', focus: true do
+  expect(foo).to be_empty
+end
+
+specify 'does something', :focus do
   expect(foo).to be_empty
 end
 
@@ -16,6 +37,16 @@ end
 it 'does something' do
   expect(foo).to be_empty
 end
+
+describe Something do
+  it 'does something' do
+    expect(foo).to be_empty
+  end
+end
+
+specify 'does something' do
+  expect(foo).to be_empty
+end
 ```
 
 ## Installation
@@ -23,14 +54,14 @@ end
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'rubocop-rspec-focused'
+gem 'rubocop-rspec-focused', require: false
 ```
 
 And then execute:
 
     $ bundle
 
-And add this to .rubocop.yml:
+And add this to your `.rubocop.yml`:
 
 ```yml
 require:

data/lib/rubocop/cop/rspec/focused.rb

@@ -28,7 +28,7 @@ module RuboCop
 
         def on_block(node)
           method, _args, _body = *node
-          _receiver, method_name, _object, metadata = *method
+          _receiver, method_name, _object, *metadata = *method
 
           if FOCUSED_METHODS.include?(method_name) || focus_set_to_true?(metadata)
             add_offense(node, :expression, MESSAGE)
@@ -38,9 +38,12 @@ module RuboCop
         private
 
         def focus_set_to_true?(metadata)
-          metadata && metadata.children.any? do |pair|
-            pair == s(:pair, s(:sym, :focus), s(:true))
-          end
+          return unless metadata
+
+          metadata.include?(s(:sym, :focus)) ||
+            metadata.last.children.any? do |pair|
+              pair == s(:pair, s(:sym, :focus), s(:true))
+            end
         end
       end
     end

data/lib/rubocop/rspec/focused/version.rb

@@ -1,7 +1,7 @@
 module RuboCop
   module RSpec
     module Focused
-      VERSION = '0.0.1'
+      VERSION = '0.0.2'
     end
   end
 end

data/rubocop-rspec-focused.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency "rubocop"
 
-  spec.add_development_dependency "bundler", "~> 1.7"
+  spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.1.0"
 end

data/spec/lib/rubocop/cop/rspec/focused_spec.rb

@@ -23,4 +23,13 @@ RSpec.describe RuboCop::Cop::RSpec::Focused do
     expect(cop.offenses.map(&:line).sort).to eq([1])
     expect(cop.messages).to eq([described_class::MESSAGE])
   end
+
+  it 'finds an example with :focus' do
+    inspect_source(cop, ['it "does something", :js, :focus do',
+                         '  expect(foo).to be_empty',
+                         'end'])
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.offenses.map(&:line).sort).to eq([1])
+    expect(cop.messages).to eq([described_class::MESSAGE])
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec-focused
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Love With Food, Hendy Tanata
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-17 00:00:00.000000000 Z
+date: 2015-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -75,6 +75,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt