rubocop-rake 0.5.1 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b71580a8ba42edbae65f9f46e4e5fd2af9e64b4bda2a8eff8a9e719e35ff4ca1
-  data.tar.gz: 6083afa2054e8ccd3e4148335d663b6872f05cdeca02265601b3a7e4d5b1501a
+  metadata.gz: a878d5ccc2eec701b39d7d2ee54cbee2eeafc822d0fdd9ebb1bd24174f62eb6e
+  data.tar.gz: 137d23f7a93f25c027872cff22cca183e87b3c57a34b63a970a6687101a2ea69
 SHA512:
-  metadata.gz: f71f3e174dae2a4a310483393c506bd3508576d93bfe6e8bd6c7cbf66fbe3104b35ac287f0b69568fb3b169e3ee20ceebb4c77219fbb8c8a9d258cb676ad79a3
-  data.tar.gz: ecd03e5d7cafc964fe1c501c85d554d07a3bdce600d1ba046cf372fcfbab5c0cde93b7fedf5c9781fdf9274e6c0adfbdd626dd59ac93f9c39e9c9c2f8b3de0cc
+  metadata.gz: 67ef6e06e7704cac677af3256d2a14c15729b521a2873d971bf0339eed83bdb04019ea7302cc35b8a461469c52c77382da35d2fca1e7d022cd471a10a832bfa4
+  data.tar.gz: 111a3788568c30c1588e4aa4108cce2c5d8a4eae21d9f11d897f19fa44495486933edbd8ca0945d63b8daefcc1551e74e69197a02c7006c1f1bf0f57da79f9fa

data/.circleci/config.yml

@@ -8,16 +8,6 @@ steps: &steps
 
 jobs:
 
-  ruby-2.3:
-    docker:
-      - image: circleci/ruby:2.3
-    <<: *steps
-
-  ruby-2.4:
-    docker:
-      - image: circleci/ruby:2.4
-    <<: *steps
-
   ruby-2.5:
     docker:
       - image: circleci/ruby:2.5
@@ -33,6 +23,11 @@ jobs:
       - image: circleci/ruby:2.7
     <<: *steps
 
+  ruby-3.0:
+    docker:
+      - image: circleci/ruby:3.0
+    <<: *steps
+
   ruby-head:
     docker:
       - image: rubocophq/circleci-ruby-snapshot:latest
@@ -42,9 +37,8 @@ workflows:
   version: 2
   build:
     jobs:
-      - ruby-2.3
-      - ruby-2.4
       - ruby-2.5
       - ruby-2.6
       - ruby-2.7
+      - ruby-3.0
       - ruby-head

data/.gitignore

@@ -1,3 +1,4 @@
+.ruby-version
 /.bundle/
 /.yardoc
 /_yardoc/

data/.rubocop.yml

@@ -1,11 +1,15 @@
 inherit_from: .rubocop_todo.yml
 
 require:
+  - rubocop/cop/internal_affairs
   - rubocop-rake
   - rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.5
+
+InternalAffairs/NodeMatcherDirective:
+  Enabled: false
 
 Layout/LineLength:
   Enabled: false
@@ -45,3 +49,8 @@ RSpec/ExampleLength:
 Naming/FileName:
   Exclude:
     - 'lib/rubocop-rake.rb'
+
+# This disabling is a workaround for https://github.com/rubocop-hq/rubocop-rspec/issues/1068.
+# The cop has been disabled because FactoryBot is not used in this repository.
+RSpec/FactoryBot/CreateList:
+  Enabled: false

data/CHANGELOG.md

@@ -2,45 +2,54 @@
 
 ## master (unreleased)
 
+## 0.6.0 (2021-06-29)
+
+### Changes
+
+* [#33](https://github.com/rubocop/rubocop-rake/pull/33): Drop support for Ruby 2.3. ([@koic][])
+* [#34](https://github.com/rubocop/rubocop-rake/pull/34): Require RuboCop 1.0 or higher. ([@koic][])
+* [#38](https://github.com/rubocop/rubocop-rake/pull/37): Drop support for Ruby 2.4. ([@tejasbubane])
+* [#36](https://github.com/rubocop/rubocop-rake/issues/36): Fix `Rake/Desc` to not generate offense for prerequisite declarations. ([@tejasbubane][])
+
 ## 0.5.1 (2020-02-14)
 
 ### Bug fixes
 
-* [#28](https://github.com/rubocop-hq/rubocop-rake/issues/28): Fix `Rake/Desc` to avoid an error when `task` is not a task definition. ([@pocke][])
+* [#28](https://github.com/rubocop/rubocop-rake/issues/28): Fix `Rake/Desc` to avoid an error when `task` is not a task definition. ([@pocke][])
 
 ## 0.5.0 (2019-10-31)
 
 ### New features
 
-* [#14](https://github.com/rubocop-hq/rubocop-rake/issues/14): Add Rake/DuplicateNamespace cop. ([@jaruuuu][])
+* [#14](https://github.com/rubocop/rubocop-rake/issues/14): Add Rake/DuplicateNamespace cop. ([@jaruuuu][])
 
 ## 0.4.0 (2019-10-13)
 
 ### New features
 
-* [#13](https://github.com/rubocop-hq/rubocop-rake/issues/13): Add Rake/DuplicateTask cop. ([@pocke][])
+* [#13](https://github.com/rubocop/rubocop-rake/issues/13): Add Rake/DuplicateTask cop. ([@pocke][])
 
 ## 0.3.1 (2019-10-06)
 
 ### Bug fixes
 
-* [#17](https://github.com/rubocop-hq/rubocop-rake/pull/17): Filter target files for Rake/ClassDefinitionInTask cop. ([@pocke][])
+* [#17](https://github.com/rubocop/rubocop-rake/pull/17): Filter target files for Rake/ClassDefinitionInTask cop. ([@pocke][])
 
 ## 0.3.0 (2019-09-25)
 
 ### New features
 
-* [#6](https://github.com/rubocop-hq/rubocop-rake/issues/6): Add `Rake/ClassDefinitionInTask` cop. ([@pocke][])
+* [#6](https://github.com/rubocop/rubocop-rake/issues/6): Add `Rake/ClassDefinitionInTask` cop. ([@pocke][])
 
 ### Bug fixes
 
-* [#8](https://github.com/rubocop-hq/rubocop-rake/issues/8): Make Rake/Desc to not require description for the default task. ([@pocke][])
+* [#8](https://github.com/rubocop/rubocop-rake/issues/8): Make Rake/Desc to not require description for the default task. ([@pocke][])
 
 ## 0.2.0 (2019-09-17)
 
 ### New features
 
-* [#5](https://github.com/rubocop-hq/rubocop-rake/pull/5): Add `Rake/MethodDefinitionInTask`. ([@pocke][])
+* [#5](https://github.com/rubocop/rubocop-rake/pull/5): Add `Rake/MethodDefinitionInTask`. ([@pocke][])
 
 ## 0.1.0 (2019-09-04)
 
@@ -51,3 +60,5 @@
 
 [@pocke]: https://github.com/pocke
 [@jaruuuu]: https://github.com/jaruuuu
+[@koic]: https://github.com/koic
+[@tejasbubane]: https://github.com/tejasbubane

data/README.md

@@ -1,9 +1,9 @@
 [![Gem Version](https://badge.fury.io/rb/rubocop-rake.svg)](https://rubygems.org/gems/rubocop-rake)
-[![CircleCI](https://circleci.com/gh/rubocop-hq/rubocop-rake.svg?style=svg)](https://circleci.com/gh/rubocop-hq/rubocop-rake)
+[![CircleCI](https://circleci.com/gh/rubocop/rubocop-rake.svg?style=svg)](https://circleci.com/gh/rubocop/rubocop-rake)
 
 # RuboCop Rake
 
-A [RuboCop](https://github.com/rubocop-hq/rubocop) plugin for Rake.
+A [RuboCop](https://github.com/rubocop/rubocop) plugin for Rake.
 
 ## Installation
 
@@ -37,5 +37,5 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/rubocop-hq/rubocop-rake.
+Bug reports and pull requests are welcome on GitHub at https://github.com/rubocop/rubocop-rake.
 

data/lib/rubocop/cop/rake/class_definition_in_task.rb

@@ -28,18 +28,14 @@ module RuboCop
       #   task :foo do
       #   end
       #
-      class ClassDefinitionInTask < Cop
+      class ClassDefinitionInTask < Base
         MSG = 'Do not define a %<type>s in rake task, because it will be defined to the top level.'
 
         def on_class(node)
           return if Helper::ClassDefinition.in_class_definition?(node)
           return unless Helper::TaskDefinition.in_task_or_namespace?(node)
 
-          add_offense(node)
-        end
-
-        def message(node)
-          format(MSG, type: node.type)
+          add_offense(node, message: format(MSG, type: node.type))
         end
 
         alias on_module on_class

data/lib/rubocop/cop/rake/desc.rb

@@ -27,15 +27,23 @@ module RuboCop
       #   task :do_something do
       #   end
       #
-      class Desc < Cop
+      class Desc < Base
         include Helper::OnTask
+        extend AutoCorrector
 
         MSG = 'Describe the task with `desc` method.'
 
+        def_node_matcher :prerequisites, <<~PATTERN
+          (send nil? :task (hash (pair _ $_)))
+        PATTERN
+
         def on_task(node)
           return if task_with_desc?(node)
           return if Helper::TaskName.task_name(node) == :default
 
+          requirements = prerequisites(node)
+          return if requirements&.array_type?
+
           add_offense(node)
         end
 
@@ -48,7 +56,7 @@ module RuboCop
           desc_candidate = parent.children[idx]
           return false unless desc_candidate
 
-          desc_candidate.send_type? && desc_candidate.method_name == :desc
+          desc_candidate.send_type? && desc_candidate.method?(:desc)
         end
 
         private def parent_and_task(task_node)

data/lib/rubocop/cop/rake/duplicate_namespace.rb

@@ -27,7 +27,7 @@ module RuboCop
       #     end
       #   end
       #
-      class DuplicateNamespace < Cop
+      class DuplicateNamespace < Base
         include Helper::OnNamespace
 
         MSG = 'Namespace `%<namespace>s` is defined at both %<previous>s and %<current>s.'
@@ -55,7 +55,7 @@ module RuboCop
 
           node.each_ancestor(:block) do |block_node|
             send_node = block_node.send_node
-            next unless send_node.method_name == :namespace
+            next unless send_node.method?(:namespace)
 
             name = Helper::TaskName.task_name(send_node)
             ns << name

data/lib/rubocop/cop/rake/duplicate_task.rb

@@ -23,7 +23,7 @@ module RuboCop
       #     p 'foo 2'
       #   end
       #
-      class DuplicateTask < Cop
+      class DuplicateTask < Base
         include Helper::OnTask
 
         MSG = 'Task `%<task>s` is defined at both %<previous>s and %<current>s.'
@@ -54,7 +54,7 @@ module RuboCop
 
           node.each_ancestor(:block) do |block_node|
             send_node = block_node.send_node
-            next unless send_node.method_name == :namespace
+            next unless send_node.method?(:namespace)
 
             name = Helper::TaskName.task_name(send_node)
             ns << name

data/lib/rubocop/cop/rake/method_definition_in_task.rb

@@ -30,7 +30,7 @@ module RuboCop
       #   task :foo do
       #   end
       #
-      class MethodDefinitionInTask < Cop
+      class MethodDefinitionInTask < Base
         MSG = 'Do not define a method in rake task, because it will be defined to the top level.'
 
         def on_def(node)

data/lib/rubocop/rake/inject.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-# The original code is from https://github.com/rubocop-hq/rubocop-rspec/blob/master/lib/rubocop/rspec/inject.rb
-# See https://github.com/rubocop-hq/rubocop-rspec/blob/master/MIT-LICENSE.md
+# The original code is from https://github.com/rubocop/rubocop-rspec/blob/master/lib/rubocop/rspec/inject.rb
+# See https://github.com/rubocop/rubocop-rspec/blob/master/MIT-LICENSE.md
 module RuboCop
   module Rake
     # Because RuboCop doesn't yet support plugins, we have to monkey patch in a

data/lib/rubocop/rake/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Rake
-    VERSION = "0.5.1"
+    VERSION = "0.6.0"
   end
 end

data/rubocop-rake.gemspec

@@ -10,15 +10,15 @@ Gem::Specification.new do |spec|
 
   spec.summary       = %q{A RuboCop plugin for Rake}
   spec.description   = %q{A RuboCop plugin for Rake}
-  spec.homepage      = "https://github.com/rubocop-hq/rubocop-rake"
-  spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
+  spec.homepage      = "https://github.com/rubocop/rubocop-rake"
+  spec.required_ruby_version = Gem::Requirement.new(">= 2.5.0")
   spec.licenses = ['MIT']
 
   spec.metadata["allowed_push_host"] = "https://rubygems.org"
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = spec.homepage
-  spec.metadata["changelog_uri"] = "https://github.com/rubocop-hq/rubocop-rake/blob/master/CHANGELOG.md"
+  spec.metadata["changelog_uri"] = "https://github.com/rubocop/rubocop-rake/blob/master/CHANGELOG.md"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -29,5 +29,5 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency 'rubocop'
+  spec.add_runtime_dependency 'rubocop', '~> 1.0'
 end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rake
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.0
 platform: ruby
 authors:
 - Masataka Pocke Kuwabara
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-02-14 00:00:00.000000000 Z
+date: 2021-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 description: A RuboCop plugin for Rake
 email:
 - kuwabara@pocke.me
@@ -60,15 +60,15 @@ files:
 - lib/rubocop/rake/inject.rb
 - lib/rubocop/rake/version.rb
 - rubocop-rake.gemspec
-homepage: https://github.com/rubocop-hq/rubocop-rake
+homepage: https://github.com/rubocop/rubocop-rake
 licenses:
 - MIT
 metadata:
   allowed_push_host: https://rubygems.org
-  homepage_uri: https://github.com/rubocop-hq/rubocop-rake
-  source_code_uri: https://github.com/rubocop-hq/rubocop-rake
-  changelog_uri: https://github.com/rubocop-hq/rubocop-rake/blob/master/CHANGELOG.md
-post_install_message: 
+  homepage_uri: https://github.com/rubocop/rubocop-rake
+  source_code_uri: https://github.com/rubocop/rubocop-rake
+  changelog_uri: https://github.com/rubocop/rubocop-rake/blob/master/CHANGELOG.md
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -76,15 +76,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.0.pre1
-signing_key: 
+rubygems_version: 3.2.13
+signing_key:
 specification_version: 4
 summary: A RuboCop plugin for Rake
 test_files: []